Re: [edk2-devel] [PATCH 3/3] MdeModulePkg: Notify BeforeExitBootServices in CoreExitBootServices

[Ard Biesheuvel]

On Thu, 12 Jan 2023 at 18:03, Laszlo Ersek  wrote:
>
> On 1/12/23 16:32, Laszlo Ersek wrote:
>
> > ... I've picked up the patches, picked up the pending feedback tags too,
> > and compared the result against Dionna's latest PR
> > .
> >
> > Beyond the Message-Id tags that git-am picked up on my side, I've found
> > another difference: patch#1 was originally authored by Sophia Wolf
> > , but that fact has been mangled in the first patch
> > of  -- commit cd4c186f1099.
> > Namely, in commit cd4c186f1099, the original authorship is recorded as
> > another line in the commit message, when it should be reflected by the
> > Author meta-datum in git. So I'm going to stick with what I have, from
> > the list archive and git-am (git-am correctly translates the From: line
> > back to the Author meta-datum), for the new PR:
> >
> >   https://github.com/tianocore/edk2/pull/3889
>
> Commit range e5ec3ba409b5..9d70d8f20d0f.
>

Thanks Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98459): https://edk2.groups.io/g/devel/message/98459
Mute This Topic: https://groups.io/mt/94894288/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 3/3] MdeModulePkg: Notify BeforeExitBootServices in CoreExitBootServices

[Laszlo Ersek]

On 1/12/23 16:32, Laszlo Ersek wrote:

> ... I've picked up the patches, picked up the pending feedback tags too,
> and compared the result against Dionna's latest PR
> .
> 
> Beyond the Message-Id tags that git-am picked up on my side, I've found
> another difference: patch#1 was originally authored by Sophia Wolf
> , but that fact has been mangled in the first patch
> of  -- commit cd4c186f1099.
> Namely, in commit cd4c186f1099, the original authorship is recorded as
> another line in the commit message, when it should be reflected by the
> Author meta-datum in git. So I'm going to stick with what I have, from
> the list archive and git-am (git-am correctly translates the From: line
> back to the Author meta-datum), for the new PR:
> 
>   https://github.com/tianocore/edk2/pull/3889

Commit range e5ec3ba409b5..9d70d8f20d0f.



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98383): https://edk2.groups.io/g/devel/message/98383
Mute This Topic: https://groups.io/mt/94894288/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 3/3] MdeModulePkg: Notify BeforeExitBootServices in CoreExitBootServices

[Dionna Glaze via groups.io]

Thanks for your explanation and fastidiousness, Laszlo. Much appreciated.

On Thu, Jan 12, 2023 at 7:32 AM Laszlo Ersek  wrote:
>
> On 1/12/23 14:38, Ard Biesheuvel wrote:
> > On Thu, 12 Jan 2023 at 13:24, Laszlo Ersek  wrote:
> >>
> >> On 1/12/23 00:08, Dionna Glaze via groups.io wrote:
> >>> On Thu, Nov 10, 2022 at 8:55 AM Kinney, Michael D
> >>>  wrote:
> 
>  Hi Dionna,
> 
>  https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
> 
>  I think you are at step 13.  If you have not done so already,
>  please update the commit messages with all the Reviewed-by and
>  Acked-by tags and make sure your branch is rebased against the
>  latest edk2/master and update the PR with that content and verify
>  that all EDK II CI checks pass.
> 
>  At that point, it is the responsibility of the EDK II Maintainers
>  to review the final state of the PR and set the "push" label if
>  everything looks correct.
>
> I didn't realize this had been adopted -- "upgrading" a contributor
> submitted PR. (More below.)
>
>  At this moment, we are in Soft Freeze and will be in Hard Freeze
>  for the next 2 weeks.  If this is considered critical for the
>  stable tag release, then please send a request to Liming with
>  justification for stable tag.  Otherwise, it will be merged after
>  the stable tag release.
> 
>  https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning
> 
>  Thanks,
> 
>  Mike
> 
> >>>
> >>> Hi Mike, my PR was closed without comment
> >>> https://github.com/tianocore/edk2/pull/3623 so I rebased and created
> >>> a new PR after the holidays and hard freeze. I hope this isn't
> >>> considered bad practice https://github.com/tianocore/edk2/pull/3885
> >>>
> >>
> >> I closed the PR -- similarly to how I manually closed 400+ stale PRs
> >> then -- because it was not a maintainer-submitted PR with the "push"
> >> label set. In other words, it was just a personal build, for
> >> triggering a CI run.
> >>
> >> And, in fact regardlessly of whether it was a "push"-labeled
> >> maintainer PR or just a personal PR, the PR was almost two months
> >> old. Clearly stale and abandoned -- per edk2 contribution workflow,
> >> anyway.
> >>
> >> Please excuse me for not explaining this in a comment on the PR, but
> >> (as I said above) I closed 400+ stale PRs manually within 10-15
> >> minutes on the github.com WebUI. The necessary muscle memory training
> >> didn't allow for individual comments.
> >>
> >> (I actually tried scripting the mass-closure at first, with the "gh"
> >> utility, but something in the github.com data model was broken, and
> >> the server wouldn't allow me to close those PRs with the utility,
> >> even though I had authenticated the utility under my account, with a
> >> complete set of scopes -- see my report at
> >> .)
> >>
> >> Regarding your new PR: it's again good for a personal CI run only. If
> >> it completes fine, please post the patches to the mailing list, using
> >> git-send-email.
> >>
> >> (From browsing recent list traffic, it seems that your colleague
> >> Moritz Fischer  has posted patches like that to
> >> the list; please consider consulting with Moritz regarding the git
> >> setup (SMTP server etc) withing Google. Cc'ing Moritz now.)
> >>
> >> When sending the patches like that, please CC the maintainers and
> >> reviewers that are supposed to review them. Once they are happy with
> >> the series, one of them will submit a PR with them, and set the
> >> "push" label on the PR. When the CI run succeeds, the mergify bot
> >> will merge *that* PR automatically.
> >>
> >
> > I think we were already way past this with Dionna's work - numerous
> > iterations have been posted and discussed, and the merge of the final
> > version was only deferred because of the soft freeze.
> >
>
> That may very well be, but the specific PR I closed (3623) was not
> queued by a maintainer, nor did it have the "push" label. So I'd expect
> that now a maintainer has to submit a new PR, with the patches most
> recently approved on the list.
>
> The official documentation in the wiki at
> 
> still says the maintainer has to use "git-am" for picking up the
> patches, and to submit a new (separate) PR, with the "push" label set.
> So I wouldn't expect the "push" label to be set, as an additional
> maintainer action, on a contributor-submitted (pre-existent) PR.
>
> Sorry for obsessing about this, but given the 400+ stale open PRs, it
> was literally impossible to tell apart this one (3623) from the rest.
> And in retrospect, I do think I was right to close 3623 as well. IIRC, I
> left the PRs younger than 2 weeks alone.
>
> Now, regarding *where* the most recent version of the series lives (i.e.
> wha

Re: [edk2-devel] [PATCH 3/3] MdeModulePkg: Notify BeforeExitBootServices in CoreExitBootServices

[Laszlo Ersek]

On 1/12/23 14:38, Ard Biesheuvel wrote:
> On Thu, 12 Jan 2023 at 13:24, Laszlo Ersek  wrote:
>>
>> On 1/12/23 00:08, Dionna Glaze via groups.io wrote:
>>> On Thu, Nov 10, 2022 at 8:55 AM Kinney, Michael D
>>>  wrote:

 Hi Dionna,

 https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

 I think you are at step 13.  If you have not done so already,
 please update the commit messages with all the Reviewed-by and
 Acked-by tags and make sure your branch is rebased against the
 latest edk2/master and update the PR with that content and verify
 that all EDK II CI checks pass.

 At that point, it is the responsibility of the EDK II Maintainers
 to review the final state of the PR and set the "push" label if
 everything looks correct.

I didn't realize this had been adopted -- "upgrading" a contributor
submitted PR. (More below.)

 At this moment, we are in Soft Freeze and will be in Hard Freeze
 for the next 2 weeks.  If this is considered critical for the
 stable tag release, then please send a request to Liming with
 justification for stable tag.  Otherwise, it will be merged after
 the stable tag release.

 https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning

 Thanks,

 Mike

>>>
>>> Hi Mike, my PR was closed without comment
>>> https://github.com/tianocore/edk2/pull/3623 so I rebased and created
>>> a new PR after the holidays and hard freeze. I hope this isn't
>>> considered bad practice https://github.com/tianocore/edk2/pull/3885
>>>
>>
>> I closed the PR -- similarly to how I manually closed 400+ stale PRs
>> then -- because it was not a maintainer-submitted PR with the "push"
>> label set. In other words, it was just a personal build, for
>> triggering a CI run.
>>
>> And, in fact regardlessly of whether it was a "push"-labeled
>> maintainer PR or just a personal PR, the PR was almost two months
>> old. Clearly stale and abandoned -- per edk2 contribution workflow,
>> anyway.
>>
>> Please excuse me for not explaining this in a comment on the PR, but
>> (as I said above) I closed 400+ stale PRs manually within 10-15
>> minutes on the github.com WebUI. The necessary muscle memory training
>> didn't allow for individual comments.
>>
>> (I actually tried scripting the mass-closure at first, with the "gh"
>> utility, but something in the github.com data model was broken, and
>> the server wouldn't allow me to close those PRs with the utility,
>> even though I had authenticated the utility under my account, with a
>> complete set of scopes -- see my report at
>> .)
>>
>> Regarding your new PR: it's again good for a personal CI run only. If
>> it completes fine, please post the patches to the mailing list, using
>> git-send-email.
>>
>> (From browsing recent list traffic, it seems that your colleague
>> Moritz Fischer  has posted patches like that to
>> the list; please consider consulting with Moritz regarding the git
>> setup (SMTP server etc) withing Google. Cc'ing Moritz now.)
>>
>> When sending the patches like that, please CC the maintainers and
>> reviewers that are supposed to review them. Once they are happy with
>> the series, one of them will submit a PR with them, and set the
>> "push" label on the PR. When the CI run succeeds, the mergify bot
>> will merge *that* PR automatically.
>>
>
> I think we were already way past this with Dionna's work - numerous
> iterations have been posted and discussed, and the merge of the final
> version was only deferred because of the soft freeze.
>

That may very well be, but the specific PR I closed (3623) was not
queued by a maintainer, nor did it have the "push" label. So I'd expect
that now a maintainer has to submit a new PR, with the patches most
recently approved on the list.

The official documentation in the wiki at

still says the maintainer has to use "git-am" for picking up the
patches, and to submit a new (separate) PR, with the "push" label set.
So I wouldn't expect the "push" label to be set, as an additional
maintainer action, on a contributor-submitted (pre-existent) PR.

Sorry for obsessing about this, but given the 400+ stale open PRs, it
was literally impossible to tell apart this one (3623) from the rest.
And in retrospect, I do think I was right to close 3623 as well. IIRC, I
left the PRs younger than 2 weeks alone.

Now, regarding *where* the most recent version of the series lives (i.e.
what needs to be picked up from the list by the maintainer, for
merging), that beats me. We're conducting the present discussion under
the following thread:

  [edk2-devel] [PATCH 0/3] SEV-SNP accepted memory and BeforeExitBootServices
  20221108164616.3251967-1-dionnaglaze@google.com">http://mid.mail-archive.com/20221108164616.3251967

Re: [edk2-devel] [PATCH 3/3] MdeModulePkg: Notify BeforeExitBootServices in CoreExitBootServices

[Ard Biesheuvel]

On Thu, 12 Jan 2023 at 13:24, Laszlo Ersek  wrote:
>
> On 1/12/23 00:08, Dionna Glaze via groups.io wrote:
> > On Thu, Nov 10, 2022 at 8:55 AM Kinney, Michael D
> >  wrote:
> >>
> >> Hi Dionna,
> >>
> >> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
> >>
> >> I think you are at step 13.  If you have not done so already, please 
> >> update the
> >> commit messages with all the Reviewed-by and Acked-by tags and make sure 
> >> your
> >> branch is rebased against the latest edk2/master and update the PR with 
> >> that
> >> content and verify that all EDK II CI checks pass.
> >>
> >> At that point, it is the responsibility of the EDK II Maintainers to review
> >> the final state of the PR and set the "push" label if everything looks 
> >> correct.
> >>
> >> At this moment, we are in Soft Freeze and will be in Hard Freeze for the 
> >> next
> >> 2 weeks.  If this is considered critical for the stable tag release, then
> >> please send a request to Liming with justification for stable tag.  
> >> Otherwise,
> >> it will be merged after the stable tag release.
> >>
> >> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning
> >>
> >> Thanks,
> >>
> >> Mike
> >>
> >
> > Hi Mike, my PR was closed without comment
> > https://github.com/tianocore/edk2/pull/3623 so I rebased and created a
> > new PR after the holidays and hard freeze. I hope this isn't
> > considered bad practice https://github.com/tianocore/edk2/pull/3885
> >
>
> I closed the PR -- similarly to how I manually closed 400+ stale PRs
> then -- because it was not a maintainer-submitted PR with the "push"
> label set. In other words, it was just a personal build, for triggering
> a CI run.
>
> And, in fact regardlessly of whether it was a "push"-labeled maintainer
> PR or just a personal PR, the PR was almost two months old. Clearly
> stale and abandoned -- per edk2 contribution workflow, anyway.
>
> Please excuse me for not explaining this in a comment on the PR, but (as
> I said above) I closed 400+ stale PRs manually within 10-15 minutes on
> the github.com WebUI. The necessary muscle memory training didn't allow
> for individual comments.
>
> (I actually tried scripting the mass-closure at first, with the "gh"
> utility, but something in the github.com data model was broken, and the
> server wouldn't allow me to close those PRs with the utility, even
> though I had authenticated the utility under my account, with a complete
> set of scopes -- see my report at
> .)
>
> Regarding your new PR: it's again good for a personal CI run only. If it
> completes fine, please post the patches to the mailing list, using
> git-send-email.
>
> (From browsing recent list traffic, it seems that your colleague Moritz
> Fischer  has posted patches like that to the list;
> please consider consulting with Moritz regarding the git setup (SMTP
> server etc) withing Google. Cc'ing Moritz now.)
>
> When sending the patches like that, please CC the maintainers and
> reviewers that are supposed to review them. Once they are happy with the
> series, one of them will submit a PR with them, and set the "push" label
> on the PR. When the CI run succeeds, the mergify bot will merge *that*
> PR automatically.
>

I think we were already way past this with Dionna's work - numerous
iterations have been posted and discussed, and the merge of the final
version was only deferred because of the soft freeze.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98368): https://edk2.groups.io/g/devel/message/98368
Mute This Topic: https://groups.io/mt/94894288/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 3/3] MdeModulePkg: Notify BeforeExitBootServices in CoreExitBootServices

[Laszlo Ersek]

On 1/12/23 00:08, Dionna Glaze via groups.io wrote:
> On Thu, Nov 10, 2022 at 8:55 AM Kinney, Michael D
>  wrote:
>>
>> Hi Dionna,
>>
>> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
>>
>> I think you are at step 13.  If you have not done so already, please update 
>> the
>> commit messages with all the Reviewed-by and Acked-by tags and make sure your
>> branch is rebased against the latest edk2/master and update the PR with that
>> content and verify that all EDK II CI checks pass.
>>
>> At that point, it is the responsibility of the EDK II Maintainers to review
>> the final state of the PR and set the "push" label if everything looks 
>> correct.
>>
>> At this moment, we are in Soft Freeze and will be in Hard Freeze for the next
>> 2 weeks.  If this is considered critical for the stable tag release, then
>> please send a request to Liming with justification for stable tag.  
>> Otherwise,
>> it will be merged after the stable tag release.
>>
>> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning
>>
>> Thanks,
>>
>> Mike
>>
> 
> Hi Mike, my PR was closed without comment
> https://github.com/tianocore/edk2/pull/3623 so I rebased and created a
> new PR after the holidays and hard freeze. I hope this isn't
> considered bad practice https://github.com/tianocore/edk2/pull/3885
> 

I closed the PR -- similarly to how I manually closed 400+ stale PRs
then -- because it was not a maintainer-submitted PR with the "push"
label set. In other words, it was just a personal build, for triggering
a CI run.

And, in fact regardlessly of whether it was a "push"-labeled maintainer
PR or just a personal PR, the PR was almost two months old. Clearly
stale and abandoned -- per edk2 contribution workflow, anyway.

Please excuse me for not explaining this in a comment on the PR, but (as
I said above) I closed 400+ stale PRs manually within 10-15 minutes on
the github.com WebUI. The necessary muscle memory training didn't allow
for individual comments.

(I actually tried scripting the mass-closure at first, with the "gh"
utility, but something in the github.com data model was broken, and the
server wouldn't allow me to close those PRs with the utility, even
though I had authenticated the utility under my account, with a complete
set of scopes -- see my report at
.)

Regarding your new PR: it's again good for a personal CI run only. If it
completes fine, please post the patches to the mailing list, using
git-send-email.

(From browsing recent list traffic, it seems that your colleague Moritz
Fischer  has posted patches like that to the list;
please consider consulting with Moritz regarding the git setup (SMTP
server etc) withing Google. Cc'ing Moritz now.)

When sending the patches like that, please CC the maintainers and
reviewers that are supposed to review them. Once they are happy with the
series, one of them will submit a PR with them, and set the "push" label
on the PR. When the CI run succeeds, the mergify bot will merge *that*
PR automatically.

Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98361): https://edk2.groups.io/g/devel/message/98361
Mute This Topic: https://groups.io/mt/94894288/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 3/3] MdeModulePkg: Notify BeforeExitBootServices in CoreExitBootServices

[Dionna Glaze via groups.io]

On Thu, Nov 10, 2022 at 8:55 AM Kinney, Michael D
 wrote:
>
> Hi Dionna,
>
> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
>
> I think you are at step 13.  If you have not done so already, please update 
> the
> commit messages with all the Reviewed-by and Acked-by tags and make sure your
> branch is rebased against the latest edk2/master and update the PR with that
> content and verify that all EDK II CI checks pass.
>
> At that point, it is the responsibility of the EDK II Maintainers to review
> the final state of the PR and set the "push" label if everything looks 
> correct.
>
> At this moment, we are in Soft Freeze and will be in Hard Freeze for the next
> 2 weeks.  If this is considered critical for the stable tag release, then
> please send a request to Liming with justification for stable tag.  Otherwise,
> it will be merged after the stable tag release.
>
> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning
>
> Thanks,
>
> Mike
>

Hi Mike, my PR was closed without comment
https://github.com/tianocore/edk2/pull/3623 so I rebased and created a
new PR after the holidays and hard freeze. I hope this isn't
considered bad practice https://github.com/tianocore/edk2/pull/3885

-- 
-Dionna Glaze, PhD (she/her)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98317): https://edk2.groups.io/g/devel/message/98317
Mute This Topic: https://groups.io/mt/94894288/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 3/3] MdeModulePkg: Notify BeforeExitBootServices in CoreExitBootServices

[Michael D Kinney]

Hi Dionna,

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

I think you are at step 13.  If you have not done so already, please update the
commit messages with all the Reviewed-by and Acked-by tags and make sure your
branch is rebased against the latest edk2/master and update the PR with that
content and verify that all EDK II CI checks pass.

At that point, it is the responsibility of the EDK II Maintainers to review
the final state of the PR and set the "push" label if everything looks correct.

At this moment, we are in Soft Freeze and will be in Hard Freeze for the next
2 weeks.  If this is considered critical for the stable tag release, then 
please send a request to Liming with justification for stable tag.  Otherwise,
it will be merged after the stable tag release.

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning

Thanks,

Mike



> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Dionna Glaze 
> via groups.io
> Sent: Thursday, November 10, 2022 8:44 AM
> To: Kinney, Michael D 
> Cc: devel@edk2.groups.io; Gerd Hoffmann ; James Bottomley 
> ; Yao, Jiewen
> ; Tom Lendacky ; Ard 
> Biesheuvel ; Xu, Min M
> ; Andrew Fish ; Ni, Ray 
> 
> Subject: Re: [edk2-devel] [PATCH 3/3] MdeModulePkg: Notify 
> BeforeExitBootServices in CoreExitBootServices
> 
> > Reviewed-by: Michael D Kinney 
> 
> Great, thanks Michael. With all three patches reviewed/acked, does
> that mean they get merged, or what else has to be done? I'm new to
> this.
> 
> --
> -Dionna Glaze, PhD (she/her)
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96201): https://edk2.groups.io/g/devel/message/96201
Mute This Topic: https://groups.io/mt/94894288/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 3/3] MdeModulePkg: Notify BeforeExitBootServices in CoreExitBootServices

[Dionna Glaze via groups.io]

> Reviewed-by: Michael D Kinney 

Great, thanks Michael. With all three patches reviewed/acked, does
that mean they get merged, or what else has to be done? I'm new to
this.

--
-Dionna Glaze, PhD (she/her)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96199): https://edk2.groups.io/g/devel/message/96199
Mute This Topic: https://groups.io/mt/94894288/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 3/3] MdeModulePkg: Notify BeforeExitBootServices in CoreExitBootServices

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Dionna Glaze 
> via groups.io
> Sent: Tuesday, November 8, 2022 8:46 AM
> To: devel@edk2.groups.io
> Cc: Dionna Glaze ; Gerd Hoffmann ; 
> James Bottomley ; Yao, Jiewen
> ; Tom Lendacky ; Ard 
> Biesheuvel ; Xu, Min M
> ; Andrew Fish ; Kinney, Michael D 
> ; Ni, Ray ;
> Yao, Jiewen 
> Subject: [edk2-devel] [PATCH 3/3] MdeModulePkg: Notify BeforeExitBootServices 
> in CoreExitBootServices
> 
> Location of notification is has been specified in UEFI v2.9.
> 
> Cc: Gerd Hoffmann 
> Cc: James Bottomley 
> Cc: Jiewen Yao 
> Cc: Tom Lendacky 
> Cc: Ard Biesheuvel 
> Cc: "Min M. Xu" 
> Cc: Andrew Fish 
> Cc: "Michael D. Kinney" 
> Cc: Ray Ni 
> 
> Acked-by: Jiewen Yao 
> Signed-off-by: Dionna Glaze 
> ---
>  MdeModulePkg/Core/Dxe/DxeMain.inf   | 1 +
>  MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 6 ++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/MdeModulePkg/Core/Dxe/DxeMain.inf 
> b/MdeModulePkg/Core/Dxe/DxeMain.inf
> index e4bca89577..35d5bf0dee 100644
> --- a/MdeModulePkg/Core/Dxe/DxeMain.inf
> +++ b/MdeModulePkg/Core/Dxe/DxeMain.inf
> @@ -100,6 +100,7 @@
>gEfiEventVirtualAddressChangeGuid ## CONSUMES ## 
> Event
>## CONSUMES   ## Event
>## PRODUCES   ## Event
> +  gEfiEventBeforeExitBootServicesGuid
>gEfiEventExitBootServicesGuid
>gEfiHobMemoryAllocModuleGuid  ## SOMETIMES_CONSUMES   ## 
> HOB
>gEfiFirmwareFileSystem2Guid   ## CONSUMES ## 
> GUID # Used to compare with FV's file system guid
> and get the FV's file system format
> diff --git a/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c 
> b/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c
> index 5733f0c8ec..4683016ed7 100644
> --- a/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c
> +++ b/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c
> @@ -763,6 +763,12 @@ CoreExitBootServices (
>  {
>EFI_STATUS  Status;
> 
> +  //
> +  // Notify other drivers of their last chance to use boot services
> +  // before the memory map is terminated.
> +  //
> +  CoreNotifySignalList (&gEfiEventBeforeExitBootServicesGuid);
> +
>//
>// Disable Timer
>//
> --
> 2.38.1.431.g37b22c650d-goog
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96167): https://edk2.groups.io/g/devel/message/96167
Mute This Topic: https://groups.io/mt/94894288/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-