Ray,
Thanks for the comments. I'll modify the code in next version patch set.
Thanks,
Dun
-Original Message-
From: Ni, Ray
Sent: Friday, March 31, 2023 3:01 PM
To: Tan, Dun ; devel@edk2.groups.io
Cc: Bi, Dandan ; Gao, Liming ;
Wang, Jian J
Subject: RE: [PATCH 7/9] MdeModulePkg/DxeIpl: Create page table by
CpuPageTableLib
Thanks for the cleanup: 166(+) 679(-).
2 minor comments:
> UINTN
> CreateIdentityMappingPageTables (
> + IN BOOLEAN Is32BitPageTable,
[Ray] Can you change the parameter name as Is64bitPageTable? Because 64bit is
the trend, I don't like to say future is "FALSE".
> + MapAttribute.Uint64 = 0;
[Ray] Can you add explicitly "MapAttribute.Bits.Present = 0"?
> + MapMask.Uint64 = 0;
> + MapMask.Bits.Present = 1;
> + if (IsNullDetectionEnabled ()) {
> +CreateOrUpdatePageTable (&PageTable, PagingMode, 0, SIZE_4KB,
> + &MapAttribute, &MapMask); }
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102239): https://edk2.groups.io/g/devel/message/102239
Mute This Topic: https://groups.io/mt/97897985/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
