Re: [edk2-devel] [PATCH V2 7/9] MdePkg: Add PcdPciMmio32(64)Translation PCDs

2021-09-28 Thread Abner Chang


> -Original Message-
> From: Schaefer, Daniel
> Sent: Wednesday, September 29, 2021 7:36 AM
> To: Chang, Abner (HPS SW/FW Technologist) ;
> devel@edk2.groups.io
> Cc: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Ard
> Biesheuvel ; Leif Lindholm
> ; Sami Mujawar ; Gerd
> Hoffmann ; Sunil V L 
> Subject: Re: [PATCH V2 7/9] MdePkg: Add PcdPciMmio32(64)Translation
> PCDs
> 
> Also here. I think this should be combined into patch 8.
Same reason as the previous one.

Because there are different maintainers for MdePkg and Arm*Pkg, thus we have to 
separate the patches for them based on Maintainers.txt. MdePkg owners just give 
their reviewed-by for the MdePkg changes but not Arm*Pkg changes. So those 
changes can't be in the same patch.
The cover letter gives each module maintainers the whole picture of this patch 
set. So they can understand the reason having the changes on their module.

Abner

> 
> On 9/28/21 16:31, Abner Chang wrote:
> > PcdPciMmio32Translation and PcdPciMmio64Translation PCDs are added
> > to MdePkg as the common PCDs for ARM and RSIC-V archs.
> >
> > The one under ArmPkg is removed in the next patch.
> >
> > Signed-off-by: Abner Chang 
> > Cc: Michael D Kinney 
> > Cc: Liming Gao 
> > Cc: Zhiguang Liu 
> > Cc: Ard Biesheuvel 
> > Cc: Leif Lindholm 
> > Cc: Sami Mujawar 
> > Cc: Gerd Hoffmann 
> > Cc: Daniel Schaefer 
> > Cc: Sunil V L 
> > ---
> >  MdePkg/MdePkg.dec | 8 
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
> > index 08d259764a..9df95abc50 100644
> > --- a/MdePkg/MdePkg.dec
> > +++ b/MdePkg/MdePkg.dec
> > @@ -2306,6 +2306,14 @@
> ># @Prompt PCI I/O Memory Map Window Base Address.
> >
> gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x0|UINT64|0x0040
> >
> > +  ## This value is used for the 32-bit PCI memory map I/O base address
> translation.
> > +  # @Prompt 32-bit PCI Memory Map I/O Base Address translation.
> > +
> gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation|0x0|UINT64|0x
> 0041
> > +
> > +  ## This value is used for the 64-bit PCI memory map I/O base address
> translation.
> > +  # @Prompt 64-bit PCI Memory Map I/O Base Address translation.
> > +
> gEfiMdePkgTokenSpaceGuid.PcdPciMmio64Translation|0x0|UINT64|0x
> 0042
> > +
> >## This value is used to set the size of PCI express hierarchy. The 
> > default
> is 256 MB.
> ># @Prompt PCI Express Base Size.
> >
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize|0x1000|UINT64|0x
> 000f
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81249): https://edk2.groups.io/g/devel/message/81249
Mute This Topic: https://groups.io/mt/85920592/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




Re: [edk2-devel] [PATCH V2 7/9] MdePkg: Add PcdPciMmio32(64)Translation PCDs

2021-09-28 Thread Daniel Schaefer
Also here. I think this should be combined into patch 8.

On 9/28/21 16:31, Abner Chang wrote:
> PcdPciMmio32Translation and PcdPciMmio64Translation PCDs are added
> to MdePkg as the common PCDs for ARM and RSIC-V archs.
> 
> The one under ArmPkg is removed in the next patch.
> 
> Signed-off-by: Abner Chang 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Zhiguang Liu 
> Cc: Ard Biesheuvel 
> Cc: Leif Lindholm 
> Cc: Sami Mujawar 
> Cc: Gerd Hoffmann 
> Cc: Daniel Schaefer 
> Cc: Sunil V L 
> ---
>  MdePkg/MdePkg.dec | 8 
>  1 file changed, 8 insertions(+)
> 
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
> index 08d259764a..9df95abc50 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -2306,6 +2306,14 @@
># @Prompt PCI I/O Memory Map Window Base Address.
>gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x0|UINT64|0x0040
>  
> +  ## This value is used for the 32-bit PCI memory map I/O base address 
> translation.
> +  # @Prompt 32-bit PCI Memory Map I/O Base Address translation.
> +  gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation|0x0|UINT64|0x0041
> +
> +  ## This value is used for the 64-bit PCI memory map I/O base address 
> translation.
> +  # @Prompt 64-bit PCI Memory Map I/O Base Address translation.
> +  gEfiMdePkgTokenSpaceGuid.PcdPciMmio64Translation|0x0|UINT64|0x0042
> +
>## This value is used to set the size of PCI express hierarchy. The 
> default is 256 MB.
># @Prompt PCI Express Base Size.
>gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize|0x1000|UINT64|0x000f
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81242): https://edk2.groups.io/g/devel/message/81242
Mute This Topic: https://groups.io/mt/85920592/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-