Re: [edk2-devel] [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection dynamic and set it accordingly
Thanks Chasel! Best Regards, Xiaoqiang Zhang -Original Message- From: Chiu, Chasel Sent: Wednesday, September 22, 2021 4:39 PM To: Zhang, Xiaoqiang ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Zeng, Star Subject: RE: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection dynamic and set it accordingly Patch pushed: https://github.com/tianocore/edk2/commit/f334c5a41dc4702b1c767c6614025aa2f802f9a4 Thanks, Chasel > -Original Message- > From: Zhang, Xiaoqiang > Sent: Thursday, September 16, 2021 11:45 AM > To: devel@edk2.groups.io > Cc: Zhang, Xiaoqiang ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection > dynamic and set it accordingly > > From: Zhang Xiaoqiang > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3632 > > PcdFspModeSelection will be used to set FSP mode. > Make PcdFspModeSelection dynamic and set it accordingly. > > Signed-off-by: Zhang Xiaoqiang > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > --- > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > index a3b9363779..b8dac1b574 100644 > --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > @@ -82,12 +82,6 @@ ># @Prompt Skip FSP API from FSP wrapper. > > > gIntelFsp2WrapperTokenSpaceGuid.PcdSkipFspApi|0x|UINT32|0x4 > 009 > > > > - ## This PCD decides how Wrapper code utilizes FSP > > - # 0: DISPATCH mode (FSP Wrapper will load PeiCore from FSP without > calling FSP API) > > - # 1: API mode (FSP Wrapper will call FSP API) > > - # > > - > gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0x0001|UIN > T8|0x400A > > - > >## This PCD decides how FSP is measured > ># 1) The BootGuard ACM may already measured the FSP component, such > as FSPT/FSPM. > ># We need a flag (PCD) to indicate if there is need to do such FSP > measurement or NOT. > > @@ -106,6 +100,12 @@ > > gIntelFsp2WrapperTokenSpaceGuid.PcdFspMeasurementConfig|0x000 > 0|UINT32|0x400B > > > > [PcdsFixedAtBuild, PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx] > > + ## This PCD decides how Wrapper code utilizes FSP > > + # 0: DISPATCH mode (FSP Wrapper will load PeiCore from FSP without > calling FSP API) > > + # 1: API mode (FSP Wrapper will call FSP API) > > + # > > + > gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0x0001|UIN > T8|0x400A > > + > ># > >## These are the base address of FSP-M/S > ># > > -- > 2.32.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#80987): https://edk2.groups.io/g/devel/message/80987 Mute This Topic: https://groups.io/mt/85644790/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection dynamic and set it accordingly
Patch pushed: https://github.com/tianocore/edk2/commit/f334c5a41dc4702b1c767c6614025aa2f802f9a4 Thanks, Chasel > -Original Message- > From: Zhang, Xiaoqiang > Sent: Thursday, September 16, 2021 11:45 AM > To: devel@edk2.groups.io > Cc: Zhang, Xiaoqiang ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection > dynamic and set it accordingly > > From: Zhang Xiaoqiang > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3632 > > PcdFspModeSelection will be used to set FSP mode. > Make PcdFspModeSelection dynamic and set it accordingly. > > Signed-off-by: Zhang Xiaoqiang > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > --- > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > index a3b9363779..b8dac1b574 100644 > --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > @@ -82,12 +82,6 @@ ># @Prompt Skip FSP API from FSP wrapper. > > > gIntelFsp2WrapperTokenSpaceGuid.PcdSkipFspApi|0x|UINT32|0x4 > 009 > > > > - ## This PCD decides how Wrapper code utilizes FSP > > - # 0: DISPATCH mode (FSP Wrapper will load PeiCore from FSP without > calling FSP API) > > - # 1: API mode (FSP Wrapper will call FSP API) > > - # > > - > gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0x0001|UIN > T8|0x400A > > - > >## This PCD decides how FSP is measured > ># 1) The BootGuard ACM may already measured the FSP component, such > as FSPT/FSPM. > ># We need a flag (PCD) to indicate if there is need to do such FSP > measurement or NOT. > > @@ -106,6 +100,12 @@ > > gIntelFsp2WrapperTokenSpaceGuid.PcdFspMeasurementConfig|0x000 > 0|UINT32|0x400B > > > > [PcdsFixedAtBuild, PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx] > > + ## This PCD decides how Wrapper code utilizes FSP > > + # 0: DISPATCH mode (FSP Wrapper will load PeiCore from FSP without > calling FSP API) > > + # 1: API mode (FSP Wrapper will call FSP API) > > + # > > + > gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0x0001|UIN > T8|0x400A > > + > ># > >## These are the base address of FSP-M/S > ># > > -- > 2.32.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#80953): https://edk2.groups.io/g/devel/message/80953 Mute This Topic: https://groups.io/mt/85644790/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection dynamic and set it accordingly
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Xiaoqiang > Sent: Thursday, September 16, 2021 11:45 AM > To: devel@edk2.groups.io > Cc: Zhang, Xiaoqiang ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection dynamic > and set it accordingly > > From: Zhang Xiaoqiang > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3632 > > PcdFspModeSelection will be used to set FSP mode. > Make PcdFspModeSelection dynamic and set it accordingly. > > Signed-off-by: Zhang Xiaoqiang > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > --- > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > index a3b9363779..b8dac1b574 100644 > --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > @@ -82,12 +82,6 @@ ># @Prompt Skip FSP API from FSP wrapper. > > > gIntelFsp2WrapperTokenSpaceGuid.PcdSkipFspApi|0x|UINT32|0x400 > 9 > > > > - ## This PCD decides how Wrapper code utilizes FSP > > - # 0: DISPATCH mode (FSP Wrapper will load PeiCore from FSP without calling > FSP API) > > - # 1: API mode (FSP Wrapper will call FSP API) > > - # > > - > gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0x0001|UINT8| > 0x400A > > - > >## This PCD decides how FSP is measured > ># 1) The BootGuard ACM may already measured the FSP component, such as > FSPT/FSPM. > ># We need a flag (PCD) to indicate if there is need to do such FSP > measurement > or NOT. > > @@ -106,6 +100,12 @@ > > gIntelFsp2WrapperTokenSpaceGuid.PcdFspMeasurementConfig|0x|UI > NT32|0x400B > > > > [PcdsFixedAtBuild, PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx] > > + ## This PCD decides how Wrapper code utilizes FSP > > + # 0: DISPATCH mode (FSP Wrapper will load PeiCore from FSP without calling > FSP API) > > + # 1: API mode (FSP Wrapper will call FSP API) > > + # > > + > gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0x0001|UINT8| > 0x400A > > + > ># > >## These are the base address of FSP-M/S > ># > > -- > 2.32.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#80750): https://edk2.groups.io/g/devel/message/80750 Mute This Topic: https://groups.io/mt/85644790/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
