Looks good to me except one typo. Please see my inline comment.
Thanks,
Ted
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
Sent: Wednesday, May 18, 2022 9:41 AM
To: Duggapu, Chinni B ; devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Zeng, Star
; S, Ashraf Ali
Subject: Re: [edk2-devel] [PATCH v5 2/2] IntelFsp2WrapperPkg: FSP_TEMP_RAM_INIT
call must follow X64 Calling Convention
Thanks Chinni!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Duggapu, Chinni B
> Sent: Tuesday, May 17, 2022 4:44 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S,
> Ashraf Ali
> Subject: [PATCH v5 2/2] IntelFsp2WrapperPkg: FSP_TEMP_RAM_INIT call
> must follow X64 Calling Convention
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3926
> Pass Input parameters using RCX.
>
> Cc: Chasel Chiu
> Cc: Nate DeSimone
> Cc: Star Zeng
> Cc: Ashraf Ali S
> Signed-off-by: cbduggap
> ---
> .../SecFspWrapperPlatformSecLibSample/X64/SecEntry.nasm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/X64
> /SecEntry.nasm
> b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/X64
> /SecEntry.nasm
> index dbbf63336e..065d80d0e2 100644
> ---
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/X64
> /SecEntry.nasm
> +++
> b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/X64
> /SecEntry.nasm
> @@ -130,6 +130,9 @@ FspHeaderFound:
>mov eax, dword [edi + FSP_HEADER_IMAGEBASE_OFFSET]
>
>add eax, dword [edi + FSP_HEADER_TEMPRAMINIT_OFFSET]
>
>
>
> + ; Pass Fsp T Udp pointer as Input parameter
[Ted]: It should be Upd not Udp.
>
> + mov rcx, ASM_PFX(FsptUpdDataPtr)
>
> +
>
>; Setup the hardcode stack
>
>mov rsp, TempRamInitStack
>
>
>
> @@ -167,5 +170,4 @@ FspApiFailed:
> align 10h
>
> TempRamInitStack:
>
> DQ TempRamInitDone
>
> -DQ ASM_PFX(FsptUpdDataPtr) ; TempRamInitParams
>
>
>
> --
> 2.36.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89874): https://edk2.groups.io/g/devel/message/89874
Mute This Topic: https://groups.io/mt/91159382/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
