Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

2019-07-16 Thread Wu, Hao A
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Tuesday, July 16, 2019 9:53 PM
> To: Wu, Hao A
> Cc: r...@edk2.groups.io; devel@edk2.groups.io; Andrew Fish; Laszlo Ersek;
> Kinney, Michael D; Wang, Jian J; Ni, Ray; Zeng, Star
> Subject: Re: [edk2-devel] [RFC] Fine-grained review ownership for
> MdeModulePkg
> 
> Hi Hao Wu,
> 
> Are you ready to send out a v1 yet? (Or did I miss it?)
> I would prefer to get this in before the GetMaintainer.py script, and
> after the comment updates to Maintainers.txt.


Sorry Leif,

You did not miss anything.
I was planning to send out the patch after your proposed changes are pushed.

Now, I have sent out the patch at:
https://edk2.groups.io/g/devel/message/43827

Best Regards,
Hao Wu


> 
> Best Regards,
> 
> Leif
> 
> On Mon, Jun 24, 2019 at 01:16:05AM +, Wu, Hao A wrote:
> > Hello all,
> >
> > With Leif's comment on the better usage of the wildcard character & 'X:' 
> > tag:
> > https://edk2.groups.io/g/devel/message/42587
> >
> > The list is updated as shown below.
> >
> > Also, I forgot to mention that some directory/file may be classified into
> > multiple classes. I think it is a valid case, for example:
> >
> > MdeModulePkg/Library/SmmMemoryAllocationProfileLib
> >
> > matches both 'Memory Management' and 'SMM' sections:
> >
> > Memory Management - F: MdeModulePkg/*Mem*/
> > SMM   - F: MdeModulePkg/*Smm*/
> >
> > Then, reviewers from both classes should be Cc-ed when changes are
> made in
> > the above library.
> >
> > If the updated list is good enough, the next step will be determining the
> > reviewer(s) for each feature in the list.
> >
> >
> > The updated list:
> > ACPI:
> > F: MdeModulePkg/Include/*/*Acpi*.h
> > F: MdeModulePkg/Universal/Acpi/
> >
> > BDS:
> > F: MdeModulePkg/*BootManager*/
> > X: MdeModulePkg/Application/BootManagerMenuApp/
> > F: MdeModulePkg/Include/Library/UefiBootManagerLib.h
> > F: MdeModulePkg/Universal/BdsDxe/
> > F: MdeModulePkg/Universal/LoadFileOnFv2/
> > F: MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.*
> >
> > Console:
> > F: MdeModulePkg/Include/Guid/ConnectConInEvent.h
> > F: MdeModulePkg/Include/Guid/Console*.h
> > F: MdeModulePkg/Include/Guid/StandardErrorDevice.h
> > F: MdeModulePkg/Include/Guid/TtyTerm.h
> > F: MdeModulePkg/Universal/Console/
> > X: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
> >
> > Core (PEI, DXE and Runtime):
> > F: MdeModulePkg/*SectionExtract*/
> > F: MdeModulePkg/Core/Dxe/
> > X: MdeModulePkg/Core/Dxe/Gcd/
> > X: MdeModulePkg/Core/Dxe/Mem/
> > F: MdeModulePkg/Core/DxeIplPeim/
> > F: MdeModulePkg/Core/Pei/
> > X: MdeModulePkg/Core/Pei/Memory/
> > X: MdeModulePkg/Core/Pei/PciCfg2/
> > X: MdeModulePkg/Core/Pei/Reset/
> > X: MdeModulePkg/Core/Pei/StatusCode/
> > F: MdeModulePkg/Core/RuntimeDxe/
> > F: MdeModulePkg/Include/Guid/Crc32GuidedSectionExtraction.h
> > F: MdeModulePkg/Include/Guid/EventExitBootServiceFailed.h
> > F: MdeModulePkg/Include/Guid/IdleLoopEvent.h
> > F: MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h
> > F: MdeModulePkg/Include/Library/SecurityManagementLib.h
> > F: MdeModulePkg/Library/DxeSecurityManagementLib/
> > F: MdeModulePkg/Universal/PlatformDriOverrideDxe/
> > F: MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c
> >
> > Debug:
> > F: MdeModulePkg/*Debug*/
> > X: MdeModulePkg/Universal/EbcDxe/EbcDebugger/
> > F: MdeModulePkg/Include/Guid/DebugMask.h
> > F: MdeModulePkg/Include/Library/DebugAgentLib.h
> > F: MdeModulePkg/Include/Ppi/Debug.h
> >
> > Decompress:
> > F: MdeModulePkg/Include/Guid/LzmaDecompress.h
> > F: MdeModulePkg/Library/*Decompress*/
> >
> > Device:
> > F: MdeModulePkg/*Serial*/
> > X: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/
> > F: MdeModulePkg/Bus/
> > X: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/
> > X: MdeModulePkg/Bus/Pci/PciBusDxe/
> > X: MdeModulePkg/Bus/Pci/PciHostBridgeDxe/
> > F: MdeModulePkg/Include/*/*Ata*.h
> > F: MdeModulePkg/Include/*/*NonDiscoverableDevice*.h
> > F: MdeModulePkg/Include/*/*NvmExpress*.h
> > F: MdeModulePkg/Include/*/*SerialPort*.h
> > F: MdeModulePkg/Include/*/*SdMmc*.h
> > F: MdeModulePkg/Include/*/*Ufs*.h
> > F: MdeModulePkg/Include/*/*Usb*.h
> > F: MdeModulePkg/Include/Guid/S3StorageDeviceInitList.h
> > F: MdeModulePkg/Include/Guid/RecoveryDevice.h
> > F: MdeModulePkg/Include/Ppi/Stor

Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

2019-07-16 Thread Leif Lindholm
Hi Hao Wu,

Are you ready to send out a v1 yet? (Or did I miss it?)
I would prefer to get this in before the GetMaintainer.py script, and
after the comment updates to Maintainers.txt.

Best Regards,

Leif

On Mon, Jun 24, 2019 at 01:16:05AM +, Wu, Hao A wrote:
> Hello all,
> 
> With Leif's comment on the better usage of the wildcard character & 'X:' tag:
> https://edk2.groups.io/g/devel/message/42587
> 
> The list is updated as shown below.
> 
> Also, I forgot to mention that some directory/file may be classified into
> multiple classes. I think it is a valid case, for example:
> 
> MdeModulePkg/Library/SmmMemoryAllocationProfileLib
> 
> matches both 'Memory Management' and 'SMM' sections:
> 
> Memory Management - F: MdeModulePkg/*Mem*/
> SMM   - F: MdeModulePkg/*Smm*/
> 
> Then, reviewers from both classes should be Cc-ed when changes are made in
> the above library.
> 
> If the updated list is good enough, the next step will be determining the
> reviewer(s) for each feature in the list.
> 
> 
> The updated list:
> ACPI:
> F: MdeModulePkg/Include/*/*Acpi*.h
> F: MdeModulePkg/Universal/Acpi/
> 
> BDS:
> F: MdeModulePkg/*BootManager*/
> X: MdeModulePkg/Application/BootManagerMenuApp/
> F: MdeModulePkg/Include/Library/UefiBootManagerLib.h
> F: MdeModulePkg/Universal/BdsDxe/
> F: MdeModulePkg/Universal/LoadFileOnFv2/
> F: MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.*
> 
> Console:
> F: MdeModulePkg/Include/Guid/ConnectConInEvent.h
> F: MdeModulePkg/Include/Guid/Console*.h
> F: MdeModulePkg/Include/Guid/StandardErrorDevice.h
> F: MdeModulePkg/Include/Guid/TtyTerm.h
> F: MdeModulePkg/Universal/Console/
> X: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
> 
> Core (PEI, DXE and Runtime):
> F: MdeModulePkg/*SectionExtract*/
> F: MdeModulePkg/Core/Dxe/
> X: MdeModulePkg/Core/Dxe/Gcd/
> X: MdeModulePkg/Core/Dxe/Mem/
> F: MdeModulePkg/Core/DxeIplPeim/
> F: MdeModulePkg/Core/Pei/
> X: MdeModulePkg/Core/Pei/Memory/
> X: MdeModulePkg/Core/Pei/PciCfg2/
> X: MdeModulePkg/Core/Pei/Reset/
> X: MdeModulePkg/Core/Pei/StatusCode/
> F: MdeModulePkg/Core/RuntimeDxe/
> F: MdeModulePkg/Include/Guid/Crc32GuidedSectionExtraction.h
> F: MdeModulePkg/Include/Guid/EventExitBootServiceFailed.h
> F: MdeModulePkg/Include/Guid/IdleLoopEvent.h
> F: MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h
> F: MdeModulePkg/Include/Library/SecurityManagementLib.h
> F: MdeModulePkg/Library/DxeSecurityManagementLib/
> F: MdeModulePkg/Universal/PlatformDriOverrideDxe/
> F: MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c
> 
> Debug:
> F: MdeModulePkg/*Debug*/
> X: MdeModulePkg/Universal/EbcDxe/EbcDebugger/
> F: MdeModulePkg/Include/Guid/DebugMask.h
> F: MdeModulePkg/Include/Library/DebugAgentLib.h
> F: MdeModulePkg/Include/Ppi/Debug.h
> 
> Decompress:
> F: MdeModulePkg/Include/Guid/LzmaDecompress.h
> F: MdeModulePkg/Library/*Decompress*/
> 
> Device:
> F: MdeModulePkg/*Serial*/
> X: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/
> F: MdeModulePkg/Bus/
> X: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/
> X: MdeModulePkg/Bus/Pci/PciBusDxe/
> X: MdeModulePkg/Bus/Pci/PciHostBridgeDxe/
> F: MdeModulePkg/Include/*/*Ata*.h
> F: MdeModulePkg/Include/*/*NonDiscoverableDevice*.h
> F: MdeModulePkg/Include/*/*NvmExpress*.h
> F: MdeModulePkg/Include/*/*SerialPort*.h
> F: MdeModulePkg/Include/*/*SdMmc*.h
> F: MdeModulePkg/Include/*/*Ufs*.h
> F: MdeModulePkg/Include/*/*Usb*.h
> F: MdeModulePkg/Include/Guid/S3StorageDeviceInitList.h
> F: MdeModulePkg/Include/Guid/RecoveryDevice.h
> F: MdeModulePkg/Include/Ppi/StorageSecurityCommand.h
> F: MdeModulePkg/Include/Protocol/Ps2Policy.h
> F: MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/
> 
> Disk:
> F: MdeModulePkg/Universal/Disk/
> 
> EBC:
> F: MdeModulePkg/Include/*/*Ebc*.h
> F: MdeModulePkg/Include/Protocol/DebuggerConfiguration.h
> F: MdeModulePkg/Universal/EbcDxe/
> 
> Firmware Update:
> F: MdeModulePkg/*Capsule*/
> F: MdeModulePkg/Include/*/*Capsule*.h
> F: MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h
> F: MdeModulePkg/Include/Library/FmpAuthenticationLib.h
> F: MdeModulePkg/Include/Protocol/EsrtManagement.h
> F: MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h
> F: MdeModulePkg/Library/DisplayUpdateProgressLib*/
> F: MdeModulePkg/Library/FmpAuthenticationLibNull/
> F: MdeModulePkg/Universal/Esrt*/
> 
> Graphic:
> F: MdeModulePkg/*Logo*/
> F: MdeModulePkg/Include/*/*Logo*.h
> F: MdeModulePkg/Include/Library/BmpSupportLib.h
> F: MdeModulePkg/Include/Library/FrameBufferBltLib.h
> F: MdeModulePkg/Library/BaseBmpSupportLib/
> F: MdeModulePkg/Library/FrameBufferBltLib/
> F: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
> 
> HII/UI:
> F: MdeModulePkg/*FileExplorer*/
> F: MdeModulePkg/*Hii*/
> F: MdeModulePkg/*Ui*/
> F: MdeModulePkg/Application/BootManagerMenuApp/
> F: MdeModulePkg/Include/*/*FileExplorer*.h
> F: MdeModulePkg/Include/*/*FormBrowser*.h
> F: MdeModulePkg/Include/*/*Hii*.h
> F: 

Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

2019-06-24 Thread Yao, Jiewen
thanks
How about to put driversample to ui?

How about to put iommu to device?

thank you!
Yao, Jiewen


> 在 2019年6月25日,上午4:30,Laszlo Ersek  写道:
> 
>> On 06/24/19 03:16, Wu, Hao A wrote:
>> Hello all,
>> 
>> With Leif's comment on the better usage of the wildcard character & 'X:' tag:
>> https://edk2.groups.io/g/devel/message/42587
>> 
>> The list is updated as shown below.
>> 
>> Also, I forgot to mention that some directory/file may be classified into
>> multiple classes. I think it is a valid case, for example:
>> 
>> MdeModulePkg/Library/SmmMemoryAllocationProfileLib
>> 
>> matches both 'Memory Management' and 'SMM' sections:
>> 
>> Memory Management - F: MdeModulePkg/*Mem*/
>> SMM   - F: MdeModulePkg/*Smm*/
>> 
>> Then, reviewers from both classes should be Cc-ed when changes are made in
>> the above library.
>> 
>> If the updated list is good enough, the next step will be determining the
>> reviewer(s) for each feature in the list.
> 
> I think it's good enough. :)
> 
> Thanks
> Laszlo
> 
>> 
>> 
>> The updated list:
>> ACPI:
>> F: MdeModulePkg/Include/*/*Acpi*.h
>> F: MdeModulePkg/Universal/Acpi/
>> 
>> BDS:
>> F: MdeModulePkg/*BootManager*/
>> X: MdeModulePkg/Application/BootManagerMenuApp/
>> F: MdeModulePkg/Include/Library/UefiBootManagerLib.h
>> F: MdeModulePkg/Universal/BdsDxe/
>> F: MdeModulePkg/Universal/LoadFileOnFv2/
>> F: MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.*
>> 
>> Console:
>> F: MdeModulePkg/Include/Guid/ConnectConInEvent.h
>> F: MdeModulePkg/Include/Guid/Console*.h
>> F: MdeModulePkg/Include/Guid/StandardErrorDevice.h
>> F: MdeModulePkg/Include/Guid/TtyTerm.h
>> F: MdeModulePkg/Universal/Console/
>> X: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
>> 
>> Core (PEI, DXE and Runtime):
>> F: MdeModulePkg/*SectionExtract*/
>> F: MdeModulePkg/Core/Dxe/
>> X: MdeModulePkg/Core/Dxe/Gcd/
>> X: MdeModulePkg/Core/Dxe/Mem/
>> F: MdeModulePkg/Core/DxeIplPeim/
>> F: MdeModulePkg/Core/Pei/
>> X: MdeModulePkg/Core/Pei/Memory/
>> X: MdeModulePkg/Core/Pei/PciCfg2/
>> X: MdeModulePkg/Core/Pei/Reset/
>> X: MdeModulePkg/Core/Pei/StatusCode/
>> F: MdeModulePkg/Core/RuntimeDxe/
>> F: MdeModulePkg/Include/Guid/Crc32GuidedSectionExtraction.h
>> F: MdeModulePkg/Include/Guid/EventExitBootServiceFailed.h
>> F: MdeModulePkg/Include/Guid/IdleLoopEvent.h
>> F: MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h
>> F: MdeModulePkg/Include/Library/SecurityManagementLib.h
>> F: MdeModulePkg/Library/DxeSecurityManagementLib/
>> F: MdeModulePkg/Universal/PlatformDriOverrideDxe/
>> F: MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c
>> 
>> Debug:
>> F: MdeModulePkg/*Debug*/
>> X: MdeModulePkg/Universal/EbcDxe/EbcDebugger/
>> F: MdeModulePkg/Include/Guid/DebugMask.h
>> F: MdeModulePkg/Include/Library/DebugAgentLib.h
>> F: MdeModulePkg/Include/Ppi/Debug.h
>> 
>> Decompress:
>> F: MdeModulePkg/Include/Guid/LzmaDecompress.h
>> F: MdeModulePkg/Library/*Decompress*/
>> 
>> Device:
>> F: MdeModulePkg/*Serial*/
>> X: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/
>> F: MdeModulePkg/Bus/
>> X: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/
>> X: MdeModulePkg/Bus/Pci/PciBusDxe/
>> X: MdeModulePkg/Bus/Pci/PciHostBridgeDxe/
>> F: MdeModulePkg/Include/*/*Ata*.h
>> F: MdeModulePkg/Include/*/*NonDiscoverableDevice*.h
>> F: MdeModulePkg/Include/*/*NvmExpress*.h
>> F: MdeModulePkg/Include/*/*SerialPort*.h
>> F: MdeModulePkg/Include/*/*SdMmc*.h
>> F: MdeModulePkg/Include/*/*Ufs*.h
>> F: MdeModulePkg/Include/*/*Usb*.h
>> F: MdeModulePkg/Include/Guid/S3StorageDeviceInitList.h
>> F: MdeModulePkg/Include/Guid/RecoveryDevice.h
>> F: MdeModulePkg/Include/Ppi/StorageSecurityCommand.h
>> F: MdeModulePkg/Include/Protocol/Ps2Policy.h
>> F: MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/
>> 
>> Disk:
>> F: MdeModulePkg/Universal/Disk/
>> 
>> EBC:
>> F: MdeModulePkg/Include/*/*Ebc*.h
>> F: MdeModulePkg/Include/Protocol/DebuggerConfiguration.h
>> F: MdeModulePkg/Universal/EbcDxe/
>> 
>> Firmware Update:
>> F: MdeModulePkg/*Capsule*/
>> F: MdeModulePkg/Include/*/*Capsule*.h
>> F: MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h
>> F: MdeModulePkg/Include/Library/FmpAuthenticationLib.h
>> F: MdeModulePkg/Include/Protocol/EsrtManagement.h
>> F: MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h
>> F: MdeModulePkg/Library/DisplayUpdateProgressLib*/
>> F: MdeModulePkg/Library/FmpAuthenticationLibNull/
>> F: MdeModulePkg/Universal/Esrt*/
>> 
>> Graphic:
>> F: MdeModulePkg/*Logo*/
>> F: MdeModulePkg/Include/*/*Logo*.h
>> F: MdeModulePkg/Include/Library/BmpSupportLib.h
>> F: MdeModulePkg/Include/Library/FrameBufferBltLib.h
>> F: MdeModulePkg/Library/BaseBmpSupportLib/
>> F: MdeModulePkg/Library/FrameBufferBltLib/
>> F: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
>> 
>> HII/UI:
>> F: MdeModulePkg/*FileExplorer*/
>> F: MdeModulePkg/*Hii*/
>> F: MdeModulePkg/*Ui*/
>> F: MdeModulePkg/Application/BootManagerMenuApp/
>> F: MdeModulePkg/Include/*/*FileExplorer*.h
>> F: 

Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

2019-06-24 Thread Laszlo Ersek
On 06/24/19 03:16, Wu, Hao A wrote:
> Hello all,
> 
> With Leif's comment on the better usage of the wildcard character & 'X:' tag:
> https://edk2.groups.io/g/devel/message/42587
> 
> The list is updated as shown below.
> 
> Also, I forgot to mention that some directory/file may be classified into
> multiple classes. I think it is a valid case, for example:
> 
> MdeModulePkg/Library/SmmMemoryAllocationProfileLib
> 
> matches both 'Memory Management' and 'SMM' sections:
> 
> Memory Management - F: MdeModulePkg/*Mem*/
> SMM   - F: MdeModulePkg/*Smm*/
> 
> Then, reviewers from both classes should be Cc-ed when changes are made in
> the above library.
> 
> If the updated list is good enough, the next step will be determining the
> reviewer(s) for each feature in the list.

I think it's good enough. :)

Thanks
Laszlo

> 
> 
> The updated list:
> ACPI:
> F: MdeModulePkg/Include/*/*Acpi*.h
> F: MdeModulePkg/Universal/Acpi/
> 
> BDS:
> F: MdeModulePkg/*BootManager*/
> X: MdeModulePkg/Application/BootManagerMenuApp/
> F: MdeModulePkg/Include/Library/UefiBootManagerLib.h
> F: MdeModulePkg/Universal/BdsDxe/
> F: MdeModulePkg/Universal/LoadFileOnFv2/
> F: MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.*
> 
> Console:
> F: MdeModulePkg/Include/Guid/ConnectConInEvent.h
> F: MdeModulePkg/Include/Guid/Console*.h
> F: MdeModulePkg/Include/Guid/StandardErrorDevice.h
> F: MdeModulePkg/Include/Guid/TtyTerm.h
> F: MdeModulePkg/Universal/Console/
> X: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
> 
> Core (PEI, DXE and Runtime):
> F: MdeModulePkg/*SectionExtract*/
> F: MdeModulePkg/Core/Dxe/
> X: MdeModulePkg/Core/Dxe/Gcd/
> X: MdeModulePkg/Core/Dxe/Mem/
> F: MdeModulePkg/Core/DxeIplPeim/
> F: MdeModulePkg/Core/Pei/
> X: MdeModulePkg/Core/Pei/Memory/
> X: MdeModulePkg/Core/Pei/PciCfg2/
> X: MdeModulePkg/Core/Pei/Reset/
> X: MdeModulePkg/Core/Pei/StatusCode/
> F: MdeModulePkg/Core/RuntimeDxe/
> F: MdeModulePkg/Include/Guid/Crc32GuidedSectionExtraction.h
> F: MdeModulePkg/Include/Guid/EventExitBootServiceFailed.h
> F: MdeModulePkg/Include/Guid/IdleLoopEvent.h
> F: MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h
> F: MdeModulePkg/Include/Library/SecurityManagementLib.h
> F: MdeModulePkg/Library/DxeSecurityManagementLib/
> F: MdeModulePkg/Universal/PlatformDriOverrideDxe/
> F: MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c
> 
> Debug:
> F: MdeModulePkg/*Debug*/
> X: MdeModulePkg/Universal/EbcDxe/EbcDebugger/
> F: MdeModulePkg/Include/Guid/DebugMask.h
> F: MdeModulePkg/Include/Library/DebugAgentLib.h
> F: MdeModulePkg/Include/Ppi/Debug.h
> 
> Decompress:
> F: MdeModulePkg/Include/Guid/LzmaDecompress.h
> F: MdeModulePkg/Library/*Decompress*/
> 
> Device:
> F: MdeModulePkg/*Serial*/
> X: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/
> F: MdeModulePkg/Bus/
> X: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/
> X: MdeModulePkg/Bus/Pci/PciBusDxe/
> X: MdeModulePkg/Bus/Pci/PciHostBridgeDxe/
> F: MdeModulePkg/Include/*/*Ata*.h
> F: MdeModulePkg/Include/*/*NonDiscoverableDevice*.h
> F: MdeModulePkg/Include/*/*NvmExpress*.h
> F: MdeModulePkg/Include/*/*SerialPort*.h
> F: MdeModulePkg/Include/*/*SdMmc*.h
> F: MdeModulePkg/Include/*/*Ufs*.h
> F: MdeModulePkg/Include/*/*Usb*.h
> F: MdeModulePkg/Include/Guid/S3StorageDeviceInitList.h
> F: MdeModulePkg/Include/Guid/RecoveryDevice.h
> F: MdeModulePkg/Include/Ppi/StorageSecurityCommand.h
> F: MdeModulePkg/Include/Protocol/Ps2Policy.h
> F: MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/
> 
> Disk:
> F: MdeModulePkg/Universal/Disk/
> 
> EBC:
> F: MdeModulePkg/Include/*/*Ebc*.h
> F: MdeModulePkg/Include/Protocol/DebuggerConfiguration.h
> F: MdeModulePkg/Universal/EbcDxe/
> 
> Firmware Update:
> F: MdeModulePkg/*Capsule*/
> F: MdeModulePkg/Include/*/*Capsule*.h
> F: MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h
> F: MdeModulePkg/Include/Library/FmpAuthenticationLib.h
> F: MdeModulePkg/Include/Protocol/EsrtManagement.h
> F: MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h
> F: MdeModulePkg/Library/DisplayUpdateProgressLib*/
> F: MdeModulePkg/Library/FmpAuthenticationLibNull/
> F: MdeModulePkg/Universal/Esrt*/
> 
> Graphic:
> F: MdeModulePkg/*Logo*/
> F: MdeModulePkg/Include/*/*Logo*.h
> F: MdeModulePkg/Include/Library/BmpSupportLib.h
> F: MdeModulePkg/Include/Library/FrameBufferBltLib.h
> F: MdeModulePkg/Library/BaseBmpSupportLib/
> F: MdeModulePkg/Library/FrameBufferBltLib/
> F: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
> 
> HII/UI:
> F: MdeModulePkg/*FileExplorer*/
> F: MdeModulePkg/*Hii*/
> F: MdeModulePkg/*Ui*/
> F: MdeModulePkg/Application/BootManagerMenuApp/
> F: MdeModulePkg/Include/*/*FileExplorer*.h
> F: MdeModulePkg/Include/*/*FormBrowser*.h
> F: MdeModulePkg/Include/*/*Hii*.h
> F: MdeModulePkg/Include/Library/CustomizedDisplayLib.h
> F: MdeModulePkg/Include/Protocol/DisplayProtocol.h
> F: MdeModulePkg/Library/CustomizedDisplayLib/
> F: MdeModulePkg/Universal/DisplayEngineDxe/
> F: 

Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

2019-06-23 Thread Wu, Hao A
Hello all,

With Leif's comment on the better usage of the wildcard character & 'X:' tag:
https://edk2.groups.io/g/devel/message/42587

The list is updated as shown below.

Also, I forgot to mention that some directory/file may be classified into
multiple classes. I think it is a valid case, for example:

MdeModulePkg/Library/SmmMemoryAllocationProfileLib

matches both 'Memory Management' and 'SMM' sections:

Memory Management - F: MdeModulePkg/*Mem*/
SMM   - F: MdeModulePkg/*Smm*/

Then, reviewers from both classes should be Cc-ed when changes are made in
the above library.

If the updated list is good enough, the next step will be determining the
reviewer(s) for each feature in the list.


The updated list:
ACPI:
F: MdeModulePkg/Include/*/*Acpi*.h
F: MdeModulePkg/Universal/Acpi/

BDS:
F: MdeModulePkg/*BootManager*/
X: MdeModulePkg/Application/BootManagerMenuApp/
F: MdeModulePkg/Include/Library/UefiBootManagerLib.h
F: MdeModulePkg/Universal/BdsDxe/
F: MdeModulePkg/Universal/LoadFileOnFv2/
F: MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.*

Console:
F: MdeModulePkg/Include/Guid/ConnectConInEvent.h
F: MdeModulePkg/Include/Guid/Console*.h
F: MdeModulePkg/Include/Guid/StandardErrorDevice.h
F: MdeModulePkg/Include/Guid/TtyTerm.h
F: MdeModulePkg/Universal/Console/
X: MdeModulePkg/Universal/Console/GraphicsOutputDxe/

Core (PEI, DXE and Runtime):
F: MdeModulePkg/*SectionExtract*/
F: MdeModulePkg/Core/Dxe/
X: MdeModulePkg/Core/Dxe/Gcd/
X: MdeModulePkg/Core/Dxe/Mem/
F: MdeModulePkg/Core/DxeIplPeim/
F: MdeModulePkg/Core/Pei/
X: MdeModulePkg/Core/Pei/Memory/
X: MdeModulePkg/Core/Pei/PciCfg2/
X: MdeModulePkg/Core/Pei/Reset/
X: MdeModulePkg/Core/Pei/StatusCode/
F: MdeModulePkg/Core/RuntimeDxe/
F: MdeModulePkg/Include/Guid/Crc32GuidedSectionExtraction.h
F: MdeModulePkg/Include/Guid/EventExitBootServiceFailed.h
F: MdeModulePkg/Include/Guid/IdleLoopEvent.h
F: MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h
F: MdeModulePkg/Include/Library/SecurityManagementLib.h
F: MdeModulePkg/Library/DxeSecurityManagementLib/
F: MdeModulePkg/Universal/PlatformDriOverrideDxe/
F: MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c

Debug:
F: MdeModulePkg/*Debug*/
X: MdeModulePkg/Universal/EbcDxe/EbcDebugger/
F: MdeModulePkg/Include/Guid/DebugMask.h
F: MdeModulePkg/Include/Library/DebugAgentLib.h
F: MdeModulePkg/Include/Ppi/Debug.h

Decompress:
F: MdeModulePkg/Include/Guid/LzmaDecompress.h
F: MdeModulePkg/Library/*Decompress*/

Device:
F: MdeModulePkg/*Serial*/
X: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/
F: MdeModulePkg/Bus/
X: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/
X: MdeModulePkg/Bus/Pci/PciBusDxe/
X: MdeModulePkg/Bus/Pci/PciHostBridgeDxe/
F: MdeModulePkg/Include/*/*Ata*.h
F: MdeModulePkg/Include/*/*NonDiscoverableDevice*.h
F: MdeModulePkg/Include/*/*NvmExpress*.h
F: MdeModulePkg/Include/*/*SerialPort*.h
F: MdeModulePkg/Include/*/*SdMmc*.h
F: MdeModulePkg/Include/*/*Ufs*.h
F: MdeModulePkg/Include/*/*Usb*.h
F: MdeModulePkg/Include/Guid/S3StorageDeviceInitList.h
F: MdeModulePkg/Include/Guid/RecoveryDevice.h
F: MdeModulePkg/Include/Ppi/StorageSecurityCommand.h
F: MdeModulePkg/Include/Protocol/Ps2Policy.h
F: MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/

Disk:
F: MdeModulePkg/Universal/Disk/

EBC:
F: MdeModulePkg/Include/*/*Ebc*.h
F: MdeModulePkg/Include/Protocol/DebuggerConfiguration.h
F: MdeModulePkg/Universal/EbcDxe/

Firmware Update:
F: MdeModulePkg/*Capsule*/
F: MdeModulePkg/Include/*/*Capsule*.h
F: MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h
F: MdeModulePkg/Include/Library/FmpAuthenticationLib.h
F: MdeModulePkg/Include/Protocol/EsrtManagement.h
F: MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h
F: MdeModulePkg/Library/DisplayUpdateProgressLib*/
F: MdeModulePkg/Library/FmpAuthenticationLibNull/
F: MdeModulePkg/Universal/Esrt*/

Graphic:
F: MdeModulePkg/*Logo*/
F: MdeModulePkg/Include/*/*Logo*.h
F: MdeModulePkg/Include/Library/BmpSupportLib.h
F: MdeModulePkg/Include/Library/FrameBufferBltLib.h
F: MdeModulePkg/Library/BaseBmpSupportLib/
F: MdeModulePkg/Library/FrameBufferBltLib/
F: MdeModulePkg/Universal/Console/GraphicsOutputDxe/

HII/UI:
F: MdeModulePkg/*FileExplorer*/
F: MdeModulePkg/*Hii*/
F: MdeModulePkg/*Ui*/
F: MdeModulePkg/Application/BootManagerMenuApp/
F: MdeModulePkg/Include/*/*FileExplorer*.h
F: MdeModulePkg/Include/*/*FormBrowser*.h
F: MdeModulePkg/Include/*/*Hii*.h
F: MdeModulePkg/Include/Library/CustomizedDisplayLib.h
F: MdeModulePkg/Include/Protocol/DisplayProtocol.h
F: MdeModulePkg/Library/CustomizedDisplayLib/
F: MdeModulePkg/Universal/DisplayEngineDxe/
F: MdeModulePkg/Universal/SetupBrowserDxe/

IPMI:
F: MdeModulePkg/Include/*/*Ipmi*.h
F: MdeModulePkg/Library/*Ipmi*/

Memory Management:
F: MdeModulePkg/*Mem*/
F: MdeModulePkg/Core/Dxe/Gcd/
F: MdeModulePkg/Include/*/*Mem*.h
F: MdeModulePkg/Include/*/*IoMmu*.h

PCD:
F: MdeModulePkg/Application/DumpDynPcd/
F: MdeModulePkg/Include/*/*Pcd*.h
F: MdeModulePkg/Universal/PCD/

PCI 

Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

2019-06-20 Thread Wu, Hao A
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> rebe...@bluestop.org
> Sent: Friday, June 21, 2019 6:24 AM
> To: devel@edk2.groups.io; Wu, Hao A
> Cc: ler...@redhat.com; Leif Lindholm; Kinney, Michael D; Andrew Fish;
> Justen, Jordan L; Ard Biesheuvel; Gao, Liming; Yao, Jiewen; Zeng, Star
> Subject: Re: [edk2-devel] [RFC] Fine-grained review ownership for
> MdeModulePkg
> 
> On 2019-06-10 02:06, Wu, Hao A wrote:
> > Hello all,
> >
> > Driven by the issue raised and discussions with thread:
> > https://edk2.groups.io/g/devel/topic/31907735#42076
> >
> > This RFC proposal is raised to work out a fine-grained review ownership
> > for MdeModulePkg.
> 
> 
> Being an RFC, I think this should be CC'd to r...@edk2.groups.io
> (https://edk2.groups.io/g/rfc)?


Thanks for the reminder, I will post the next update to the above list.

Best Regards,
Hao Wu


> 
> 
> --
> Rebecca Cran
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42664): https://edk2.groups.io/g/devel/message/42664
Mute This Topic: https://groups.io/mt/32001926/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

2019-06-20 Thread rebecca
On 2019-06-10 02:06, Wu, Hao A wrote:
> Hello all,
>
> Driven by the issue raised and discussions with thread:
> https://edk2.groups.io/g/devel/topic/31907735#42076
>
> This RFC proposal is raised to work out a fine-grained review ownership
> for MdeModulePkg.


Being an RFC, I think this should be CC'd to r...@edk2.groups.io
(https://edk2.groups.io/g/rfc)?


-- 
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42662): https://edk2.groups.io/g/devel/message/42662
Mute This Topic: https://groups.io/mt/32001926/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

2019-06-20 Thread Laszlo Ersek
On 06/19/19 11:35, Leif Lindholm wrote:
> On Wed, Jun 19, 2019 at 05:09:40AM +, Wu, Hao A wrote:
>> Hello all,
>>
>> As suggested by Ray and Leif, modules (with wildcard) in MdeModulePkg are
>> classified to a list of features.
>>
>> Please note that:
>> * The below list is a draft at this moment, please help to provide
>>   feedbacks/comments;
>> * Modules with no clear classification are listed under the 'Misc' section
>>   at the bottom of the list.
> 
> Thank you for doing the heavy lifting.

+1

> A few comments below on how this could be more easily described in the
> Maintainer.txt syntax.

With Leif's comments addressed, I'd be super pleased to have this
pattern list for covering MdeModulePkg, minimally as a starting point.
(I'm neutral on moving around GraphicsOutputDxe and Logo -- we could do
that now, or as a later improvement.)

Thanks!
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42652): https://edk2.groups.io/g/devel/message/42652
Mute This Topic: https://groups.io/mt/32001926/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

2019-06-19 Thread Leif Lindholm
On Wed, Jun 19, 2019 at 05:09:40AM +, Wu, Hao A wrote:
> Hello all,
> 
> As suggested by Ray and Leif, modules (with wildcard) in MdeModulePkg are
> classified to a list of features.
> 
> Please note that:
> * The below list is a draft at this moment, please help to provide
>   feedbacks/comments;
> * Modules with no clear classification are listed under the 'Misc' section
>   at the bottom of the list.

Thank you for doing the heavy lifting.

A few comments below on how this could be more easily described in the
Maintainer.txt syntax.

> ACPI:
> MdeModulePkg/Include/*/*Acpi*.h
> MdeModulePkg/Universal/Acpi/
>
> BDS:
> MdeModulePkg/Include/Library/PlatformBootManagerLib.h
> MdeModulePkg/Include/Library/UefiBootManagerLib.h
> MdeModulePkg/Library/PlatformBootManagerLibNull/
> MdeModulePkg/Library/UefiBootManagerLib/

MdeModulePkg/*BootManagerLib*/

> MdeModulePkg/Universal/BdsDxe/
> MdeModulePkg/Universal/BootManagerPolicyDxe/

Or maybe even
MdeModulePkg/*BootManager*/, which would also match the line above.

> MdeModulePkg/Universal/LoadFileOnFv2/
> MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.*
> 
> Console:
> MdeModulePkg/Include/Guid/ConnectConInEvent.h
> MdeModulePkg/Include/Guid/ConsoleInDevice.h
> MdeModulePkg/Include/Guid/ConsoleOutDevice.h
> MdeModulePkg/Include/Guid/StandardErrorDevice.h
> MdeModulePkg/Include/Guid/TtyTerm.h
> MdeModulePkg/Universal/Console/ConPlatformDxe/
> MdeModulePkg/Universal/Console/ConSplitterDxe/
> MdeModulePkg/Universal/Console/GraphicsConsoleDxe/
> MdeModulePkg/Universal/Console/TerminalDxe/

I was intrigued as to why this did not specify
MdeModulePkg/Universal/Console/
See [1] below.

However, even if suggestions included below were not implemented, the
situation could be described as:
F: MdeModulePkg/Universal/Console/
X: MdeModulePkg/Universal/Console/GraphicsOutputDxe/

> Core (PEI, DXE and Runtime):
> MdeModulePkg/Core/Dxe/*
> MdeModulePkg/Core/Dxe/Dispatcher/
> MdeModulePkg/Core/Dxe/DxeMain/
> MdeModulePkg/Core/Dxe/Event/
> MdeModulePkg/Core/Dxe/FwVol*/
> MdeModulePkg/Core/Dxe/Hand/
> MdeModulePkg/Core/Dxe/Image/
> MdeModulePkg/Core/Dxe/Library/
> MdeModulePkg/Core/Dxe/Misc/
> MdeModulePkg/Core/Dxe/SectionExtraction/

F: MdeModulePkg/Core/Dxe/
X: MdeModulePkg/Core/Dxe/Mem/

> MdeModulePkg/Core/DxeIplPeim/
> MdeModulePkg/Core/Pei/*
> MdeModulePkg/Core/Pei/BootMode/
> MdeModulePkg/Core/Pei/CpuIo/
> MdeModulePkg/Core/Pei/Dependency/
> MdeModulePkg/Core/Pei/Dispatcher/
> MdeModulePkg/Core/Pei/FwVol/
> MdeModulePkg/Core/Pei/Hob/
> MdeModulePkg/Core/Pei/Image/
> MdeModulePkg/Core/Pei/PeiMain/
> MdeModulePkg/Core/Pei/Ppi/
> MdeModulePkg/Core/Pei/Security/

F: MdeModulePkg/Core/Pei/
X: MdeModulePkg/Core/Pei/Memory/
X: MdeModulePkg/Core/Pei/PciCfg2/
X: MdeModulePkg/Core/Pei/Reset/
X: MdeModulePkg/Core/Pei/StatusCode/

I'm going to stop there, because I'm lazy, and I realise this is about
the responsibility areas rather than an actual patch to
Maintainers.txt - and I think my point is made.

Further comments below.

> MdeModulePkg/Core/RuntimeDxe/
> MdeModulePkg/Include/Guid/Crc32GuidedSectionExtraction.h
> MdeModulePkg/Include/Guid/EventExitBootServiceFailed.h
> MdeModulePkg/Include/Guid/IdleLoopEvent.h
> MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h
> MdeModulePkg/Include/Library/SecurityManagementLib.h
> MdeModulePkg/Library/*SectionExtract*/
> MdeModulePkg/Library/DxeSecurityManagementLib/
> MdeModulePkg/Universal/PlatformDriOverrideDxe/
> MdeModulePkg/Universal/SectionExtraction*/
> MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c
> 
> Debug:
> MdeModulePkg/Include/Guid/DebugMask.h
> MdeModulePkg/Include/Library/DebugAgentLib.h
> MdeModulePkg/Include/Ppi/Debug.h
> MdeModulePkg/Library/*Debug*/
> MdeModulePkg/Universal/Debug*/
> 
> Decompress:
> MdeModulePkg/Include/Guid/LzmaDecompress.h
> MdeModulePkg/Library/*Decompress*/
> 
> Device:
> MdeModulePkg/Bus/Ata/
> MdeModulePkg/Bus/I2c/
> MdeModulePkg/Bus/Isa/
> MdeModulePkg/Bus/Pci/Ehci*/
> MdeModulePkg/Bus/Pci/IdeBusPei/
> MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/
> MdeModulePkg/Bus/Pci/NvmExpress*/
> MdeModulePkg/Bus/Pci/PciSioSerialDxe/
> MdeModulePkg/Bus/Pci/SataControllerDxe/
> MdeModulePkg/Bus/Pci/SdMmc*/
> MdeModulePkg/Bus/Pci/Ufs*/
> MdeModulePkg/Bus/Pci/Uhci*/
> MdeModulePkg/Bus/Pci/Xhci*/
> MdeModulePkg/Bus/Scsi/
> MdeModulePkg/Bus/Sd/
> MdeModulePkg/Bus/Ufs/
> MdeModulePkg/Bus/Usb/
> MdeModulePkg/Include/*/*Ata*.h
> MdeModulePkg/Include/*/*NonDiscoverableDevice*.h
> MdeModulePkg/Include/*/*NvmExpress*.h
> MdeModulePkg/Include/*/*SerialPort*.h
> MdeModulePkg/Include/*/*SdMmc*.h
> MdeModulePkg/Include/*/*Ufs*.h
> MdeModulePkg/Include/*/*Usb*.h
> MdeModulePkg/Include/Guid/S3StorageDeviceInitList.h
> MdeModulePkg/Include/Guid/RecoveryDevice.h
> MdeModulePkg/Include/Guid/UsbKeyBoardLayout.h
> MdeModulePkg/Include/Ppi/StorageSecurityCommand.h
> MdeModulePkg/Include/Protocol/Ps2Policy.h
> MdeModulePkg/Library/BaseSerialPortLib16550/
> 

Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

2019-06-11 Thread Laszlo Ersek
On 06/11/19 11:51, Leif Lindholm wrote:
> Hi Wu Hao,
> 
> I am working on a proposal (and proof-of-concept) machine readable
> Maintainers.txt format, and a GetMaintainer.py script, based on the
> format used by QEMU.
> 
> One of the key features of that format is the F: tag, which specifes a
> filesytem path (with wildcard support).

This is great news! QEMU's pathnames are very flexible.

> 
> While this is just an RFC in progress (to be sent out later in week),
> if you could take that into account, and figure out which paths
> correspond to which areas of responsibility, that would make a test
> run of the script much easier.
> 
> For my part, I would suggest adding (not just for MdeModulePkg)
> F: */ARM/*
> F: */AARCH64/*
> as maintained by myself and Ard.

* Under ArmVirtPkg, we distinguish "Xen modules":

R: Julien Grall 
   (Xen modules)

I hope that Ard can come up with a set of patterns for these modules. :)

* Under OvmfPkg, we distinguish:

R: Anthony Perard 
   (Xen modules)
R: Julien Grall 
   (Xen modules)

and

R: Marc-André Lureau 
   (TPM2 modules)
R: Stefan Berger 
   (TPM2 modules)

For "Xen modules", I'd suggest:

F: OvmfPkg/AcpiPlatformDxe/Xen.c
F: OvmfPkg/Include/Guid/Xen*.h
F: OvmfPkg/Include/IndustryStandard/Xen/
F: OvmfPkg/Include/Library/Xen*.h
F: OvmfPkg/Include/Protocol/Xen*.h
F: OvmfPkg/Library/PciHostBridgeLib/XenSupport.c
F: OvmfPkg/Library/XenConsoleSerialPortLib/
F: OvmfPkg/Library/XenHypercallLib/
F: OvmfPkg/Library/XenIoMmioLib
F: OvmfPkg/PlatformPei/Xen.*
F: OvmfPkg/SmbiosPlatformDxe/*Xen.c
F: OvmfPkg/XenBusDxe/
F: OvmfPkg/XenIoPciDxe/
F: OvmfPkg/XenPvBlkDxe/

For "TPM2 modules":

F: OvmfPkg/Include/IndustryStandard/QemuTpm.h
F: OvmfPkg/Library/Tcg2PhysicalPresenceLib*/
F: OvmfPkg/Tcg/

Thanks
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42210): https://edk2.groups.io/g/devel/message/42210
Mute This Topic: https://groups.io/mt/32001926/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

2019-06-11 Thread Leif Lindholm
Hi Wu Hao,

I am working on a proposal (and proof-of-concept) machine readable
Maintainers.txt format, and a GetMaintainer.py script, based on the
format used by QEMU.

One of the key features of that format is the F: tag, which specifes a
filesytem path (with wildcard support).

While this is just an RFC in progress (to be sent out later in week),
if you could take that into account, and figure out which paths
correspond to which areas of responsibility, that would make a test
run of the script much easier.

For my part, I would suggest adding (not just for MdeModulePkg)
F: */ARM/*
F: */AARCH64/*
as maintained by myself and Ard.

Best Regards,

Leif

On Mon, Jun 10, 2019 at 08:06:23AM +, Wu, Hao A wrote:
> Hello all,
> 
> Driven by the issue raised and discussions with thread:
> https://edk2.groups.io/g/devel/topic/31907735#42076
> 
> This RFC proposal is raised to work out a fine-grained review ownership
> for MdeModulePkg.
> 
> The goal is to update the 'MdeModulePkg' section in file Maintainers.txt
> to resemble the format like the 'OvmfPkg' section. Several reviewers will
> be listed to take the ownership to review patches for a specific feature
> in the package.
> 
> In order to get the list of reviewers, a 2-step process will be adopted:
> 1. Work out a list that contains major features in MdeModulePkg.
> 2. Call for owners for every item in the list.
> 
> For 1, a coarse feature list is:
> Acpi
> Bds
> Capsule
> Compress
> Console
> Core (PeiCore, DxeCore, PiSmmCore, etc. Mainly content in MdeModulePkg/Core/ 
> folder)
> Device (peripheral & storage)
> Disk
> EBC
> HII
> MemoryManagement (include memory test, memory allocation, memory profile, 
> etc.)
> PCD
> PCI bus
> Reset
> S3 (including LockBox)
> SMBIOS
> SMM
> Status Code
> UI
> Variable
> Misc (all the components that do not fit in the above items)
> 
> Once we think the granularity of the above list is fine and there is no
> significant feature missing, I will update such list to include the
> modules that belong to a specific feature. So adjustments can be done to
> work out the final feature list.
> 
> The proposal here is far from mature, so any feedback/suggestion will be
> appreciated.
> 
> 
> Best Regards,
> Hao Wu
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42198): https://edk2.groups.io/g/devel/message/42198
Mute This Topic: https://groups.io/mt/32001926/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-