Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC
Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, March 23, 2022 9:28 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Liming > ; Dong, Eric > Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing > libraries to [Components] in DSC > > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3619 > > Adds libraries implemented in MinPlatformPkg to the [Components] > section in MinPlatformPkg.dsc so they are included in the package build. > > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Michael Kubacki > --- > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > index 0f47182c2647..a8373a4ecb37 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > @@ -211,6 +211,13 @@ [Components] > > MinPlatformPkg/Library/BaseVariableReadLibNull/BaseVariableReadLibNull. > inf > > MinPlatformPkg/Library/SmmVariableReadLib/StandaloneMmVariableRead > Lib.inf > > MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWri > teLib.inf > + MinPlatformPkg/Library/PeiVariableReadLib/PeiVariableReadLib.inf > + > + > MinPlatformPkg/Library/DxeRuntimeVariableReadLib/DxeRuntimeVariableR > ea > + dLib.inf > + > MinPlatformPkg/Library/DxeRuntimeVariableWriteLib/DxeRuntimeVariable > Wr > + iteLib.inf > + > MinPlatformPkg/Library/SmmVariableReadLib/TraditionalMmVariableRead > Lib > + .inf > + > MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWrit > eL > + ib.inf > + > MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableReadLib.i > + nf > + MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableWriteLib. > + inf > > [BuildOptions] >*_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES > -- > 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87892): https://edk2.groups.io/g/devel/message/87892 Mute This Topic: https://groups.io/mt/89967094/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC
Thanks for the review. Can you please merge this soon if there are no concerns? On 3/23/2022 2:15 AM, Chiu, Chasel wrote: Reviewed-by: Chasel Chiu -Original Message- From: mikub...@linux.microsoft.com Sent: Wednesday, March 23, 2022 9:28 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3619 Adds libraries implemented in MinPlatformPkg to the [Components] section in MinPlatformPkg.dsc so they are included in the package build. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki --- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc index 0f47182c2647..a8373a4ecb37 100644 --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc @@ -211,6 +211,13 @@ [Components] MinPlatformPkg/Library/BaseVariableReadLibNull/BaseVariableReadLibNull. inf MinPlatformPkg/Library/SmmVariableReadLib/StandaloneMmVariableRead Lib.inf MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWri teLib.inf + MinPlatformPkg/Library/PeiVariableReadLib/PeiVariableReadLib.inf + + MinPlatformPkg/Library/DxeRuntimeVariableReadLib/DxeRuntimeVariableR ea + dLib.inf + MinPlatformPkg/Library/DxeRuntimeVariableWriteLib/DxeRuntimeVariable Wr + iteLib.inf + MinPlatformPkg/Library/SmmVariableReadLib/TraditionalMmVariableRead Lib + .inf + MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWrit eL + ib.inf + MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableReadLib.i + nf + MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableWriteLib. + inf [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES -- 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88335): https://edk2.groups.io/g/devel/message/88335 Mute This Topic: https://groups.io/mt/89967094/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC
Just another reminder to please merge this patch if there is no further feedback. Thanks, Michael On 4/1/2022 10:12 AM, Michael Kubacki wrote: Thanks for the review. Can you please merge this soon if there are no concerns? On 3/23/2022 2:15 AM, Chiu, Chasel wrote: Reviewed-by: Chasel Chiu -Original Message- From: mikub...@linux.microsoft.com Sent: Wednesday, March 23, 2022 9:28 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3619 Adds libraries implemented in MinPlatformPkg to the [Components] section in MinPlatformPkg.dsc so they are included in the package build. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki --- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc index 0f47182c2647..a8373a4ecb37 100644 --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc @@ -211,6 +211,13 @@ [Components] MinPlatformPkg/Library/BaseVariableReadLibNull/BaseVariableReadLibNull. inf MinPlatformPkg/Library/SmmVariableReadLib/StandaloneMmVariableRead Lib.inf MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWri teLib.inf + MinPlatformPkg/Library/PeiVariableReadLib/PeiVariableReadLib.inf + + MinPlatformPkg/Library/DxeRuntimeVariableReadLib/DxeRuntimeVariableR ea + dLib.inf + MinPlatformPkg/Library/DxeRuntimeVariableWriteLib/DxeRuntimeVariable Wr + iteLib.inf + MinPlatformPkg/Library/SmmVariableReadLib/TraditionalMmVariableRead Lib + .inf + MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWrit eL + ib.inf + MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableReadLib.i + nf + MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableWriteLib. + inf [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES -- 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88415): https://edk2.groups.io/g/devel/message/88415 Mute This Topic: https://groups.io/mt/89967094/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC
Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Tuesday, March 22, 2022 6:28 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3619 Adds libraries implemented in MinPlatformPkg to the [Components] section in MinPlatformPkg.dsc so they are included in the package build. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki --- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc index 0f47182c2647..a8373a4ecb37 100644 --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc @@ -211,6 +211,13 @@ [Components] MinPlatformPkg/Library/BaseVariableReadLibNull/BaseVariableReadLibNull.inf MinPlatformPkg/Library/SmmVariableReadLib/StandaloneMmVariableReadLib.inf MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLib.inf + MinPlatformPkg/Library/PeiVariableReadLib/PeiVariableReadLib.inf + + MinPlatformPkg/Library/DxeRuntimeVariableReadLib/DxeRuntimeVariableRea + dLib.inf + MinPlatformPkg/Library/DxeRuntimeVariableWriteLib/DxeRuntimeVariableWr + iteLib.inf + MinPlatformPkg/Library/SmmVariableReadLib/TraditionalMmVariableReadLib + .inf + MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteL + ib.inf + MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableReadLib.i + nf + MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableWriteLib. + inf [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES -- 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88486): https://edk2.groups.io/g/devel/message/88486 Mute This Topic: https://groups.io/mt/89967094/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC
Pushed: https://github.com/tianocore/edk2-platforms/commit/edf5edf -Original Message- From: mikub...@linux.microsoft.com Sent: Tuesday, March 22, 2022 6:28 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3619 Adds libraries implemented in MinPlatformPkg to the [Components] section in MinPlatformPkg.dsc so they are included in the package build. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki --- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc index 0f47182c2647..a8373a4ecb37 100644 --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc @@ -211,6 +211,13 @@ [Components] MinPlatformPkg/Library/BaseVariableReadLibNull/BaseVariableReadLibNull.inf MinPlatformPkg/Library/SmmVariableReadLib/StandaloneMmVariableReadLib.inf MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLib.inf + MinPlatformPkg/Library/PeiVariableReadLib/PeiVariableReadLib.inf + + MinPlatformPkg/Library/DxeRuntimeVariableReadLib/DxeRuntimeVariableRea + dLib.inf + MinPlatformPkg/Library/DxeRuntimeVariableWriteLib/DxeRuntimeVariableWr + iteLib.inf + MinPlatformPkg/Library/SmmVariableReadLib/TraditionalMmVariableReadLib + .inf + MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteL + ib.inf + MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableReadLib.i + nf + MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableWriteLib. + inf [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES -- 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88488): https://edk2.groups.io/g/devel/message/88488 Mute This Topic: https://groups.io/mt/89967094/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
