Re: [edk2-devel] [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance
On Thu, May 09, 2019 at 12:43:15AM +, Dandan Bi wrote: > > > Cc: Ard Biesheuvel > > > Cc: Leif Lindholm > > > Cc: Michael D Kinney > > > > For the series: > > Reviewed-by: Leif Lindholm > > > > Are you happy to push these yourself? > > Could you help to push them? Since I don't have the push rights. Sure. Series pushed as d83f1ca097..c08d3d0931. Thanks! / Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#40332): https://edk2.groups.io/g/devel/message/40332 Mute This Topic: https://groups.io/mt/31539219/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Thursday, May 9, 2019 2:02 AM > To: Bi, Dandan > Cc: devel@edk2.groups.io; Ard Biesheuvel ; > Kinney, Michael D > Subject: Re: [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib > instance > > On Wed, May 08, 2019 at 10:00:24AM +0800, Dandan Bi wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722 > > > > BaseUefiDecompressLib in MdePkg is the base UEFI decompress Library. > > BaseUefiTianoCustomDecompressLib in MdeModulePkg implements the > base > > UEFI decompress functionality and Tiano decompress functionality. > > > > 1. TIANOCOMPRESSED rule in OverdriveBoard.fdf is not used, so remove > > it. > > 2. Platform doesn't use the TianoCompress, so do not have to use > > BaseUefiTianoCustomDecompressLib, can use the BaseUefiDecompressLib > in > > MdePkg directly. > > 3. A common UefiDecompressLib resolution can apply to all module types > > now. So keep the common one in [LibraryClasses.common] section and > > remove all others. > > > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > For the series: > Reviewed-by: Leif Lindholm > > Are you happy to push these yourself? Could you help to push them? Since I don't have the push rights. Thanks, Dandan > > Final note - it would be even better if --stat=1000 and > --stat-graph-width=20 were also used, in accordance with > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git- > guide-for-edk2-contributors-and-maintainers#contrib-23 > While we have a bug in upstream git that means the cover letter still shows > truncated paths, that resolves the problem for the actual patches. > > Best Regards, > > Leif > > > Dandan Bi (7): > > Platform/AMD: Update UefiDecompressLib instance > > Platform/LeMaker: Update UefiDecompressLib instance > > Platform/RPi3: Update UefiDecompressLib instance > > Platform/SoftIron: Update UefiDecompressLib instance > > Silicon/Hisilicon: Update UefiDecompressLib instance > > Silicon/Armada7k8k: Remove TIANOCOMPRESSED rule > > Platform: Remove TIANOCOMPRESSED rule > > > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 5 - > > Platform/AMD/OverdriveBoard/OverdriveBoard.fdf | 9 - > > Platform/ARM/SgiPkg/SgiPlatform.fdf | 9 - > > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 5 - > > Platform/LeMaker/CelloBoard/CelloBoard.fdf | 9 - > > Platform/RaspberryPi/RPi3/RPi3.dsc | 3 --- > > Platform/RaspberryPi/RPi3/RPi3.fdf | 9 - > > Platform/Socionext/DeveloperBox/DeveloperBox.fdf | 9 - > > .../Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf | 9 - > > .../SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 5 - > > .../SoftIron/Overdrive1000Board/Overdrive1000Board.fdf | 9 - > > Silicon/Hisilicon/Hisilicon.dsc.inc | 5 - > > Silicon/Hisilicon/Hisilicon.fdf.inc | 9 - > > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc| 1 - > > Silicon/Marvell/Armada7k8k/Armada7k8k.fdf| 9 - > > 15 files changed, 105 deletions(-) > > > > -- > > 2.18.0.windows.1 > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#40221): https://edk2.groups.io/g/devel/message/40221 Mute This Topic: https://groups.io/mt/31539219/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance
On Wed, May 08, 2019 at 10:00:24AM +0800, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722 > > BaseUefiDecompressLib in MdePkg is the > base UEFI decompress Library. > BaseUefiTianoCustomDecompressLib in MdeModulePkg > implements the base UEFI decompress functionality and > Tiano decompress functionality. > > 1. TIANOCOMPRESSED rule in OverdriveBoard.fdf > is not used, so remove it. > 2. Platform doesn't use the TianoCompress, so do > not have to use BaseUefiTianoCustomDecompressLib, > can use the BaseUefiDecompressLib in MdePkg directly. > 3. A common UefiDecompressLib resolution can apply to > all module types now. So keep the common one in > [LibraryClasses.common] section and remove all others. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney For the series: Reviewed-by: Leif Lindholm Are you happy to push these yourself? Final note - it would be even better if --stat=1000 and --stat-graph-width=20 were also used, in accordance with https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23 While we have a bug in upstream git that means the cover letter still shows truncated paths, that resolves the problem for the actual patches. Best Regards, Leif > Dandan Bi (7): > Platform/AMD: Update UefiDecompressLib instance > Platform/LeMaker: Update UefiDecompressLib instance > Platform/RPi3: Update UefiDecompressLib instance > Platform/SoftIron: Update UefiDecompressLib instance > Silicon/Hisilicon: Update UefiDecompressLib instance > Silicon/Armada7k8k: Remove TIANOCOMPRESSED rule > Platform: Remove TIANOCOMPRESSED rule > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 5 - > Platform/AMD/OverdriveBoard/OverdriveBoard.fdf | 9 - > Platform/ARM/SgiPkg/SgiPlatform.fdf | 9 - > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 5 - > Platform/LeMaker/CelloBoard/CelloBoard.fdf | 9 - > Platform/RaspberryPi/RPi3/RPi3.dsc | 3 --- > Platform/RaspberryPi/RPi3/RPi3.fdf | 9 - > Platform/Socionext/DeveloperBox/DeveloperBox.fdf | 9 - > .../Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf | 9 - > .../SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 5 - > .../SoftIron/Overdrive1000Board/Overdrive1000Board.fdf | 9 - > Silicon/Hisilicon/Hisilicon.dsc.inc | 5 - > Silicon/Hisilicon/Hisilicon.fdf.inc | 9 - > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc| 1 - > Silicon/Marvell/Armada7k8k/Armada7k8k.fdf| 9 - > 15 files changed, 105 deletions(-) > > -- > 2.18.0.windows.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#40214): https://edk2.groups.io/g/devel/message/40214 Mute This Topic: https://groups.io/mt/31539219/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
