Oded AT2 DLR patch

[Andrea Viscovich]

There is a problem.
In at2_send_one message here is the code:
 /* gen DLR_SMSC_SUCCESS */
 if (msg-sms.dlr_mask  DLR_SMSC_SUCCESS)
 {
Msg* dlrmsg;

dlrmsg = msg_create(sms);
dlrmsg-sms.id = msg-sms.id;
dlrmsg-sms.service = octstr_duplicate(msg-sms.service);
dlrmsg-sms.dlr_mask = DLR_SMSC_SUCCESS;
dlrmsg-sms.sms_type = report;
dlrmsg-sms.smsc_id = octstr_duplicate(privdata-conn-id);
dlrmsg-sms.sender = octstr_duplicate(msg-sms.receiver);
dlrmsg-sms.receiver = octstr_duplicate(msg-sms.sender);
dlrmsg-sms.msgdata = octstr_create(ACK/);
octstr_append(dlrmsg-sms.msgdata,msg-sms.dlr_url);
   /* store DLR message if needed for SMSC generated delivery
reports */
   if (msg-sms.dlr_mask  (DLR_SUCCESS | DLR_FAIL |
DLR_BUFFERED)) {
  ...

So if one has dlrmask = 3 will never get dlr, as there is dlr only
if in the mask is set DLR_SMSC_SUCCESS bit
Oded, think I found my problem :-),
by the way you should tell me which dlrmask you were using!
Andrea
P.S. in smsc_at2.c in your patch you have some debug(bb.at2..

RE: Oded AT2 DLR patch

[Oded Arbel]

 -Original Message-
 From: Andrea Viscovich [mailto:[EMAIL PROTECTED]]
 
 There is a problem.
 In at2_send_one message here is the code:
snip
 So if one has dlrmask = 3 will never get dlr, as there is dlr only
 if in the mask is set DLR_SMSC_SUCCESS bit

ahmm.. oops ? :-\

 Oded, think I found my problem :-),

Yes you did. updated patch attached.

 by the way you should tell me which dlrmask you were using!

31.

 P.S. in smsc_at2.c in your patch you have some debug(bb.at2..

So ?

--
Oded Arbel
m-Wise mobile solutions
[EMAIL PROTECTED]

+972-9-9581711 (116)
+972-67-340014

::..
Diplomacy is the art of saying nice doggy until you can find a rock.



smsc_at2.patch
Description: smsc_at2.patch