Re: [PATCH] configurable max retries
Hi Stipe,
it's pretty simple why we need 2 ints. We need to track 2 values: a)
time of last resend, in order to not to send too oft (delayed); b) how
much retries we did.
If you know how to awoid or better to say how track 2 values within one
int I would like to hear.
Thanks,
Alex
Stipe Tolj wrote:
Stipe Tolj wrote:
+1 on the logic, I assume you did regression test this Alex, did you?
I'm -1 on the new config directive naming, and I'd like to change it to:
sms-resend-freq
sms-resend-retry
Reasons:
'sms-resend-freq' follows naming convention as introduced to prior
config directives 'store-dump-freq' within core group and 'timer-freq'
for wapbox group
'sms-resend-retry' follows naming and semantical convention introduced
via 'http-request-retry' within smsbox group.
I'll change these and commit to cvs.
commited the naming convention fix for the two new directives to cvs.
@Alex: are we required in having two seperate integers in the Msg struct
to reflect the resending issue? I know that you generally do reduce
needed vars as much as possible, so a short description why two are
needed would be great.
Stipe
mailto:stolj_{at}_wapme-group.de
---
Wapme Systems AG
Vogelsanger Weg 80
40470 Düsseldorf, NRW, Germany
phone: +49.211.74845.0
fax: +49.211.74845.299
mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
---
Re: [PATCH] configurable max retries
Alexander Malysh wrote:
Hi Stipe,
it's pretty simple why we need 2 ints. We need to track 2 values: a)
time of last resend, in order to not to send too oft (delayed); b) how
much retries we did.
If you know how to awoid or better to say how track 2 values within one
int I would like to hear.
now, obviously via bit operations ;) ... but that's not considered serios here,
or?
Stipe
mailto:stolj_{at}_wapme-group.de
---
Wapme Systems AG
Vogelsanger Weg 80
40470 Düsseldorf, NRW, Germany
phone: +49.211.74845.0
fax: +49.211.74845.299
mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
---
Re: [PATCH] configurable max retries
hmm, time_t as bit operations... Good luck ;)
Thanks,
Alex
Stipe Tolj wrote:
Alexander Malysh wrote:
Hi Stipe,
it's pretty simple why we need 2 ints. We need to track 2 values: a)
time of last resend, in order to not to send too oft (delayed); b) how
much retries we did.
If you know how to awoid or better to say how track 2 values within
one int I would like to hear.
now, obviously via bit operations ;) ... but that's not considered
serios here, or?
Stipe
mailto:stolj_{at}_wapme-group.de
---
Wapme Systems AG
Vogelsanger Weg 80
40470 Düsseldorf, NRW, Germany
phone: +49.211.74845.0
fax: +49.211.74845.299
mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
---
