Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages)
Hi, Wierd because I sent it as an attachment. Kind Regards, -Original Message- From: Alexander Malysh [mailto:malys...@googlemail.com] On Behalf Of Alexander Malysh Sent: Tuesday, September 14, 2010 6:44 PM To: Michael Zervakis Cc: devel@kannel.org; aguerri...@kannel.org Subject: Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages) could you please send your patch as attachment ? Thanks, Alexander Malysh Am 14.09.2010 um 16:09 schrieb Michael Zervakis: Hi, I moved smscconn_uuid to struct split_parts. Please check. BR, -Original Message- From: Alexander Malysh [mailto:malys...@googlemail.com] On Behalf Of Alexander Malysh Sent: Tuesday, September 14, 2010 1:02 AM To: Michael Zervakis Cc: devel@kannel.org; aguerri...@kannel.org Subject: Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages) Hi Michael, you don't have to alter Msg struct. Just add smscconn_uuid to struct split_parts in gw/msg.h. Thanks, Alexander Malysh Am 13.09.2010 um 21:31 schrieb Michael Zervakis: Hi, I forgot to mention that msg-msg_ConnId uuid is not saved in store since it's useless because if the process restarts the whole Msg will be resend. At least this solution will apply sms-resend-* directives for long sms. BR, -Original Message- From: Alejandro Guerrieri [mailto:aguerri...@kannel.org] Sent: Monday, September 13, 2010 8:25 PM To: Alexander Malysh Cc: Michael Zervakis; malys...@googlemail.com; devel@kannel.org Subject: Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages) The uuid would be different each time you start the service right? What would happen if Kannel is restarted and there were pending parts to send? The new uuid wouldn't match with the pending segments. Regards, -- Alejandro Guerrieri aguerri...@kannel.org On 13/09/2010, at 19:16, Alexander Malysh wrote: Hi, great idea to use uuid to uniquely identify smscconn. we can use this for http admin as well. Thanks, Alexander Malysh Am 13.09.2010 um 19:04 schrieb Michael Zervakis: Hi, I figured out that we can use the same mechanism as in Msg struct to uniquelly identify each SMSCconn. In the attached patch the smscconn struct was modified to include a uuid_t field and Msg struct to store the smscconn uuid_t if we get a temporary error. Smsc_rout2 was also modified to respect msg-msg_ConnId if set. SMSC-A - splits (2 parts) - 1 part sent OK - 2 part get temp. error - write the conn-uuid_t and put it into global queue for resend - router reads msg-msg_ConnId and sends failed part via same connection (if still active) -Original Message- From: Alexander Malysh [mailto:malys...@googlemail.com] On Behalf Of Alexander Malysh Sent: Sunday, September 12, 2010 1:06 PM To: Michael Zervakis Cc: devel@kannel.org; pon...@appcell.net Subject: Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages) Hi, as I already wrote, this patch is not enough. Please see ML wy... Thanks, Alexander Malysh Am 09.09.2010 um 19:04 schrieb Michael Zervakis: Hi, This patch is a possible solution fog Bug #529. The Msg definition was modified so we can store the conn-id originally selected by router. SMSC-A - splits (2 parts) - 1 part sent OK - 2 part get temp. error - write the conn-id and put it into global queue for resend - router reads msg-sms.msg_ConnId and sends failed part via same connection (if still active) Regards, From: devel-boun...@kannel.org [mailto:devel-boun...@kannel.org] On Behalf Of Konstantin Vayner Sent: Thursday, December 17, 2009 12:28 PM To: Alexander Malysh Cc: devel@kannel.org Subject: Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages) why remembering smsc-id in sms.smsc_id is not enough? how does smsbox remember routing when i submit a message with predefined smsc id from http (sendsms) ? On
Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages)
On Wed, 2010-09-15 at 10:52, Alejandro Guerrieri wrote: Send it compressed, Kannel's mail server sends text attachments as part of the body. Maybe your mail client does not interpret it properly because I have got patch as attachment. -- Kind regards, Milan -- Arvanta, IT Securityhttp://www.arvanta.net Please do not send me e-mail containing HTML code.
Submitted...
.minor patch to smppbox. It now sends a nack to bearerbox upon receiving an invalid MO/DLR, so messages won't stay in store. Patch by Victor Luchitz. == Rene pdu_failed_nack.patch Description: Binary data
RE: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages)
I think it's your email client that converts the attachment to text. We receive it as an attachment. -Original Message- From: devel-boun...@kannel.org [mailto:devel-boun...@kannel.org] On Behalf Of Alejandro Guerrieri Sent: Wednesday, 15 September, 2010 10:53 To: Michael Zervakis Cc: devel@kannel.org Subject: Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages) Send it compressed, Kannel's mail server sends text attachments as part of the body. Regards, -- Alejandro Guerrieri aguerri...@kannel.org On 15/09/2010, at 10:06, Michael Zervakis wrote: Hi, Wierd because I sent it as an attachment. Kind Regards, -Original Message- From: Alexander Malysh [mailto:malys...@googlemail.com] On Behalf Of Alexander Malysh Sent: Tuesday, September 14, 2010 6:44 PM To: Michael Zervakis Cc: devel@kannel.org; aguerri...@kannel.org Subject: Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages) could you please send your patch as attachment ? Thanks, Alexander Malysh Am 14.09.2010 um 16:09 schrieb Michael Zervakis: Hi, I moved smscconn_uuid to struct split_parts. Please check. BR, -Original Message- From: Alexander Malysh [mailto:malys...@googlemail.com] On Behalf Of Alexander Malysh Sent: Tuesday, September 14, 2010 1:02 AM To: Michael Zervakis Cc: devel@kannel.org; aguerri...@kannel.org Subject: Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages) Hi Michael, you don't have to alter Msg struct. Just add smscconn_uuid to struct split_parts in gw/msg.h. Thanks, Alexander Malysh Am 13.09.2010 um 21:31 schrieb Michael Zervakis: Hi, I forgot to mention that msg-msg_ConnId uuid is not saved in store since it's useless because if the process restarts the whole Msg will be resend. At least this solution will apply sms-resend-* directives for long sms. BR, -Original Message- From: Alejandro Guerrieri [mailto:aguerri...@kannel.org] Sent: Monday, September 13, 2010 8:25 PM To: Alexander Malysh Cc: Michael Zervakis; malys...@googlemail.com; devel@kannel.org Subject: Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages) The uuid would be different each time you start the service right? What would happen if Kannel is restarted and there were pending parts to send? The new uuid wouldn't match with the pending segments. Regards, -- Alejandro Guerrieri aguerri...@kannel.org On 13/09/2010, at 19:16, Alexander Malysh wrote: Hi, great idea to use uuid to uniquely identify smscconn. we can use this for http admin as well. Thanks, Alexander Malysh Am 13.09.2010 um 19:04 schrieb Michael Zervakis: Hi, I figured out that we can use the same mechanism as in Msg struct to uniquelly identify each SMSCconn. In the attached patch the smscconn struct was modified to include a uuid_t field and Msg struct to store the smscconn uuid_t if we get a temporary error. Smsc_rout2 was also modified to respect msg-msg_ConnId if set. SMSC-A - splits (2 parts) - 1 part sent OK - 2 part get temp. error - write the conn-uuid_t and put it into global queue for resend - router reads msg-msg_ConnId and sends failed part via same connection (if still active) -Original Message- From: Alexander Malysh [mailto:malys...@googlemail.com] On Behalf Of Alexander Malysh Sent: Sunday, September 12, 2010 1:06 PM To: Michael Zervakis Cc: devel@kannel.org; pon...@appcell.net Subject: Re: [PATCH] fix bug #529 (sms-resend-* ignored for concatenated messages) Hi, as I already wrote, this patch is not enough. Please see ML wy... Thanks, Alexander Malysh Am 09.09.2010 um 19:04 schrieb Michael Zervakis: Hi, This patch is a possible solution fog Bug #529. The Msg definition was modified so
