Re: [RFC] adding solaris lib dependencies

2004-10-06 Thread Alexander Malysh 
Stipe Tolj wrote:

> Alexander Malysh wrote:
> 
>> Stipe Tolj wrote:
>> 
>> 
>>>Enver ALTIN wrote:
>>>
It would be a bit better to be under or over semaphore support checks.
>> 
>> 
>> hmm, parse error ;)
>> it's now over semaphore support check, what ist a problem here?
>> 
>> 
Also, we might want to check the *-hpux-* or, sunos part of uname
output, just to be sure this change doesn't affect other systems which
don't need librt (although autoconf/configure is supposed to handle
that).
>> 
>> 
>> if librt is not needed on some systems then it will not be included (see
>> autoconf docs ;))...
> 
> basically I'd like to go with Enver's idea to put it in the case
> "$host" block, like we did for the libc_r.a and likse.a for OpenBSD
> and FreeBSD.

what is a reason to do it manually if autoconf does better job?
anyway too late, just commited to cvs ;)

> 
> Stipe
> 
> mailto:stolj_{at}_wapme.de
> ---
> Wapme Systems AG
> 
> Vogelsanger Weg 80
> 40470 Düsseldorf, NRW, Germany
> 
> phone: +49.211.74845.0
> fax: +49.211.74845.299
> 
> mailto:info_{at}_wapme-systems.de
> http://www.wapme-systems.de/
> ---

-- 
Thanks,
Alex

Re: [RFC] adding solaris lib dependencies

2004-10-06 Thread Stipe Tolj 
Stipe Tolj wrote:
basically I'd like to go with Enver's idea to put it in the case "$host" 
block, like we did for the libc_r.a and likse.a for OpenBSD and FreeBSD.
but consider this more as a +0 option. ;)
Stipe
mailto:stolj_{at}_wapme.de
---
Wapme Systems AG
Vogelsanger Weg 80
40470 Düsseldorf, NRW, Germany
phone: +49.211.74845.0
fax: +49.211.74845.299
mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
---

Re: [RFC] adding solaris lib dependencies

2004-10-06 Thread Stipe Tolj 
Alexander Malysh wrote:
Stipe Tolj wrote:

Enver ALTIN wrote:
It would be a bit better to be under or over semaphore support checks.

hmm, parse error ;)
it's now over semaphore support check, what ist a problem here?

Also, we might want to check the *-hpux-* or, sunos part of uname
output, just to be sure this change doesn't affect other systems which
don't need librt (although autoconf/configure is supposed to handle
that).

if librt is not needed on some systems then it will not be included (see
autoconf docs ;))...
basically I'd like to go with Enver's idea to put it in the case 
"$host" block, like we did for the libc_r.a and likse.a for OpenBSD 
and FreeBSD.

Stipe
mailto:stolj_{at}_wapme.de
---
Wapme Systems AG
Vogelsanger Weg 80
40470 Düsseldorf, NRW, Germany
phone: +49.211.74845.0
fax: +49.211.74845.299
mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
---

Re: [RFC] adding solaris lib dependencies

2004-10-06 Thread Alexander Malysh 
Stipe Tolj wrote:

> Enver ALTIN wrote:
>> It would be a bit better to be under or over semaphore support checks.

hmm, parse error ;)
it's now over semaphore support check, what ist a problem here?

>> Also, we might want to check the *-hpux-* or, sunos part of uname
>> output, just to be sure this change doesn't affect other systems which
>> don't need librt (although autoconf/configure is supposed to handle
>> that).

if librt is not needed on some systems then it will not be included (see
autoconf docs ;))...

I will commit this tiny patch then...

> 
> agreed.
> 
> Stipe
> 
> mailto:stolj_{at}_wapme.de
> ---
> Wapme Systems AG
> 
> Vogelsanger Weg 80
> 40470 Düsseldorf, NRW, Germany
> 
> phone: +49.211.74845.0
> fax: +49.211.74845.299
> 
> mailto:info_{at}_wapme-systems.de
> http://www.wapme-systems.de/
> ---

-- 
Thanks,
Alex

Re: [RFC] adding solaris lib dependencies

2004-10-06 Thread Stipe Tolj 
Enver ALTIN wrote:
It would be a bit better to be under or over semaphore support checks.
Also, we might want to check the *-hpux-* or, sunos part of uname
output, just to be sure this change doesn't affect other systems which
don't need librt (although autoconf/configure is supposed to handle
that).
agreed.
Stipe
mailto:stolj_{at}_wapme.de
---
Wapme Systems AG
Vogelsanger Weg 80
40470 Düsseldorf, NRW, Germany
phone: +49.211.74845.0
fax: +49.211.74845.299
mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
---

Re: [RFC] adding solaris lib dependencies

2004-10-06 Thread Stipe Tolj 
Alexander Malysh wrote:
Stipe Tolj wrote:

Alexander Malysh wrote:

Hi,
how about attached patch?
yes, but do we need to include the lib on our own in $LIBS before
configure runs the Makefile.in mangle and substitutes the vars?! Or is
it enough to call AC_CHECK_LIB() and it will include it on its own?

it's enough to call AC_CHECK_LIB()...
ok, then ++1 from me.
mailto:stolj_{at}_wapme.de
---
Wapme Systems AG
Vogelsanger Weg 80
40470 Düsseldorf, NRW, Germany
phone: +49.211.74845.0
fax: +49.211.74845.299
mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
---

Re: [RFC] adding solaris lib dependencies

2004-10-06 Thread Enver ALTIN 




On Wed, 2004-10-06 at 17:35 +0200, Alexander Malysh wrote:


Hi,



Hi,



how about attached patch?




Index: configure.in
===
RCS file: /home/cvs/gateway/configure.in,v
retrieving revision 1.145
diff -a -u -p -r1.145 configure.in
--- configure.in28 Aug 2004 13:29:10 -  1.145
+++ configure.in6 Oct 2004 15:34:43 -
@@ -303,6 +303,8 @@ pthread_rwlock_destroy(&lock);
 AC_MSG_RESULT(Cross compiling - assuming suuported) ; AC_DEFINE(HAVE_PTHREAD_RWLOCK)])
 
 dnl checking for native semaphore support
+dnl Solaris & HP-UX needs librt.
+AC_CHECK_LIB(rt, sem_init)
 AC_MSG_CHECKING([for semaphore support])
 AC_TRY_RUN([#include 
 int main(void) {


It would be a bit better to be under or over semaphore support checks. Also, we might want to check the *-hpux-* or, sunos part of uname output, just to be sure this change doesn't affect other systems which don't need librt (although autoconf/configure is supposed to handle that).




-- 
Enver ALTIN   |    http://skyblue.gen.tr/
Software developer @ Parkyeri |  http://www.parkyeri.com/








signature.asc
Description: This is a digitally signed message part

Re: [RFC] adding solaris lib dependencies

2004-10-06 Thread Alexander Malysh 
Stipe Tolj wrote:

> Alexander Malysh wrote:
> 
>> Hi,
>> 
>> how about attached patch?
> 
> yes, but do we need to include the lib on our own in $LIBS before
> configure runs the Makefile.in mangle and substitutes the vars?! Or is
> it enough to call AC_CHECK_LIB() and it will include it on its own?

it's enough to call AC_CHECK_LIB()...

> 
> Not sure.
> 
> Stipe
> 
> mailto:stolj_{at}_wapme.de
> ---
> Wapme Systems AG
> 
> Vogelsanger Weg 80
> 40470 Düsseldorf, NRW, Germany
> 
> phone: +49.211.74845.0
> fax: +49.211.74845.299
> 
> mailto:info_{at}_wapme-systems.de
> http://www.wapme-systems.de/
> ---
> 

[skip Stipe's broken pgp signature ;)]

-- 
Thanks,
Alex

Re: [RFC] adding solaris lib dependencies

2004-10-06 Thread Enver ALTIN 
Hi,

On Wed, 2004-10-06 at 17:40 +0200, Stipe Tolj wrote:
> yes, but do we need to include the lib on our own in $LIBS before 
> configure runs the Makefile.in mangle and substitutes the vars?! Or is 
> it enough to call AC_CHECK_LIB() and it will include it on its own?

It should be enough. Looks good to me, please go ahead.
-- 
Enver ALTIN   |http://skyblue.gen.tr/
Software developer @ Parkyeri |  http://www.parkyeri.com/


signature.asc
Description: This is a digitally signed message part

Re: [RFC] adding solaris lib dependencies

2004-10-06 Thread Stipe Tolj 
Alexander Malysh wrote:
Hi,
how about attached patch?
yes, but do we need to include the lib on our own in $LIBS before 
configure runs the Makefile.in mangle and substitutes the vars?! Or is 
it enough to call AC_CHECK_LIB() and it will include it on its own?

Not sure.
Stipe
mailto:stolj_{at}_wapme.de
---
Wapme Systems AG
Vogelsanger Weg 80
40470 Düsseldorf, NRW, Germany
phone: +49.211.74845.0
fax: +49.211.74845.299
mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
---
-BEGIN PGP PUBLIC KEY BLOCK-
Version: GnuPG v1.2.2 (Cygwin)
mIsEP6mcYwEEAMDnUiUwrbb+xwTFWN6TxF2+XZu7/alwJMeCwMBRvXtPZqfjpPhS
OkBpU0F4TrVuugz1HINTSaJTYq10AzDQXp5NkyWgckqW79nPAWuOX0dicbJk+cN2
nM2TI4KaxUDe6u8hghNEnH/i2lXsUu9apnP/iixzV81VC2je3uc9hZpnAAYptEVT
dGlwZSBUb2xqIChUZWNobm9sb2d5IENlbnRlciAmIFJlc2VhcmNoIExhYikgPHRv
bGpAd2FwbWUtc3lzdGVtcy5kZT6ItAQTAQIAHgUCP6mcYwIbAwYLCQgHAwIDFQID
AxYCAQIeAQIXgAAKCRABV0w1BqPYRuSqA/wPzsQxao2YePENCtgRTrO86U6zg3sl
OcS6CJFI4FZP5h/xD3GRsNH1+MPSvZlomDdpFnr547DGz/Kq9MXuQwVvlVig5yWZ
K5dtKp1r5YLhxJQBhfirZbRFFnYmf19f18J8OoS28tuFVftDl1AIwJS3HLyBTv6H
g2HyLAEKQIp30Q==
=aYCI
-END PGP PUBLIC KEY BLOCK-

Re: [RFC] adding solaris lib dependencies

2004-10-06 Thread Alexander Malysh 
Hi,

how about attached patch?

Stipe Tolj wrote:

> Hi list,
> 
> just a quick RFC for adding lib dependency checks for solaris
> sem_foobar() functions implemented in librt.a, in reference to bug #154.
> 
> This may be added to configure.in and hence made more smooth for users
> that compile on solaris systems.
> 
> Stipe
> 
> mailto:stolj_{at}_wapme.de
> ---
> Wapme Systems AG
> 
> Vogelsanger Weg 80
> 40470 Düsseldorf, NRW, Germany
> 
> phone: +49.211.74845.0
> fax: +49.211.74845.299
> 
> mailto:info_{at}_wapme-systems.de
> http://www.wapme-systems.de/
> ---
> 

-- 
Thanks,
AlexIndex: configure.in
===
RCS file: /home/cvs/gateway/configure.in,v
retrieving revision 1.145
diff -a -u -p -r1.145 configure.in
--- configure.in	28 Aug 2004 13:29:10 -	1.145
+++ configure.in	6 Oct 2004 15:34:43 -
@@ -303,6 +303,8 @@ pthread_rwlock_destroy(&lock);
 AC_MSG_RESULT(Cross compiling - assuming suuported) ; AC_DEFINE(HAVE_PTHREAD_RWLOCK)])
 
 dnl checking for native semaphore support
+dnl Solaris & HP-UX needs librt.
+AC_CHECK_LIB(rt, sem_init)
 AC_MSG_CHECKING([for semaphore support])
 AC_TRY_RUN([#include 
 int main(void) {
Index: configure
===
RCS file: /home/cvs/gateway/configure,v
retrieving revision 1.142
diff -a -u -p -r1.142 configure
--- configure	28 Aug 2004 13:29:10 -	1.142
+++ configure	6 Oct 2004 15:34:45 -
@@ -2774,8 +2774,55 @@ else
 fi
 rm -f conftest*
 
+echo $ac_n "checking for sem_init in -lrt""... $ac_c" 1>&6
+echo "configure:2779: checking for sem_init in -lrt" >&5
+ac_lib_var=`echo rt'_'sem_init | sed 'y%./+-%__p_%'`
+if eval "test \"`echo '$''{'ac_cv_lib_$ac_lib_var'+set}'`\" = set"; then
+  echo $ac_n "(cached) $ac_c" 1>&6
+else
+  ac_save_LIBS="$LIBS"
+LIBS="-lrt  $LIBS"
+cat > conftest.$ac_ext <&5; (eval $ac_link) 2>&5; } && test -s conftest${ac_exeext}; then
+  rm -rf conftest*
+  eval "ac_cv_lib_$ac_lib_var=yes"
+else
+  echo "configure: failed program was:" >&5
+  cat conftest.$ac_ext >&5
+  rm -rf conftest*
+  eval "ac_cv_lib_$ac_lib_var=no"
+fi
+rm -f conftest*
+LIBS="$ac_save_LIBS"
+
+fi
+if eval "test \"`echo '$ac_cv_lib_'$ac_lib_var`\" = yes"; then
+  echo "$ac_t""yes" 1>&6
+ac_tr_lib=HAVE_LIB`echo rt | sed -e 's/[^a-zA-Z0-9_]/_/g' \
+-e 'y/abcdefghijklmnopqrstuvwxyz/ABCDEFGHIJKLMNOPQRSTUVWXYZ/'`
+  cat >> confdefs.h <&6
+fi
+
 echo $ac_n "checking for semaphore support""... $ac_c" 1>&6
-echo "configure:2779: checking for semaphore support" >&5
+echo "configure:2826: checking for semaphore support" >&5
 if test "$cross_compiling" = yes; then
   
 echo "$ac_t""Cross compiling - assuming suuported" 1>&6 ; cat >> confdefs.h <<\EOF
@@ -2784,7 +2831,7 @@ EOF
 
 else
   cat > conftest.$ac_ext <
 int main(void) {
@@ -2801,7 +2848,7 @@ int main(void) {
 }
 
 EOF
-if { (eval echo configure:2805: \"$ac_link\") 1>&5; (eval $ac_link) 2>&5; } && test -s conftest${ac_exeext} && (./conftest; exit) 2>/dev/null
+if { (eval echo configure:2852: \"$ac_link\") 1>&5; (eval $ac_link) 2>&5; } && test -s conftest${ac_exeext} && (./conftest; exit) 2>/dev/null
 then
   echo "$ac_t""yes" 1>&6; cat >> confdefs.h <<\EOF
 #define HAVE_SEMAPHORE 1
@@ -2829,7 +2876,7 @@ do
 # Extract the first word of "$ac_prog", so it can be a program name with args.
 set dummy $ac_prog; ac_word=$2
 echo $ac_n "checking for $ac_word""... $ac_c" 1>&6
-echo "configure:2833: checking for $ac_word" >&5
+echo "configure:2880: checking for $ac_word" >&5
 if eval "test \"`echo '$''{'ac_cv_path_XML_CONFIG'+set}'`\" = set"; then
   echo $ac_n "(cached) $ac_c" 1>&6
 else
@@ -2869,7 +2916,7 @@ if test "$XML_CONFIG" = "no"; then
   { echo "configure: error: You MUST have the libxml2 (aka gnome-xml) library installed" 1>&2; exit 1; }
 else
   echo $ac_n "checking libxml version""... $ac_c" 1>&6
-echo "configure:2873: checking libxml version" >&5
+echo "configure:2920: checking libxml version" >&5
   xml_version=`$XML_CONFIG --version`
   echo "$ac_t""$xml_version" 1>&6

@@ -2913,7 +2960,7 @@ fi
   echo "${nl}${T_MD}Configuring for PCRE support ...${T_ME}"
 
 echo $ac_n "checking whether to compile with PCRE support""... $ac_c" 1>&6
-echo "configure:2917: checking whether to compile with PCRE support" >&5
+echo "configure:2964: checking whether to compile with PCRE support" >&5
 # Check whether --enable-pcre or --disable-pcre was given.
 if test "${enable_pcre+set}" = set; then
   enableval="$enable_pcre"
@@ -2927,7 +2974,7 @@ do
 # Extract the first word of "$ac_prog", so it can be a program name with args.
 set dummy $ac_prog; ac_word=$2
 echo $ac_n "checking for $ac_word""... $ac_c" 1>&6
-echo "configure:2931: checking for $ac_word" >&5
+echo "configure:2978: checking for $ac_word" >&5
 if eval "test \"`echo '$''{'ac_cv_path_PCRE_CONFIG'+set}'`\" = set"; then
   ec

Re: [RFC] adding solaris lib dependencies

2004-10-06 Thread Enver ALTIN 
Hi Stipe,

On Wed, 2004-10-06 at 16:17 +0200, Stipe Tolj wrote:
> just a quick RFC for adding lib dependency checks for solaris 
> sem_foobar() functions implemented in librt.a, in reference to bug
> #154. This may be added to configure.in and hence made more smooth for
> users that compile on solaris systems.

That would also make HP-UX and other UNIX people's lives easier. I'm all
for it. I had to add "-lrt" to $CFLAGS by hand on HP-UX.
-- 
Enver ALTIN   |http://skyblue.gen.tr/
Software developer @ Parkyeri |  http://www.parkyeri.com/


signature.asc
Description: This is a digitally signed message part

[RFC] adding solaris lib dependencies

2004-10-06 Thread Stipe Tolj 
Hi list,
just a quick RFC for adding lib dependency checks for solaris 
sem_foobar() functions implemented in librt.a, in reference to bug #154.

This may be added to configure.in and hence made more smooth for users 
that compile on solaris systems.

Stipe
mailto:stolj_{at}_wapme.de
---
Wapme Systems AG
Vogelsanger Weg 80
40470 Düsseldorf, NRW, Germany
phone: +49.211.74845.0
fax: +49.211.74845.299
mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
---
-BEGIN PGP PUBLIC KEY BLOCK-
Version: GnuPG v1.2.2 (Cygwin)
mIsEP6mcYwEEAMDnUiUwrbb+xwTFWN6TxF2+XZu7/alwJMeCwMBRvXtPZqfjpPhS
OkBpU0F4TrVuugz1HINTSaJTYq10AzDQXp5NkyWgckqW79nPAWuOX0dicbJk+cN2
nM2TI4KaxUDe6u8hghNEnH/i2lXsUu9apnP/iixzV81VC2je3uc9hZpnAAYptEVT
dGlwZSBUb2xqIChUZWNobm9sb2d5IENlbnRlciAmIFJlc2VhcmNoIExhYikgPHRv
bGpAd2FwbWUtc3lzdGVtcy5kZT6ItAQTAQIAHgUCP6mcYwIbAwYLCQgHAwIDFQID
AxYCAQIeAQIXgAAKCRABV0w1BqPYRuSqA/wPzsQxao2YePENCtgRTrO86U6zg3sl
OcS6CJFI4FZP5h/xD3GRsNH1+MPSvZlomDdpFnr547DGz/Kq9MXuQwVvlVig5yWZ
K5dtKp1r5YLhxJQBhfirZbRFFnYmf19f18J8OoS28tuFVftDl1AIwJS3HLyBTv6H
g2HyLAEKQIp30Q==
=aYCI
-END PGP PUBLIC KEY BLOCK-