Re: [PATCH] [BUG] http.c does not follow redirections at all

2003-03-28 Thread Stipe Tolj
Angel Fradejas wrote:
 
 Current http.c does not follow 302 Location redirections at all. I
 tracked down the problem down to the handle_transaction() function.
 
 If we leave trans-host and trans-port set there, there will be no
 parse_url() for the redirection, and the original url is fetched
 again and again :-(
 
 Attached is a patch that fixes it.

yep, seems get_redirection_location() does not what it should do.

Stipe

[EMAIL PROTECTED]
---
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [EMAIL PROTECTED]
Internet: http://www.wapme-systems.de
---
wapme.net - wherever you are



RE: [PATCH] [BUG] http.c does not follow redirections at all

2003-03-28 Thread Angel Fradejas



I did not test with proxy, to be frank

Could you do test that Andreas?

/Angel

  -Mensaje original-De: [EMAIL PROTECTED] 
  [mailto:[EMAIL PROTECTED]En nombre de Andreas FinkEnviado 
  el: viernes 28 de marzo de 2003 16:46Para: 
  [EMAIL PROTECTED]Asunto: Re: [PATCH] [BUG] http.c does not 
  follow redirections at allOn Freitag, März 28, 2003, 
  at 04:33 Uhr, Stipe Tolj wrote:
  Angel Fradejas wrote:
Current http.c does not follow 302 Location redirections 
  at all. Itracked down the problem down to the handle_transaction() 
  function.If we leave trans-host and trans-port set there, 
  there will be noparse_url() for the redirection, and the original url 
  is fetchedagain and again :-(Attached is a patch that fixes 
  it.I've created a bug report in mantis 
anyway.yep, +1, will commit to cvs. Thanks a 
lot.StipeDid everyone test this with and without 
  Proxy?While using a proxy is exactly the locatio where the host would stay 
  the same.Andreas FinkGlobal 
  Networks Switzerland 
  AG--Tel: 
  +41-61-333 Fax: +41-61-334 Mobile: +41-79-2457333Global Networks, 
  Inc. Clarastrasse 3, 4058 Basel, SwitzerlandWeb: 
  http://www.global-networks.ch/ 
  [EMAIL PROTECTED]--Send 
  SMS to +979 979 UNICEF (+979979864233) to donate 10 euro tothe children of 
  Iraq. 
http://www.gni.ch/unicef


Re: [PATCH] [BUG] http.c does not follow redirections at all

2003-03-28 Thread Stipe Tolj
Andreas Fink wrote:
 
 Did everyone test this with and without Proxy?
 While using a proxy is exactly the locatio where the host would stay the same.

I have to addmit, no, I didn't test proxy mode. 

Andreas, can you do this please. The code is already commited. If
there are problems please report.

Stipe

[EMAIL PROTECTED]
---
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [EMAIL PROTECTED]
Internet: http://www.wapme-systems.de
---
wapme.net - wherever you are



Re: [PATCH] [BUG] http.c does not follow redirections at all

2003-03-28 Thread Andreas Fink

On Freitag, März 28, 2003, at 04:33  Uhr, Stipe Tolj wrote:

Angel Fradejas wrote:
Current http.c does not follow 302 Location redirections at all. I
tracked down the problem down to the handle_transaction() function.

If we leave trans->host and trans->port set there, there will be no
parse_url() for the redirection, and the original url is fetched
again and again :-(

Attached is a patch that fixes it.

I've created a bug report in mantis anyway.

yep, +1, will commit to cvs. Thanks a lot.

Stipe

Did everyone test this with and without Proxy?
While using a proxy is exactly the locatio where the host would stay the same.

Andreas Fink
Global Networks Switzerland AG

--
Tel: +41-61-333  Fax: +41-61-334   Mobile: +41-79-2457333
Global Networks, Inc. Clarastrasse 3, 4058 Basel, Switzerland
Web: http://www.global-networks.ch/  [EMAIL PROTECTED]
--
Send SMS to +979 979 UNICEF (+979979864233) to donate 10 euro to
the children of Iraq.  http://www.gni.ch/unicef