Re: [RFV] Re: [PATCH] datatype inconsistency in wsp_strings.c
+1 from me, too
Aarno
On 24.8.2004, at 22:26, Alexander Malysh wrote:
Hi Stipe, Slava all ;)
+1 for cvs write access!
Stipe Tolj wrote:
This is a request for votes!
Vjacheslav Chekushin wrote:
Hi, list.
This patch fix quite obviouse data type inconsistency.
This make sence in 64 bit environment where sizeof(int) !=
sizeof(long)
yep, +1, thanks a lot.
Vjacheslav, since you are providing patches for some time now, I'd
like to get you upgraded to cvs access, so you'd be able to commit
obvious patches and fixes on your own. What about that?
@group: I'd vote for Vjacheslav to have cvs write access. We need at
least 2 more votes from developers with cvs access. So please review
Vjacheslav's submission history and vote!
(thinking especially on votes from Mr. Stress-test Alex and Aarno ;)
oops, thanks for compliment :)
Stipe
mailto:stolj_{at}_wapme.de
---
Wapme Systems AG
Vogelsanger Weg 80
40470 Düsseldorf, NRW, Germany
phone: +49.211.74845.0
fax: +49.211.74845.299
mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
---
--
Thanks,
Alex
Re: [PATCH] datatype inconsistency in wsp_strings.c
Vjacheslav Chekushin wrote:
Hi, list.
This patch fix quite obviouse data type inconsistency.
This make sence in 64 bit environment where sizeof(int) != sizeof(long)
--- ../gateway-1.3.2_base/wap/wsp_strings.c Thu Jan 22 16:08:25 2004
+++ wap/wsp_strings.c Mon Aug 16 14:52:38 2004
@@ -203,7 +203,7 @@
static long string_to_versioned_number(Octstr *ostr, struct table *table,
int version)
{
-unsigned int i, ret;
+long i, ret;
gw_assert(initialized);
commited to cvs. Thanks a lot.
Stipe
mailto:stolj_{at}_wapme.de
---
Wapme Systems AG
Vogelsanger Weg 80
40470 Dsseldorf, NRW, Germany
phone: +49.211.74845.0
fax: +49.211.74845.299
mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
---
-BEGIN PGP PUBLIC KEY BLOCK-
Version: GnuPG v1.2.2 (Cygwin)
mIsEP6mcYwEEAMDnUiUwrbb+xwTFWN6TxF2+XZu7/alwJMeCwMBRvXtPZqfjpPhS
OkBpU0F4TrVuugz1HINTSaJTYq10AzDQXp5NkyWgckqW79nPAWuOX0dicbJk+cN2
nM2TI4KaxUDe6u8hghNEnH/i2lXsUu9apnP/iixzV81VC2je3uc9hZpnAAYptEVT
dGlwZSBUb2xqIChUZWNobm9sb2d5IENlbnRlciAmIFJlc2VhcmNoIExhYikgPHRv
bGpAd2FwbWUtc3lzdGVtcy5kZT6ItAQTAQIAHgUCP6mcYwIbAwYLCQgHAwIDFQID
AxYCAQIeAQIXgAAKCRABV0w1BqPYRuSqA/wPzsQxao2YePENCtgRTrO86U6zg3sl
OcS6CJFI4FZP5h/xD3GRsNH1+MPSvZlomDdpFnr547DGz/Kq9MXuQwVvlVig5yWZ
K5dtKp1r5YLhxJQBhfirZbRFFnYmf19f18J8OoS28tuFVftDl1AIwJS3HLyBTv6H
g2HyLAEKQIp30Q==
=aYCI
-END PGP PUBLIC KEY BLOCK-
[RFV] Re: [PATCH] datatype inconsistency in wsp_strings.c
This is a request for votes!
Vjacheslav Chekushin wrote:
Hi, list.
This patch fix quite obviouse data type inconsistency.
This make sence in 64 bit environment where sizeof(int) != sizeof(long)
yep, +1, thanks a lot.
Vjacheslav, since you are providing patches for some time now, I'd
like to get you upgraded to cvs access, so you'd be able to commit
obvious patches and fixes on your own. What about that?
@group: I'd vote for Vjacheslav to have cvs write access. We need at
least 2 more votes from developers with cvs access. So please review
Vjacheslav's submission history and vote!
(thinking especially on votes from Mr. Stress-test Alex and Aarno ;)
Stipe
mailto:stolj_{at}_wapme.de
---
Wapme Systems AG
Vogelsanger Weg 80
40470 Dsseldorf, NRW, Germany
phone: +49.211.74845.0
fax: +49.211.74845.299
mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
---
-BEGIN PGP PUBLIC KEY BLOCK-
Version: GnuPG v1.2.2 (Cygwin)
mIsEP6mcYwEEAMDnUiUwrbb+xwTFWN6TxF2+XZu7/alwJMeCwMBRvXtPZqfjpPhS
OkBpU0F4TrVuugz1HINTSaJTYq10AzDQXp5NkyWgckqW79nPAWuOX0dicbJk+cN2
nM2TI4KaxUDe6u8hghNEnH/i2lXsUu9apnP/iixzV81VC2je3uc9hZpnAAYptEVT
dGlwZSBUb2xqIChUZWNobm9sb2d5IENlbnRlciAmIFJlc2VhcmNoIExhYikgPHRv
bGpAd2FwbWUtc3lzdGVtcy5kZT6ItAQTAQIAHgUCP6mcYwIbAwYLCQgHAwIDFQID
AxYCAQIeAQIXgAAKCRABV0w1BqPYRuSqA/wPzsQxao2YePENCtgRTrO86U6zg3sl
OcS6CJFI4FZP5h/xD3GRsNH1+MPSvZlomDdpFnr547DGz/Kq9MXuQwVvlVig5yWZ
K5dtKp1r5YLhxJQBhfirZbRFFnYmf19f18J8OoS28tuFVftDl1AIwJS3HLyBTv6H
g2HyLAEKQIp30Q==
=aYCI
-END PGP PUBLIC KEY BLOCK-
Re: [RFV] Re: [PATCH] datatype inconsistency in wsp_strings.c
Hi Stipe, Slava all ;)
+1 for cvs write access!
Stipe Tolj wrote:
This is a request for votes!
Vjacheslav Chekushin wrote:
Hi, list.
This patch fix quite obviouse data type inconsistency.
This make sence in 64 bit environment where sizeof(int) != sizeof(long)
yep, +1, thanks a lot.
Vjacheslav, since you are providing patches for some time now, I'd
like to get you upgraded to cvs access, so you'd be able to commit
obvious patches and fixes on your own. What about that?
@group: I'd vote for Vjacheslav to have cvs write access. We need at
least 2 more votes from developers with cvs access. So please review
Vjacheslav's submission history and vote!
(thinking especially on votes from Mr. Stress-test Alex and Aarno ;)
oops, thanks for compliment :)
Stipe
mailto:stolj_{at}_wapme.de
---
Wapme Systems AG
Vogelsanger Weg 80
40470 Düsseldorf, NRW, Germany
phone: +49.211.74845.0
fax: +49.211.74845.299
mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
---
--
Thanks,
Alex
