Re: /bin/sh and lua; was: Re: common location of spec files in upstream sources

2017-10-28 Thread Florian Weimer

On 10/28/2017 03:49 AM, Chris Adams wrote:

Once upon a time, Adam Williamson  said:

FWIW, ISTR being told at some point that it's a good idea to write
scriptlets in lua because RPM should *always* be able to run lua
scriptlets, whereas at least in theory a scriptlet written in shell
script could be hit before /bin/sh is installed and thus fail to
run...


I don't think that's true - I think an RPM with a /bin/sh scriptlet will
get a dependency on /bin/sh, so it shouldn't be installed before
/bin/sh.


That's not true in general if your package is in turn a dependency of 
whatever provides /bin/sh.  That affects a dozen or so packages in 
Fedora, according to a quick check.


Thanks,
Florian
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: /bin/sh and lua; was: Re: common location of spec files in upstream sources

2017-10-28 Thread Florian Weimer

On 10/27/2017 10:36 PM, Colin Walters wrote:

https://bugzilla.redhat.com/show_bug.cgi?id=1367585


(But currently, as linked from one of the PRs, we just override
  the Fedora glibc packages' use of lua, since it's unnecessary.
  It seems strange to me that Florian has time to reply on list
  here and not review the patch in the BZ...)


I don't know what to say on the BZ.  The current spec file is buggy: 
using %posttrans for this step is wrong because it means that many 
scriptlets will run with the wrong locale archive.  The proposed patch 
does not fix this issue.


Thanks,
Florian
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: /bin/sh and lua; was: Re: common location of spec files in upstream sources

2017-10-28 Thread Florian Weimer

On 10/27/2017 09:27 PM, Jason L Tibbitts III wrote:

"FW" == Florian Weimer  writes:


FW> It's often necessary to use Lua for scriptlets which run reliably
FW> because RPM lacks delayed script execution.

I guess it depends on how delayed you want them.  The ordering is
certainly well defined but it's all a bit esoteric.


I don't think the point where the cycle is broken is well-defined. 
Doesn't it depend on the transaction contents?



But sure, Lua is there and it works.  Unfortunately it lacks usability
because it really needs a standard library and more state needs to be
visible in the Lua symbol table.


The posix module that RPM provides internally is quite useful.  The 
problem is that it's not luaposix, so it can be confusing initially.



FW> Furthermore, changes in this area (such as replacing Lua with other
FW> mechanisms such as shell scripts) are difficult to test properly
FW> because differences in RPM or the repository contents could cause
FW> dependency loops be broken at different points.

Well, yes, low level distribution work is hard and the environment as
you are doing an initial OS install is, at least in the early part of
the process, extremely limited.


Installs are the easy part.  Upgrades are much harder because there are 
so many more moving parts.


Thanks,
Florian
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: Packages looking for new maintainers

2017-10-28 Thread Ville Skyttä
On Fri, Oct 27, 2017 at 11:24 AM, Hedayat Vatankhah
 wrote:
> If nobody else wants it, I'd take kid3

Transferred, thanks!
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Review swap: python-mpd2: It is a Python library which provides a client interface for MPD

2017-10-28 Thread Ankur Sinha
Hello,

Another simple python package that I'd like reviewed - would someone
like to swap reviews please? :)

https://bugzilla.redhat.com/show_bug.cgi?id=1507235

(It's holding up the update of another package: mpdris2)

-- 
Thanks,
Regards,
Ankur Sinha "FranciscoD"

https://fedoraproject.org/wiki/User:Ankursinha

signature.asc
Description: This is a digitally signed message part
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Fedora Modular 27 compose report: 20171028.n.0 changes

2017-10-28 Thread Fedora Branched Report
OLD: Fedora-Modular-27-20171028.n.0
NEW: Fedora-Modular-27-20171028.n.0

= SUMMARY =
Added images:0
Dropped images:  0
Added packages:  0
Dropped packages:0
Upgraded packages:   0
Downgraded packages: 0

Size of added packages:  0.00 B
Size of dropped packages:0.00 B
Size of upgraded packages:   0.00 B
Size of downgraded packages: 0.00 B

Size change of upgraded packages:   0.00 B
Size change of downgraded packages: 0.00 B

= ADDED IMAGES =

= DROPPED IMAGES =

= ADDED PACKAGES =

= DROPPED PACKAGES =

= UPGRADED PACKAGES =

= DOWNGRADED PACKAGES =
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Fedora 27-20171028.n.0 compose check report

2017-10-28 Thread Fedora compose checker
Missing expected images:

Workstation live i386
Kde live i386

Failed openQA tests: 9/137 (x86_64), 1/22 (i386), 1/2 (arm)

New failures (same test did not fail in 27-20171027.n.0):

ID: 162845  Test: x86_64 Workstation-live-iso base_services_start
URL: https://openqa.fedoraproject.org/tests/162845
ID: 162941  Test: x86_64 universal install_repository_http_graphical
URL: https://openqa.fedoraproject.org/tests/162941
ID: 162972  Test: i386 universal install_blivet_xfs
URL: https://openqa.fedoraproject.org/tests/162972

Old failures (same test failed in 27-20171027.n.0):

ID: 162819  Test: x86_64 Server-dvd-iso base_services_start
URL: https://openqa.fedoraproject.org/tests/162819
ID: 162843  Test: x86_64 Workstation-live-iso install_no_user
URL: https://openqa.fedoraproject.org/tests/162843
ID: 162864  Test: x86_64 KDE-live-iso base_services_start
URL: https://openqa.fedoraproject.org/tests/162864
ID: 162872  Test: x86_64 KDE-live-iso desktop_notifications_postinstall
URL: https://openqa.fedoraproject.org/tests/162872
ID: 162874  Test: arm Minimal-raw_xz-raw.xz base_services_start_arm
URL: https://openqa.fedoraproject.org/tests/162874
ID: 162879  Test: x86_64 Workstation Ostree-dvd_ostree-iso install_no_user
URL: https://openqa.fedoraproject.org/tests/162879
ID: 162881  Test: x86_64 Workstation Ostree-dvd_ostree-iso 
base_services_start
URL: https://openqa.fedoraproject.org/tests/162881
ID: 162928  Test: x86_64 universal upgrade_server_domain_controller
URL: https://openqa.fedoraproject.org/tests/162928

Soft failed openQA tests: 6/137 (x86_64)
(Tests completed, but using a workaround for a known bug)

New soft failures (same test did not soft fail in 27-20171027.n.0):

ID: 162931  Test: x86_64 universal upgrade_2_minimal_64bit
URL: https://openqa.fedoraproject.org/tests/162931
ID: 162945  Test: x86_64 universal install_sata
URL: https://openqa.fedoraproject.org/tests/162945

Old soft failures (same test soft failed in 27-20171027.n.0):

ID: 162890  Test: x86_64 universal install_asian_language
URL: https://openqa.fedoraproject.org/tests/162890
ID: 162915  Test: x86_64 universal upgrade_server_64bit
URL: https://openqa.fedoraproject.org/tests/162915
ID: 162923  Test: x86_64 universal upgrade_minimal_64bit
URL: https://openqa.fedoraproject.org/tests/162923
ID: 162933  Test: x86_64 universal upgrade_2_server_64bit
URL: https://openqa.fedoraproject.org/tests/162933

Passed openQA tests: 121/137 (x86_64), 21/22 (i386), 1/2 (arm)

New passes (same test did not pass in 27-20171027.n.0):

ID: 162841  Test: x86_64 Workstation-live-iso install_default_upload
URL: https://openqa.fedoraproject.org/tests/162841
ID: 162842  Test: x86_64 Workstation-live-iso install_default@uefi
URL: https://openqa.fedoraproject.org/tests/162842
ID: 162844  Test: x86_64 Workstation-live-iso base_selinux
URL: https://openqa.fedoraproject.org/tests/162844
ID: 162846  Test: x86_64 Workstation-live-iso base_service_manipulation
URL: https://openqa.fedoraproject.org/tests/162846
ID: 162847  Test: x86_64 Workstation-live-iso base_update_cli
URL: https://openqa.fedoraproject.org/tests/162847
ID: 162848  Test: x86_64 Workstation-live-iso base_system_logging
URL: https://openqa.fedoraproject.org/tests/162848
ID: 162849  Test: x86_64 Workstation-live-iso desktop_update_graphical
URL: https://openqa.fedoraproject.org/tests/162849
ID: 162850  Test: x86_64 Workstation-live-iso desktop_terminal
URL: https://openqa.fedoraproject.org/tests/162850
ID: 162851  Test: x86_64 Workstation-live-iso desktop_browser
URL: https://openqa.fedoraproject.org/tests/162851
ID: 162853  Test: x86_64 Workstation-live-iso 
desktop_notifications_postinstall
URL: https://openqa.fedoraproject.org/tests/162853
ID: 162896  Test: x86_64 universal install_btrfs
URL: https://openqa.fedoraproject.org/tests/162896
ID: 162910  Test: x86_64 universal upgrade_2_desktop_encrypted_64bit
URL: https://openqa.fedoraproject.org/tests/162910
ID: 162950  Test: x86_64 universal install_multi@uefi
URL: https://openqa.fedoraproject.org/tests/162950
ID: 162955  Test: x86_64 universal install_kickstart_nfs
URL: https://openqa.fedoraproject.org/tests/162955
ID: 162964  Test: i386 universal upgrade_desktop_32bit
URL: https://openqa.fedoraproject.org/tests/162964

Installed system changes in test x86_64 Server-boot-iso install_default@uefi: 
6 packages(s) removed since previous compose: python2, python2-libs, 
python2-pip, python2-setuptools, python2-talloc, samba-libs
Previous test data: https://openqa.fedoraproject.org/tests/162474#downloads
Current test data: https://openqa.fedoraproject.org/tests/162814#downloads

Installed system changes in test x86_64 Server-boot-iso install_default: 
6 packages(s) removed since previous compose: python2, python2-libs, 
python2-pip, python2-setuptools, python2-talloc, samba-libs
Previous test data: https://openqa.fedoraproject.o

Re: /bin/sh and lua; was: Re: common location of spec files in upstream sources

2017-10-28 Thread nicolas . mailhot
Hi Florian,

One problem is that there is a "rpm lua" and a "system lua" making it hard to 
switch between scriplets and actual scripts.

As for bashisms, I don't seen the point of struggling for a smaller shell when 
everything lately has been about wrapping code in fatter and fatter virtual 
delivery enveloppes.

Regards,

-- 
Nicolas Mailhot
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Fedora Modular bikeshed compose report: 20171026.n.0 changes

2017-10-28 Thread Fedora Rawhide Report
OLD: Fedora-Modular-Bikeshed-20171026.n.0
NEW: Fedora-Modular-Bikeshed-20171026.n.0

= SUMMARY =
Added images:0
Dropped images:  0
Added packages:  0
Dropped packages:0
Upgraded packages:   0
Downgraded packages: 0

Size of added packages:  0.00 B
Size of dropped packages:0.00 B
Size of upgraded packages:   0.00 B
Size of downgraded packages: 0.00 B

Size change of upgraded packages:   0.00 B
Size change of downgraded packages: 0.00 B

= ADDED IMAGES =

= DROPPED IMAGES =

= ADDED PACKAGES =

= DROPPED PACKAGES =

= UPGRADED PACKAGES =

= DOWNGRADED PACKAGES =
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org