Re: [389-devel] Please review: Remove redundant code - make a global into a static

2012-01-20 Thread Noriko Hosoi

Rich Megginson wrote:




--
389-devel mailing list
389-de...@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel

ack.

--
389-devel mailing list
389-de...@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: Remove redundant code - make a global into a static

2012-01-20 Thread Rich Megginson



From 1ddcc951eec9ede74ae6650de04a921198aec493 Mon Sep 17 00:00:00 2001
From: Rich Megginson 
Date: Fri, 20 Jan 2012 09:52:33 -0700
Subject: [PATCH] Remove redundant code - make a global into a static

Remove redundant code - make a global into a static
---
 ldap/servers/plugins/linkedattrs/fixup_task.c |7 ---
 ldap/servers/plugins/usn/usn.c|2 +-
 2 files changed, 1 insertions(+), 8 deletions(-)

diff --git a/ldap/servers/plugins/linkedattrs/fixup_task.c 
b/ldap/servers/plugins/linkedattrs/fixup_task.c
index b1c29d3..a698a6c 100644
--- a/ldap/servers/plugins/linkedattrs/fixup_task.c
+++ b/ldap/servers/plugins/linkedattrs/fixup_task.c
@@ -77,13 +77,6 @@ linked_attrs_fixup_task_add(Slapi_PBlock *pb, Slapi_Entry *e,
goto out;
}
 
-   /* make sure the plugin is not closed */
-   if(!linked_attrs_is_started()){
-   *returncode = LDAP_OPERATIONS_ERROR;
-   rv = SLAPI_DSE_CALLBACK_ERROR;
-   goto out;
-   }
-
/* get arg(s) */
linkdn = fetch_attr(e, "linkdn", 0);
 
diff --git a/ldap/servers/plugins/usn/usn.c b/ldap/servers/plugins/usn/usn.c
index dbae1d5..faa737c 100644
--- a/ldap/servers/plugins/usn/usn.c
+++ b/ldap/servers/plugins/usn/usn.c
@@ -68,7 +68,7 @@ static int usn_get_attr(Slapi_PBlock *pb, const char* type, 
void *value);
 static int usn_rootdse_search(Slapi_PBlock *pb, Slapi_Entry* e,
 Slapi_Entry* entryAfter, int *returncode, char *returntext, void *arg);
 
-int g_plugin_started = 0;
+static int g_plugin_started = 0;
 /*
  * Register USN plugin
  * Note: USN counter initialization is done in the backend (ldbm_usn_init).
-- 
1.7.1

--
389-devel mailing list
389-de...@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel