Re: A new depedency of existing BuildRequires causes build failure - who to blame?

2013-08-23 Thread Orion Poplawski

On 08/21/2013 03:09 AM, Ville Skyttä wrote:

On Tue, Aug 20, 2013 at 4:19 PM, Tadej Janež
 wrote:

I'll fill a bug against plplot.


By the way, plplotd.pc lists quite a few things in its Libs: line --
without having a deeper look I think chances are that at least some of
them should be moved to Libs.private to avoid unnecessary linkage
bloat when dependent packages aren't built with ld --as-needed. If
that's correct, this is something to report upstream (plplot
maintainer Cc'd).



Yeah, they shouldn't be there.  I've removed them in 
plplot-5.9.9-20.svn12479.fc21, building now.  Please give that a try.


--
Orion Poplawski
Technical Manager 303-415-9701 x222
NWRA, Boulder/CoRA Office FAX: 303-415-9702
3380 Mitchell Lane   or...@nwra.com
Boulder, CO 80301   http://www.nwra.com
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: A new depedency of existing BuildRequires causes build failure - who to blame?

2013-08-21 Thread Ville Skyttä
On Tue, Aug 20, 2013 at 4:19 PM, Tadej Janež
 wrote:
> I'll fill a bug against plplot.

By the way, plplotd.pc lists quite a few things in its Libs: line --
without having a deeper look I think chances are that at least some of
them should be moved to Libs.private to avoid unnecessary linkage
bloat when dependent packages aren't built with ld --as-needed. If
that's correct, this is something to report upstream (plplot
maintainer Cc'd).
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: A new depedency of existing BuildRequires causes build failure - who to blame?

2013-08-20 Thread Tadej Janež
On Tue, 2013-08-20 at 16:11 +0300, Ville Skyttä wrote: 
> 
> In this case (and usually IME) it's the latter. -lshp was added to
> plplotd.pc in plplot-devel-5.9.9-18.svn12474.fc20 but the
> corresponding shapelib-devel package dep wasn't.

I just discovered the same thing. Here is the diff of the config.log
that Florian requested:
http://paste.fedoraproject.org/33439/13770043/

The "old" one is with plplot-5.9.9-16.svn12281.fc20, which doesn't
require shapelib, and the "new" one is with
plplot-5.9.9-19.svn12479.fc20.x86_64, which requires shapelib.

I'll fill a bug against plplot.

Thanks for helping me resolve the issue!

Tadej


-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: A new depedency of existing BuildRequires causes build failure - who to blame?

2013-08-20 Thread Florian Weimer

On 08/20/2013 03:11 PM, Ville Skyttä wrote:

On Tue, Aug 20, 2013 at 2:22 PM, Florian Weimer  wrote:

On 08/20/2013 01:15 PM, Tadej Janež wrote:


Inspecting the log files, I discovered that some BuildRequires pulled in
the shapelib package, which then caused the build to fail with:
"/usr/bin/ld: cannot find -lshp" since shapelib-devel was missing.

Who should I blame:
- the techne package which detected shapelib and tried to build against
it, or
- the package which introduced this dependency and/or did not also put
in a Requires on shapelib-devel?


Probably the former.


In this case (and usually IME) it's the latter. -lshp was added to
plplotd.pc in plplot-devel-5.9.9-18.svn12474.fc20 but the
corresponding shapelib-devel package dep wasn't.


Ah, okay, you are right.  So techne did not actually detect shapelib 
support.


--
Florian Weimer / Red Hat Product Security Team
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: A new depedency of existing BuildRequires causes build failure - who to blame?

2013-08-20 Thread Ville Skyttä
On Tue, Aug 20, 2013 at 2:22 PM, Florian Weimer  wrote:
> On 08/20/2013 01:15 PM, Tadej Janež wrote:
>>
>> Inspecting the log files, I discovered that some BuildRequires pulled in
>> the shapelib package, which then caused the build to fail with:
>> "/usr/bin/ld: cannot find -lshp" since shapelib-devel was missing.
>>
>> Who should I blame:
>> - the techne package which detected shapelib and tried to build against
>> it, or
>> - the package which introduced this dependency and/or did not also put
>> in a Requires on shapelib-devel?
>
> Probably the former.

In this case (and usually IME) it's the latter. -lshp was added to
plplotd.pc in plplot-devel-5.9.9-18.svn12474.fc20 but the
corresponding shapelib-devel package dep wasn't.
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: A new depedency of existing BuildRequires causes build failure - who to blame?

2013-08-20 Thread Tadej Janež
On Tue, 2013-08-20 at 14:01 +0200, Florian Weimer wrote: 
> 
> Could you diff config.log instead, please?

I'll have to get hold of a rawhide machine to do that, previously I just
diffed the build logs from koji.

> Do you link something statically, by chance?

This would be above my knowledge. How should I do that?

Tadej

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: A new depedency of existing BuildRequires causes build failure - who to blame?

2013-08-20 Thread Florian Weimer

On 08/20/2013 01:58 PM, Tadej Janež wrote:

On Tue, 2013-08-20 at 13:22 +0200, Florian Weimer wrote:


Probably the former.  How does it detect shapelib support if linking to
its library fails?


It uses autoconf to check for dependencies, however, I couldn't find an
explicit check for shapelib in configure.ac.

Comparing the output of ./configure of both builds (failed and
successful one) revealed no differences.


Could you diff config.log instead, please?

Do you link something statically, by chance?

--
Florian Weimer / Red Hat Product Security Team
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: A new depedency of existing BuildRequires causes build failure - who to blame?

2013-08-20 Thread Tadej Janež
On Tue, 2013-08-20 at 13:22 +0200, Florian Weimer wrote: 
> 
> Probably the former.  How does it detect shapelib support if linking to 
> its library fails?

It uses autoconf to check for dependencies, however, I couldn't find an
explicit check for shapelib in configure.ac.

Comparing the output of ./configure of both builds (failed and
successful one) revealed no differences.

Regards,
Tadej

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: A new depedency of existing BuildRequires causes build failure - who to blame?

2013-08-20 Thread Christopher Meng
在 2013-8-20 PM7:15,"Tadej Janež" 写道:
was missing.
> Who should I blame:
> - the techne package which detected shapelib and tried to build against
> it, or
> - the package which introduced this dependency and/or did not also put
> in a Requires on shapelib-devel?

If it can be built on f19, I think it's the latter.
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: A new depedency of existing BuildRequires causes build failure - who to blame?

2013-08-20 Thread Florian Weimer

On 08/20/2013 01:15 PM, Tadej Janež wrote:

Hi!

The techne package FTBFS during the recent F20 mass rebuild, which I
fixed and pushed a new build:
http://koji.fedoraproject.org/koji/buildinfo?buildID=455280

The same package failed to build yesterday:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5830172

Inspecting the log files, I discovered that some BuildRequires pulled in
the shapelib package, which then caused the build to fail with:
"/usr/bin/ld: cannot find -lshp" since shapelib-devel was missing.

Who should I blame:
- the techne package which detected shapelib and tried to build against
it, or
- the package which introduced this dependency and/or did not also put
in a Requires on shapelib-devel?


Probably the former.  How does it detect shapelib support if linking to 
its library fails?


--
Florian Weimer / Red Hat Product Security Team
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

A new depedency of existing BuildRequires causes build failure - who to blame?

2013-08-20 Thread Tadej Janež
Hi!

The techne package FTBFS during the recent F20 mass rebuild, which I
fixed and pushed a new build:
http://koji.fedoraproject.org/koji/buildinfo?buildID=455280

The same package failed to build yesterday:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5830172

Inspecting the log files, I discovered that some BuildRequires pulled in
the shapelib package, which then caused the build to fail with:
"/usr/bin/ld: cannot find -lshp" since shapelib-devel was missing.

Who should I blame:
- the techne package which detected shapelib and tried to build against
it, or
- the package which introduced this dependency and/or did not also put
in a Requires on shapelib-devel?

Regards,
Tadej

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct