Re: Fedora 30 System-Wide Change proposal: Remove glibc-all-langpacks from buildroot
On Tue, Sep 04, 2018 at 01:53:50PM +0900, Jens-Ulrik Petersen wrote: > Hi Zbigniew, nice to meet you at Flock. > > On Thu, Aug 23, 2018 at 5:30 AM Ben Cotton wrote: > > > > > https://fedoraproject.org/wiki/Changes/Remove_glibc-langpacks-all_from_buildroot > > > > == Summary == > > glibc-minimal-langpack is added to @Buildsystem group and installed > > into the minimal buildroot instead of glibc-all-langpacks. Packages > > which need more locales than plain C/C.UTF-8/POSIX need to pull them > > in through BuildRequires. > > > > I think not installing glibc-all-langpacks by default in the Koji > buildroot makes good sense but how about replacing it in the first instance > with glibc-langpack-en? > > A quick grep over spec files reveals: > > ``` > > $ rg -l 'LC_CTYPE=[^C]' *.spec | wc -l > > 11 > > $ rg -l 'LC_ALL=[^C]' *.spec | wc -l > > 42 > > ``` > > > > Also: > $ grep -l -e LANG=en *.spec | wc -l > 99 I patched all the spec files with LC_{ALL,CTYPE}= locally, and rebuilt them, and they all work just fine with C.utf8 (or fail to build for unrelated reasons). I'll do the same for the ones with LANG=, but I expect the result to be the same. glibc-langpack-en is noticeably larger, so I think that if we're doing it, we might just as well do it "properly". Zbyszek ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Fedora 30 System-Wide Change proposal: Remove glibc-all-langpacks from buildroot
Hi Zbigniew, nice to meet you at Flock. On Thu, Aug 23, 2018 at 5:30 AM Ben Cotton wrote: > > https://fedoraproject.org/wiki/Changes/Remove_glibc-langpacks-all_from_buildroot > > == Summary == > glibc-minimal-langpack is added to @Buildsystem group and installed > into the minimal buildroot instead of glibc-all-langpacks. Packages > which need more locales than plain C/C.UTF-8/POSIX need to pull them > in through BuildRequires. > I think not installing glibc-all-langpacks by default in the Koji buildroot makes good sense but how about replacing it in the first instance with glibc-langpack-en? A quick grep over spec files reveals: > ``` > $ rg -l 'LC_CTYPE=[^C]' *.spec | wc -l > 11 > $ rg -l 'LC_ALL=[^C]' *.spec | wc -l > 42 > ``` > Also: $ grep -l -e LANG=en *.spec | wc -l 99 Jens ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Fedora 30 System-Wide Change proposal: Remove glibc-all-langpacks from buildroot
On Fri, Aug 24, 2018 at 05:24:25PM +0100, Peter Robinson wrote: > On Fri, Aug 24, 2018 at 5:18 PM Zbigniew Jędrzejewski-Szmek > wrote: > > > > On Fri, Aug 24, 2018 at 02:39:47PM +, Zbigniew Jędrzejewski-Szmek wrote: > > > On Fri, Aug 24, 2018 at 01:55:54PM +0100, Daniel P. Berrangé wrote: > > > > On Fri, Aug 24, 2018 at 12:38:48PM +, Petr Pisar wrote: > > > > > On 2018-08-22, Ben Cotton wrote: > > > > > > https://fedoraproject.org/wiki/Changes/Remove_glibc-langpacks-all_from_buildroot > > > > > > > > > > > > glibc-minimal-langpack is added to @Buildsystem group and installed > > > > > > into the minimal buildroot instead of glibc-all-langpacks. Packages > > > > > > which need more locales than plain C/C.UTF-8/POSIX need to pull them > > > > > > in through BuildRequires. > > > > > > > > > > > I already wrote it in previous thread about this change but it seems > > > > > nobody takes me seriosly. Once again: > > > > > > When you wrote about mock configuration previously, I answered: > > > > Thanks, that's a good point. Do you know where this is configured? > > > > > > This was me taking the issue seriously. I haven't started working on > > > this yet because it got bumped to F30, but I keep a list of all the > > > points raised, including this one. > > > > I turns out Tomasz Torcz already fixed this: > > https://github.com/rpm-software-management/mock/commit/33db2351074753271700ee78c316bf1e36a00594 > > > env['LANG'] = os.environ.setdefault('LANG', 'C.UTF-8') > > That fixes the mock use case but koji configures and passes it's own > mock config and doesn't necessarily use the mock defaults so while it > may fix mock it's likely koji will need an associated patch as well. Can you point me to this config? Upstream koji [https://pagure.io/koji/] seems to have no locale configuration at all (searching for any LC_, LANG, en_US occurrences yields nothing). Zbyszek ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/AFDNHN5IPMKOEDM6VQVKMEDXJ3ADNFFK/
Re: Fedora 30 System-Wide Change proposal: Remove glibc-all-langpacks from buildroot
On Fri, Aug 24, 2018 at 5:18 PM Zbigniew Jędrzejewski-Szmek wrote: > > On Fri, Aug 24, 2018 at 02:39:47PM +, Zbigniew Jędrzejewski-Szmek wrote: > > On Fri, Aug 24, 2018 at 01:55:54PM +0100, Daniel P. Berrangé wrote: > > > On Fri, Aug 24, 2018 at 12:38:48PM +, Petr Pisar wrote: > > > > On 2018-08-22, Ben Cotton wrote: > > > > > https://fedoraproject.org/wiki/Changes/Remove_glibc-langpacks-all_from_buildroot > > > > > > > > > > glibc-minimal-langpack is added to @Buildsystem group and installed > > > > > into the minimal buildroot instead of glibc-all-langpacks. Packages > > > > > which need more locales than plain C/C.UTF-8/POSIX need to pull them > > > > > in through BuildRequires. > > > > > > > > > I already wrote it in previous thread about this change but it seems > > > > nobody takes me seriosly. Once again: > > > > When you wrote about mock configuration previously, I answered: > > > Thanks, that's a good point. Do you know where this is configured? > > > > This was me taking the issue seriously. I haven't started working on > > this yet because it got bumped to F30, but I keep a list of all the > > points raised, including this one. > > I turns out Tomasz Torcz already fixed this: > https://github.com/rpm-software-management/mock/commit/33db2351074753271700ee78c316bf1e36a00594 > > env['LANG'] = os.environ.setdefault('LANG', 'C.UTF-8') That fixes the mock use case but koji configures and passes it's own mock config and doesn't necessarily use the mock defaults so while it may fix mock it's likely koji will need an associated patch as well. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/EV6ZLPN4BDBLVKWCRXSTLRRE2U5A2ZF7/
Re: Fedora 30 System-Wide Change proposal: Remove glibc-all-langpacks from buildroot
On Fri, Aug 24, 2018 at 02:39:47PM +, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Aug 24, 2018 at 01:55:54PM +0100, Daniel P. Berrangé wrote: > > On Fri, Aug 24, 2018 at 12:38:48PM +, Petr Pisar wrote: > > > On 2018-08-22, Ben Cotton wrote: > > > > https://fedoraproject.org/wiki/Changes/Remove_glibc-langpacks-all_from_buildroot > > > > > > > > glibc-minimal-langpack is added to @Buildsystem group and installed > > > > into the minimal buildroot instead of glibc-all-langpacks. Packages > > > > which need more locales than plain C/C.UTF-8/POSIX need to pull them > > > > in through BuildRequires. > > > > > > > I already wrote it in previous thread about this change but it seems > > > nobody takes me seriosly. Once again: > > When you wrote about mock configuration previously, I answered: > > Thanks, that's a good point. Do you know where this is configured? > > This was me taking the issue seriously. I haven't started working on > this yet because it got bumped to F30, but I keep a list of all the > points raised, including this one. I turns out Tomasz Torcz already fixed this: https://github.com/rpm-software-management/mock/commit/33db2351074753271700ee78c316bf1e36a00594 > env['LANG'] = os.environ.setdefault('LANG', 'C.UTF-8') Thanks Tomasz! Zbyszek ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/OO6HBAHZQNIZJFGFYTIACTS56GAGBQR4/
Re: Fedora 30 System-Wide Change proposal: Remove glibc-all-langpacks from buildroot
On Fri, Aug 24, 2018 at 01:55:54PM +0100, Daniel P. Berrangé wrote: > On Fri, Aug 24, 2018 at 12:38:48PM +, Petr Pisar wrote: > > On 2018-08-22, Ben Cotton wrote: > > > https://fedoraproject.org/wiki/Changes/Remove_glibc-langpacks-all_from_buildroot > > > > > > glibc-minimal-langpack is added to @Buildsystem group and installed > > > into the minimal buildroot instead of glibc-all-langpacks. Packages > > > which need more locales than plain C/C.UTF-8/POSIX need to pull them > > > in through BuildRequires. > > > > > I already wrote it in previous thread about this change but it seems > > nobody takes me seriosly. Once again: When you wrote about mock configuration previously, I answered: > Thanks, that's a good point. Do you know where this is configured? This was me taking the issue seriously. I haven't started working on this yet because it got bumped to F30, but I keep a list of all the points raised, including this one. > > These three locales are not enough because Brew builders have > > en_US.UTF-8 locale that is propagated to mock and then into rpmbuild. > > That means all the build have set en_US.UTF-8 locale. If you stop > > installing the locale things will blow up. > > > > Either install glibc-langpack-en or change Brew locale first or edit > > every spec file to set LC_ALL explicitly. > > NB, some apps will explicitly force locale to en_US.UTF-8 in order to > ensure their output artifacts are stable & repeatable, and/or to work > around bugs in tools they run. If they do it even though a different locale is configured, they are buggy. Worst case, if some packages are built using tools which simply require en_US.UTF-8, a BR: glibc-langpack-en can be added to them. I don't expected that this would be necessary in more than a handful of cases. Zbyszek ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/PTP4KWQUFUXORVS5UEC6HFQBKYRKKAG6/
Re: Fedora 30 System-Wide Change proposal: Remove glibc-all-langpacks from buildroot
On Fri, Aug 24, 2018 at 12:38:48PM +, Petr Pisar wrote: > On 2018-08-22, Ben Cotton wrote: > > https://fedoraproject.org/wiki/Changes/Remove_glibc-langpacks-all_from_buildroot > > > > glibc-minimal-langpack is added to @Buildsystem group and installed > > into the minimal buildroot instead of glibc-all-langpacks. Packages > > which need more locales than plain C/C.UTF-8/POSIX need to pull them > > in through BuildRequires. > > > I already wrote it in previous thread about this change but it seems > nobody takes me seriosly. Once again: > > These three locales are not enough because Brew builders have > en_US.UTF-8 locale that is propagated to mock and then into rpmbuild. > That means all the build have set en_US.UTF-8 locale. If you stop > installing the locale things will blow up. > > Either install glibc-langpack-en or change Brew locale first or edit > every spec file to set LC_ALL explicitly. NB, some apps will explicitly force locale to en_US.UTF-8 in order to ensure their output artifacts are stable & repeatable, and/or to work around bugs in tools they run. Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :| ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/ZVMGOBT4B5YTLUCRTGZDQKEROEEIEKPQ/
Re: Fedora 30 System-Wide Change proposal: Remove glibc-all-langpacks from buildroot
On 2018-08-22, Ben Cotton wrote: > https://fedoraproject.org/wiki/Changes/Remove_glibc-langpacks-all_from_buildroot > > glibc-minimal-langpack is added to @Buildsystem group and installed > into the minimal buildroot instead of glibc-all-langpacks. Packages > which need more locales than plain C/C.UTF-8/POSIX need to pull them > in through BuildRequires. > I already wrote it in previous thread about this change but it seems nobody takes me seriosly. Once again: These three locales are not enough because Brew builders have en_US.UTF-8 locale that is propagated to mock and then into rpmbuild. That means all the build have set en_US.UTF-8 locale. If you stop installing the locale things will blow up. Either install glibc-langpack-en or change Brew locale first or edit every spec file to set LC_ALL explicitly. -- Petr ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/CPZYQWAAJQAVMX3Q4BSK4QMSYHKSGWHX/
Fedora 30 System-Wide Change proposal: Remove glibc-all-langpacks from buildroot
https://fedoraproject.org/wiki/Changes/Remove_glibc-langpacks-all_from_buildroot == Summary == glibc-minimal-langpack is added to @Buildsystem group and installed into the minimal buildroot instead of glibc-all-langpacks. Packages which need more locales than plain C/C.UTF-8/POSIX need to pull them in through BuildRequires. == Owner == * Name: Zbigniew Jędrzejewski-Szmek (zbyszek) * Email: zbys...@in.waw.pl == Detailed Description == Right now glibc-all-langpacks is installed in buildroots (mock, koji, …). It is 24 MB, out of the total of 145 MB. Replacing it with glibc-minimal-langpack, which has negligible size, decreases the buildroot size by 17%. glibc Requires glibc-langpack, and Suggests glibc-all-langpacks, so it gets installed automatically to satisfy that dependency. If a different package providing glibc-langpack is installed, glibc-all-langpacks is skipped. This change is basically adding glibc-minimal-langpack to @Buildsystem in comps and fixing any fallout in packages. A quick grep over spec files reveals: ``` $ rg -l 'LC_CTYPE=[^C]' *.spec | wc -l 11 $ rg -l 'LC_ALL=[^C]' *.spec | wc -l 42 ``` that there are at least ~50 packages which need adjustment. They can be either switched over to C.UTF-8 or a BuildRequires can be added. == Benefit to Fedora == The minimal buildroot becomes smaller, making builds slightly faster. == Scope == * Proposal owners: ** adjust comps ** fix packages which can be identified without rebuilding (see grep output above) ** fix fallout in the mass rebuild if anything is missed above * Other developers: report breakage and/or fix their own packages * Release engineering: [https://pagure.io/releng/issue/7610 #7610] * Policies and guidelines: no changes needed (The Packaging Guidelines already specify that all necessary dependencies must be declared using BuildRequires.) * Trademark approval: N/A (not needed for this Change) == Upgrade/compatibility impact == This only affect package building process, so it has no end-user impact. == How To Test == Verify that packages still build after the comps change. == User Experience == Not visible to end-users. == Dependencies == None. == Contingency Plan == Revert the comps change. Any changes in packages would be backwards compatible, so there's no need to revert them. There is also no need to rebuild any packages already successfully built. * Contingency mechanism: remove glibc-minimal-langpack from @Buildsystem * Blocks release? not directly, but if packages fail to build, it would be problem * Blocks product? no == Documentation == None -- Ben Cotton Fedora Program Manager TZ=America/Indiana/Indianapolis ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/WSV6XZGC24EJGHWVKG63OOJQFDZ6ITP6/