Re: Heads up - %configure and %cmake changes affecting MPI packages
Le mercredi 24 juin 2020 à 21:49 -0600, Orion Poplawski a écrit :
> This change in redhat-rpm-config:
>
> * Wed Jun 03 2020 Igor Raits -
> 158-1
> - Add option to choose C/C++ toolchain
>
> changed %_set_build_flags to also set the CC/CXX compiler variables:
>
> CC=%{__cc}; export CC ; \
> CXX=%{__cxx}; export CXX ; \
>
> This breaks the relatively common construct for building MPI versions
> of
> packages:
>
> export CC=mpicc
> export CXX=mpicxx
> %configure
This is why macros should never set variables blindly but use
constructs like safeset (in redhat-rpm-config’s common.lua) that check
if the packager already set things to other value before blindly
stomping over them
Regards,
--
Nicolas Mailhot
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Heads up - %configure and %cmake changes affecting MPI packages
This change in redhat-rpm-config:
* Wed Jun 03 2020 Igor Raits - 158-1
- Add option to choose C/C++ toolchain
changed %_set_build_flags to also set the CC/CXX compiler variables:
CC=%{__cc}; export CC ; \
CXX=%{__cxx}; export CXX ; \
This breaks the relatively common construct for building MPI versions of
packages:
export CC=mpicc
export CXX=mpicxx
%configure
For %configure you can change to:
%configure CC=mpicc CXX=mpicxx
For %cmake (this will also work with %configure) you'll need to do:
%define __cc mpicc
%define __cxx mpicxx
%cmake
With koschei down (I presume it is due to the move) I think this has
gone mostly unnoticed so far.
HTH,
Orion
--
Orion Poplawski
Manager of NWRA Technical Systems 720-772-5637
NWRA, Boulder/CoRA Office FAX: 303-415-9702
3380 Mitchell Lane or...@nwra.com
Boulder, CO 80301 https://www.nwra.com/
smime.p7s
Description: S/MIME Cryptographic Signature
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
