Re: How to properly go from arch-specific to noarch? (Finnish spell-checking)
On Wed, 20 Jan 2021 at 00:12, Zbigniew Jędrzejewski-Szmek wrote: > If the files are not arch-specific, just override the location to be > always /usr/lib/voikko. Pedantically speaking, this is not exactly following > the FHS, but it's easiest to follow upstream here. The difference between > /usr/lib and /usr/share is unimportant. Thanks. My review request is here: https://bugzilla.redhat.com/show_bug.cgi?id=1919688 I'll make a new mailing list post about a review swap if there aren't other review swap requests currently open in the latest posts on the list. -Ville-Pekka ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: How to properly go from arch-specific to noarch? (Finnish spell-checking)
On Tue, Jan 19, 2021 at 10:02:48PM +0200, Ville-Pekka Vainio wrote:
> Thanks, Zbyszek!
>
> I just realised one thing, which may affect the arch/noarch question.
> Upstream prefers to place the data files under /usr/lib/voikko. Of
> course, in a 64 bit system this would be /usr/lib64/voikko. But if I
> make the package noarch, %{_libdir} will change depending on the
> architecture of the system, which builds the package. So, should I
> just make the package arch-specific anyway or try to come up with
> another location for the data files? Logically, it could be
> %{_datadir}. I'll need to test that the code actually works, if I use
> that.
If the files are not arch-specific, just override the location to be
always /usr/lib/voikko. Pedantically speaking, this is not exactly following
the FHS, but it's easiest to follow upstream here. The difference between
/usr/lib and /usr/share is unimportant.
Zbyszek
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: How to properly go from arch-specific to noarch? (Finnish spell-checking)
Thanks, Zbyszek!
I just realised one thing, which may affect the arch/noarch question.
Upstream prefers to place the data files under /usr/lib/voikko. Of
course, in a 64 bit system this would be /usr/lib64/voikko. But if I
make the package noarch, %{_libdir} will change depending on the
architecture of the system, which builds the package. So, should I
just make the package arch-specific anyway or try to come up with
another location for the data files? Logically, it could be
%{_datadir}. I'll need to test that the code actually works, if I use
that.
On Sun, 17 Jan 2021 at 13:58, Zbigniew Jędrzejewski-Szmek
wrote:
>
> On Sun, Jan 17, 2021 at 12:12:19PM +0200, Ville-Pekka Vainio wrote:
> > %define debug_package %{nil}
> Looks iffy. Shouldn't your package have BuildArch:noarch? This should
> not be necessary once you add BuildArch:noarch.
You're right. This was a workaround I used in the older package, when
it needed to be arch-specific.
> > URL:http://voikko.puimula.org
> No https?
Good point. They do use HTTPS these days, I'll change the URL.
> > make vvfst
> %make_build vvfst ?
Seems to work, I'll use that.
-Ville-Pekka
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: How to properly go from arch-specific to noarch? (Finnish spell-checking)
On Mon, Jan 18, 2021 at 7:58 AM Dominik 'Rathann' Mierzejewski wrote: > > On Monday, 18 January 2021 at 09:43, Vít Ondruch wrote: > > > > Dne 17. 01. 21 v 11:12 Ville-Pekka Vainio napsal(a): > > > Hi, > > > > > > I am working on updating the Finnish spell-checking stack to the > > > current upstream versions. > > > > > > Currently Fedora has the malaga-suomi-voikko package, which is > > > arch-specific. For example, my own system has > > > malaga-suomi-voikko-1.19-12.fc33.x86_64 installed. In upstream, the > > > successor of this package is called voikko-fi and according to the > > > upstream developers the data files are not arch-specific anymore. > > > > > > My WIP spec file is at > > > https://vpv.fedorapeople.org/packages/voikko-fi.spec > > > > > > How should I handle Obsoletes and possibly Provides in this case? Do I > > > just do Obsoletes: malaga-suomi-voikko < 1.19-13 and that's it? > > > > > > Do you really need any explicit Obsoletes or Provides if you go with > > `BuildArch:noarch` as Zbyszek already pointed out? > > Yes. Otherwise you won't be able to upgrade between archful and noarch > (and vice-versa) without forcing it. Been there, done that. It's not a process entirely controlled by the packager: when the upstream module author elects to add, or discard, compiled code as part of the module, both the name of the RPM and the location of the built software can change based on architecture. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: How to properly go from arch-specific to noarch? (Finnish spell-checking)
On Monday, 18 January 2021 at 09:43, Vít Ondruch wrote: > > Dne 17. 01. 21 v 11:12 Ville-Pekka Vainio napsal(a): > > Hi, > > > > I am working on updating the Finnish spell-checking stack to the > > current upstream versions. > > > > Currently Fedora has the malaga-suomi-voikko package, which is > > arch-specific. For example, my own system has > > malaga-suomi-voikko-1.19-12.fc33.x86_64 installed. In upstream, the > > successor of this package is called voikko-fi and according to the > > upstream developers the data files are not arch-specific anymore. > > > > My WIP spec file is at https://vpv.fedorapeople.org/packages/voikko-fi.spec > > > > How should I handle Obsoletes and possibly Provides in this case? Do I > > just do Obsoletes: malaga-suomi-voikko < 1.19-13 and that's it? > > > Do you really need any explicit Obsoletes or Provides if you go with > `BuildArch:noarch` as Zbyszek already pointed out? Yes. Otherwise you won't be able to upgrade between archful and noarch (and vice-versa) without forcing it. Regards, Dominik -- Fedora https://getfedora.org | RPM Fusion http://rpmfusion.org There should be a science of discontent. People need hard times and oppression to develop psychic muscles. -- from "Collected Sayings of Muad'Dib" by the Princess Irulan ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: How to properly go from arch-specific to noarch? (Finnish spell-checking)
Dne 17. 01. 21 v 11:12 Ville-Pekka Vainio napsal(a): Hi, I am working on updating the Finnish spell-checking stack to the current upstream versions. Currently Fedora has the malaga-suomi-voikko package, which is arch-specific. For example, my own system has malaga-suomi-voikko-1.19-12.fc33.x86_64 installed. In upstream, the successor of this package is called voikko-fi and according to the upstream developers the data files are not arch-specific anymore. My WIP spec file is at https://vpv.fedorapeople.org/packages/voikko-fi.spec How should I handle Obsoletes and possibly Provides in this case? Do I just do Obsoletes: malaga-suomi-voikko < 1.19-13 and that's it? Do you really need any explicit Obsoletes or Provides if you go with `BuildArch:noarch` as Zbyszek already pointed out? Vít I am close to submitting this package for review and would take review swaps as well. This package is basically the only blocker left, the others are relatively simple version updates that I should be able to manage by myself. -Ville-Pekka ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org OpenPGP_0x0CE09EE79917B87C.asc Description: application/pgp-keys OpenPGP_signature Description: OpenPGP digital signature ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: How to properly go from arch-specific to noarch? (Finnish spell-checking)
On Sun, Jan 17, 2021 at 12:12:19PM +0200, Ville-Pekka Vainio wrote:
> Hi,
>
> I am working on updating the Finnish spell-checking stack to the
> current upstream versions.
>
> Currently Fedora has the malaga-suomi-voikko package, which is
> arch-specific. For example, my own system has
> malaga-suomi-voikko-1.19-12.fc33.x86_64 installed. In upstream, the
> successor of this package is called voikko-fi and according to the
> upstream developers the data files are not arch-specific anymore.
>
> My WIP spec file is at https://vpv.fedorapeople.org/packages/voikko-fi.spec
>
> How should I handle Obsoletes and possibly Provides in this case? Do I
> just do Obsoletes: malaga-suomi-voikko < 1.19-13 and that's it?
Yeah, obsoletes are not arch specific.
(Though maybe make it <1.19-20, to avoid issues if the package gets
rebuilt for whatever reason before the replacement is ready).
> %define debug_package %{nil}
Looks iffy. Shouldn't your package have BuildArch:noarch? This should
not be necessary once you add BuildArch:noarch.
> URL:http://voikko.puimula.org
No https?
> make vvfst
%make_build vvfst ?
Zbyszek
> I am close to submitting this package for review and would take review
> swaps as well. This package is basically the only blocker left, the
> others are relatively simple version updates that I should be able to
> manage by myself.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
How to properly go from arch-specific to noarch? (Finnish spell-checking)
Hi, I am working on updating the Finnish spell-checking stack to the current upstream versions. Currently Fedora has the malaga-suomi-voikko package, which is arch-specific. For example, my own system has malaga-suomi-voikko-1.19-12.fc33.x86_64 installed. In upstream, the successor of this package is called voikko-fi and according to the upstream developers the data files are not arch-specific anymore. My WIP spec file is at https://vpv.fedorapeople.org/packages/voikko-fi.spec How should I handle Obsoletes and possibly Provides in this case? Do I just do Obsoletes: malaga-suomi-voikko < 1.19-13 and that's it? I am close to submitting this package for review and would take review swaps as well. This package is basically the only blocker left, the others are relatively simple version updates that I should be able to manage by myself. -Ville-Pekka ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
