Re: JOSM now use openjfx, but openjfx not added to jvm after installation

2017-07-22 Thread Jonny Heggheim
> On Wednesday, 19 July 2017 at 21:54, Dominik 'Rathann' Mierzejewski wrote:
> 
> Also, reading
> https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOp...
> it should build on ARM, but has this in spec:
> ExclusiveArch:  %{ix86} x86_64
> without any comments or bug references.

This is a issue I would love that got solved, the build script from upstream 
explicit will fail to build on non x86 architectures.

I see that there is a build script that is used for cross-complication for ARM. 
Debian have several patches for ARM support, I will not have time to maintain 
and test ARM with so support from upstream. 

> This package definitely needs
> some maintainer care, especially since it FTBFS on rawhide:
> https://koji.fedoraproject.org/koji/buildinfo?buildID=914585

I agree 100%, I would love that someone else could also help maintaining this 
package, it is gigantic and messy.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: JOSM now use openjfx, but openjfx not added to jvm after installation

2017-07-22 Thread Jonny Heggheim
> openjfx is packaged incorrectly, installing files into
> /usr/lib/jvm/openjfx/rt/lib is wrong.

This has been discussed before the review and during the package review: 
https://bugzilla.redhat.com/show_bug.cgi?id=1438673#c76

It doesn't make much sense here. Guys elaborated it and came up with solution 
to place openjfx beside JDK/JRE and it makes perfect sense to me. Oracle has 
jfx included in their JDK and that's what developers expect. We decided to go 
with openjfx placed beside JDK and create openjfx subpackage that place links 
inside JDK.
Openjdk package itself also "violates" this and openjfx is same case.
So I don't see this to be an issue.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: JOSM now use openjfx, but openjfx not added to jvm after installation

2017-07-22 Thread Jonny Heggheim
> Hi,
> 
> I maintain JOSM and want to update it.
> 
> JOSM now use JavaFX, which is available over openjfx package.
> 
> But in openjfx package, there is a second step that needs to performed
> manually. These steps are described in
> /usr/share/doc/openjfx/README.fedora. 
> 
> These step create symlinks to activate javafx in the JVM. 
> 
> How can I do in my rpm JOSM's spec file ?

TLDR; use the javafx and javafx-devel virtual provides.

You can also use https://jonny.fedorapeople.org/reactfx.spec as a guideline.

There are currently no guidelines and no packages that depend on 
openjfx/openjdk-openjfx packages, but
https://bugzilla.redhat.com/show_bug.cgi?id=1145303 provides lots of the 
discussion.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: JOSM now use openjfx, but openjfx not added to jvm after installation

2017-07-19 Thread Dominik 'Rathann' Mierzejewski
On Wednesday, 19 July 2017 at 21:54, Dominik 'Rathann' Mierzejewski wrote:
> On Wednesday, 19 July 2017 at 19:51, Cedric OLIVIER wrote:
> > Le mercredi 19 juillet 2017 à 19:35 +0200, Germano Massullo a écrit :
> > > Il 19/07/2017 18:03, OLIVIER Cedric ha scritto:
> > > > These steps are described in
> > > > /usr/share/doc/openjfx/README.fedora. 
> > > 
> > > Could you please attach such file in the discussion?
> > 
> > You can find it here :
> > https://src.fedoraproject.org/cgit/rpms/openjfx.git/tree/README.fedora
> 
> openjfx is packaged incorrectly, installing files into
> /usr/lib/jvm/openjfx/rt/lib is wrong.
> 
> Java Packaging Guidelines must be followed. In particular:
> https://fedoraproject.org/wiki/Packaging:Java#Installation_directory
> and
> https://fedoraproject.org/wiki/Packaging:Java#Guideline

Also, reading
https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-LinuxARM
it should build on ARM, but has this in spec:
ExclusiveArch:  %{ix86} x86_64
without any comments or bug references. This package definitely needs
some maintainer care, especially since it FTBFS on rawhide:
https://koji.fedoraproject.org/koji/buildinfo?buildID=914585

Regards,
-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org
"Faith manages."
-- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: JOSM now use openjfx, but openjfx not added to jvm after installation

2017-07-19 Thread Dominik 'Rathann' Mierzejewski
On Wednesday, 19 July 2017 at 19:51, Cedric OLIVIER wrote:
> Le mercredi 19 juillet 2017 à 19:35 +0200, Germano Massullo a écrit :
> > Il 19/07/2017 18:03, OLIVIER Cedric ha scritto:
> > > These steps are described in
> > > /usr/share/doc/openjfx/README.fedora. 
> > 
> > Could you please attach such file in the discussion?
> 
> You can find it here :
> https://src.fedoraproject.org/cgit/rpms/openjfx.git/tree/README.fedora

openjfx is packaged incorrectly, installing files into
/usr/lib/jvm/openjfx/rt/lib is wrong.

Java Packaging Guidelines must be followed. In particular:
https://fedoraproject.org/wiki/Packaging:Java#Installation_directory
and
https://fedoraproject.org/wiki/Packaging:Java#Guideline

Regards,
Dominik
-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org
"Faith manages."
-- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: JOSM now use openjfx, but openjfx not added to jvm after installation

2017-07-19 Thread Cedric OLIVIER
Le mercredi 19 juillet 2017 à 19:35 +0200, Germano Massullo a écrit :
> Il 19/07/2017 18:03, OLIVIER Cedric ha scritto:
> > These steps are described in
> > /usr/share/doc/openjfx/README.fedora. 
> 
> Could you please attach such file in the discussion?

You can find it here : https://src.fedoraproject.org/cgit/rpms/openjfx.
git/tree/README.fedora

___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: JOSM now use openjfx, but openjfx not added to jvm after installation

2017-07-19 Thread Germano Massullo
Il 19/07/2017 18:03, OLIVIER Cedric ha scritto:
> These steps are described in
> /usr/share/doc/openjfx/README.fedora. 
Could you please attach such file in the discussion?
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


JOSM now use openjfx, but openjfx not added to jvm after installation

2017-07-19 Thread OLIVIER Cedric
Hi,

I maintain JOSM and want to update it.

JOSM now use JavaFX, which is available over openjfx package.

But in openjfx package, there is a second step that needs to performed
manually. These steps are described in
/usr/share/doc/openjfx/README.fedora. 

These step create symlinks to activate javafx in the JVM. 

How can I do in my rpm JOSM's spec file ?

Regards,
Cedric OLIVIER
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org