Re: Multilib issue with hard-coded paths in mash script

2010-11-08 Thread Christian Krause
Hi,

On 11/08/2010 11:15 PM, Matthias Clasen wrote:
>> 1. Specifically with respect to the problem with gdk-pixbuf: Should the
>> gdk-pixbuf loaders be multilib or not? If yes, the mash script must be
>> adjusted.
>  
> The loaders are shared objects, and the 64-bit modules won't help you on
> 32-bit, so yes, they need to be multilib.

Thanks for the info - I've added all relevant information to the
mentioned bug report [1] and moved it to the "mash" component.

Best regards,
Christian

[1] https://bugzilla.redhat.com/show_bug.cgi?id=649339
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: Multilib issue with hard-coded paths in mash script

2010-11-08 Thread Matthias Clasen
On Sun, 2010-11-07 at 00:43 +0100, Christian Krause wrote:
> Hi,

> The whole issue raises now some questions:
> 
> 1. Specifically with respect to the problem with gdk-pixbuf: Should the
> gdk-pixbuf loaders be multilib or not? If yes, the mash script must be
> adjusted.
> 
> 2. Should the mash script be reviewed whether there are any other
> hard-coded paths outdated? Should the script even be Fedora release
> specific?
> 

Sigh, multilib is just so broken...
 
The loaders are shared objects, and the 64-bit modules won't help you on
32-bit, so yes, they need to be multilib.

And yes, having hardcoded paths like that stored in a script without the
package maintainers knowledge is a good way to have breakage like this.


Matthias



-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Multilib issue with hard-coded paths in mash script

2010-11-07 Thread Christian Krause
Hi,

During the F14 release cycle gtk2 was updated from 2.20.x to 2.22.x.
During this change gdk-pixbuf2 was split off into a separate package and
the location of the gdk-pixbuf loaders has changed from:

F13: /usr/lib/gtk-2.0/2.10.0/loaders/
to
F14: /usr/lib/gdk-pixbuf-2.0/2.10.0/loaders

This caused now some strange effects due to the hard-coded paths in the
mash script for creating the x86_64 repository:

>From mash/mash/multilib.py:
if fnmatch(dirname, '/usr/lib*/gtk-2.0/*/loaders'):
return True

So in F13 the mash script picked up all i686 packages which provided
gdk-pixbuf loaders.

In F14 the script does not pick them up anymore (because of the changed
path) and so the i686 versions of some loaders are missing in the x86_64
repository.

This has now caused e.g. the following bug
https://bugzilla.redhat.com/show_bug.cgi?id=649339 .

The whole issue raises now some questions:

1. Specifically with respect to the problem with gdk-pixbuf: Should the
gdk-pixbuf loaders be multilib or not? If yes, the mash script must be
adjusted.

2. Should the mash script be reviewed whether there are any other
hard-coded paths outdated? Should the script even be Fedora release
specific?


Best regards,
Christian
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel