Re: Packages still using %{?_smp_mflags} manually?

2020-05-28 Thread Richard Shaw 
On Wed, May 27, 2020 at 10:01 AM Tom Stellard  wrote:

> On 05/27/2020 07:47 AM, Richard Shaw wrote:
> > On Wed, May 27, 2020 at 9:44 AM Tom Stellard  > wrote:
> >
> >
> > Also, I used to use %make_build without the {}, but someone
> suggested[1] I
> > add the {} in case the macro ever became a function.
> >
> > -Tom
> >
> > [1]
> https://src.fedoraproject.org/rpms/perl-Digest-SHA/pull-request/1#comment-37158
> >
> >
> > Well the packaging guidelines don't use them. If the macro did become a
> function I would expect that a mass automated change would need to be
> performed first anyway.
> >
>
> Ok, would you like me to update the pull requests?
>

Meh, I don't think it's a big deal since the maintainers are ignoring them
anyway :)

Thanks,
Richard
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Packages still using %{?_smp_mflags} manually?

2020-05-27 Thread Tom Stellard 
On 05/27/2020 07:47 AM, Richard Shaw wrote:
> On Wed, May 27, 2020 at 9:44 AM Tom Stellard  > wrote:
> 
> 
> Also, I used to use %make_build without the {}, but someone suggested[1] I
> add the {} in case the macro ever became a function.
> 
> -Tom
> 
> [1] 
> https://src.fedoraproject.org/rpms/perl-Digest-SHA/pull-request/1#comment-37158
> 
> 
> Well the packaging guidelines don't use them. If the macro did become a 
> function I would expect that a mass automated change would need to be 
> performed first anyway.
> 

Ok, would you like me to update the pull requests?

-Tom

> Thanks,
> Richard 
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Packages still using %{?_smp_mflags} manually?

2020-05-27 Thread Richard Shaw 
On Wed, May 27, 2020 at 9:44 AM Tom Stellard  wrote:

>
> Also, I used to use %make_build without the {}, but someone suggested[1] I
> add the {} in case the macro ever became a function.
>
> -Tom
>
> [1]
> https://src.fedoraproject.org/rpms/perl-Digest-SHA/pull-request/1#comment-37158


Well the packaging guidelines don't use them. If the macro did become a
function I would expect that a mass automated change would need to be
performed first anyway.

Thanks,
Richard
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Packages still using %{?_smp_mflags} manually?

2020-05-27 Thread Tom Stellard 
On 05/27/2020 05:19 AM, Richard Shaw wrote:
> On Tue, May 26, 2020 at 10:12 PM Tom Stellard  > wrote:
> 
> On 05/21/2020 07:57 AM, Richard Shaw wrote:
> > Not really a big deal but %build_make has been available for quite a 
> while. I noticed a few of my packages still supply _smp_mflags manually.
> >
> > Is this worth a script and automatic BZ? Probably not, but I think 
> there is an intrinsic value to consistency.
> >
> 
> I've been going through and fixing this manually in some spec files.
> Do you want to merge these and do the builds?
> 
> https://src.fedoraproject.org/rpms/dumpet/pull-request/1
> https://src.fedoraproject.org/rpms/byaccj/pull-request/1
> https://src.fedoraproject.org/rpms/splix/pull-request/1
> https://src.fedoraproject.org/rpms/qiv/pull-request/1
> https://src.fedoraproject.org/rpms/tss2/pull-request/8
> https://src.fedoraproject.org/rpms/marisa/pull-request/3
> https://src.fedoraproject.org/rpms/ldns/pull-request/2
> 
> 
> While it's a simple change, we should wait a little a little while and see if 
> the maintainers respond. Also, it doesn't hurt anything but typically it's 
> "%make_build / %make_install" without the {}.
> 

These changes were actually submitted a while ago.  Some pull requests are
2-3 months old.

Also, I used to use %make_build without the {}, but someone suggested[1] I
add the {} in case the macro ever became a function.

-Tom

[1] 
https://src.fedoraproject.org/rpms/perl-Digest-SHA/pull-request/1#comment-37158

> Thanks,
> Richard 
> 
> 
> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: 
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
> 
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Packages still using %{?_smp_mflags} manually?

2020-05-27 Thread Richard Shaw 
On Tue, May 26, 2020 at 10:12 PM Tom Stellard  wrote:

> On 05/21/2020 07:57 AM, Richard Shaw wrote:
> > Not really a big deal but %build_make has been available for quite a
> while. I noticed a few of my packages still supply _smp_mflags manually.
> >
> > Is this worth a script and automatic BZ? Probably not, but I think there
> is an intrinsic value to consistency.
> >
>
> I've been going through and fixing this manually in some spec files.
> Do you want to merge these and do the builds?
>
> https://src.fedoraproject.org/rpms/dumpet/pull-request/1
> https://src.fedoraproject.org/rpms/byaccj/pull-request/1
> https://src.fedoraproject.org/rpms/splix/pull-request/1
> https://src.fedoraproject.org/rpms/qiv/pull-request/1
> https://src.fedoraproject.org/rpms/tss2/pull-request/8
> https://src.fedoraproject.org/rpms/marisa/pull-request/3
> https://src.fedoraproject.org/rpms/ldns/pull-request/2


While it's a simple change, we should wait a little a little while and see
if the maintainers respond. Also, it doesn't hurt anything but typically
it's "%make_build / %make_install" without the {}.

Thanks,
Richard
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Packages still using %{?_smp_mflags} manually?

2020-05-27 Thread Björn 'besser82' Esser 
Am Donnerstag, den 21.05.2020, 17:53 +0200 schrieb Igor Raits:
> > In the spec file of another one that I've inherited, I see "make V=1
> > %{?_smp_mflags}".
> 
> %make_build V=1

Not even neccessary since `V=1` already gets injected by the
`%make_build` macro at least since F32:

$ rpm -E %make_build
/usr/bin/make -O -j8 V=1 VERBOSE=1


signature.asc
Description: This is a digitally signed message part
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Packages still using %{?_smp_mflags} manually?

2020-05-26 Thread Tom Stellard 
On 05/21/2020 07:57 AM, Richard Shaw wrote:
> Not really a big deal but %build_make has been available for quite a while. I 
> noticed a few of my packages still supply _smp_mflags manually.
> 
> Is this worth a script and automatic BZ? Probably not, but I think there is 
> an intrinsic value to consistency. 
> 

I've been going through and fixing this manually in some spec files.
Do you want to merge these and do the builds?

https://src.fedoraproject.org/rpms/dumpet/pull-request/1
https://src.fedoraproject.org/rpms/byaccj/pull-request/1
https://src.fedoraproject.org/rpms/splix/pull-request/1
https://src.fedoraproject.org/rpms/qiv/pull-request/1
https://src.fedoraproject.org/rpms/tss2/pull-request/8
https://src.fedoraproject.org/rpms/marisa/pull-request/3
https://src.fedoraproject.org/rpms/ldns/pull-request/2

-Tom


> Thanks,
> Richard
> 
> 
> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: 
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
> 
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Packages still using %{?_smp_mflags} manually?

2020-05-21 Thread Alexander Ploumistos 
Thanks Igor, I'll update both ASAP.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Packages still using %{?_smp_mflags} manually?

2020-05-21 Thread Igor Raits 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

On Thu, 2020-05-21 at 17:41 +0200, Alexander Ploumistos wrote:
> On Thu, May 21, 2020 at 5:01 PM Richard Shaw 
> wrote:
> > Not really a big deal but %build_make has been available for quite
> > a while. I noticed a few of my packages still supply _smp_mflags
> > manually.
> 
> Recently, one of my packages switched to meson and while searching
> through our documentation, I came across a page that had
> "%meson_build
> %{?_smp_mflags}" in an example.

The second part here is just ignored. And is just wrong. Please remove
it ASAP :)

> In the spec file of another one that I've inherited, I see "make V=1
> %{?_smp_mflags}".

%make_build V=1

> What should I be using?
> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: 
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: 
> https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
- -- 
Igor Raits 
-BEGIN PGP SIGNATURE-

iQIzBAEBCgAdFiEEcwgJ58gsbV5f5dMcEV1auJxcHh4FAl7GpBUACgkQEV1auJxc
Hh6s2BAAiuWycwMr+BjMVYNWSyHIThgKq3rrA3ifqz/aHZ8bqJALAvRKFxsORCwD
3gG1qnHTpatnZyBPcmCoIAuoQthhG3wrCZcBNrxO/CGhQ7FjSRqnfPnSC5xx+btv
gySQRkHZXnsdjRfThtp6tIUMFts0UnFbap4Y5gLXvYOg1x4LIxgAZSSgxS3TiztG
wZXP+KYzB+eO434Qx54VMcMgbqwTk86j96qritZT49Jqt2jerPlXsthPGg/GVA4h
/VJjUJlRcC8XjsjPebh/Aud6nZukdV2QBlY58JglpfOk3VDIfCz1MH3hOyiVhdJr
Gb15RH5i00rmaNxb8HD2etJzeXB5i75C+XcoP0sAgHfvZ42oKbHRI6PCjhYijq52
owOBgFB1VyXUBYUZUfcdIpN8re//+opHnd6rUmPYWMCVgBqHCBl9uV/5hQszxpqZ
VNvMY+kPHbGuQFYeT17rtDBSkitOEkI3KXpi7rxrVHzHwO1Igi1BKSzk1K5XXxo9
f9N/3xGMh2UQtkdnGXeOcZISrh/WhAApV0Nip+R8ZMhWC1wmYQ7lSzi3oQnHMQOM
3eeI0Evqc3f8Rfe0fCOhz1/DAsir3mWMH28URq4XFaHPNUG28irNuDiuA6PuAxqs
pa5UPtSy173ryBk7kSEJME63usKJXxInknsyAKY6vs01AGO1ItQ=
=u1Rg
-END PGP SIGNATURE-
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Packages still using %{?_smp_mflags} manually?

2020-05-21 Thread Alexander Ploumistos 
On Thu, May 21, 2020 at 5:01 PM Richard Shaw  wrote:
>
> Not really a big deal but %build_make has been available for quite a while. I 
> noticed a few of my packages still supply _smp_mflags manually.

Recently, one of my packages switched to meson and while searching
through our documentation, I came across a page that had "%meson_build
%{?_smp_mflags}" in an example.
In the spec file of another one that I've inherited, I see "make V=1
%{?_smp_mflags}".

What should I be using?
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Packages still using %{?_smp_mflags} manually?

2020-05-21 Thread Richard Shaw 
Not really a big deal but %build_make has been available for quite a while.
I noticed a few of my packages still supply _smp_mflags manually.

Is this worth a script and automatic BZ? Probably not, but I think there is
an intrinsic value to consistency.

Thanks,
Richard
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org