Re: Pidgin Lync-collab COPR

2015-03-10 Thread Jan Synacek
David Woodhouse  writes:

> I've *just* managed to commit the in-call DTMF
> support that has been kicking around for about 4 years!
> ...
> In the meantime though, any additional testing would be welcome...

For the interested, this patch is now in F21 testing:

https://admin.fedoraproject.org/updates/pidgin-2.10.11-2.fc21

-- 
Jan Synacek
Software Engineer, Red Hat


signature.asc
Description: PGP signature
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Pidgin Lync-collab COPR

2015-03-09 Thread David Woodhouse
On Mon, 2015-03-09 at 10:57 -0500, Michael Cronenworth wrote:
> 
> File sharing works but immediately crashes when it finishes. I see an issue 
> is 
> already in github for that. If I can get additional debugging output I'll 
> forward it 
> off-list.

Thanks.

File sharing was working for me but only if I'm offered one file at a
time. If I'm offered two, *then* it fails to download them, just sitting
at 'Waiting for download to start'. And crashes when I click 'Stop' in
the UI.

Sending works, but runs in the main thread so appears to lock up the UI
a lot of the time... but it *is* actually working.

-- 
dwmw2


smime.p7s
Description: S/MIME cryptographic signature
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Pidgin Lync-collab COPR

2015-03-09 Thread Michael Cronenworth

On 03/09/2015 09:23 AM, David Woodhouse wrote:

It certainly looked easy when I glanced at it, although I really need to
be doing "real work" this week so I'm resisting the temptation to look
harder. Please could you share your patches?


I will send them off-list.


And if you have the inclination to also look at backporting the collab
patches I've attempted to consolidate in
http://git.infradead.org/users/dwmw2/pidgin-collab.git  that would be
much appreciated!


If I have time I'll take a look.


Probably, yes. I assume you do have the updated freerdp packages
installed, for receiving a shared screen? And freerdp-server if you want
to share your own? The error handling is fairly much non-existent for
now; it'll spawn 'xfreerdp' or 'freerdp-server' but just fail silently
if it doesn't work.


Yes, I used your copr repo and installed all the required packages. I see freerdp 
start-up in the background but no window displays for either party for either 
direction of desktop sharing.



I've just been in a screen-sharing session as a recipient, and that much
seems to work fine here. But*sending*, and file transfer of large files
in both directions, seemed to deadlock work initially and then deadlock.
Precisely what did you see? Can you capture 'pidgin -d' output when you
attempt it?


File sharing works but immediately crashes when it finishes. I see an issue is 
already in github for that. If I can get additional debugging output I'll forward it 
off-list.

--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Pidgin Lync-collab COPR

2015-03-09 Thread David Woodhouse
On Mon, 2015-03-09 at 08:29 -0500, Michael Cronenworth wrote:
> 
> Good work!
> 
> It's easy to get Pidgin 2 to build against GST 1.x as I've had it for a while

It certainly looked easy when I glanced at it, although I really need to
be doing "real work" this week so I'm resisting the temptation to look
harder. Please could you share your patches?

And if you have the inclination to also look at backporting the collab
patches I've attempted to consolidate in
http://git.infradead.org/users/dwmw2/pidgin-collab.git that would be
much appreciated!

> Calls work for me, but desktop sharing does not. Is github the place to 
> report 
> issues with this?

Probably, yes. I assume you do have the updated freerdp packages
installed, for receiving a shared screen? And freerdp-server if you want
to share your own? The error handling is fairly much non-existent for
now; it'll spawn 'xfreerdp' or 'freerdp-server' but just fail silently
if it doesn't work.

I've just been in a screen-sharing session as a recipient, and that much
seems to work fine here. But *sending*, and file transfer of large files
in both directions, seemed to deadlock work initially and then deadlock.
Precisely what did you see? Can you capture 'pidgin -d' output when you
attempt it?

-- 
dwmw2


smime.p7s
Description: S/MIME cryptographic signature
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Pidgin Lync-collab COPR

2015-03-09 Thread Michael Cronenworth

On 03/09/2015 07:14 AM, David Woodhouse wrote:
[snip]

Aside from trying to chase the outstanding patches into Pidgin 3, I'm
also I'm going to take a look at what it would take to backport them to
Pidgin 2 (starting with farstream02/gstreamer1 support which doesn't
look that hard), and then I might make my COPR based on that instead.

In the meantime though, any additional testing would be welcome...


Good work!

It's easy to get Pidgin 2 to build against GST 1.x as I've had it for a while, but I 
was unaware of this effort against Pidgin 3.


Calls work for me, but desktop sharing does not. Is github the place to report 
issues with this?


Thanks,
Michael
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Pidgin Lync-collab COPR

2015-03-09 Thread David Woodhouse
I have created a COPR at
https://copr.fedoraproject.org/coprs/dwmw2/pidgin3-sipe/

This contains the work that has been done by Tieto to add media
encryption, file transfer and screen sharing to pidgin-sipe, from:
https://github.com/tieto/pidgin and
https://github.com/tieto/sipe

They've been doing an excellent job of developing this "upstream first",
so most of the updated dependencies are already in Fedora or are
upstream and just waiting for us to update. I've already pushed updates
to F21 updates-testing for the gstreamer1-plugins packages and freerdp,
and will potentially do libnice and farstream02 soon.

The biggest issue has been Pidgin itself, which is utterly painful to
get patches into — I've *just* managed to commit the in-call DTMF
support that has been kicking around for about 4 years! And obviously
there are outstanding patches to pidgin-sipe which can't go upstream
until Pidgin exports the new APIs they depend on.

Aside from trying to chase the outstanding patches into Pidgin 3, I'm
also I'm going to take a look at what it would take to backport them to
Pidgin 2 (starting with farstream02/gstreamer1 support which doesn't
look that hard), and then I might make my COPR based on that instead.

In the meantime though, any additional testing would be welcome...

-- 
dwmw2



smime.p7s
Description: S/MIME cryptographic signature
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct