Re: Follow-up - Please BuildRequire python3-setuptools explicitly

[Petr Viktorin]

On 2020-10-05 13:53, Richard Shaw wrote:
I updated fail2ban and gmsh and committed to master. I assume that is 
sufficient?


Thank you!
As I understand it, it is sufficient.  But since repo queries look at 
"live" packages, you might get some spurious notifications about this in 
the future.

___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Follow-up - Please BuildRequire python3-setuptools explicitly

[Miroslav Suchý]

Dne 05. 10. 20 v 12:55 Tomas Hrnciar napsal(a):
> copr-messaging   schlupov 

Fixed in upstream.
https://pagure.io/copr/copr/pull-request/1534
Will propagate to Fedora soon.

-- 
Miroslav Suchy, RHCA
Red Hat, Associate Manager ABRT/Copr, #brno, #fedora-buildsys
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Follow-up - Please BuildRequire python3-setuptools explicitly

[Stephen Gallagher]

On Mon, Oct 5, 2020 at 6:56 AM Tomas Hrnciar  wrote:
>
> Hello everyone,
>
> this is a follow-up email to the one I wrote a couple of months ago 
> (https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/GCPGM34ZGEOVUHSBGZTRYR5XKHTIJ3T7/).

> sgallagh   nodejs

I've fixed this in the "14" branch (which gets synced to "master") so
it will be in the next build.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Follow-up - Please BuildRequire python3-setuptools explicitly

[Ankur Sinha]

On Mon, Oct 05, 2020 12:55:49 +0200, Tomas Hrnciar wrote:
> 
> ankursinha arbor python-petlink 

I've fixed both of these now. Apologies for the delay.

-- 
Thanks,
Regards,
Ankur Sinha "FranciscoD" (He / Him / His) | 
https://fedoraproject.org/wiki/User:Ankursinha
Time zone: Europe/London


signature.asc
Description: PGP signature
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Follow-up - Please BuildRequire python3-setuptools explicitly

[Parag Nemade]

Hi,

I think fontforge is a false positive. It's just one line which imports
setuptools and that is from third party sources in the pycontrib directory.
That file (or directory) is not installed by the fontforge package.

Regards,
Parag
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Follow-up - Please BuildRequire python3-setuptools explicitly

[Richard Shaw]

I updated fail2ban and gmsh and committed to master. I assume that is
sufficient?

Thanks,
Richard
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Athos Ribeiro]

On Tue, Jun 23, 2020 at 06:26:23PM +0200, Tomas Hrnciar wrote:

Hello everyone,

there are plenty of Python packages in Fedora currently using setuptools at
buildtime but not all of them are BuildRequiring it explicitly. This only works
because python3-devel (transitively) depends on python3-setuptools.

We would like to kindly ask you to add explicit BuildRequires for
python3-setuptools to packages where setuptools is used. It will help us
with testing new versions of setuptools in the future or with decoupling
Python and setuptools. Today, if we want to know if a package is using
setuptools, we have to do `fedpkg prep` and use grep to search for
setuptools. Using a repoquery is much more convenient.

Several packages can successfully build either with or without setuptools
(they use try-except import and fallback to distutils from the standard
library). Such packages are especially dangerous when not BuildRequiring
setuptools -- they can produce different results depending on the presence
of setuptools: either an .egg-info metadata directory (w/setuptools) or
.egg-info text file (w/distutils). RPM has troubles when upgrading
directories to files [1].

[1]
https://docs.fedoraproject.org/en-US/packaging-guidelines/Directory_Replacement/

According to our grep based query on Fedora Rawhide, there are 621 known
packages using setuptools without BuildRequiring it at this point:

Thank you very much for your help with this.

On behalf of python-setuptools maintainers,
Tomáš Hrnčiar


[snip...]


flawfinder   athoscr


Fixed in rawhide

[snip...]
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Richard W.M. Jones]

On Tue, Jun 23, 2020 at 06:28:00PM -, Miro Hrončok wrote:
> > On Tue, Jun 23, 2020 at 06:26:23PM +0200, Tomas Hrnciar wrote:
> > 
> > This package depends on python3-devel.  However the last build.log:
> > 
> >  
> > https://kojipkgs.fedoraproject.org//packages/qemu/5.0.0/2.fc33/data/logs/...
> > 
> > does not contain the substring /setupto/ anywhere.  Nor does the
> > upstream git repo.  How do we know it is required?
> 
> $ fedpkg prep
> $ rg setuptools qemu-5.0.0
> qemu-5.0.0/capstone/bindings/python/setup.py
> 10:from setuptools import setup
> 14:from setuptools.command.bdist_egg import bdist_egg
> 176:from setuptools.command.develop import develop
> 
> Is this file used during the build? If not, it's a false hit.

Oh I see, it's a git submodule which is why my "git grep" on the
upstream repo didn't catch it.

However we actually use ‘configure --disable-capstone’, because we
remove the bundled library and use the Fedora-built capstone instead.
So I don't believe setuptools is needed.  I guess we'll find out if it
breaks down the road.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Artur Iwicki]

> suve   copydeps dnstwist python-ssdeep
Fixed in rawhide (just dist-git, didn't run the builds). Should there be a new 
release for any of these, I'll fix it for F32/31, too.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Jerry James]

On Tue, Jun 23, 2020 at 10:26 AM Tomas Hrnciar  wrote:
> python-zodbpicklejjames
> sympycbm jjames jussilehtola orion

I fixed these two in Rawhide, and also fixed a python 3.9 bug in sympy
and an endianness bug in python-gmpy2 en passant.
-- 
Jerry James
http://www.jamezone.org/
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Robbie Harwood]

Tomas Hrnciar  writes:

> We would like to kindly ask you to add explicit BuildRequires for
> python3-setuptools to packages where setuptools is used. It will help
> us with testing new versions of setuptools in the future or with
> decoupling Python and setuptools. Today, if we want to know if a
> package is using setuptools, we have to do `fedpkg prep` and use grep
> to search for setuptools. Using a repoquery is much more convenient.
>
> python-kdcproxy  rharwood

Done in python-kdcproxy-0.4.2-5.fc33.

Thanks,
--Robbie


signature.asc
Description: PGP signature
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Gabriel L. Somlo]

On Tue, Jun 23, 2020 at 06:26:23PM +0200, Tomas Hrnciar wrote:
> somlo  python-logzero python-migen

Fixed in rawhide. Thanks,
--Gabriel
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Miro Hrončok]

On 23. 06. 20 18:26, Tomas Hrnciar wrote:
churchyard python-django python-ipykernel python-more-itertools 
python-ndg_httpsclient thonny


All fixed at least in git. The changes should be visible in repoquery upon the 
next rebuild.


--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Ankur Sinha]

Thanks for the list.

> ankursinha python-PyLEMS python-SALib python-airspeed python-duecredit
> python-efel python-feedgenerator python-fsleyes python-fsleyes-props
> python-fsleyes-widgets python-fslpy python-hl7 python-indexed_gzip
> python-klusta python-libNeuroML python-matplotlib-scalebar python-nilearn
> python-nistats python-nitime python-nixio python-petlink python-pingouin
> python-pyelectro python-pyemd python-pylatex python-pymatreader python-pypet
> python-pytest-lazy-fixture python-sciunit python-steps python-tasklib 

I've updated all of these apart from nistats which I'm waiting to
retire.

There are a few more neuro-sig packages in the list, but I'll wait for
the primary maintainers to look into them before I start touching them.

-- 
Thanks,
Regards,
Ankur Sinha "FranciscoD" (He / Him / His) | 
https://fedoraproject.org/wiki/User:Ankursinha
Time zone: Europe/London


signature.asc
Description: PGP signature
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Felix Schwarz]

Am 23.06.20 um 18:26 schrieb Tomas Hrnciar:
> fschwarz   pdfarranger python-ndg_httpsclient python-pdfrw python-pyrfc3339
> python-tinycss2 

I fixed python-ndg_httpsclient, python-pdfrw, python-pyrfc3339 and 
python-tinycss2

dreua fixed pdfarranger.

Felix
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Miro Hrončok]

On 24. 06. 20 20:21, Andy Mender wrote:
*Packages MAY use the automatic Python dependency generator. This generator uses 
upstream egg/dist metadata (such as setuptool’s install_requires 
)


This is about the runtime dependencies.

--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Andy Mender]

On Tue, 23 Jun 2020 at 18:37, Adam Williamson 
wrote:

> IMBW, but I think I recall the Python packaging guidelines specifically
> said that you could or should (I forget which) just BR python-devel and
> not BR python-setuptools at some point. At this point there seems to be
> no explicit mention, but the sample spec file looks a lot like a
> project that uses setuptools, but does not explicitly BuildRequire
> it...
>
>From the Python packaging guidelines here:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
*Packages building for Python 3 will need BuildRequires: python3-devel.*
And also this:

*Packages MAY use the automatic Python dependency generator. This generator
uses upstream egg/dist metadata (such as setuptool’s install_requires
) *

Considering the file vs dir difference in metadata storage, I would say
it's fair to expect dependencies to be strict.
I myself don't have any Python packages yet, but I'll try to pay extra
attention to python3-setuptools in the future :).
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Andrea Musuruane]

On Tue, Jun 23, 2020 at 6:26 PM Tomas Hrnciar  wrote:

> Hello everyone,
>
> there are plenty of Python packages in Fedora currently using setuptools at
> buildtime but not all of them are BuildRequiring it explicitly. This only 
> works
> because python3-devel (transitively) depends on python3-setuptools.
>
> We would like to kindly ask you to add explicit BuildRequires for
> python3-setuptools to packages where setuptools is used. It will help us
> with testing new versions of setuptools in the future or with decoupling
> Python and setuptools. Today, if we want to know if a package is using
> setuptools, we have to do `fedpkg prep` and use grep to search for
> setuptools. Using a repoquery is much more convenient.
>
> Several packages can successfully build either with or without setuptools
> (they use try-except import and fallback to distutils from the standard
> library). Such packages are especially dangerous when not BuildRequiring
> setuptools -- they can produce different results depending on the presence
> of setuptools: either an .egg-info metadata directory (w/setuptools) or
> .egg-info text file (w/distutils). RPM has troubles when upgrading
> directories to files [1].
>
> [1]
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Directory_Replacement/
>
> According to our grep based query on Fedora Rawhide, there are 621 known
> packages using setuptools without BuildRequiring it at this point:
>
> Thank you very much for your help with this.
>
[...]
>
> musuruan   ogr2osm
>

Fixed and rebuilt in rawhide.

BR,

Andrea
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Dan Čermák]

Tomas Hrnciar  writes:

> pyxattr  defolos frankcrawford kevin szpak

Fixed and rebuild in Rawhide.


signature.asc
Description: PGP signature
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Michael J Gruber]

So, turns out I got this right somehow (setup.py defaults to distutils) but not 
really:

We don't even use setup.py but build the portmidi python module directly 
(cython/gcc/install). I removed setup.py and rebuilt, this works fine and 
produces the same package.

So, I suggest removing setup.py in spec and not installing the shipped README 
(which does not match the installation). I'm not the owner/main admin/you name 
it, so I'll suggest this to the portmidi team as a PR to have possible 
technical discussions there.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Miro Hrončok]

On 23. 06. 20 18:43, Miro Hrončok wrote:

On 23. 06. 20 18:36, Adam Williamson wrote:

IMBW, but I think I recall the Python packaging guidelines specifically
said that you could or should (I forget which) just BR python-devel and
not BR python-setuptools at some point. At this point there seems to be
no explicit mention, but the sample spec file looks a lot like a
project that uses setuptools, but does not explicitly BuildRequire
it...


I'll work towards adding the explicit BR there.


https://pagure.io/packaging-committee/pull-request/992

--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Vitaly Zaitsev via devel]

On 23.06.2020 18:26, Tomas Hrnciar wrote:
> xvitaly    libolm python-emoji python-node-semver python-patch-ng
> python-pytelegrambotapi python-wloc 

Fixed. Thanks.

-- 
Sincerely,
  Vitaly Zaitsev (vit...@easycoding.org)
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Jakub Jelen]

On Tue, 2020-06-23 at 18:26 +0200, Tomas Hrnciar wrote:
> [...]
> tpm2-pkcs11  jjelen pbrobinson

Done for this package in rawhide (without rebuilt yet).

Regards,
-- 
Jakub Jelen
Senior Software Engineer
Security Technologies
Red Hat, Inc.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Michel Alexandre Salim]

On 6/23/20 9:26 AM, Tomas Hrnciar wrote:

Hello everyone,

there are plenty of Python packages in Fedora currently using setuptools at 
buildtime but not all of them are BuildRequiring it explicitly. This only 
works because python3-devel (transitively) depends on python3-setuptools.


We would like to kindly ask you to add explicit 
BuildRequires for python3-setuptools to packages where setuptools is used. It 
will help us with testing new versions of setuptools in the future or 
with decoupling Python and setuptools. Today, if we want to know if a 
package is using setuptools,we have to do `fedpkgprep` and use grep to 
search for setuptools. Using a repoquery is much more convenient.



...

salimma    python-django python-psutil
Done (for Rawhide). For python-psutil I'm following the other pattern in 
the spec and using python%{python3_pkgversion}-setuptools, but this 
should resolve to python3-setuptools when you use repoquery.


Cheers,

--
Michel Alexandre Salim
profile: https://keybase.io/michel_slm
chat via email: https://delta.chat/
GPG key: 96A7 A6ED FB4D 2113 4056 3257 CAF9 AD10 ACB1 BEF2
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Miro Hrončok]

On 23. 06. 20 21:58, Michael J Gruber wrote:

The hit on portmidi is a false positive: while it allows to be built with setuptools it 
by default does not, and the spec does not override the default. Is there a way to 
specify this (other than patching out anything "setuptools" from the source)?


Would it make sense to explicitly enable setuptools based build instead? Among 
other things, it has richer metadata when the package is installed.


--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Mukundan Ragavan]

On 6/23/20 12:26 PM, Tomas Hrnciar wrote:


> 
> We would like to kindly ask you to add explicit
> BuildRequires for python3-setuptools to packages where setuptools is used.



> nonamedotc python-nmrglue python-rope spyder 



I have added buildrequires on setuptools for these three packages.



signature.asc
Description: OpenPGP digital signature
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Michael J Gruber]

Hi there

Thanks for the clear posting.

I have updated dblatex with the BR in rawhide. I guess it's enough to trickle 
this down to other branches when they need a rebuild anyways.

The hit on portmidi is a false positive: while it allows to be built with 
setuptools it by default does not, and the spec does not override the default. 
Is there a way to specify this (other than patching out anything "setuptools" 
from the source)?
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Miro Hrončok]

> On Tue, Jun 23, 2020 at 06:26:23PM +0200, Tomas Hrnciar wrote:
> 
> This package depends on python3-devel.  However the last build.log:
> 
>  
> https://kojipkgs.fedoraproject.org//packages/qemu/5.0.0/2.fc33/data/logs/...
> 
> does not contain the substring /setupto/ anywhere.  Nor does the
> upstream git repo.  How do we know it is required?

$ fedpkg prep
$ rg setuptools qemu-5.0.0
qemu-5.0.0/capstone/bindings/python/setup.py
10:from setuptools import setup
14:from setuptools.command.bdist_egg import bdist_egg
176:from setuptools.command.develop import develop

Is this file used during the build? If not, it's a false hit.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Richard W.M. Jones]

On Tue, Jun 23, 2020 at 06:26:23PM +0200, Tomas Hrnciar wrote:
> qemu amitshah berrange bonzini crobinso dwmw2 ehabkost
> jforbes lkundrak quintela rjones

This package depends on python3-devel.  However the last build.log:

  
https://kojipkgs.fedoraproject.org//packages/qemu/5.0.0/2.fc33/data/logs/x86_64/build.log

does not contain the substring /setupto/ anywhere.  Nor does the
upstream git repo.  How do we know it is required?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Miro Hrončok]

On 23. 06. 20 18:36, Adam Williamson wrote:

IMBW, but I think I recall the Python packaging guidelines specifically
said that you could or should (I forget which) just BR python-devel and
not BR python-setuptools at some point. At this point there seems to be
no explicit mention, but the sample spec file looks a lot like a
project that uses setuptools, but does not explicitly BuildRequire
it...


I'll work towards adding the explicit BR there.

--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: Please BuildRequire python3-setuptools explicitly

[Adam Williamson]

On Tue, 2020-06-23 at 18:26 +0200, Tomas Hrnciar wrote:
> Hello everyone,
> 
> there are plenty of Python packages in Fedora currently using
> setuptools at
> buildtime but not all of them are BuildRequiring it explicitly. This
> only works
> because python3-devel (transitively) depends on python3-setuptools.
> 
> We would like to kindly ask you to add explicit BuildRequires for
> python3-setuptools to packages where setuptools is used. It will help
> us
> with testing new versions of setuptools in the future or with
> decoupling
> Python and setuptools. Today, if we want to know if a package is
> using
> setuptools, we have to do `fedpkg prep` and use grep to search for
> setuptools. Using a repoquery is much more convenient.
> 
> Several packages can successfully build either with or without
> setuptools
> (they use try-except import and fallback to distutils from the
> standard
> library). Such packages are especially dangerous when not
> BuildRequiring
> setuptools -- they can produce different results depending on the
> presence
> of setuptools: either an .egg-info metadata directory (w/setuptools)
> or
> .egg-info text file (w/distutils). RPM has troubles when upgrading
> directories to files [1].

IMBW, but I think I recall the Python packaging guidelines specifically
said that you could or should (I forget which) just BR python-devel and
not BR python-setuptools at some point. At this point there seems to be
no explicit mention, but the sample spec file looks a lot like a
project that uses setuptools, but does not explicitly BuildRequire
it...
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org