Re: [build system] New optimization failed to follow /Usr Merge

2020-07-22 Thread Sérgio Basto
On Wed, 2020-07-22 at 07:51 -0700, Luya Tshimbalanga wrote:
> 
> 
> 
> On 2020-07-19 11:12 a.m., Luya
>   Tshimbalanga wrote:
> 
> 
> 
> >   
> >   Hello team,
> >   when doing a scratch build [1], I noticed some changes like
> > these lines on %build:
> >   '/builddir/build/BUILD/partio-1.10.1/build/Linux-5.6.15-
> > x86_64-optimize'
> >   and on %install i.e.
> > 
> >   
> >   -- Installing: /builddir/build/BUILDROOT/partio-1.10.1-
> > 3.fc33.x86_64/builddir/build/BUILD/partio-1.10.1/Linux-5.6.15-
> > x86_64-optimize/lib64/libpartio.so.1.5.2
> >   It seems someone forgot that Fedora adopted /usr Merge method
> > since the 17 release [3,4] which should look like
> >   -- Installing: /builddir/build/BUILDROOT/partio-1.10.1-
> > 3.fc33.x86_64/builddir/build/BUILD/partio-1.10.1/Linux-5.6.15-
> > x86_64-optimize/usr/lib64/libpartio.so.1.5.2
> >   Although the optimization is welcome, that issue should get
> > addressed to avoid confusion among maintainers.
> >   T
> > 
> 
> Answering my own question. Setting a prefix and using %cmake
> macros
> did the trick.

you may want read 
https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds
  with  "%global __cmake_in_source_build 1"  use have the old behavior 
> 
> >   -- 
> > 
> 
> Luya TshimbalangaFedora Design TeamFedora Design Suite maintainer
>   
> 
> ___devel mailing list -- 
> devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: 
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: 
> https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
-- 
Sérgio M. B.

___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: [build system] New optimization failed to follow /Usr Merge

2020-07-22 Thread Luya Tshimbalanga


On 2020-07-19 11:12 a.m., Luya Tshimbalanga wrote:


Hello team,

when doing a scratch build [1], I noticed some changes like these 
lines on %build:


'/builddir/build/BUILD/partio-1.10.1/build/Linux-5.6.15-x86_64-optimize'

and on %install i.e.

-- Installing: 
/builddir/build/BUILDROOT/partio-1.10.1-3.fc33.x86_64/builddir/build/BUILD/partio-1.10.1/Linux-5.6.15-x86_64-optimize/lib64/libpartio.so.1.5.2

It seems someone forgot that Fedora adopted /usr Merge method since 
the 17 release [3,4] which should look like


-- Installing: 
/builddir/build/BUILDROOT/partio-1.10.1-3.fc33.x86_64/builddir/build/BUILD/partio-1.10.1/Linux-5.6.15-x86_64-optimize/usr/lib64/libpartio.so.1.5.2

Although the optimization is welcome, that issue should get addressed 
to avoid confusion among maintainers.


T

Answering my own question. Setting a prefix and using %cmake macros did 
the trick.


--


Luya Tshimbalanga
Fedora Design Team
Fedora Design Suite maintainer

___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org