Re: Orphaned: elementry, evas-generic-loaders
Christopher Meng wrote:
> 100 is not enough at all, even .
100 is enough for all practical purposes. Even kdelibs3, which has had no
upstream release for 8 years, is only at -75. And in the unlikely event you
really reach 99, you can go to 99.1, 99.2, …
> Since efl has higher version, just use proper macros.
>
> Obsoletes: evas-generic-loaders <= %{version}-%{release}
That should be < rather than <= again. And it only makes sense if the
version numbers actually correlate. Otherwise it is too broad.
There is no case in which < 1.17.0-100 will fail, but something like < 3.0
will work. The -100 hack is actually the narrowest Obsoletes you can use. If
you don't like it, use < 1.17.1 (the next narrowest).
> Obsoletes: evas-generic-loaders%{?_isa} <= %{version}-%{release}
And this one is just nonsense, as Igor Gnatenko pointed out.
Kevin Kofler
--
devel mailing list
devel@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
Re: Orphaned: elementry, evas-generic-loaders
Kevin, yeah, you are right. It will work as there is no -Release.
Didn't see this before.
On Thu, Sep 8, 2016 at 12:59 AM, Kevin Kofler wrote:
> Igor Gnatenko wrote:
>> +Obsoletes: evas-generic-loaders <= 1.17.0
>>
>> This is basically wrong because current version is 1.17.0-5%{?dist}.
>
> <= 1.17.0 should still match that, I think (because there's no -Release in
> there), but still, <= Obsoletes are usually a bad idea (< is safer).
>
> Kevin Kofler
> --
> devel mailing list
> devel@lists.fedoraproject.org
> https://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
--
-Igor Gnatenko
--
devel mailing list
devel@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
Re: Orphaned: elementry, evas-generic-loaders
On Thu, Sep 8, 2016 at 5:34 AM, Christopher Meng wrote:
>
>
> On Thursday, September 8, 2016, Kevin Kofler wrote:
>>
>> I wrote:
>> > <= 1.17.0 should still match that, I think (because there's no -Release
>> > in
>> > there), but still, <= Obsoletes are usually a bad idea (< is safer).
>>
>> PS: To be clear, I would use either:
>> Obsoletes: evas-generic-loaders < 1.17.1
>> if I am sure that the version will never go back to 1.17.0, or:
>> Obsoletes: evas-generic-loaders < 1.17.0-100
>> to be safe. (It should catch all current and future EVRs on the branches
>> that still ship the old version (in the worst case, use Release: 99.1,
>> 99.2,
>> etc.), but still allow you to bring back evas-generic-loaders-1.17.0 if
>> needed.)
>
>
> 100 is not enough at all, even . Since efl has higher version, just use
> proper macros.
>
> Obsoletes: evas-generic-loaders <= %{version}-%{release}
This is bad idea though.
>
>
> Obsoletes: evas-generic-loaders%{?_isa} <= %{version}-%{release}
As I wrote week ago to ML, %{?_isa} is virtual provides and it will
never work for Obsoletes.
>
>
>
> --
>
> Yours sincerely,
> Christopher Meng
>
> http://cicku.me
>
> --
> devel mailing list
> devel@lists.fedoraproject.org
> https://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
>
--
-Igor Gnatenko
--
devel mailing list
devel@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
Re: Orphaned: elementry, evas-generic-loaders
On Thursday, September 8, 2016, Kevin Kofler wrote:
> I wrote:
> > <= 1.17.0 should still match that, I think (because there's no -Release
> in
> > there), but still, <= Obsoletes are usually a bad idea (< is safer).
>
> PS: To be clear, I would use either:
> Obsoletes: evas-generic-loaders < 1.17.1
> if I am sure that the version will never go back to 1.17.0, or:
> Obsoletes: evas-generic-loaders < 1.17.0-100
> to be safe. (It should catch all current and future EVRs on the branches
> that still ship the old version (in the worst case, use Release: 99.1,
> 99.2,
> etc.), but still allow you to bring back evas-generic-loaders-1.17.0 if
> needed.)
>
100 is not enough at all, even . Since efl has higher version, just use
proper macros.
Obsoletes: evas-generic-loaders <= %{version}-%{release}
Obsoletes: evas-generic-loaders%{?_isa} <= %{version}-%{release}
--
Yours sincerely,
Christopher Meng
http://cicku.me
--
devel mailing list
devel@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
Re: Orphaned: elementry, evas-generic-loaders
I wrote: > <= 1.17.0 should still match that, I think (because there's no -Release in > there), but still, <= Obsoletes are usually a bad idea (< is safer). PS: To be clear, I would use either: Obsoletes: evas-generic-loaders < 1.17.1 if I am sure that the version will never go back to 1.17.0, or: Obsoletes: evas-generic-loaders < 1.17.0-100 to be safe. (It should catch all current and future EVRs on the branches that still ship the old version (in the worst case, use Release: 99.1, 99.2, etc.), but still allow you to bring back evas-generic-loaders-1.17.0 if needed.) Kevin Kofler -- devel mailing list devel@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
Re: Orphaned: elementry, evas-generic-loaders
Igor Gnatenko wrote:
> +Obsoletes: evas-generic-loaders <= 1.17.0
>
> This is basically wrong because current version is 1.17.0-5%{?dist}.
<= 1.17.0 should still match that, I think (because there's no -Release in
there), but still, <= Obsoletes are usually a bad idea (< is safer).
Kevin Kofler
--
devel mailing list
devel@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
Re: Orphaned: elementry, evas-generic-loaders
+Obsoletes: evas-generic-loaders <= 1.17.0
This is basically wrong because current version is 1.17.0-5%{?dist}.
On Wed, Sep 7, 2016 at 4:09 PM, Tom Callaway wrote:
> On 09/06/2016 03:48 AM, Peter Robinson wrote:
>> On Tue, Sep 6, 2016 at 2:32 AM, Ding Yi Chen wrote:
>>> As elementry and evas-generic-loaders are merged to efl after 1.8.0.
>>>
>>> The elementry and evas-generic-loaders will be orphanded.
>>
>> Please actually actively retire them, rather than just orphaning then,
>> making sure you add the appropriate obsoletes to EFL to ensure a clean
>> upgrade for users.
>
> EFL should have the proper Provides/Obsoletes now. Lemme know if I
> screwed it up. :)
>
> ~tom
>
> ==
> Red Hat
> --
> devel mailing list
> devel@lists.fedoraproject.org
> https://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
--
-Igor Gnatenko
--
devel mailing list
devel@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
Re: Orphaned: elementry, evas-generic-loaders
On 09/06/2016 03:48 AM, Peter Robinson wrote: > On Tue, Sep 6, 2016 at 2:32 AM, Ding Yi Chen wrote: >> As elementry and evas-generic-loaders are merged to efl after 1.8.0. >> >> The elementry and evas-generic-loaders will be orphanded. > > Please actually actively retire them, rather than just orphaning then, > making sure you add the appropriate obsoletes to EFL to ensure a clean > upgrade for users. EFL should have the proper Provides/Obsoletes now. Lemme know if I screwed it up. :) ~tom == Red Hat -- devel mailing list devel@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
Re: Orphaned: elementry, evas-generic-loaders
On Tue, Sep 6, 2016 at 2:32 AM, Ding Yi Chen wrote: > As elementry and evas-generic-loaders are merged to efl after 1.8.0. > > The elementry and evas-generic-loaders will be orphanded. Please actually actively retire them, rather than just orphaning then, making sure you add the appropriate obsoletes to EFL to ensure a clean upgrade for users. The only reason you orphan a package is if it's still relevant but you don't wish to maintain it anymore, in this case the package has been actively replaced so should be actively retired to ensure someone doesn't pick it up and it ends up conflicting with EFL. Peterr -- devel mailing list devel@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
