Re: Packaging Question - Building the Binaries of my package
On Thu, Mar 07, 2019 at 06:49:12PM +, Michael Zhang wrote: > So after tinkering around, I can incorporate the building of the > openliberty.zip into the Travis CI build but I cannot directly add it > into the %install phase of the rpm spec file. Would that be fine? It should be in the %build section, not %install, but that's a detail. Can you elaborate on why you can build it in Travis CI but not in the RPM build itself? That might help us help you better. We have a proposal and some interesting work focused on going from source to RPM in a more automated way — see https://github.com/packit-service/packit. This doesn't solve your problem today, but perhaps could make things easier and better for you in the future. -- Matthew Miller Fedora Project Leader ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Packaging Question - Building the Binaries of my package
Michael Zhang wrote: > Recently, someone advised me that I have to build the binaries from the > source code in the %install phase. That is to say that I have to make it > transparent how the binaries (ex. jar) are built. See https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#prebuilt-binaries-or-libraries -- Rex ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Packaging Question - Building the Binaries of my package
On Thu, 2019-03-07 at 18:49 +, Michael Zhang wrote: > Recently, someone advised me that I have to build the binaries from > the source code in the %install phase. The building should happein the %build phase. The %install phase is where the resulting artifacts are copied into the buildroot. signature.asc Description: This is a digitally signed message part ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Packaging Question - Building the Binaries of my package
On Thu, Mar 07, 2019 at 06:49:12PM +, Michael Zhang wrote: > Recently, someone advised me that I have to build the binaries from the > source code in the %install phase. That is to say that I have to make it > transparent how the binaries (ex. jar) are built. As I understand it, in Debian, developers can build packages on their own systems and upload them. In Fedora, it doesn't work like that -- we have dist-git (https://src.fedoraproject.org/) which holds spec files and patches and references to source code in the look-aside cache. Those source files should be "pure" -- they shouldn't have pre-built binaries. > So after tinkering around, I can incorporate the building of the > openliberty.zip into the Travis CI build but I cannot directly add it > into the %install phase of the rpm spec file. Would that be fine? So, no. :) Travis CI is completely outside of our control, and we don't have a way to verify that the thing built there came from the provided source. And, someone without access to Travis CI wouldn't be able to replicate your build. -- Matthew Miller Fedora Project Leader ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Packaging Question - Building the Binaries of my package
Am 07.03.19 um 19:49 schrieb Michael Zhang: > So after tinkering around, I can incorporate the building of the > openliberty.zip into the Travis CI build but I cannot directly add it into the > %install phase of the rpm spec file. Would that be fine? To the best of my knowledge all building from source has to happen on Fedora infrastructure. (There are - rare - exceptions for bootstrapping compilers but that it likely not the case for OpenLiberty.). Felix ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
