Re: Problems with Automake 1.13 and 1.13.1
>> Kevin Fenzi wrote: > Paolo Bonzini wrote: > >> Of course (BTW the Automake maintainer now confirmed to me privately >> that he'd accept such a patch), though it would probably would make >> sense to put it in Fedora even before 1.13.2. >> >> I'll try to put together the patch tomorrow, unless anyone beats me. > > Any news? > > We really should fix this asap... since lots of people are adding nasty > hacks to work around this, which they will only have to remove after > it's fixed. ;( I have updated automake-1.13.1 with trivial patch re-adding missing macros again - https://bugzilla.redhat.com/show_bug.cgi?id=896442 . HTH. I tried several packages with AM_CONFIG_HEADER issue and it seems to work now again. Any response (negative/positive) is welcomed. Thanks, Pavel -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Problems with Automake 1.13 and 1.13.1
On Thu, Jan 17, 2013 at 12:27:35PM +, Richard W.M. Jones wrote: > On Thu, Jan 17, 2013 at 12:05:03PM +, Richard W.M. Jones wrote: > > Automake 1.13.1 also miscompiles the following: > > > > TESTS = run-bindtests \ > > $(sort \ > > $(patsubst %,%.bc,$(test_progs)) \ > > $(patsubst %,%.opt,$(test_progs))) > > Apparently even jamming them into a single line doesn't work. I WILL > file a bug ... Should appear here at some point: http://lists.gnu.org/archive/html/bug-automake/2013-01/threads.html Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Problems with Automake 1.13 and 1.13.1
On Thu, Jan 17, 2013 at 12:05:03PM +, Richard W.M. Jones wrote: > Automake 1.13.1 also miscompiles the following: > > TESTS = run-bindtests \ > $(sort \ > $(patsubst %,%.bc,$(test_progs)) \ > $(patsubst %,%.opt,$(test_progs))) Apparently even jamming them into a single line doesn't work. I WILL file a bug ... Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Problems with Automake 1.13 and 1.13.1
Automake 1.13.1 also miscompiles the following: TESTS = run-bindtests \ $(sort \ $(patsubst %,%.bc,$(test_progs)) \ $(patsubst %,%.opt,$(test_progs))) which worked in previous versions. It turns it into the following which breaks make because of the unclosed '$(sort' variables: run-bindtests.log: run-bindtests @p='run-bindtests'; \ b='run-bindtests'; \ $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \ --log-file $$b.log --trs-file $$b.trs \ $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) -\ - $(LOG_COMPILE) \ "$$tst" $(AM_TESTS_FD_REDIRECT) $(sort.log: $(sort @p='$(sort'; \ b='$(sort'; \ $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \ --log-file $$b.log --trs-file $$b.trs \ $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) -\ - $(LOG_COMPILE) \ "$$tst" $(AM_TESTS_FD_REDIRECT) $(patsubst.log: $(patsubst @p='$(patsubst'; \ b='$(patsubst'; \ $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \ --log-file $$b.log --trs-file $$b.trs \ $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) -\ - $(LOG_COMPILE) \ "$$tst" $(AM_TESTS_FD_REDIRECT) [etc] If I file a bug about this, is it likely to get attention? It's just as easy for me to change my code so it works. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Problems with Automake 1.13 and 1.13.1
On Mon, 14 Jan 2013 16:57:02 +0100 Paolo Bonzini wrote: > Of course (BTW the Automake maintainer now confirmed to me privately > that he'd accept such a patch), though it would probably would make > sense to put it in Fedora even before 1.13.2. > > I'll try to put together the patch tomorrow, unless anyone beats me. Any news? We really should fix this asap... since lots of people are adding nasty hacks to work around this, which they will only have to remove after it's fixed. ;( kevin signature.asc Description: PGP signature -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Problems with Automake 1.13 and 1.13.1
Paolo Bonzini wrote: > Of course (BTW the Automake maintainer now confirmed to me privately > that he'd accept such a patch), though it would probably would make > sense to put it in Fedora even before 1.13.2. +1 It's time to stop breaking backwards compatibility willy nilly! Kevin Kofler -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Problems with Automake 1.13 and 1.13.1
Il 14/01/2013 16:10, Stephen Gallagher ha scritto: >> Choices are: >> >> 1) introducing automake-1.12: I believe distros should agree on _not_ >> introducing an automake-1.12 or similar package and get the Automake >> maintainer to fix his mess. >> >> 2) fixing all packages individually: sounds like a nightmare. >> From a very small collection of ~20 autoconfiscated packages >> whose "fedpkg prep" output I have ready on my machines, I get 4 hits: >> >> $ grep AM_CONFIG_H */*/configure.ac >> irqbalance/irqbalance-1.0.3/configure.ac:AM_CONFIG_HEADER(config.h) >> lsscsi/lsscsi-0.25/configure.ac:AM_CONFIG_HEADER(config.h) >> sed/sed-4.2.1/configure.ac:AM_CONFIG_HEADER(config.h:config_h.in) >> udisks/udisks-1.0.4/configure.ac:AM_CONFIG_HEADER(config.h) >> >> 3) reintroducing the macros in Fedora's 1.13.1 version. My favorite. > > 4) Submit a patch upstream restoring the macros and ask representatives > from various distros to help champion its inclusion. Of course (BTW the Automake maintainer now confirmed to me privately that he'd accept such a patch), though it would probably would make sense to put it in Fedora even before 1.13.2. I'll try to put together the patch tomorrow, unless anyone beats me. Paolo -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
Re: Problems with Automake 1.13 and 1.13.1
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon 14 Jan 2013 09:52:39 AM EST, Paolo Bonzini wrote: > As of the original 1.13 release two macros where removed from Automake: > AM_PROG_CC_STDC (replaced by AC_PROG_CC as provided by autoconf) and > AM_CONFIG_HEADER (replaced by AC_CONFIG_HEADERS). These were later > reintroduced in 1.13.1, but not with the original behavior---they just > give an error message.The maintainer is new and really didn't > listen to the community telling him not to do this. > > With my (former) Autotools developer hat on, I believe this is a > horrible mistake and it will be a big hassle for everyone involved in > distro packaging. Deprecation is okay, but in this case the macros > were not providing any "feature" and as such were largely unnoticed. > Myself, I had never bothered replacing them in my projects. > > Automake 1.13.1 is already in rawhide and we need to do something about > it before a F19 mass rebuild starts. > > Choices are: > > 1) introducing automake-1.12: I believe distros should agree on _not_ > introducing an automake-1.12 or similar package and get the Automake > maintainer to fix his mess. > > 2) fixing all packages individually: sounds like a nightmare. > From a very small collection of ~20 autoconfiscated packages > whose "fedpkg prep" output I have ready on my machines, I get 4 hits: > > $ grep AM_CONFIG_H */*/configure.ac > irqbalance/irqbalance-1.0.3/configure.ac:AM_CONFIG_HEADER(config.h) > lsscsi/lsscsi-0.25/configure.ac:AM_CONFIG_HEADER(config.h) > sed/sed-4.2.1/configure.ac:AM_CONFIG_HEADER(config.h:config_h.in) > udisks/udisks-1.0.4/configure.ac:AM_CONFIG_HEADER(config.h) > > 3) reintroducing the macros in Fedora's 1.13.1 version. My favorite. > > > Any other opinions? > 4) Submit a patch upstream restoring the macros and ask representatives from various distros to help champion its inclusion. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlD0H+wACgkQeiVVYja6o6OFagCgqrQXGkE+I3pUoi7ScX5N7Yoo yNUAoJyaqLvIFlZtXZgjkavqwrTxPd4V =lm2N -END PGP SIGNATURE- -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
