Re: Self Introduction: Matthew Smith

2017-05-14 Thread Athos Ribeiro
On Sun, May 14, 2017 at 10:47:29AM +0100, Matthew Smith wrote:
> Whoops yeah, I meant to include that. It's bug 1450590.

Here is a link, in case anyone wants to check it out:
https://bugzilla.redhat.com/show_bug.cgi?id=1450590

> I ran the package review tool against my own bug and there are a few problems.
> 
> Should I make the appropriate changes, upload the new spec and SRPM with a
> bumped version number and link to those in a new comment of the bug?

I believe you meant Release number, in this case, yes, you can upload
the new spec and srpm in a new comment with a new release number!

Some people also like to show rpmlint output in the review request.
Since you already ran fedora-review in it, it wouldn't hurt to show that
as well.

-- 
Athos Ribeiro

http://www.ime.usp.br/~athoscr
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: Self Introduction: Matthew Smith

2017-05-14 Thread Zbigniew Jędrzejewski-Szmek
On Sun, May 14, 2017 at 10:47:29AM +0100, Matthew Smith wrote:
> Thanks for the welcome :)
> 
> > It would be nice to provide a link to that review request. In the
> > meanwhile, you probably want to perform some package reviews [1] and
> > provide links for them in your review request.
> 
> Whoops yeah, I meant to include that. It's bug 1450590.
> I ran the package review tool against my own bug and there are a few problems.
> 
> Should I make the appropriate changes, upload the new spec and SRPM with a
> bumped version number and link to those in a new comment of the bug?

Yes.

Zbyszek
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: Self Introduction: Matthew Smith

2017-05-14 Thread Matthew Smith
Thanks for the welcome :)

> It would be nice to provide a link to that review request. In the
> meanwhile, you probably want to perform some package reviews [1] and
> provide links for them in your review request.

Whoops yeah, I meant to include that. It's bug 1450590.
I ran the package review tool against my own bug and there are a few problems.

Should I make the appropriate changes, upload the new spec and SRPM with a
bumped version number and link to those in a new comment of the bug?
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org


Re: Self Introduction: Matthew Smith

2017-05-13 Thread Athos Ribeiro
On Sat, May 13, 2017 at 02:53:12PM +0100, Matthew Smith wrote:
> The Fedora wiki suggests that new people introduce themselves and
> point out their review request on this mailing list, so here I am :)

Welcome :)

> 
> I've attempted to package the Facebook watchman tool, I suppose it's
> just a wrapper around inotify and friends but it ends up being quite
> useful.

It would be nice to provide a link to that review request. In the
meanwhile, you probably want to perform some package reviews [1] and
provide links for them in your review request.

You will need a sponsor and he/she will probably ask you to perform
those reviews. Make sure to let the packagers know you are not a
packager yet so your reviews are not formal ones.

> 
> I don't have much prior experience with open source but learning is
> fun and it all seems so interesting.

Awesome, I hope we can help with that!

[1]
https://fedoraproject.org/wiki/Package_Review_Process
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines

-- 
Athos Ribeiro

http://www.ime.usp.br/~athoscr
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org