Re: Transmission and Deluge sysv to systemd

2011-09-10 Thread Tomasz Torcz
On Wed, Sep 07, 2011 at 08:34:31PM +0530, Rahul Sundaram wrote:
> On 09/07/2011 08:20 PM, Tomasz Torcz wrote:
> > (I would prefer dropping sysconfig file altogether, like Lennart
> > suggested some time ago. And few other. It should work with only
> > ExecStart= and User= in [Service]). 
> 
> I am fine with dropping the sysconfig file

  Patches attached to https://bugzilla.redhat.com/show_bug.cgi?id=659919

-- 
Tomasz TorczTo co nierealne -- tutaj jest normalne.
xmpp: zdzich...@chrome.pl  Ziomale na życie mają tu patenty specjalne.



pgpn1VeobMtZz.pgp
Description: PGP signature
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: Transmission and Deluge sysv to systemd

2011-09-07 Thread Jóhann B. Guðmundsson
On 09/07/2011 03:06 PM, "Jóhann B. Guðmundsson" wrote:
> On 09/07/2011 03:04 PM, Rahul Sundaram wrote:
>> On 09/07/2011 08:20 PM, Tomasz Torcz wrote:
>>> (I would prefer dropping sysconfig file altogether, like Lennart
>>> suggested some time ago. And few other. It should work with only
>>> ExecStart= and User= in [Service]).
>> I am fine with dropping the sysconfig file
>
> It kinda does not server purpose from my point of view having an 
> Environment= that gets called once so final would look something like 
> this...
>
> [Unit]
> Description=Transmission-Daemon A bittorrent Client
> After=syslog.target network.target
>
> [Service]
> User=transmission
> ExecStart=/usr/bin/transmission-daemon -f --blocklist -g 
> /var/lib/transmission/.config/transmission
> StandardError=syslog
>
> [Install]
> WantedBy=multi-user.target
>

Sorry missed the -T when puzzle this together for that post so ExecStart 
should look like...

ExecStart=/usr/bin/transmission-daemon -f -T --blocklist -g 
/var/lib/transmission/.config/transmission

JBG
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: Transmission and Deluge sysv to systemd

2011-09-07 Thread Jóhann B. Guðmundsson
On 09/07/2011 03:04 PM, Rahul Sundaram wrote:
> On 09/07/2011 08:20 PM, Tomasz Torcz wrote:
>> (I would prefer dropping sysconfig file altogether, like Lennart
>> suggested some time ago. And few other. It should work with only
>> ExecStart= and User= in [Service]).
> I am fine with dropping the sysconfig file

It kinda does not server purpose from my point of view having an 
Environment= that gets called once so final would look something like 
this...

[Unit]
Description=Transmission-Daemon A bittorrent Client
After=syslog.target network.target

[Service]
User=transmission
ExecStart=/usr/bin/transmission-daemon -f --blocklist -g 
/var/lib/transmission/.config/transmission
StandardError=syslog

[Install]
WantedBy=multi-user.target

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: Transmission and Deluge sysv to systemd

2011-09-07 Thread Rahul Sundaram
On 09/07/2011 08:20 PM, Tomasz Torcz wrote:
> (I would prefer dropping sysconfig file altogether, like Lennart
> suggested some time ago. And few other. It should work with only
> ExecStart= and User= in [Service]). 

I am fine with dropping the sysconfig file

Rahul
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: Transmission and Deluge sysv to systemd

2011-09-07 Thread Tomasz Torcz
On Wed, Sep 07, 2011 at 02:43:56PM +, "Jóhann B. Guðmundsson" wrote:
>  Here is a service file for transmission
>  https://github.com/eventhorizonpl/systemd-services/blob/master/transmission-daemon.service
> >>>   From the looks of it missing an
> > I uploaded a new version with this command and changes suggested by
> > Tomasz Torcz.
> 
> Your unit file is still incomplete
> 
> 2. If using an EnvironmentFile= we add '-' in front of the path.
> 3. Adding the -f has the daemon stuck in foreground leaving the user 
> waiting for the command to complete

  Note that Type=forking is removed in new version, so it defaults to
Type=simple and DTRT.

  (I would prefer dropping sysconfig file altogether, like Lennart suggested
some time ago. And few other. It should work with only ExecStart= and User=
in [Service]).

-- 
Tomasz TorczThere exists no separation between gods and men:
xmpp: zdzich...@chrome.pl   one blends softly casual into the other.

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: Transmission and Deluge sysv to systemd

2011-09-07 Thread Jóhann B. Guðmundsson
On 09/07/2011 02:29 PM, Michał Piotrowski wrote:
> W dniu 7 września 2011 16:18 użytkownik Michał Piotrowski
>   napisał:
>> 2011/9/7 "Jóhann B. Guðmundsson":
>>> On 09/07/2011 01:55 PM, Michał Piotrowski wrote:
 Yes, conversion into two separate services seems to be the most
 appropriate solution.

 Here is a service file for transmission
 https://github.com/eventhorizonpl/systemd-services/blob/master/transmission-daemon.service
>>>   From the looks of it missing an
>>>
>>> PIDFile=/run/transmission-daemon.pid
>> I added this command to service and pid file isn't created. I'm using F15.
>>
> I uploaded a new version with this command and changes suggested by
> Tomasz Torcz.

Your unit file is still incomplete

1. there is no point in sourcing the sysconfig file if you are using an 
Environment variable
2. If using an EnvironmentFile= we add '-' in front of the path.
3. Adding the -f has the daemon stuck in foreground leaving the user 
waiting for the command to complete
4. You are calling the Environment you set wrong which results in..
  22197 /usr/bin/transmission-daemon -f -T # missing --blocklist -g 
/var/lib/transmission/.config/transmission
5. the reason there exist no pid file is because you omitted the section 
that creates it in the legacy sysv init script as in ""pidof -o %PPID -x 
$NAME > $DAEMON_PIDFILE"

JBG

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: Transmission and Deluge sysv to systemd

2011-09-07 Thread Michał Piotrowski
W dniu 7 września 2011 16:18 użytkownik Michał Piotrowski
 napisał:
> 2011/9/7 "Jóhann B. Guðmundsson" :
>> On 09/07/2011 01:55 PM, Michał Piotrowski wrote:
>>> Yes, conversion into two separate services seems to be the most
>>> appropriate solution.
>>>
>>> Here is a service file for transmission
>>> https://github.com/eventhorizonpl/systemd-services/blob/master/transmission-daemon.service
>>
>>  From the looks of it missing an
>>
>> PIDFile=/run/transmission-daemon.pid
>
> I added this command to service and pid file isn't created. I'm using F15.
>

I uploaded a new version with this command and changes suggested by
Tomasz Torcz.


-- 
Best regards,
Michal

http://eventhorizon.pl/
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: Transmission and Deluge sysv to systemd

2011-09-07 Thread Michał Piotrowski
2011/9/7 "Jóhann B. Guðmundsson" :
> On 09/07/2011 01:55 PM, Michał Piotrowski wrote:
>> Yes, conversion into two separate services seems to be the most
>> appropriate solution.
>>
>> Here is a service file for transmission
>> https://github.com/eventhorizonpl/systemd-services/blob/master/transmission-daemon.service
>
>  From the looks of it missing an
>
> PIDFile=/run/transmission-daemon.pid

I added this command to service and pid file isn't created. I'm using F15.

>
> JBG
> --
> devel mailing list
> devel@lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/devel



-- 
Best regards,
Michal

http://eventhorizon.pl/
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: Transmission and Deluge sysv to systemd

2011-09-07 Thread Jóhann B. Guðmundsson
On 09/07/2011 01:55 PM, Michał Piotrowski wrote:
> Yes, conversion into two separate services seems to be the most
> appropriate solution.
>
> Here is a service file for transmission
> https://github.com/eventhorizonpl/systemd-services/blob/master/transmission-daemon.service

 From the looks of it missing an

PIDFile=/run/transmission-daemon.pid

JBG
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: Transmission and Deluge sysv to systemd

2011-09-07 Thread Michał Piotrowski
2011/9/7 "Jóhann B. Guðmundsson" :
> On 09/07/2011 01:12 PM, Rahul Sundaram wrote:
>> Hi
>>
>> These two torrent packages includes init scripts for the daemons and
>> need to be converted to systemd.  I have been meaning to convert but
>> could use some help.  If someone can take a look a look and file a
>> patch,  I will be happy to role them in.  Thanks
>>
>> Rahul
>
> Hum I thought a had converted torrent already anyway deluge into two
> seperated daemons from a quick look of it the service and the "web.service"

Yes, conversion into two separate services seems to be the most
appropriate solution.

Here is a service file for transmission
https://github.com/eventhorizonpl/systemd-services/blob/master/transmission-daemon.service

> --
> devel mailing list
> devel@lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/devel
>



-- 
Best regards,
Michal

http://eventhorizon.pl/
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: Transmission and Deluge sysv to systemd

2011-09-07 Thread Jóhann B. Guðmundsson
On 09/07/2011 01:12 PM, Rahul Sundaram wrote:
> Hi
>
> These two torrent packages includes init scripts for the daemons and
> need to be converted to systemd.  I have been meaning to convert but
> could use some help.  If someone can take a look a look and file a
> patch,  I will be happy to role them in.  Thanks
>
> Rahul

Hum I thought a had converted torrent already anyway deluge into two 
seperated daemons from a quick look of it the service and the "web.service"
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: Transmission and Deluge sysv to systemd

2011-09-07 Thread Michał Piotrowski
Hi,

2011/9/7 Rahul Sundaram :
> Hi
>
> These two torrent packages includes init scripts for the daemons and
> need to be converted to systemd.  I have been meaning to convert but
> could use some help.  If someone can take a look a look and file a
> patch,  I will be happy to role them in.  Thanks

I don't use it, but I can take a look.

>
> Rahul
> --
> devel mailing list
> devel@lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/devel
>



-- 
Best regards,
Michal

http://eventhorizon.pl/
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel