Re: fedora-review fails with "warning: line 16: Possible unexpanded macro in: Requires .."
On Fri, Aug 28, 2020 at 01:47:14PM -, Martin Gansser wrote: > when I want to do a review with: fedora-review -m fedora-rawhide-x86_64 -b > 1873407 > i get this error message: > > warning: line 16: Possible unexpanded macro in: Requires: > vdr(abi)(x86-64) = %{vdr_apiversion} It means the %{vdr_apiversion} macro is not defined > Building target platforms: x86_64 > Building for target x86_64 > setting SOURCE_DATE_EPOCH=1598313600 > Wrote: /builddir/build/SRPMS/vdr-skinelchihd-0.5.0-1.fc34.src.rpm when building the source package. > How can i solve this ? > Requires tags are evaluated when building a source package, although they are not used at this stage in any way. This is a deficiency in a rpmbuild tool. Until (if ever) it is fixed in rpmbuild, you need to work around it in the spec file. First, the macro is not available in a minimal build root used for build source packages. Thus you need to check its definess and use it only if it is defined: Requires: vdr(abi)(%{_isa}) = %{?vdr_apiversion:%{vdr_apiversion}} But that's not all. The Requires tag value must be a valid dependency value after the expansion. In that form it would yield an invalid dependency value "vdr(abi)(x86-64) = ". Thus you need either to supply a dummy value after the equal sign if the macro is not defined, or better just do not generate the dependency at all: %if %{defined vdr_apiversion} Requires: vdr(abi)(%{_isa}) = %{vdr_apiversion} %endif -- Petr signature.asc Description: PGP signature ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: fedora-review fails with "warning: line 16: Possible unexpanded macro in: Requires .."
On Fri, Aug 28, 2020 at 10:44 PM Sérgio Basto wrote: > > On Fri, 2020-08-28 at 15:03 +, Martin Gansser wrote: > > ok, I'll try again tomorrow or the day after tomorrow when it's > > available in Rawhide. > > you may build it with koji package if you add enabled=1 in [local] > configuration at /etc/mock/templates/fedora-rawhide.tpl [1] No need to modify system config files: fedora-review -m fedora-rawhide-x86_64 -o "--enablerepo local" -b 1234567 Does the same thing :) Fabio ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: fedora-review fails with "warning: line 16: Possible unexpanded macro in: Requires .."
On Fri, 2020-08-28 at 15:03 +, Martin Gansser wrote: > ok, I'll try again tomorrow or the day after tomorrow when it's > available in Rawhide. you may build it with koji package if you add enabled=1 in [local] configuration at /etc/mock/templates/fedora-rawhide.tpl [1] [1] [local] name=local baseurl=https://kojipkgs.fedoraproject.org/repos/rawhide/latest/$basearch/ cost=2000 enabled=1 skip_if_unavailable=False > Regards > Martin > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: > https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org -- Sérgio M. B. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: fedora-review fails with "warning: line 16: Possible unexpanded macro in: Requires .."
On Fri, 2020-08-28 at 16:41 +0200, Tomasz Torcz wrote: > On Fri, Aug 28, 2020 at 02:30:20PM -, Martin Gansser wrote: > > the macro "%{vdr_apiversion}" is included in the package vdr-devel > > > > rpm -qf /usr/lib/rpm/macros.d/macros.vdr > > vdr-devel-2.4.4-1.fc32.x86_64 > > There is no such version in Fedora (is this a local build)? > Latest in F32 is vdr-2.4.1-5.fc32, and the spec has BR >= 2.4.3. > > For Rawhide, you just built vdr-2.4.4-1.fc34 yesterday – it may not > be > available in Rawhide compose yet. yes, I see in root.log DEBUG util.py:623: Last metadata expiration check: 0:00:02 ago on Fri Aug 28 19:11:55 2020. DEBUG util.py:621: No matching package to install: 'vdr-devel >= 2.4.3' DEBUG util.py:621: Not all dependencies satisfied DEBUG util.py:621: Error: Some packages could not be found. -- Sérgio M. B. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: fedora-review fails with "warning: line 16: Possible unexpanded macro in: Requires .."
ok, I'll try again tomorrow or the day after tomorrow when it's available in Rawhide. Regards Martin ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: fedora-review fails with "warning: line 16: Possible unexpanded macro in: Requires .."
On Fri, Aug 28, 2020 at 02:30:20PM -, Martin Gansser wrote: > the macro "%{vdr_apiversion}" is included in the package vdr-devel > > rpm -qf /usr/lib/rpm/macros.d/macros.vdr > vdr-devel-2.4.4-1.fc32.x86_64 There is no such version in Fedora (is this a local build)? Latest in F32 is vdr-2.4.1-5.fc32, and the spec has BR >= 2.4.3. For Rawhide, you just built vdr-2.4.4-1.fc34 yesterday – it may not be available in Rawhide compose yet. -- Tomasz TorczTo co nierealne – tutaj jest normalne. to...@pipebreaker.pl Ziomale na życie mają tu patenty specjalne. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: fedora-review fails with "warning: line 16: Possible unexpanded macro in: Requires .."
the macro "%{vdr_apiversion}" is included in the package vdr-devel rpm -qf /usr/lib/rpm/macros.d/macros.vdr vdr-devel-2.4.4-1.fc32.x86_64 ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org