Re: Request to review a MinGW subpackges in libsodium
On Mon, Aug 21, 2023 at 03:17:21PM +0200, Marián Konček wrote: > I opened a PR adding mingw subpackages to libsodium according to my best > knowledge (which is not too large related to mingw packaging): > https://src.fedoraproject.org/rpms/libsodium/pull-request/3 > > I talked with the maintainer and it could be accepted, but I would like > someone more experienced from https://fedoraproject.org/wiki/MinGW to take a > look and tell me if i missed some simplifications. The main item I see missing is conditionalization of the sub-packages, which is important for anyone wanting to rebuild the same spec on RHEL/EPEL where most of mingw is not present. https://docs.fedoraproject.org/en-US/packaging-guidelines/MinGW/#_disabling_mingw_packages With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :| ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: Request to review a MinGW subpackges in libsodium
Hi
Please check out [1] for a sample unified native/mingw spec with
autotools build. Specific remarks:
- Add %{?mingw_debug_package}
- Explicit BR on mingw-binutils probably unnecessary
- Try %global _configure ../configure instead of cloning the entire
source tree
- Add %mingw_debug_install_post
Sandro
[1]
https://src.fedoraproject.org/rpms/gtkspell3/blob/rawhide/f/gtkspell3.spec
On 21.08.23 15:17, Marián Konček wrote:
I opened a PR adding mingw subpackages to libsodium according to my
best knowledge (which is not too large related to mingw packaging):
https://src.fedoraproject.org/rpms/libsodium/pull-request/3
I talked with the maintainer and it could be accepted, but I would
like someone more experienced from
https://fedoraproject.org/wiki/MinGW to take a look and tell me if i
missed some simplifications.
Thanks.
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
Request to review a MinGW subpackges in libsodium
I opened a PR adding mingw subpackages to libsodium according to my best knowledge (which is not too large related to mingw packaging): https://src.fedoraproject.org/rpms/libsodium/pull-request/3 I talked with the maintainer and it could be accepted, but I would like someone more experienced from https://fedoraproject.org/wiki/MinGW to take a look and tell me if i missed some simplifications. Thanks. -- Marián Konček ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
