Re: Update gating test is "failed" with no useful information
On Tue, Mar 02, 2021 at 08:26:31AM -0800, Adam Williamson wrote: On Tue, 2021-03-02 at 13:59 +, Richard W.M. Jones wrote: Other tests are kind of random. I mean, what does this mean? https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-pipeline/job/master/12861/testReport/(root)/tests/ Stuff like: 1) File /usr/lib64/ocaml/cmdliner/cmdliner.a changed content on x86_64. Amazing! The package was rebuilt, what did you expect? The test description does explain this to some extent: "Report changed files from the before build to the after build. Certain file changes will raise additional warnings if the concern is more critical than just reporting changes (e.g., a suspected security impact)." I suspect the types of files that changed here are flagged as being "critical" on the basis that they are effectively ABI, so this is telling you more or less the same thing as the abidiff failure: the update changes the ABI. Note that many other files in the package will have changed, but they're not *all* shown in the test results, just these specific ones. The question here is more "should ABI change-type issues be counted as failures on Rawhide 'updates'?", I think. No, it shouldn't count. What I did yesterday is add a 'rawhide' profile to rpminspect-data-fedora: https://github.com/rpminspect/rpminspect-data-fedora/blob/master/profiles/fedora/rawhide.yaml This will be used by the rpminspect runner for all rawhide builds. It just turns off a lot of inspections that are not useful for active and ongoing development. Some context: what rpminspect does is largely based on what the internal rpmdiff tool did, unraveling that, and then building new inspections in rpminspect. About half of the rpmdiff checks were tied to stuff like this where the assumption is we are comparing builds in a maintenance release of RHEL. That is, we don't want any unexpected surprises in the packages. A file changing that we didn't want to change should raise some sort of alarm. Those checks have been implemented in rpminspect and broken out in to more logical sections, but rpminspect also has the ability to turn off entire inspections you don't want or need to run. For information on what can go in the rpminspect configuration file, see the generic template: https://github.com/rpminspect/rpminspect/blob/master/data/generic.yaml When rpminspect runs for Fedora builds it will first read in /usr/share/rpminspect/fedora.yaml, then if a profile is specified it reads that in and overlays that on the current configuration, and lastly if you have a local 'rpminspect.yaml' file in your dist-git branch then it reads that in last for any final overlays. To see the default Fedora config file: https://github.com/rpminspect/rpminspect-data-fedora/blob/master/fedora.yaml I keep promising a man page for the rpminspect.yaml file and I promise I will do it soon, I just haven't gotten around to it. The generic template fills the need for config file docs for the moment. Please let me know if you have any questions. Thanks, -- David Cantrell Red Hat, Inc. | Boston, MA | EST5EDT ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: Update gating test is "failed" with no useful information
On Tue, Mar 02, 2021 at 08:26:31AM -0800, Adam Williamson wrote: > On Tue, 2021-03-02 at 13:59 +, Richard W.M. Jones wrote: > > > > Other tests are kind of random. I mean, what does this mean? > > > > https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-pipeline/job/master/12861/testReport/(root)/tests/ > > > > Stuff like: > > > > 1) File /usr/lib64/ocaml/cmdliner/cmdliner.a changed content on x86_64. > > > > Amazing! The package was rebuilt, what did you expect? > > The test description does explain this to some extent: > "Report changed files from the before build to the after build. > Certain file changes will raise additional warnings if the concern is > more critical than just reporting changes (e.g., a suspected security > impact)." > I suspect the types of files that changed here are flagged as being > "critical" on the basis that they are effectively ABI, so this is > telling you more or less the same thing as the abidiff failure: the > update changes the ABI. Note that many other files in the package will > have changed, but they're not *all* shown in the test results, just > these specific ones. > > The question here is more "should ABI change-type issues be counted as > failures on Rawhide 'updates'?", I think. For OCaml packages this isn't especially relevant. The *.a files are just a convenient format to ship compiled OCaml code, which won't make much sense to abidiff-type tooling. $ nm /usr/lib64/ocaml/cmdliner/cmdliner.a | head -20 cmdliner_trie.o: 0010 r caml_absf_mask U caml_alloc1 U caml_call_gc U caml_c_call 0170 D camlCmdliner_trie 0228 D camlCmdliner_trie__1 0158 d camlCmdliner_trie__10 0138 d camlCmdliner_trie__11 0120 d camlCmdliner_trie__12 0100 d camlCmdliner_trie__13 00e0 d camlCmdliner_trie__14 00c0 d camlCmdliner_trie__15 00a0 d camlCmdliner_trie__16 0208 d camlCmdliner_trie__2 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: Update gating test is "failed" with no useful information
> Hi Richard, > > > This is https://pagure.io/fedora-ci/general/issue/161, only know workaround > is to rerun > the test (by logging in to the Jenkins instance and hitting the Rebuild > button). Not yet > sure why this is happening, I will try to concentrate on it in next weeks, it > is quite > random. > > > I believe you can now configure rpminspect do not run tests which are not > interesting to > you. I am looking for a documentation how to do that. So announcement for this feature is just coming according to #fedora-ci IRC channel > > Best regards, > /M > > > > > Rich. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: Update gating test is "failed" with no useful information
On Tue, 2021-03-02 at 13:59 +, Richard W.M. Jones wrote: > > Other tests are kind of random. I mean, what does this mean? > > https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-pipeline/job/master/12861/testReport/(root)/tests/ > > Stuff like: > > 1) File /usr/lib64/ocaml/cmdliner/cmdliner.a changed content on x86_64. > > Amazing! The package was rebuilt, what did you expect? The test description does explain this to some extent: "Report changed files from the before build to the after build. Certain file changes will raise additional warnings if the concern is more critical than just reporting changes (e.g., a suspected security impact)." I suspect the types of files that changed here are flagged as being "critical" on the basis that they are effectively ABI, so this is telling you more or less the same thing as the abidiff failure: the update changes the ABI. Note that many other files in the package will have changed, but they're not *all* shown in the test results, just these specific ones. The question here is more "should ABI change-type issues be counted as failures on Rawhide 'updates'?", I think. -- Adam Williamson Fedora QA IRC: adamw | Twitter: adamw_ha https://www.happyassassin.net ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: Update gating test is "failed" with no useful information
On Tue, Mar 02, 2021 at 03:59:55PM +0100, Fabio Valentini wrote: > On Tue, Mar 2, 2021 at 3:00 PM Richard W.M. Jones wrote: > > > > https://bodhi.fedoraproject.org/updates/FEDORA-2021-667db9b546 > > > > Some tests have failed, but as usual there seems to be no easy way to > > work out why. For example the hivex test has this useless console > > output: > > > > > > https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-pipeline/job/master/12835/console > > > > The closest thing to an error message in all that seems to be: > > > > ERROR: There was an infrastructure failure. > > > > The virt-top test has failed with "ABSENT" and no further information > > at all. (I actually ran the virt-top test locally and it's fine.) > > > > Other tests are kind of random. I mean, what does this mean? > > > > https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-pipeline/job/master/12861/testReport/(root)/tests/ > > > > Stuff like: > > > > 1) File /usr/lib64/ocaml/cmdliner/cmdliner.a changed content on x86_64. > > > > Amazing! The package was rebuilt, what did you expect? > > > > Ideally I'd like to skip all this and tell it to put the update out. > > If you think the test failures are all due to infrastructure problems > or false positives, you should be able to waive the gating tests: > > $ bodhi updates waive FEDORA-2021-667db9b546 "failed gating tests are > false positives" I did it and the update now seems to be heading for Rawhide, thanks. Could this useful command/information be included on the bodhi page itself? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/ ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: Update gating test is "failed" with no useful information
Hi Richard, > https://bodhi.fedoraproject.org/updates/FEDORA-2021-667db9b546 > > Some tests have failed, but as usual there seems to be no easy way to > work out why. For example the hivex test has this useless console > output: > > > https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-... > > The closest thing to an error message in all that seems to be: > > ERROR: There was an infrastructure failure. This is https://pagure.io/fedora-ci/general/issue/161, only know workaround is to rerun the test (by logging in to the Jenkins instance and hitting the Rebuild button). Not yet sure why this is happening, I will try to concentrate on it in next weeks, it is quite random. > > The virt-top test has failed with "ABSENT" and no further information > at all. (I actually ran the virt-top test locally and it's fine.) > > Other tests are kind of random. I mean, what does this mean? > > https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-... > > Stuff like: > > 1) File /usr/lib64/ocaml/cmdliner/cmdliner.a changed content on x86_64. > > Amazing! The package was rebuilt, what did you expect? > > Ideally I'd like to skip all this and tell it to put the update out. I believe you can now configure rpminspect do not run tests which are not interesting to you. I am looking for a documentation how to do that. Best regards, /M > > Rich. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: Update gating test is "failed" with no useful information
On Tue, Mar 2, 2021 at 3:00 PM Richard W.M. Jones wrote: > > https://bodhi.fedoraproject.org/updates/FEDORA-2021-667db9b546 > > Some tests have failed, but as usual there seems to be no easy way to > work out why. For example the hivex test has this useless console > output: > > > https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-pipeline/job/master/12835/console > > The closest thing to an error message in all that seems to be: > > ERROR: There was an infrastructure failure. > > The virt-top test has failed with "ABSENT" and no further information > at all. (I actually ran the virt-top test locally and it's fine.) > > Other tests are kind of random. I mean, what does this mean? > > https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-pipeline/job/master/12861/testReport/(root)/tests/ > > Stuff like: > > 1) File /usr/lib64/ocaml/cmdliner/cmdliner.a changed content on x86_64. > > Amazing! The package was rebuilt, what did you expect? > > Ideally I'd like to skip all this and tell it to put the update out. If you think the test failures are all due to infrastructure problems or false positives, you should be able to waive the gating tests: $ bodhi updates waive FEDORA-2021-667db9b546 "failed gating tests are false positives" or something like that. Fabio ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Update gating test is "failed" with no useful information
https://bodhi.fedoraproject.org/updates/FEDORA-2021-667db9b546 Some tests have failed, but as usual there seems to be no easy way to work out why. For example the hivex test has this useless console output: https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-pipeline/job/master/12835/console The closest thing to an error message in all that seems to be: ERROR: There was an infrastructure failure. The virt-top test has failed with "ABSENT" and no further information at all. (I actually ran the virt-top test locally and it's fine.) Other tests are kind of random. I mean, what does this mean? https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-pipeline/job/master/12861/testReport/(root)/tests/ Stuff like: 1) File /usr/lib64/ocaml/cmdliner/cmdliner.a changed content on x86_64. Amazing! The package was rebuilt, what did you expect? Ideally I'd like to skip all this and tell it to put the update out. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
