Re: What if you only want to package part of upstream?
Thanks for all the input! I went with the popular option of calling it qrcode-generator and inviting comaintainers to add subpackages in the future if they desire: https://bugzilla.redhat.com/show_bug.cgi?id=1422344 signature.asc Description: This is a digitally signed message part ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Re: What if you only want to package part of upstream?
On Tue, Feb 14, 2017 at 11:19:11AM +, Richard W.M. Jones wrote: > (3) Let others create subpackages for the other bindings in future on > an as-needed basis (and make them become co-maintainers and do the > work :-) This seems like the right approach to me too. -- Matthew Miller Fedora Project Leader ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Re: What if you only want to package part of upstream?
Randy Barlow wrote: > In working on packaging Ampache, I found a dependency that has a > bundled version of this file: > > https://github.com/kazuhikoarase/qrcode-generator/blob/master/js/qrcode.js ... > Is it ok to just name my source package js-qrcode-generator and package > just the js bits of it, or do I need to name my package qrcode- > generator? If the latter, would I be compelled to package all those > language implementations as subpackages, or could I package just the JS > one for now and wait to see if anyone files an issue to request the > other languages in the future? I'd suggest a variant of the last option. Keep the source package as canonical upstream name (qrcode-generator), and just generate a subpkg of the bits you want (js-qrcode-generator) for now. That leaves the possibility open to include more later as needed. -- Rex ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Re: What if you only want to package part of upstream?
On Mon, Feb 13, 2017 at 08:46:19PM -0500, Randy Barlow wrote: > Is it ok to just name my source package js-qrcode-generator and package > just the js bits of it, or do I need to name my package qrcode- > generator? If the latter, would I be compelled to package all those > language implementations as subpackages, or could I package just the JS > one for now and wait to see if anyone files an issue to request the > other languages in the future? I'm not very familiar with the packaging > guidelines for all of those languages, so it would be tricky to get it > right for all of them. I'm something of an expert in packaging one source package -> multiple language bindings because of this and a few other packages: http://pkgs.fedoraproject.org/cgit/rpms/libguestfs.git/tree/ It's a pain! I would say in your case: (1) Give the source code package a generic name (qrcode-generator). (2) Package up the javascript bindings. (3) Let others create subpackages for the other bindings in future on an as-needed basis (and make them become co-maintainers and do the work :-) You ought to give the Javascript output subpackage a different name from the source package, to facilitate the other subpackages being created in future. Otherwise you'd end up needing to rename the JS subpackage in future which can be a pain. It's possible with recent rpmbuild to have the output name be completely different from the source name. For an example of this, see: http://pkgs.fedoraproject.org/cgit/rpms/xorg-x11-server.git/tree/xorg-x11-server.spec (note there is no %files section at all) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/ ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Re: What if you only want to package part of upstream?
On Mon, Feb 13, 2017 at 08:46:19PM -0500, Randy Barlow wrote: > Hello! > > In working on packaging Ampache, I found a dependency that has a > bundled version of this file: > > https://github.com/kazuhikoarase/qrcode-generator/blob/master/js/qrcode.js > > I started working on doing the right thing and packaging that file > separately, but it seems that the repository also has qrcode > implementations for ActionScript, Java, PHP, and more. That's a lot of > work for me just to get that one js file packaged, and I don't have > anything that depends on those other implementations at this time. > > Is it ok to just name my source package js-qrcode-generator and package > just the js bits of it, or do I need to name my package qrcode- > generator? If the latter, would I be compelled to package all those > language implementations as subpackages, or could I package just the JS > one for now and wait to see if anyone files an issue to request the > other languages in the future? I'm not very familiar with the packaging > guidelines for all of those languages, so it would be tricky to get it > right for all of them. I think you should name the package qrcode-generator, and build a js-qrcode-generator binary package from it. I don't think there's any rule that binding for all languages must be build. (One example I remember is libsbml, which has C, R, C#, octave, perl, python 2, 3, and ruby bindings. In the initial review, only a subset built correctly, and the other ones were added later on.) Zbyszek ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
What if you only want to package part of upstream?
Hello! In working on packaging Ampache, I found a dependency that has a bundled version of this file: https://github.com/kazuhikoarase/qrcode-generator/blob/master/js/qrcode.js I started working on doing the right thing and packaging that file separately, but it seems that the repository also has qrcode implementations for ActionScript, Java, PHP, and more. That's a lot of work for me just to get that one js file packaged, and I don't have anything that depends on those other implementations at this time. Is it ok to just name my source package js-qrcode-generator and package just the js bits of it, or do I need to name my package qrcode- generator? If the latter, would I be compelled to package all those language implementations as subpackages, or could I package just the JS one for now and wait to see if anyone files an issue to request the other languages in the future? I'm not very familiar with the packaging guidelines for all of those languages, so it would be tricky to get it right for all of them. signature.asc Description: This is a digitally signed message part ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
