Re: fedpkg / koji error

[Jesse Keating]

On 11/06/2012 11:34 AM, Tom Callaway wrote:

Jesse, please review and apply these upstream and make a new update.

Fixed comments. Other patch
(fedpkg-1.10-use-nil-to-unset-distunset.patch) is fine as is.


Tweaked and pushed.  Building an update now.

--
Jesse Keating
Fedora -- Freedom² is a feature!
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg / koji error

[Tom Callaway]

On 11/06/2012 02:00 PM, Tom Callaway wrote:

> Okay, so here are two patches:
> 
> fedpkg-1.10-use-nil-to-unset-distunset.patch (this one uses %nil instead
> of 0 in my previous fix)
> fedpkg-1.10-unset-runtime-disttag.patch (this patch detects the runtime
> environment and unsets the version specific tag (e.g. %{fc17} or
> %{el6}), except in the case where the runtime env matches the build
> target exactly)
> 
> Jesse, please review and apply these upstream and make a new update.

Fixed comments. Other patch
(fedpkg-1.10-use-nil-to-unset-distunset.patch) is fine as is.

~tom

==
Fedora Project
diff -up fedpkg-1.10/src/pyrpkg/fedpkg/__init__.py.unset-runtime-disttag fedpkg-1.10/src/pyrpkg/fedpkg/__init__.py
--- fedpkg-1.10/src/pyrpkg/fedpkg/__init__.py.unset-runtime-disttag	2012-11-06 13:46:22.767693545 -0500
+++ fedpkg-1.10/src/pyrpkg/fedpkg/__init__.py	2012-11-06 13:54:08.767907308 -0500
@@ -17,6 +17,7 @@ import git
 import re
 import pycurl
 import fedora_cert
+import platform
 
 # This check (decorator) can go away after a few months
 def _check_newstyle_branches(func):
@@ -153,6 +154,9 @@ class Commands(pyrpkg.Commands):
 def load_rpmdefines(self):
 """Populate rpmdefines based on branch data"""
 
+# Determine runtime environment
+self._runtime_disttag = self._determine_runtime_env()
+
 # We only match the top level branch name exactly.
 # Anything else is too dangerous and --dist should be used
 # This regex works until after Fedora 99.
@@ -199,6 +203,11 @@ class Commands(pyrpkg.Commands):
 "--define '%s %s'" % (self._distvar, self._distval),
 "--define '%s %%{nil}'" % self._distunset,
 "--define '%s 1'" % self.dist]
+if self._runtime_disttag:
+if self.dist != self._runtime_disttag:
+# This means that the runtime is known, and is different from the target,
+# so we need to unset the _runtime_disttag 
+self._rpmdefines.append("--define '%s %%{nil}'" % self._runtime_disttag)
 
 def load_target(self):
 """This creates the target attribute based on branch merge"""
@@ -313,6 +322,33 @@ class Commands(pyrpkg.Commands):
 desttag = rawhidetarget['dest_tag_name']
 return desttag.replace('f', '')
 
+def _determine_runtime_env(self):
+"""Need to know what the runtime env is, so we can unset anything conflicting"""
+try:
+   mydist = platform.linux_distribution()
+except:
+   # This is marked as eventually being deprecated.
+   try:
+  mydist = platform.dist()
+   except:
+  runtime_os = 'unknown'
+  runtime_version = '0'
+
+if mydist:
+   runtime_os = mydist[0]
+   runtime_version = mydist[1]
+else:
+   runtime_os = 'unknown'
+   runtime_version = '0'
+
+if runtime_os == 'redhat' or runtime_os == 'centos':
+return 'el%s' % runtime_version
+if runtime_os == 'Fedora':
+return 'fc%s' % runtime_version
+
+# fall through, return None
+return None
+
 def new_ticket(self, passwd, desc, build=None):
 """Open a new ticket on Rel-Eng trac instance.
 
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg / koji error

[Tom Callaway]

On 10/23/2012 04:54 PM, Thorsten Leemhuis wrote:
> Lo!
> 
> On 23.10.2012 17:23, Tom Callaway wrote:
>> On 10/22/2012 10:37 PM, Ralf Corsepius wrote:
>>> On 10/22/2012 10:43 PM, Tom Callaway wrote:
 On 10/22/2012 12:09 PM, Ralf Corsepius wrote:
>> There is currently no way to "undefine" a macro at the rpm
>> commandline,
>
> rpmbuild --define " %{nil}" ?

 Huh, I swear I knew that once. :) Attached is a patch to use the %{nil}
 behavior instead of setting the unused dist macro to 0. I smoke tested
 and confirmed that the %{rhel} macro is unset on Fedora with this patch
 applied.
>>>
>>> I haven't tried your patch, but don't you have to unset/define %{nil}
>>> all build-host related rpm macros from /etc/rpm/macros.dist?
>>>
>>> It's at least what I can not avoid doing in my before-mentioned
>>> build-scripts.
>>>
>>> I.e. when running my script on Fedora 17, I invoke rpmbuild this way:
>>>
>>> rpmbuild ... \
>>>   --define "fedora %{nil}" --define "fc17 %{nil}"
>>>   --define "dist .el6" --define "rhel 6"  --define "el6 1"
>>>   ...
>>>
>>> Otherwise constructs such as
>>> %{?fc17:}
>>> %{?el6:}
>>> also won't work correctly in rpm.specs.
>>>
>>> IIUC, fedpkg with your patch sets %dist and unsets %fedora, but it
>>> doesn't seem to catch "fc17".
>>
>> Yeah, thats a valid corner case. It wasn't in the original issue, so I
>> didn't think about it. I'll work on a fix that covers that as well.
> 
> Spot: Thanks for working on this and finding a solution that removes the
> inconsistency I was running into with someone else package.

Okay, so here are two patches:

fedpkg-1.10-use-nil-to-unset-distunset.patch (this one uses %nil instead
of 0 in my previous fix)
fedpkg-1.10-unset-runtime-disttag.patch (this patch detects the runtime
environment and unsets the version specific tag (e.g. %{fc17} or
%{el6}), except in the case where the runtime env matches the build
target exactly)

Jesse, please review and apply these upstream and make a new update.

~tom

==
Fedora Project
diff -up fedpkg-1.10/src/pyrpkg/fedpkg/__init__.py.unset-runtime-disttag fedpkg-1.10/src/pyrpkg/fedpkg/__init__.py
--- fedpkg-1.10/src/pyrpkg/fedpkg/__init__.py.unset-runtime-disttag	2012-11-06 13:46:22.767693545 -0500
+++ fedpkg-1.10/src/pyrpkg/fedpkg/__init__.py	2012-11-06 13:54:08.767907308 -0500
@@ -17,6 +17,7 @@ import git
 import re
 import pycurl
 import fedora_cert
+import platform
 
 # This check (decorator) can go away after a few months
 def _check_newstyle_branches(func):
@@ -153,6 +154,9 @@ class Commands(pyrpkg.Commands):
 def load_rpmdefines(self):
 """Populate rpmdefines based on branch data"""
 
+""" Determine runtime environment"""
+self._runtime_disttag = self._determine_runtime_env()
+
 # We only match the top level branch name exactly.
 # Anything else is too dangerous and --dist should be used
 # This regex works until after Fedora 99.
@@ -199,6 +203,11 @@ class Commands(pyrpkg.Commands):
 "--define '%s %s'" % (self._distvar, self._distval),
 "--define '%s %%{nil}'" % self._distunset,
 "--define '%s 1'" % self.dist]
+if self._runtime_disttag:
+if self.dist != self._runtime_disttag:
+""" This means that the runtime is known, and is different from the target, """ 
+""" so we need to unset the _runtime_disttag """ 
+self._rpmdefines.append("--define '%s %%{nil}'" % self._runtime_disttag)
 
 def load_target(self):
 """This creates the target attribute based on branch merge"""
@@ -313,6 +322,33 @@ class Commands(pyrpkg.Commands):
 desttag = rawhidetarget['dest_tag_name']
 return desttag.replace('f', '')
 
+def _determine_runtime_env(self):
+"""Need to know what the runtime env is, so we can unset anything conflicting"""
+try:
+   mydist = platform.linux_distribution()
+except:
+   """ This is marked as eventually being deprecated. """
+   try:
+  mydist = platform.dist()
+   except:
+  runtime_os = 'unknown'
+  runtime_version = '0'
+
+if mydist:
+   runtime_os = mydist[0]
+   runtime_version = mydist[1]
+else:
+   runtime_os = 'unknown'
+   runtime_version = '0'
+
+if runtime_os == 'redhat' or runtime_os == 'centos':
+return 'el%s' % runtime_version
+if runtime_os == 'Fedora':
+return 'fc%s' % runtime_version
+
+""" fall through, return None """
+return None
+
 def new_ticket(self, passwd, desc, build=None):
 """Open a new ticket on Rel-Eng trac instance.
 
diff -up fedpkg-1.10/src/pyrpkg/fedpkg/__init__.py.nil fedpkg-1.10/src/pyrpkg/fedpkg/__init__.py
--- fedpkg-1.10/src/pyrpkg/fedpkg/__init__.py.nil	2012-10-22 13:51:28.706781587 -0

Re: fedpkg / koji error

[Thorsten Leemhuis]

Lo!

On 23.10.2012 17:23, Tom Callaway wrote:

On 10/22/2012 10:37 PM, Ralf Corsepius wrote:

On 10/22/2012 10:43 PM, Tom Callaway wrote:

On 10/22/2012 12:09 PM, Ralf Corsepius wrote:

There is currently no way to "undefine" a macro at the rpm commandline,


rpmbuild --define " %{nil}" ?


Huh, I swear I knew that once. :) Attached is a patch to use the %{nil}
behavior instead of setting the unused dist macro to 0. I smoke tested
and confirmed that the %{rhel} macro is unset on Fedora with this patch
applied.


I haven't tried your patch, but don't you have to unset/define %{nil}
all build-host related rpm macros from /etc/rpm/macros.dist?

It's at least what I can not avoid doing in my before-mentioned
build-scripts.

I.e. when running my script on Fedora 17, I invoke rpmbuild this way:

rpmbuild ... \
  --define "fedora %{nil}" --define "fc17 %{nil}"
  --define "dist .el6" --define "rhel 6"  --define "el6 1"
  ...

Otherwise constructs such as
%{?fc17:}
%{?el6:}
also won't work correctly in rpm.specs.

IIUC, fedpkg with your patch sets %dist and unsets %fedora, but it
doesn't seem to catch "fc17".


Yeah, thats a valid corner case. It wasn't in the original issue, so I
didn't think about it. I'll work on a fix that covers that as well.


Spot: Thanks for working on this and finding a solution that removes the 
inconsistency I was running into with someone else package.


Ralf: Thanks for the idea with the %{nil}

CU
knurd
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg / koji error

[Tom Callaway]

On 10/22/2012 10:37 PM, Ralf Corsepius wrote:
> On 10/22/2012 10:43 PM, Tom Callaway wrote:
>> On 10/22/2012 12:09 PM, Ralf Corsepius wrote:
 There is currently no way to "undefine" a macro at the rpm commandline,
>>>
>>> rpmbuild --define " %{nil}" ?
>>
>> Huh, I swear I knew that once. :) Attached is a patch to use the %{nil}
>> behavior instead of setting the unused dist macro to 0. I smoke tested
>> and confirmed that the %{rhel} macro is unset on Fedora with this patch
>> applied.
> 
> I haven't tried your patch, but don't you have to unset/define %{nil}
> all build-host related rpm macros from /etc/rpm/macros.dist?
> 
> It's at least what I can not avoid doing in my before-mentioned
> build-scripts.
> 
> I.e. when running my script on Fedora 17, I invoke rpmbuild this way:
> 
> rpmbuild ... \
>  --define "fedora %{nil}" --define "fc17 %{nil}"
>  --define "dist .el6" --define "rhel 6"  --define "el6 1"
>  ...
> 
> Otherwise constructs such as
> %{?fc17:}
> %{?el6:}
> also won't work correctly in rpm.specs.
> 
> IIUC, fedpkg with your patch sets %dist and unsets %fedora, but it
> doesn't seem to catch "fc17".

Yeah, thats a valid corner case. It wasn't in the original issue, so I
didn't think about it. I'll work on a fix that covers that as well.

~tom

==
Fedora Project
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg / koji error

[Ralf Corsepius]

On 10/22/2012 10:43 PM, Tom Callaway wrote:

On 10/22/2012 12:09 PM, Ralf Corsepius wrote:

There is currently no way to "undefine" a macro at the rpm commandline,


rpmbuild --define " %{nil}" ?


Huh, I swear I knew that once. :) Attached is a patch to use the %{nil}
behavior instead of setting the unused dist macro to 0. I smoke tested
and confirmed that the %{rhel} macro is unset on Fedora with this patch
applied.


I haven't tried your patch, but don't you have to unset/define %{nil} 
all build-host related rpm macros from /etc/rpm/macros.dist?


It's at least what I can not avoid doing in my before-mentioned 
build-scripts.


I.e. when running my script on Fedora 17, I invoke rpmbuild this way:

rpmbuild ... \
 --define "fedora %{nil}" --define "fc17 %{nil}"
 --define "dist .el6" --define "rhel 6"  --define "el6 1"
 ...

Otherwise constructs such as
%{?fc17:}
%{?el6:}
also won't work correctly in rpm.specs.

IIUC, fedpkg with your patch sets %dist and unsets %fedora, but it 
doesn't seem to catch "fc17".


Ralf

--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg / koji error

[Tom Callaway]

On 10/22/2012 12:09 PM, Ralf Corsepius wrote:
>> There is currently no way to "undefine" a macro at the rpm commandline,
> 
> rpmbuild --define " %{nil}" ?

Huh, I swear I knew that once. :) Attached is a patch to use the %{nil}
behavior instead of setting the unused dist macro to 0. I smoke tested
and confirmed that the %{rhel} macro is unset on Fedora with this patch
applied.

~tom

==
Fedora Project
diff -up fedpkg-1.10/src/pyrpkg/fedpkg/__init__.py.nil fedpkg-1.10/src/pyrpkg/fedpkg/__init__.py
--- fedpkg-1.10/src/pyrpkg/fedpkg/__init__.py.nil	2012-10-22 13:51:28.706781587 -0400
+++ fedpkg-1.10/src/pyrpkg/fedpkg/__init__.py	2012-10-22 13:54:23.750857940 -0400
@@ -197,7 +197,7 @@ class Commands(pyrpkg.Commands):
 "--define '_rpmdir %s'" % self.path,
 "--define 'dist .%s'" % self.dist,
 "--define '%s %s'" % (self._distvar, self._distval),
-"--define '%s 0'" % self._distunset,
+"--define '%s %%{nil}'" % self._distunset,
 "--define '%s 1'" % self.dist]
 
 def load_target(self):
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg / koji error

[Ralf Corsepius]

On 10/22/2012 05:56 PM, Tom Callaway wrote:

On 10/18/2012 03:57 AM, Thorsten Leemhuis wrote:

I'd say the current behaviour is the quite bad, as it leads to different
results when building with fedpkg and rpmbuild on F18. The real fix
afaics would be to revert the change and, if wanted, define rhel as 0 in
Fedora's redhat-rpm-config, too -- but then we obviously need to fix all
%{!?rhel:foo} statements in current spec files.

Options? Spot, Simone?


Ignoring the fact that this behavior is explicitly what we document that
you should not do in a spec file, for precisely this reason...

There is currently no way to "undefine" a macro at the rpm commandline,


rpmbuild --define " %{nil}" ?


so barring rpm growing that support, setting %rhel to 0 is the only way
to address the original issue that I know of.


Couldn't you let pass koji --define "rhel %{nil}" or let
mock invoke rpmbuild --define "rhel %{nil}" ?

I am using a similar trick when building "other rpm-based-distros" 
src.rpms on Fedora.


Ralf



--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg / koji error

[Tom Callaway]

On 10/18/2012 03:57 AM, Thorsten Leemhuis wrote:
> I'd say the current behaviour is the quite bad, as it leads to different
> results when building with fedpkg and rpmbuild on F18. The real fix
> afaics would be to revert the change and, if wanted, define rhel as 0 in
> Fedora's redhat-rpm-config, too -- but then we obviously need to fix all
> %{!?rhel:foo} statements in current spec files.
> 
> Options? Spot, Simone?

Ignoring the fact that this behavior is explicitly what we document that
you should not do in a spec file, for precisely this reason...

There is currently no way to "undefine" a macro at the rpm commandline,
so barring rpm growing that support, setting %rhel to 0 is the only way
to address the original issue that I know of.

~tom

==
Fedora Project
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg / koji error

[Simone Caronni]

On 18 October 2012 14:47, Thorsten Leemhuis  wrote:
> > With the old one I had to check like this (first line) for building;
> > which is not correct anyway as the behaviour was different as well
> > between fedpkg and rpmbuild/mock: [...]
>
> And that should not be the case imho. But if we define rhel as 0 in
> redhat-rpm-config instead (or in addition?) of fedpgk, then your case
> should remain fixed as well -- or am I missing something?

People dealing with fedpkg are fedora contributors, so I think they
can deal with it anyway.
From a logical point of view I don't see any objections for adding it
to the base macros, but I'm not the best person to say if there could
be any implication.

Regards,
--Simone

--
You cannot discover new oceans unless you have the courage to lose
sight of the shore (R. W. Emerson).
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg / koji error

[Thorsten Leemhuis]

On 18.10.2012 10:45, Simone Caronni wrote:
> On 18 October 2012 09:57, Thorsten Leemhuis  > wrote:
> > --with-egl-platforms=x11,drm%{!?rhel:,wayland} \
> The ",wayland" is not added, as rhel is defined now as 0 when building
> with fedpgk. If you build a srpm and try to build it with rpmbuild then
> it works, as it's not defined there. I explained it in more detail in
> https://bugzilla.redhat.com/show_bug.cgi?id=867375 , which made me
> brining up the issue here, as Jesse was unsure how to proceed.
> Can't you

Just for completeness: Mesa isn't my package. I just build a modified
version locally when I ran into trouble that lead to the bug I mentioned.

> check that rhel is not defined and different than 0?

That's obviously possible.

> The packaging guidelines say that a "0" should be used when checking for
> conditions:

But sometimes people do things wrong :-/ If we define rhel as 0 in
redhat-rpm-config then people will notice this case immediately themselves.

> With the old one I had to check like this (first line) for building;
> which is not correct anyway as the behaviour was different as well
> between fedpkg and rpmbuild/mock: [...]

And that should not be the case imho. But if we define rhel as 0 in
redhat-rpm-config instead (or in addition?) of fedpgk, then your case
should remain fixed as well -- or am I missing something?

Cu
knurd
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg / koji error

[Simone Caronni]

Hello,

On 18 October 2012 09:57, Thorsten Leemhuis  wrote:

> > --with-egl-platforms=x11,drm%{!?rhel:,wayland} \
>
> The ",wayland" is not added, as rhel is defined now as 0 when building
> with fedpgk. If you build a srpm and try to build it with rpmbuild then
> it works, as it's not defined there. I explained it in more detail in
> https://bugzilla.redhat.com/show_bug.cgi?id=867375 , which made me
> brining up the issue here, as Jesse was unsure how to proceed.
>

Can't you check that rhel is not defined and different than 0? Something
like the following. It is untested as I don't have commit access; but at
least fedpkg prep on the mesa clone does not give me any error.

$ git diff
diff --git a/mesa.spec b/mesa.spec
index 150a5bc..a61185c 100644
--- a/mesa.spec
+++ b/mesa.spec
@@ -302,7 +302,7 @@ export CXXFLAGS="$RPM_OPT_FLAGS"
 --enable-gles1 \
 --enable-gles2 \
 --disable-gallium-egl \
---with-egl-platforms=x11,drm%{!?rhel:,wayland} \
+--with-egl-platforms=x11,drm%{!0%{?rhel}:,wayland} \
 --enable-shared-glapi \
 --enable-gbm \
 %if %{with_hardware}

Or since you are using already the %if statements elsewhere you can add
another one with the 2 different config lines,  like

$ git diff
diff --git a/mesa.spec b/mesa.spec
index 150a5bc..764449a 100644
--- a/mesa.spec
+++ b/mesa.spec
@@ -302,7 +302,11 @@ export CXXFLAGS="$RPM_OPT_FLAGS"
 --enable-gles1 \
 --enable-gles2 \
 --disable-gallium-egl \
---with-egl-platforms=x11,drm%{!?rhel:,wayland} \
+%if 0%{?rhel}
+--with-egl-platforms=x11,drm} \
+%else
+--with-egl-platforms=x11,drm,wayland} \
+%endif
 --enable-shared-glapi \
 --enable-gbm \
 %if %{with_hardware}

The packaging guidelines say that a "0" should be used when checking for
conditions:

http://fedoraproject.org/wiki/Packaging:DistTag

I'd say the current behaviour is the quite bad, as it leads to different
> results when building with fedpkg and rpmbuild on F18. The real fix
> afaics would be to revert the change and, if wanted, define rhel as 0 in
> Fedora's redhat-rpm-config, too -- but then we obviously need to fix all
> %{!?rhel:foo} statements in current spec files.
>

With the old one I had to check like this (first line) for building; which
is not correct anyway as the behaviour was different as well between fedpkg
and rpmbuild/mock:

-%if (0%{?fedora} == 16 || 0%{?fedora} == 17) && !0%{?rhel}
+%if 0%{?fedora} == 16 || 0%{?fedora} == 17

Regards,
--Simone

-- 
You cannot discover new oceans unless you have the courage to lose sight of
the shore (R. W. Emerson).
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg / koji error

[Thorsten Leemhuis]

Lo!

On 09.10.2012 20:03, Jesse Keating wrote:
> On 10/09/2012 07:14 AM, Simone Caronni wrote:
>> On 19 September 2012 00:26, Orion Poplawski  wrote:
>>> On 09/05/2012 08:07 PM, Tom Callaway wrote:
 Jesse, I'm not sure if you're still the correct upstream here, please
 correct me if you're not, and I'll send the patch somewhere else.
>>> This helps me a lot as well building el srpms from master with "fedpkg
>>> --dist el6 srpm".  +1 from me.
>> Any news regarding this? Is the patch planned to be included?
>> I don't see any activity in git: http://git.fedorahosted.org/cgit/fedpkg.git/
> Oops.  I dropped the ball.  Spot even pinged me about it and I made a 
> promise I didn't keep.  Rectifying.

Patch was integrated and a updated fedpkg is in updates-testing
currently -- which leads to wayland support in mesa.spec being not build
when you build it with fedpkg, as it contains this %configure statement:

> --with-egl-platforms=x11,drm%{!?rhel:,wayland} \

The ",wayland" is not added, as rhel is defined now as 0 when building
with fedpgk. If you build a srpm and try to build it with rpmbuild then
it works, as it's not defined there. I explained it in more detail in
https://bugzilla.redhat.com/show_bug.cgi?id=867375 , which made me
brining up the issue here, as Jesse was unsure how to proceed.

I'd say the current behaviour is the quite bad, as it leads to different
results when building with fedpkg and rpmbuild on F18. The real fix
afaics would be to revert the change and, if wanted, define rhel as 0 in
Fedora's redhat-rpm-config, too -- but then we obviously need to fix all
%{!?rhel:foo} statements in current spec files.

Options? Spot, Simone?

CU
knurd
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg / koji error

[Simone Caronni]

On 19 September 2012 00:26, Orion Poplawski  wrote:
> On 09/05/2012 08:07 PM, Tom Callaway wrote:
>> Jesse, I'm not sure if you're still the correct upstream here, please
>> correct me if you're not, and I'll send the patch somewhere else.
>
> This helps me a lot as well building el srpms from master with "fedpkg
> --dist el6 srpm".  +1 from me.

Any news regarding this? Is the patch planned to be included?
I don't see any activity in git: http://git.fedorahosted.org/cgit/fedpkg.git/

Thanks,
--Simone


-- 
You cannot discover new oceans unless you have the courage to lose
sight of the shore (R. W. Emerson).
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg / koji error

[Orion Poplawski]

On 09/05/2012 08:07 PM, Tom Callaway wrote:

On 09/05/2012 12:48 PM, Simone Caronni wrote:

This means that even for the EPEL branch the first %if block is
evaluated; so the fedpkg on my system (Fedora 17) sets %rhel to 6 but
does not unset %fedora and they are both present.


Confirmed. fedpkg is inheriting the value of "%fedora" from the base OS
on EPEL targets.

The reason why is because fedpkg determines the dist tag values from the
branch name, and then passes them to rpm via the "--define" flag, which
overrides those specific macros if present, but leaves all the other RPM
macros intact. RPM has no "--undefine" flag to disable a macro, so the
best thing we can do is to --define the unused dist tag target to 0
(%fedora for EL branches, %rhel for Fedora branches). There is some
legacy code in fedmsg handling now-obsolete OLPC branches, so in my
patch, I just told it to treat "rhel" as the unused dist tag for the
OLPC branch case.

This change might cause a slight change in evaluated behavior, if anyone
was doing something depending on %rhel or %fedora being unset, but the
common case of checking value like you do (and like we document):

%if 0%{rhel}

should evaluate to:

00, or 0. I've tested and confirmed this fix resolves your specific
conditionals such that only one resolves on each branch.

(If you want to see this in action on a Fedora box, check out a package
that has an EPEL branch, go to the EPEL branch, and add the following
under %setup:

echo "fedora is %{?fedora}"
echo "rhel is %{?rhel}"

Then, run fedpkg prep and note the output.)

Jesse, I'm not sure if you're still the correct upstream here, please
correct me if you're not, and I'll send the patch somewhere else.

~tom

==
Fedora Project





This helps me a lot as well building el srpms from master with "fedpkg --dist 
el6 srpm".  +1 from me.



--
Orion Poplawski
Technical Manager 303-415-9701 x222
NWRA, Boulder Office  FAX: 303-415-9702
3380 Mitchell Lane   or...@nwra.com
Boulder, CO 80301   http://www.nwra.com
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg / koji error

[Tom Callaway]

On 09/05/2012 12:48 PM, Simone Caronni wrote:
> This means that even for the EPEL branch the first %if block is
> evaluated; so the fedpkg on my system (Fedora 17) sets %rhel to 6 but
> does not unset %fedora and they are both present.

Confirmed. fedpkg is inheriting the value of "%fedora" from the base OS
on EPEL targets.

The reason why is because fedpkg determines the dist tag values from the
branch name, and then passes them to rpm via the "--define" flag, which
overrides those specific macros if present, but leaves all the other RPM
macros intact. RPM has no "--undefine" flag to disable a macro, so the
best thing we can do is to --define the unused dist tag target to 0
(%fedora for EL branches, %rhel for Fedora branches). There is some
legacy code in fedmsg handling now-obsolete OLPC branches, so in my
patch, I just told it to treat "rhel" as the unused dist tag for the
OLPC branch case.

This change might cause a slight change in evaluated behavior, if anyone
was doing something depending on %rhel or %fedora being unset, but the
common case of checking value like you do (and like we document):

%if 0%{rhel}

should evaluate to:

00, or 0. I've tested and confirmed this fix resolves your specific
conditionals such that only one resolves on each branch.

(If you want to see this in action on a Fedora box, check out a package
that has an EPEL branch, go to the EPEL branch, and add the following
under %setup:

echo "fedora is %{?fedora}"
echo "rhel is %{?rhel}"

Then, run fedpkg prep and note the output.)

Jesse, I'm not sure if you're still the correct upstream here, please
correct me if you're not, and I'll send the patch somewhere else.

~tom

==
Fedora Project
diff -up fedpkg-1.9/src/pyrpkg/fedpkg/__init__.py.unset-fix fedpkg-1.9/src/pyrpkg/fedpkg/__init__.py
--- fedpkg-1.9/src/pyrpkg/fedpkg/__init__.py.unset-fix	2012-09-05 21:51:48.394497326 -0400
+++ fedpkg-1.9/src/pyrpkg/fedpkg/__init__.py	2012-09-05 21:55:16.011500434 -0400
@@ -162,6 +162,7 @@ class Commands(pyrpkg.Commands):
 self.dist = 'fc%s' % self._distval
 self.mockconfig = 'fedora-%s-%s' % (self._distval, self.localarch)
 self.override = 'dist-f%s-override' % self._distval
+self._distunset = 'rhel'
 # Works until RHEL 10
 elif re.match(r'el\d$', self.branch_merge):
 self._distval = self.branch_merge.split('el')[1]
@@ -169,11 +170,13 @@ class Commands(pyrpkg.Commands):
 self.dist = 'el%s' % self._distval
 self.mockconfig = 'epel-%s-%s' % (self._distval, self.localarch)
 self.override = 'dist-%sE-epel-override' % self._distval
+self._distunset = 'fedora'
 elif re.match(r'olpc\d$', self.branch_merge):
 self._distval = self.branch_merge.split('olpc')[1]
 self._distvar = 'olpc'
 self.dist = 'olpc%s' % self._distval
 self.override = 'dist-olpc%s-override' % self._distval
+self._distunset = 'rhel'
 # master
 elif re.match(r'master$', self.branch_merge):
 self._distval = self._findmasterbranch()
@@ -181,6 +184,7 @@ class Commands(pyrpkg.Commands):
 self.dist = 'fc%s' % self._distval
 self.mockconfig = 'fedora-devel-%s' % self.localarch
 self.override = None
+self._distunset = 'rhel'
 # If we don't match one of the above, punt
 else:
 raise pyrpkg.rpkgError('Could not find the dist from branch name '
@@ -193,6 +197,7 @@ class Commands(pyrpkg.Commands):
 "--define '_rpmdir %s'" % self.path,
 "--define 'dist .%s'" % self.dist,
 "--define '%s %s'" % (self._distvar, self._distval),
+"--define '%s 0'" % self._distunset,
 "--define '%s 1'" % self.dist]
 
 def load_target(self):
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg / koji error

[Simone Caronni]

On 5 September 2012 18:48, Simone Caronni  wrote:
> %if 0%{?fedora} >= 16 || 0%{?fedora} == 17
> %post
> %endif

Sorry, a typo, the spec file is done this way for the first block:

%if 0%{?fedora} == 16 || 0%{?fedora} == 17
%post
%endif

Thanks,
--Simone



-- 
You cannot discover new oceans unless you have the courage to lose
sight of the shore (R. W. Emerson).
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

fedpkg / koji error

[Simone Caronni]

Hello,

I have a weird error that I do not have when building a package in
mock or locally.

When I try to build a package for EPEL6 that has conditionals inside
for checking the distribution it seems that Fedora is always
validated.

Let me explain.

The spec file is structured like this:

%if 0%{?fedora} >= 16 || 0%{?fedora} == 17
%post
%endif

%if 0%{?fedora} >= 18 || 0%{?rhel} >= 7
%post
%endif

%if 0%{?rhel} == 6 || 0%{?rhel} == 5
%post
%endif

Each time I try a build with koji or fedpkg on the el6 branch I obtain
the following:

error: line 110: Second %post
error: query of specfile
/home/slaanesh/fedora-scm/package/package.spec failed, can't parse
Could not execute build: need more than 0 values to unpack

This means that even for the EPEL branch the first %if block is
evaluated; so the fedpkg on my system (Fedora 17) sets %rhel to 6 but
does not unset %fedora and they are both present.
To confirm this, removing the first block or changing it this way
makes the build successful:

%if (0%{?fedora} == 16 || 0%{?fedora} == 17) && !0%{?rhel}
%endif

It's me making the wrong thing in the spec file or something else is broken?

-

A note on this, before introducing this change, the spec file was
structured like this:

%if 0%{?fedora} >= 15 || 0%{?rhel} > 6
%post
%else
%post
%endif

I was trying to insert the F18+ systemd macros.

It would be very beneficial to have the new systemd macros also in
f16/f17 with the simple %systemd_post macro expanding differently if
on f16/f17.

Thanks & Regards,
--Simone






-- 
You cannot discover new oceans unless you have the courage to lose
sight of the shore (R. W. Emerson).
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg koji error

[Farkas Levente]

On 10/08/2010 08:51 PM, Dennis Gilmore wrote:
> On Friday, October 08, 2010 01:09:32 pm Farkas Levente wrote:
>> On 10/08/2010 07:57 PM, Jesse Keating wrote:
>>> On 10/8/10 10:52 AM, Farkas Levente wrote:
 rhel-6 beta2's
 nss-3.12.6-3.el6.x86_64
 anyway yesterday morning i was not able to build, but afternoot after a
 new cert ie: fedora-packager-setup i was able to build again. then today
 i can't build again...
>>>
>>> Are you generating the cert on multiple hosts?  You can only ever have
>>> one cert, you have to copy it manually to all the hosts that you work
>>> from.
>>>
>>> Also, I seem to recall RHEL6's nss having issues with our cert, somebody
>>> more familiar with the problem will have to verify though.
>>
>> i synchronize my home and all of my system use rhel-6 beta2 and
>> yesterday i was able to build today i'm not again (and there was not any
>> kind of package in the last few weeks:-).
> Rhel6's curl doesnt support fas certs.
>  but openssl does since it makes them. 
> 
> does
> koji list-tasks --mine
> 
> work?

ok. sorry it was my fault:-( one of my machine use koji-1.4.0-4 which is
no longer works on rhel-6, just only on fedora. after i downgrade to
koji-1.4.0-2 it's start to work again...
anyway it'd be useful to keep koji and fedpkg versions consistent on all
release (both fedora and rhel) to avoid such problems...

-- 
  Levente   "Si vis pacem para bellum!"
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg koji error

[Farkas Levente]

On 10/08/2010 08:49 PM, Toshio Kuratomi wrote:
> On Fri, Oct 08, 2010 at 08:09:32PM +0200, Farkas Levente wrote:
>> On 10/08/2010 07:57 PM, Jesse Keating wrote:
>>> On 10/8/10 10:52 AM, Farkas Levente wrote:
 rhel-6 beta2's
 nss-3.12.6-3.el6.x86_64
 anyway yesterday morning i was not able to build, but afternoot after a
 new cert ie: fedora-packager-setup i was able to build again. then today
 i can't build again...
>>>
>>>
>>> Are you generating the cert on multiple hosts?  You can only ever have
>>> one cert, you have to copy it manually to all the hosts that you work from.
>>>
>>> Also, I seem to recall RHEL6's nss having issues with our cert, somebody
>>> more familiar with the problem will have to verify though.
>>
>> i synchronize my home and all of my system use rhel-6 beta2 and
>> yesterday i was able to build today i'm not again (and there was not any
>> kind of package in the last few weeks:-).
>>
> Okay, here's something to try:
> 
> python
 import fedora_cert
 c = fedora_cert._open_cert()
 hex(c.get_serial_number())
> 
> Looking at our CA, your certificate's serial number should currently be:
>   3ECB

Python 2.6.2 (r262:71600, Jun 22 2010, 15:25:05)
[GCC 4.4.4 20100611 (Red Hat 4.4.4-8)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import fedora_cert
>>> c = fedora_cert._open_cert()
>>> hex(c.get_serial_number())
'0x3ecbL'


-- 
  Levente   "Si vis pacem para bellum!"
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg koji error

[Dennis Gilmore]

On Friday, October 08, 2010 01:09:32 pm Farkas Levente wrote:
> On 10/08/2010 07:57 PM, Jesse Keating wrote:
> > On 10/8/10 10:52 AM, Farkas Levente wrote:
> >> rhel-6 beta2's
> >> nss-3.12.6-3.el6.x86_64
> >> anyway yesterday morning i was not able to build, but afternoot after a
> >> new cert ie: fedora-packager-setup i was able to build again. then today
> >> i can't build again...
> > 
> > Are you generating the cert on multiple hosts?  You can only ever have
> > one cert, you have to copy it manually to all the hosts that you work
> > from.
> > 
> > Also, I seem to recall RHEL6's nss having issues with our cert, somebody
> > more familiar with the problem will have to verify though.
> 
> i synchronize my home and all of my system use rhel-6 beta2 and
> yesterday i was able to build today i'm not again (and there was not any
> kind of package in the last few weeks:-).
Rhel6's curl doesnt support fas certs.
 but openssl does since it makes them. 

does
koji list-tasks --mine

work?

Dennis


signature.asc
Description: This is a digitally signed message part.
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg koji error

[Toshio Kuratomi]

On Fri, Oct 08, 2010 at 08:09:32PM +0200, Farkas Levente wrote:
> On 10/08/2010 07:57 PM, Jesse Keating wrote:
> > On 10/8/10 10:52 AM, Farkas Levente wrote:
> >> rhel-6 beta2's
> >> nss-3.12.6-3.el6.x86_64
> >> anyway yesterday morning i was not able to build, but afternoot after a
> >> new cert ie: fedora-packager-setup i was able to build again. then today
> >> i can't build again...
> > 
> > 
> > Are you generating the cert on multiple hosts?  You can only ever have
> > one cert, you have to copy it manually to all the hosts that you work from.
> > 
> > Also, I seem to recall RHEL6's nss having issues with our cert, somebody
> > more familiar with the problem will have to verify though.
> 
> i synchronize my home and all of my system use rhel-6 beta2 and
> yesterday i was able to build today i'm not again (and there was not any
> kind of package in the last few weeks:-).
> 
Okay, here's something to try:

python
>>> import fedora_cert
>>> c = fedora_cert._open_cert()
>>> hex(c.get_serial_number())

Looking at our CA, your certificate's serial number should currently be:
  3ECB

-Toshio


pgpD7iCOZzgap.pgp
Description: PGP signature
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg koji error

[Toshio Kuratomi]

On Fri, Oct 08, 2010 at 10:57:58AM -0700, Jesse Keating wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
> 
> On 10/8/10 10:52 AM, Farkas Levente wrote:
> > rhel-6 beta2's
> > nss-3.12.6-3.el6.x86_64
> > anyway yesterday morning i was not able to build, but afternoot after a
> > new cert ie: fedora-packager-setup i was able to build again. then today
> > i can't build again...
> > 
> 
> Are you generating the cert on multiple hosts?  You can only ever have
> one cert, you have to copy it manually to all the hosts that you work from.
> 
This would seem to fit the symptoms of being able to build yesterday but not
today -- the crl that invalidates an old key when a new one is created would
take time to be generated and then propogated to the servers so creating
multiple new certs would have all of them working for a period of time.

> Also, I seem to recall RHEL6's nss having issues with our cert, somebody
> more familiar with the problem will have to verify though.
> 
Dennis informed me this morning that the koji stuff uses pyOpenSSL so it
shouldn't be affected by nss.  Uploading to the lookaside cache uses curl
which uses nss in RHEL6 and all current Fedoras.

One way to test whether the nss or openssl library is at fault would be to
see if you can upload to lookaside even though building doesn't work or
vice-versa.  If neither one works, it's more likely that there's something
wrong with the certificate itself.

-Toshio


pgpCAggUwiAgg.pgp
Description: PGP signature
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg koji error

[Dennis Gilmore]

On Friday, October 08, 2010 12:19:46 pm Jesse Keating wrote:
> On 10/8/10 9:57 AM, Farkas Levente wrote:
> > 
> > [lfar...@eagle jna (f12)]$ fedora-cert -v
> > Verifying Certificate
> > cert expires: 2011-04-06
> > CRL Checking not implemented yet
> > [lfar...@eagle jna (f12)]$ fedpkg -v build
> > Creating module object from /home/lfarkas/work/lenux/fedora/jna
> > Initiating a koji session to http://koji.fedoraproject.org/kojihub
> > Could not log into koji: Opening a SSL connection failed
> 
> What version of nss do you have installed?  There was a nss build that
> could not handle the certs offered by FAS.

the nss issue only effects uploads to the lookaside cache. koji itself uses 
pyopenssl and have no such issues

Dennis


signature.asc
Description: This is a digitally signed message part.
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg koji error

[Jesse Keating]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 10/8/10 11:09 AM, Farkas Levente wrote:
> On 10/08/2010 07:57 PM, Jesse Keating wrote:
>> On 10/8/10 10:52 AM, Farkas Levente wrote:
>>> rhel-6 beta2's
>>> nss-3.12.6-3.el6.x86_64
>>> anyway yesterday morning i was not able to build, but afternoot after a
>>> new cert ie: fedora-packager-setup i was able to build again. then today
>>> i can't build again...
>>
>>
>> Are you generating the cert on multiple hosts?  You can only ever have
>> one cert, you have to copy it manually to all the hosts that you work from.
>>
>> Also, I seem to recall RHEL6's nss having issues with our cert, somebody
>> more familiar with the problem will have to verify though.
> 
> i synchronize my home and all of my system use rhel-6 beta2 and
> yesterday i was able to build today i'm not again (and there was not any
> kind of package in the last few weeks:-).
> 

Can you please try on a Fedora release?

- -- 
Jesse Keating
Fedora -- Freedom² is a feature!
identi.ca: http://identi.ca/jkeating


-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkyvXwUACgkQ4v2HLvE71NVypgCgtexDBoV6eXV4jKvRCqw4hYJz
CVkAnjOWI020y4rY/HDw+MF5X3WW8fPp
=loxA
-END PGP SIGNATURE-
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg koji error

[Farkas Levente]

On 10/08/2010 07:57 PM, Jesse Keating wrote:
> On 10/8/10 10:52 AM, Farkas Levente wrote:
>> rhel-6 beta2's
>> nss-3.12.6-3.el6.x86_64
>> anyway yesterday morning i was not able to build, but afternoot after a
>> new cert ie: fedora-packager-setup i was able to build again. then today
>> i can't build again...
> 
> 
> Are you generating the cert on multiple hosts?  You can only ever have
> one cert, you have to copy it manually to all the hosts that you work from.
> 
> Also, I seem to recall RHEL6's nss having issues with our cert, somebody
> more familiar with the problem will have to verify though.

i synchronize my home and all of my system use rhel-6 beta2 and
yesterday i was able to build today i'm not again (and there was not any
kind of package in the last few weeks:-).

-- 
  Levente   "Si vis pacem para bellum!"
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg koji error

[Jesse Keating]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 10/8/10 10:52 AM, Farkas Levente wrote:
> rhel-6 beta2's
> nss-3.12.6-3.el6.x86_64
> anyway yesterday morning i was not able to build, but afternoot after a
> new cert ie: fedora-packager-setup i was able to build again. then today
> i can't build again...
> 

Are you generating the cert on multiple hosts?  You can only ever have
one cert, you have to copy it manually to all the hosts that you work from.

Also, I seem to recall RHEL6's nss having issues with our cert, somebody
more familiar with the problem will have to verify though.

- -- 
Jesse Keating
Fedora -- Freedom² is a feature!
identi.ca: http://identi.ca/jkeating


-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkyvW6MACgkQ4v2HLvE71NXa3ACfVIQbS63JWqgAh2zhspHDzNNT
QBAAniO3uORk4uwwLVGgrtzOLDIWXXRF
=lvVW
-END PGP SIGNATURE-
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg koji error

[Farkas Levente]

On 10/08/2010 07:19 PM, Jesse Keating wrote:
> On 10/8/10 9:57 AM, Farkas Levente wrote:
>> On 10/08/2010 04:28 PM, Dennis Gilmore wrote:
>>> On Friday, October 08, 2010 09:15:08 am Farkas Levente wrote:
 On 10/08/2010 03:53 PM, Dennis Gilmore wrote:
> On Thursday, October 07, 2010 04:25:45 am Thomas Spura wrote:
>> On Wed, 06 Oct 2010 11:19:21 +0200
>>
>> Farkas Levente wrote:
>>> hi,
>>> while try to make a scratch build i always got:
>>> -
>>> # fedpkg scratch-build
>>> Could not log into koji: Opening a SSL connection failed
>>> -
>>> even if i try to remove .fedora.cert and fedora-packager-setup (so
>>> it's not a certificate problem).
>>> what else can be the reason?
>>> thanks in advance.
>>> regards.
>>
>> This is because the ssl_login to koji failed, so your SSL key is
>> expired. Generate a new one and upload it to fas:
>> https://admin.fedoraproject.org/accounts/
>>
>> After waiting an hour or something, it should work again (I hope).
>>
>>  Thomas
>
> "fedora-cert -v"  will verify if the cert is valid or not.
>
> when you need a new cert the recommended way to get it it to use fedora-
> packager-setup or fedora-cert.
>
> you dont upload a ssl cert to fas. and there is no waiting for it to be
> valid.

 ---
 [lfar...@fox jna (f12)]$ fedora-cert -v
 Verifying Certificate
 cert expires: 2011-04-06
 CRL Checking not implemented yet
 [lfar...@fox jna (f12)]$ fedpkg build
 Could not log into koji: Opening a SSL connection failed
 ---
 so what's now?
>>>
>>> fedpkg -v build
> 
>> [lfar...@eagle jna (f12)]$ fedora-cert -v
>> Verifying Certificate
>> cert expires: 2011-04-06
>> CRL Checking not implemented yet
>> [lfar...@eagle jna (f12)]$ fedpkg -v build
>> Creating module object from /home/lfarkas/work/lenux/fedora/jna
>> Initiating a koji session to http://koji.fedoraproject.org/kojihub
>> Could not log into koji: Opening a SSL connection failed
> 
> 
> 
> What version of nss do you have installed?  There was a nss build that
> could not handle the certs offered by FAS.

rhel-6 beta2's
nss-3.12.6-3.el6.x86_64
anyway yesterday morning i was not able to build, but afternoot after a
new cert ie: fedora-packager-setup i was able to build again. then today
i can't build again...

-- 
  Levente   "Si vis pacem para bellum!"
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg koji error

[Jesse Keating]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 10/8/10 9:57 AM, Farkas Levente wrote:
> On 10/08/2010 04:28 PM, Dennis Gilmore wrote:
>> On Friday, October 08, 2010 09:15:08 am Farkas Levente wrote:
>>> On 10/08/2010 03:53 PM, Dennis Gilmore wrote:
 On Thursday, October 07, 2010 04:25:45 am Thomas Spura wrote:
> On Wed, 06 Oct 2010 11:19:21 +0200
>
> Farkas Levente wrote:
>> hi,
>> while try to make a scratch build i always got:
>> -
>> # fedpkg scratch-build
>> Could not log into koji: Opening a SSL connection failed
>> -
>> even if i try to remove .fedora.cert and fedora-packager-setup (so
>> it's not a certificate problem).
>> what else can be the reason?
>> thanks in advance.
>> regards.
>
> This is because the ssl_login to koji failed, so your SSL key is
> expired. Generate a new one and upload it to fas:
> https://admin.fedoraproject.org/accounts/
>
> After waiting an hour or something, it should work again (I hope).
>
>   Thomas

 "fedora-cert -v"  will verify if the cert is valid or not.

 when you need a new cert the recommended way to get it it to use fedora-
 packager-setup or fedora-cert.

 you dont upload a ssl cert to fas. and there is no waiting for it to be
 valid.
>>>
>>> ---
>>> [lfar...@fox jna (f12)]$ fedora-cert -v
>>> Verifying Certificate
>>> cert expires: 2011-04-06
>>> CRL Checking not implemented yet
>>> [lfar...@fox jna (f12)]$ fedpkg build
>>> Could not log into koji: Opening a SSL connection failed
>>> ---
>>> so what's now?
>>
>> fedpkg -v build
> 
> [lfar...@eagle jna (f12)]$ fedora-cert -v
> Verifying Certificate
> cert expires: 2011-04-06
> CRL Checking not implemented yet
> [lfar...@eagle jna (f12)]$ fedpkg -v build
> Creating module object from /home/lfarkas/work/lenux/fedora/jna
> Initiating a koji session to http://koji.fedoraproject.org/kojihub
> Could not log into koji: Opening a SSL connection failed
> 
> 

What version of nss do you have installed?  There was a nss build that
could not handle the certs offered by FAS.

- -- 
Jesse Keating
Fedora -- Freedom² is a feature!
identi.ca: http://identi.ca/jkeating


-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkyvUq8ACgkQ4v2HLvE71NVnfACfYKS3/swSu0RMh9kjpjLNpDm8
XFUAn3uCFFKj1y7khE++ZG1a+flQ1tMW
=+M7o
-END PGP SIGNATURE-
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg koji error

[Farkas Levente]

On 10/08/2010 04:28 PM, Dennis Gilmore wrote:
> On Friday, October 08, 2010 09:15:08 am Farkas Levente wrote:
>> On 10/08/2010 03:53 PM, Dennis Gilmore wrote:
>>> On Thursday, October 07, 2010 04:25:45 am Thomas Spura wrote:
 On Wed, 06 Oct 2010 11:19:21 +0200

 Farkas Levente wrote:
> hi,
> while try to make a scratch build i always got:
> -
> # fedpkg scratch-build
> Could not log into koji: Opening a SSL connection failed
> -
> even if i try to remove .fedora.cert and fedora-packager-setup (so
> it's not a certificate problem).
> what else can be the reason?
> thanks in advance.
> regards.

 This is because the ssl_login to koji failed, so your SSL key is
 expired. Generate a new one and upload it to fas:
 https://admin.fedoraproject.org/accounts/

 After waiting an hour or something, it should work again (I hope).

Thomas
>>>
>>> "fedora-cert -v"  will verify if the cert is valid or not.
>>>
>>> when you need a new cert the recommended way to get it it to use fedora-
>>> packager-setup or fedora-cert.
>>>
>>> you dont upload a ssl cert to fas. and there is no waiting for it to be
>>> valid.
>>
>> ---
>> [lfar...@fox jna (f12)]$ fedora-cert -v
>> Verifying Certificate
>> cert expires: 2011-04-06
>> CRL Checking not implemented yet
>> [lfar...@fox jna (f12)]$ fedpkg build
>> Could not log into koji: Opening a SSL connection failed
>> ---
>> so what's now?
> 
> fedpkg -v build

[lfar...@eagle jna (f12)]$ fedora-cert -v
Verifying Certificate
cert expires: 2011-04-06
CRL Checking not implemented yet
[lfar...@eagle jna (f12)]$ fedpkg -v build
Creating module object from /home/lfarkas/work/lenux/fedora/jna
Initiating a koji session to http://koji.fedoraproject.org/kojihub
Could not log into koji: Opening a SSL connection failed


-- 
  Levente   "Si vis pacem para bellum!"
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg koji error

[Dennis Gilmore]

On Friday, October 08, 2010 09:15:08 am Farkas Levente wrote:
> On 10/08/2010 03:53 PM, Dennis Gilmore wrote:
> > On Thursday, October 07, 2010 04:25:45 am Thomas Spura wrote:
> >> On Wed, 06 Oct 2010 11:19:21 +0200
> >> 
> >> Farkas Levente wrote:
> >>> hi,
> >>> while try to make a scratch build i always got:
> >>> -
> >>> # fedpkg scratch-build
> >>> Could not log into koji: Opening a SSL connection failed
> >>> -
> >>> even if i try to remove .fedora.cert and fedora-packager-setup (so
> >>> it's not a certificate problem).
> >>> what else can be the reason?
> >>> thanks in advance.
> >>> regards.
> >> 
> >> This is because the ssl_login to koji failed, so your SSL key is
> >> expired. Generate a new one and upload it to fas:
> >> https://admin.fedoraproject.org/accounts/
> >> 
> >> After waiting an hour or something, it should work again (I hope).
> >> 
> >>Thomas
> > 
> > "fedora-cert -v"  will verify if the cert is valid or not.
> > 
> > when you need a new cert the recommended way to get it it to use fedora-
> > packager-setup or fedora-cert.
> > 
> > you dont upload a ssl cert to fas. and there is no waiting for it to be
> > valid.
> 
> ---
> [lfar...@fox jna (f12)]$ fedora-cert -v
> Verifying Certificate
> cert expires: 2011-04-06
> CRL Checking not implemented yet
> [lfar...@fox jna (f12)]$ fedpkg build
> Could not log into koji: Opening a SSL connection failed
> ---
> so what's now?

fedpkg -v build


signature.asc
Description: This is a digitally signed message part.
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg koji error

[Farkas Levente]

On 10/08/2010 03:53 PM, Dennis Gilmore wrote:
> On Thursday, October 07, 2010 04:25:45 am Thomas Spura wrote:
>> On Wed, 06 Oct 2010 11:19:21 +0200
>>
>> Farkas Levente wrote:
>>> hi,
>>> while try to make a scratch build i always got:
>>> -
>>> # fedpkg scratch-build
>>> Could not log into koji: Opening a SSL connection failed
>>> -
>>> even if i try to remove .fedora.cert and fedora-packager-setup (so
>>> it's not a certificate problem).
>>> what else can be the reason?
>>> thanks in advance.
>>> regards.
>>
>> This is because the ssl_login to koji failed, so your SSL key is
>> expired. Generate a new one and upload it to fas:
>> https://admin.fedoraproject.org/accounts/
>>
>> After waiting an hour or something, it should work again (I hope).
>>
>>  Thomas
> 
> "fedora-cert -v"  will verify if the cert is valid or not.
> 
> when you need a new cert the recommended way to get it it to use fedora-
> packager-setup or fedora-cert.  
> 
> you dont upload a ssl cert to fas. and there is no waiting for it to be valid.

---
[lfar...@fox jna (f12)]$ fedora-cert -v
Verifying Certificate
cert expires: 2011-04-06
CRL Checking not implemented yet
[lfar...@fox jna (f12)]$ fedpkg build
Could not log into koji: Opening a SSL connection failed
---
so what's now?

-- 
  Levente   "Si vis pacem para bellum!"
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg koji error

[Dennis Gilmore]

On Thursday, October 07, 2010 04:25:45 am Thomas Spura wrote:
> On Wed, 06 Oct 2010 11:19:21 +0200
> 
> Farkas Levente wrote:
> > hi,
> > while try to make a scratch build i always got:
> > -
> > # fedpkg scratch-build
> > Could not log into koji: Opening a SSL connection failed
> > -
> > even if i try to remove .fedora.cert and fedora-packager-setup (so
> > it's not a certificate problem).
> > what else can be the reason?
> > thanks in advance.
> > regards.
> 
> This is because the ssl_login to koji failed, so your SSL key is
> expired. Generate a new one and upload it to fas:
> https://admin.fedoraproject.org/accounts/
> 
> After waiting an hour or something, it should work again (I hope).
> 
>   Thomas

"fedora-cert -v"  will verify if the cert is valid or not.

when you need a new cert the recommended way to get it it to use fedora-
packager-setup or fedora-cert.  

you dont upload a ssl cert to fas. and there is no waiting for it to be valid.

Dennis


signature.asc
Description: This is a digitally signed message part.
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg koji error

[Thomas Spura]

On Wed, 06 Oct 2010 11:19:21 +0200
Farkas Levente wrote:

> hi,
> while try to make a scratch build i always got:
> -
> # fedpkg scratch-build
> Could not log into koji: Opening a SSL connection failed
> -
> even if i try to remove .fedora.cert and fedora-packager-setup (so
> it's not a certificate problem).
> what else can be the reason?
> thanks in advance.
> regards.

This is because the ssl_login to koji failed, so your SSL key is
expired. Generate a new one and upload it to fas:
https://admin.fedoraproject.org/accounts/

After waiting an hour or something, it should work again (I hope).

Thomas
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: fedpkg koji error

[Pavel Alexeev (aka Pahan-Hubbitus)]

 Try verbose variant to figure out what happened:

$ fedpkg -v scratch-build


06.10.2010 13:19, Farkas Levente wrote:
> hi,
> while try to make a scratch build i always got:
> -
> # fedpkg scratch-build
> Could not log into koji: Opening a SSL connection failed
> -
> even if i try to remove .fedora.cert and fedora-packager-setup (so it's
> not a certificate problem).
> what else can be the reason?
> thanks in advance.
> regards.
>

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

fedpkg koji error

[Farkas Levente]

hi,
while try to make a scratch build i always got:
-
# fedpkg scratch-build
Could not log into koji: Opening a SSL connection failed
-
even if i try to remove .fedora.cert and fedora-packager-setup (so it's
not a certificate problem).
what else can be the reason?
thanks in advance.
regards.

-- 
  Levente   "Si vis pacem para bellum!"
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel