Re: isomd5sum 1.2.4-1 checksum bug
On Mon, Apr 29, 2024 at 12:20:37PM GMT, Brian C. Lane wrote: > I screwed up the isomd5sum checksums in the 1.2.4 release while trying > to fix support for small isos. I've reverted the change and 1.2.4-2 is > building for rawhide and Fedora 40. Thanks to Jonathan Billings for the > bug report (https://bugzilla.redhat.com/show_bug.cgi?id=2277398). Thanks Billings! > The bad version made it into Fedora 40 and Rawhide. > > With the bad version it will implant a checksum that is too short by 3 > characters, but checking it will pass if you use 1.2.4-1 -- but not if > you use any of the previous versions. You can check for the bad checksum > by running checkisomd5sum --verbose and look for ';FR' at the end of the > reported checksum. :( > > Spot checking the Fedora 40 netinst and workstation isos I don't see the > bad checksums so it looks like the build system was using a previous > version of implantisomd5 for the released isos. Thats good. > Currently in rawhide the isos have the bad checksums, so the builders > will need to be updated to isomd5sum-1.2.4-2 to fix this. Well, livemedia creation is done in a chroot in koji, so it should pick that up in tomorrow's rawhide automatically. I don't think anything needs manually updating, but if I am missing something let me know. kevin -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
isomd5sum 1.2.4-1 checksum bug
I screwed up the isomd5sum checksums in the 1.2.4 release while trying to fix support for small isos. I've reverted the change and 1.2.4-2 is building for rawhide and Fedora 40. Thanks to Jonathan Billings for the bug report (https://bugzilla.redhat.com/show_bug.cgi?id=2277398). The bad version made it into Fedora 40 and Rawhide. With the bad version it will implant a checksum that is too short by 3 characters, but checking it will pass if you use 1.2.4-1 -- but not if you use any of the previous versions. You can check for the bad checksum by running checkisomd5sum --verbose and look for ';FR' at the end of the reported checksum. Spot checking the Fedora 40 netinst and workstation isos I don't see the bad checksums so it looks like the build system was using a previous version of implantisomd5 for the released isos. Currently in rawhide the isos have the bad checksums, so the builders will need to be updated to isomd5sum-1.2.4-2 to fix this. Nobody except Jonathan noticed because normally the same version making the checksum is used to check it. He was using mkksiso to make a custom iso which resulted in the new iso failing the test at boot time due to the iso having 1.2.3-23 on it and his host having 1.2.4-1 on it. Hopefully this doesn't cause too many problems for people, Brian -- Brian C. Lane (PST8PDT) - weldr.io - lorax - parted - pykickstart -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
