Re: orphaning dx (OpenDX)
Dominik 'Rathann' Mierzejewski wrote:
> Well, in this case, an array of char is initialised with values > 128
> and the passed to XCreatePixmapFromBitmapData, which requires a char *
> parameter, so it's not trivial (at least to me).
These narrowing issues are all trivial to fix:
export CXXFLAGS="%{optflags} -Wno-error=narrowing"
That said, in this case, you should at least check whether the code does not
actually want to be compiled with -funsigned-char instead. (I.e., is it only
building that char array to pass it to XCreatePixmapFromBitmapData, or is it
trying to read values from this or other char arrays and expecting them to
come back out as unsigned? In the former case, -Wno-error=narrowing is
enough, in the latter case, the code was never right and needs either
-funsigned-char or some deeper fixing.)
Kevin Kofler
--
devel mailing list
devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
Re: orphaning dx (OpenDX)
On Thursday, 18 February 2016 at 14:45, Ralf Corsepius wrote: > On 02/18/2016 01:54 PM, Dominik 'Rathann' Mierzejewski wrote: > >On Wednesday, 17 February 2016 at 17:37, Ralf Corsepius wrote: > >>On 02/17/2016 02:54 PM, Dominik 'Rathann' Mierzejewski wrote: > >>>Hello, > >>>I'm orphaning the dx and dx-samples in rawhide. > >[...] > >>>Feel free to take it (and request other branches/admin access). I'll > >>>give away the other branches as well if someone wants to step in all > >>>the way. > >> > >>I've taken it. > > > >Thanks, Ralf. Would you like to take over the other branches as well? > > I tried to do so, yesterday, but me and packagedb GUI probably will never > make friends - Read: I tried and failed ;) It's all yours now. Regards, Dominik -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations" -- devel mailing list devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
Re: orphaning dx (OpenDX)
On 02/18/2016 01:54 PM, Dominik 'Rathann' Mierzejewski wrote: On Wednesday, 17 February 2016 at 17:37, Ralf Corsepius wrote: On 02/17/2016 02:54 PM, Dominik 'Rathann' Mierzejewski wrote: Hello, I'm orphaning the dx and dx-samples in rawhide. [...] Feel free to take it (and request other branches/admin access). I'll give away the other branches as well if someone wants to step in all the way. I've taken it. Thanks, Ralf. Would you like to take over the other branches as well? I tried to do so, yesterday, but me and packagedb GUI probably will never make friends - Read: I tried and failed ;) Ralf -- devel mailing list devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
Re: orphaning dx (OpenDX)
On Wednesday, 17 February 2016 at 17:37, Ralf Corsepius wrote: > On 02/17/2016 02:54 PM, Dominik 'Rathann' Mierzejewski wrote: > >Hello, > >I'm orphaning the dx and dx-samples in rawhide. [...] > >Feel free to take it (and request other branches/admin access). I'll > >give away the other branches as well if someone wants to step in all > >the way. > > I've taken it. Thanks, Ralf. Would you like to take over the other branches as well? Regards, Dominik -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations" -- devel mailing list devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
Re: orphaning dx (OpenDX)
On 02/17/2016 02:54 PM, Dominik 'Rathann' Mierzejewski wrote: Hello, I'm orphaning the dx and dx-samples in rawhide. It is FTBFS in rawhide due to stricter checks in gcc-6, the upstream is dead (or actually it was never there, ever since IBM released the code), and the code itself is ancient (1999). I don't use it and I don't know anyone who does, so it's not really worth my effort to fix it to build with gcc-6. I've been keeping the code building (and running, mostly) for almost 10 years now and I think it's time for someone else to take over, if they're interested. Feel free to take it (and request other branches/admin access). I'll give away the other branches as well if someone wants to step in all the way. I've taken it. Ralf -- devel mailing list devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
Re: orphaning dx (OpenDX)
On 02/17/2016 03:09 PM, Dominik 'Rathann' Mierzejewski wrote:
On Wednesday, 17 February 2016 at 15:00, Richard Shaw wrote:
On Wed, Feb 17, 2016 at 7:54 AM, Dominik 'Rathann' Mierzejewski <
domi...@greysector.net> wrote:
Hello,
I'm orphaning the dx and dx-samples in rawhide.
It is FTBFS in rawhide due to stricter checks in gcc-6, the upstream
is dead (or actually it was never there, ever since IBM released the
code), and the code itself is ancient (1999). I don't use it and I don't
know anyone who does, so it's not really worth my effort to fix it
to build with gcc-6. I've been keeping the code building (and running,
mostly) for almost 10 years now and I think it's time for someone
else to take over, if they're interested.
If no one is using it then it's not worth the effort but in the packages
I've had that have the narrowing conversion issues they have been
relatively easy to fix.
Well, in this case, an array of char is initialised with values > 128
and the passed to XCreatePixmapFromBitmapData, which requires a char *
parameter, so it's not trivial (at least to me).
AFAIS, this is Xt/Xm code. Xm/Xt is C, with all types and parameters
being C. Also, Xm/Xt's APIs predate the invention of "const" and had
never actually cared about it.
I.e. this is a situation, where spraying C-type-casts into
Xm/Xt-API-calls is the solution - seriously!
I haven't looked into this particular package yet, but in the situation
you line out, something along the lines of the snippet below, is the
solution:
unsigned char xbm[] = { 0xff, }
XCreatePixmapFromBitmapData( , (char*) xbm,...)
[Similar considerations apply to tcl/tk and other "old" C/C++-SDKs]
Ralf
--
devel mailing list
devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
Re: orphaning dx (OpenDX)
On Wednesday, 17 February 2016 at 15:00, Richard Shaw wrote: > On Wed, Feb 17, 2016 at 7:54 AM, Dominik 'Rathann' Mierzejewski < > domi...@greysector.net> wrote: > > > Hello, > > I'm orphaning the dx and dx-samples in rawhide. > > > > It is FTBFS in rawhide due to stricter checks in gcc-6, the upstream > > is dead (or actually it was never there, ever since IBM released the > > code), and the code itself is ancient (1999). I don't use it and I don't > > know anyone who does, so it's not really worth my effort to fix it > > to build with gcc-6. I've been keeping the code building (and running, > > mostly) for almost 10 years now and I think it's time for someone > > else to take over, if they're interested. > > > If no one is using it then it's not worth the effort but in the packages > I've had that have the narrowing conversion issues they have been > relatively easy to fix. Well, in this case, an array of char is initialised with values > 128 and the passed to XCreatePixmapFromBitmapData, which requires a char * parameter, so it's not trivial (at least to me). Regards, Dominik -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations" -- devel mailing list devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
Re: orphaning dx (OpenDX)
On Wed, Feb 17, 2016 at 7:54 AM, Dominik 'Rathann' Mierzejewski < domi...@greysector.net> wrote: > Hello, > I'm orphaning the dx and dx-samples in rawhide. > > It is FTBFS in rawhide due to stricter checks in gcc-6, the upstream > is dead (or actually it was never there, ever since IBM released the > code), and the code itself is ancient (1999). I don't use it and I don't > know anyone who does, so it's not really worth my effort to fix it > to build with gcc-6. I've been keeping the code building (and running, > mostly) for almost 10 years now and I think it's time for someone > else to take over, if they're interested. If no one is using it then it's not worth the effort but in the packages I've had that have the narrowing conversion issues they have been relatively easy to fix. Thanks, Richard -- devel mailing list devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
orphaning dx (OpenDX)
Hello, I'm orphaning the dx and dx-samples in rawhide. It is FTBFS in rawhide due to stricter checks in gcc-6, the upstream is dead (or actually it was never there, ever since IBM released the code), and the code itself is ancient (1999). I don't use it and I don't know anyone who does, so it's not really worth my effort to fix it to build with gcc-6. I've been keeping the code building (and running, mostly) for almost 10 years now and I think it's time for someone else to take over, if they're interested. Feel free to take it (and request other branches/admin access). I'll give away the other branches as well if someone wants to step in all the way. Regards, Dominik -- Fedora http://fedoraproject.org/wiki/User:Rathann RPMFusion http://rpmfusion.org "Faith manages." -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations" -- devel mailing list devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
