Re: rpmlint whitelisting broken in taskotron?

2019-04-29 Thread Tim Flink
On Fri, 26 Apr 2019 20:33:43 +0200
Fabio Valentini  wrote:

> On Fri, Apr 26, 2019, 20:24 Tim Flink  wrote:
> 
> > On Fri, 26 Apr 2019 16:42:30 +0200
> > Fabio Valentini  wrote:
> >  
> > > Hi,
> > >
> > > I've noticed that my bodhi updates started showing rpmlint errors
> > > for my packages again, where they were previously silent because
> > > I supply a $SRCNAME.rpmlintrc file in my dist-git repos.
> > >
> > > It looks like taskotron is broken and/or ignores this file again.
> > > Is this a known issue?
> > >
> > > For example, this build from today shows rpmlint issues that are
> > > explicitly whitelisted (using the file locally suppresses the
> > > warnings/errors as intended):
> > >
> > > update:
> > > https://bodhi.fedoraproject.org/updates/FEDORA-2019-ecaba1eef1 in
> > > repo: 
> > https://src.fedoraproject.org/rpms/elementary-greeter/blob/f30/f/elementary-greeter.rpmlintrc
> >
> > This was not a known issue, no. It stems from us depending on the
> > cgit interface which was taken down a few days ago - we're getting
> > 404s when we try to grab the rpmlintrc file
> >
> > I'm still looking into this but have filed an issue track it:
> >
> > https://pagure.io/taskotron/libtaskotron/issue/429
> >
> > Thanks for the report and sorry for the bother.
> >
> > Tim
> >  
> 
> Great, thanks for looking into it!
> 
> pagure provides really simple URLs to fetch raw files, so it
> shouldn't be hard to adapt the code from cgit, for example:
> 
> https://src.fedoraproject.org/rpms/elementary-photos/raw/47e73b7ac14dea07b5fcbd39b5f2aff67fea4fbc/f/elementary-photos.rpmlintrc

The freeze break request I needed to update the packages was approved
over the weekend and libtaskotron has been updated in production.

This issue with finding package-specific rpmlintrc files should be
fixed. Please let us know if you continue to see the issue.

Thanks,

Tim


pgpwZidTguql8.pgp
Description: OpenPGP digital signature
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: rpmlint whitelisting broken in taskotron?

2019-04-26 Thread Fabio Valentini
On Fri, Apr 26, 2019, 20:24 Tim Flink  wrote:

> On Fri, 26 Apr 2019 16:42:30 +0200
> Fabio Valentini  wrote:
>
> > Hi,
> >
> > I've noticed that my bodhi updates started showing rpmlint errors for
> > my packages again, where they were previously silent because I supply
> > a $SRCNAME.rpmlintrc file in my dist-git repos.
> >
> > It looks like taskotron is broken and/or ignores this file again. Is
> > this a known issue?
> >
> > For example, this build from today shows rpmlint issues that are
> > explicitly whitelisted (using the file locally suppresses the
> > warnings/errors as intended):
> >
> > update: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ecaba1eef1
> > in repo:
> >
> https://src.fedoraproject.org/rpms/elementary-greeter/blob/f30/f/elementary-greeter.rpmlintrc
>
> This was not a known issue, no. It stems from us depending on the cgit
> interface which was taken down a few days ago - we're getting 404s when
> we try to grab the rpmlintrc file
>
> I'm still looking into this but have filed an issue track it:
>
> https://pagure.io/taskotron/libtaskotron/issue/429
>
> Thanks for the report and sorry for the bother.
>
> Tim
>

Great, thanks for looking into it!

pagure provides really simple URLs to fetch raw files, so it shouldn't be
hard to adapt the code from cgit, for example:

https://src.fedoraproject.org/rpms/elementary-photos/raw/47e73b7ac14dea07b5fcbd39b5f2aff67fea4fbc/f/elementary-photos.rpmlintrc

Thanks again, Fabio


___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
>
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


Re: rpmlint whitelisting broken in taskotron?

2019-04-26 Thread Tim Flink
On Fri, 26 Apr 2019 16:42:30 +0200
Fabio Valentini  wrote:

> Hi,
> 
> I've noticed that my bodhi updates started showing rpmlint errors for
> my packages again, where they were previously silent because I supply
> a $SRCNAME.rpmlintrc file in my dist-git repos.
> 
> It looks like taskotron is broken and/or ignores this file again. Is
> this a known issue?
> 
> For example, this build from today shows rpmlint issues that are
> explicitly whitelisted (using the file locally suppresses the
> warnings/errors as intended):
> 
> update: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ecaba1eef1
> in repo:
> https://src.fedoraproject.org/rpms/elementary-greeter/blob/f30/f/elementary-greeter.rpmlintrc

This was not a known issue, no. It stems from us depending on the cgit
interface which was taken down a few days ago - we're getting 404s when
we try to grab the rpmlintrc file 

I'm still looking into this but have filed an issue track it:

https://pagure.io/taskotron/libtaskotron/issue/429

Thanks for the report and sorry for the bother.

Tim


pgpoygVPxciLF.pgp
Description: OpenPGP digital signature
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


rpmlint whitelisting broken in taskotron?

2019-04-26 Thread Fabio Valentini
Hi,

I've noticed that my bodhi updates started showing rpmlint errors for
my packages again, where they were previously silent because I supply
a $SRCNAME.rpmlintrc file in my dist-git repos.

It looks like taskotron is broken and/or ignores this file again. Is
this a known issue?

For example, this build from today shows rpmlint issues that are
explicitly whitelisted (using the file locally suppresses the
warnings/errors as intended):

update: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ecaba1eef1
in repo: 
https://src.fedoraproject.org/rpms/elementary-greeter/blob/f30/f/elementary-greeter.rpmlintrc

Fabio
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org