Re: rust: Request for packaging rust-html-escape and rust-smallbitvec
On Sun, Dec 5, 2021 at 8:10 AM Andreas Schneider wrote: > > On Friday, 3 December 2021 18:40:12 CET Aleksei Bavshin wrote: > > On 12/3/21 03:15, Andreas Schneider wrote: > > > > > On Thursday, December 2, 2021 9:07:06 PM CET Aleksei Bavshin wrote: > > > > > >> `smallbitvec` deps are only needed for benchmark, so the test suite is > > >> actually passing without these. Should be safe to drop with metadata > > >> patch. > >> > > >> > > >> > > >> rust-tiny_http 0.8.2 also has a benchmark-only dependency `fdlimit` > > >> which we can drop. > > >> > > >> > > >> > > >> The situation with tree-sitter-cli testsuite is complicated: it requires > > >> a few other github repos with a grammar definitions and who knows what > > >> else. I haven't succeeded in running it so far, so we can keep it turned > > >> off. And that would make `rust-spin` update unnecessary. > > >> > > >> > > >> > > >> The draft packages are available from > > >> https://copr.fedorainfracloud.org/coprs/alebastr/rust-tree-sitter-cli/; > > >> seems working with available grammar files (with exception of > > >> `build-wasm` and `playground` subcommands which require emscripten). > > > > > > > > > This is great work, thank you very much. I didn't know that the > > > tree-sitter- > cli needs it own package and can't be built in the current > > > tree-sitter package. So I will just continue to take care of tree-sitter > > > and just build the lib. > > > > > > So having tree-sitter-cli in the next fedora version would be awesome. > > > > > > Reviews (and PR for rust-tiny_http update) are sent. > > > > Upstream issue for missing license file: > > https://github.com/tree-sitter/tree-sitter/issues/1520 > > > > Andreas, do you want to have comaintainer access to the tree-sitter-cli > > packages? > > I can do the co-maintainer if you're interested :-) Please also add any new Rust packages to the @rust-sig group. It makes it much easier for me to maintain the Rust stack when I can see the whole picture when querying dist-git and bugzilla. Administrative things aside, consider this a co-maintainer offer from me on behalf of the Rust SIG as well :-) Fabio ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: rust: Request for packaging rust-html-escape and rust-smallbitvec
On Friday, 3 December 2021 18:40:12 CET Aleksei Bavshin wrote: > On 12/3/21 03:15, Andreas Schneider wrote: > > > On Thursday, December 2, 2021 9:07:06 PM CET Aleksei Bavshin wrote: > > > >> `smallbitvec` deps are only needed for benchmark, so the test suite is > >> actually passing without these. Should be safe to drop with metadata > >> patch. >> > >> > >> > >> rust-tiny_http 0.8.2 also has a benchmark-only dependency `fdlimit` > >> which we can drop. > >> > >> > >> > >> The situation with tree-sitter-cli testsuite is complicated: it requires > >> a few other github repos with a grammar definitions and who knows what > >> else. I haven't succeeded in running it so far, so we can keep it turned > >> off. And that would make `rust-spin` update unnecessary. > >> > >> > >> > >> The draft packages are available from > >> https://copr.fedorainfracloud.org/coprs/alebastr/rust-tree-sitter-cli/; > >> seems working with available grammar files (with exception of > >> `build-wasm` and `playground` subcommands which require emscripten). > > > > > > This is great work, thank you very much. I didn't know that the > > tree-sitter- cli needs it own package and can't be built in the current > > tree-sitter package. So I will just continue to take care of tree-sitter > > and just build the lib. > > > > So having tree-sitter-cli in the next fedora version would be awesome. > > > Reviews (and PR for rust-tiny_http update) are sent. > > Upstream issue for missing license file: > https://github.com/tree-sitter/tree-sitter/issues/1520 > > Andreas, do you want to have comaintainer access to the tree-sitter-cli > packages? I can do the co-maintainer if you're interested :-) Andreas ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: rust: Request for packaging rust-html-escape and rust-smallbitvec
On 12/3/21 03:15, Andreas Schneider wrote: On Thursday, December 2, 2021 9:07:06 PM CET Aleksei Bavshin wrote: `smallbitvec` deps are only needed for benchmark, so the test suite is actually passing without these. Should be safe to drop with metadata patch. rust-tiny_http 0.8.2 also has a benchmark-only dependency `fdlimit` which we can drop. The situation with tree-sitter-cli testsuite is complicated: it requires a few other github repos with a grammar definitions and who knows what else. I haven't succeeded in running it so far, so we can keep it turned off. And that would make `rust-spin` update unnecessary. The draft packages are available from https://copr.fedorainfracloud.org/coprs/alebastr/rust-tree-sitter-cli/; seems working with available grammar files (with exception of `build-wasm` and `playground` subcommands which require emscripten). This is great work, thank you very much. I didn't know that the tree-sitter- cli needs it own package and can't be built in the current tree-sitter package. So I will just continue to take care of tree-sitter and just build the lib. So having tree-sitter-cli in the next fedora version would be awesome. Reviews (and PR for rust-tiny_http update) are sent. Upstream issue for missing license file: https://github.com/tree-sitter/tree-sitter/issues/1520 Andreas, do you want to have comaintainer access to the tree-sitter-cli packages? Best regards Andreas ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: rust: Request for packaging rust-html-escape and rust-smallbitvec
On Thursday, December 2, 2021 9:07:06 PM CET Aleksei Bavshin wrote: > `smallbitvec` deps are only needed for benchmark, so the test suite is > actually passing without these. Should be safe to drop with metadata patch. > > rust-tiny_http 0.8.2 also has a benchmark-only dependency `fdlimit` > which we can drop. > > The situation with tree-sitter-cli testsuite is complicated: it requires > a few other github repos with a grammar definitions and who knows what > else. I haven't succeeded in running it so far, so we can keep it turned > off. And that would make `rust-spin` update unnecessary. > > The draft packages are available from > https://copr.fedorainfracloud.org/coprs/alebastr/rust-tree-sitter-cli/; > seems working with available grammar files (with exception of > `build-wasm` and `playground` subcommands which require emscripten). This is great work, thank you very much. I didn't know that the tree-sitter- cli needs it own package and can't be built in the current tree-sitter package. So I will just continue to take care of tree-sitter and just build the lib. So having tree-sitter-cli in the next fedora version would be awesome. Best regards Andreas ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: rust: Request for packaging rust-html-escape and rust-smallbitvec
On Thu, Dec 2, 2021 at 9:07 PM Aleksei Bavshin wrote: > (snip) > > `smallbitvec` deps are only needed for benchmark, so the test suite is > actually passing without these. Should be safe to drop with metadata patch. > > rust-tiny_http 0.8.2 also has a benchmark-only dependency `fdlimit` > which we can drop. > > The situation with tree-sitter-cli testsuite is complicated: it requires > a few other github repos with a grammar definitions and who knows what > else. I haven't succeeded in running it so far, so we can keep it turned > off. And that would make `rust-spin` update unnecessary. > > The draft packages are available from > https://copr.fedorainfracloud.org/coprs/alebastr/rust-tree-sitter-cli/; > seems working with available grammar files (with exception of > `build-wasm` and `playground` subcommands which require emscripten). You're right, benchmark-only dev-dependencies can be safely dropped, because we don't build or run benchmarks during Fedora builds. That makes some problems easier. Disabling the test suite in tree-sitter-cli is fine. If published crates don't contain the files needed to run the tests, we don't run the tests. The only real "problem" I see is that none of the tree-sitter crates contain LICENSE files. So by publishing them to crates.io as they do, they don't comply with their own license terms. :) In such cases, it's a good idea to remind the upstream project to read the terms of the license they choose, and that they actually need to include the license text with redistributed sources ... Fabio ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: rust: Request for packaging rust-html-escape and rust-smallbitvec
On 12/2/21 09:56, Fabio Valentini wrote: On Wed, Dec 1, 2021 at 5:07 PM Andreas Schneider wrote: Hello, I would like to compile the tree-sitter parser generating tool. For this rust- html-escape and rust-smallbitvec is missing in the distro. It would allow that you can add additional languages for highlighting in neovim. If someone who is familiar with rust could packages those two small extensions, that would be really great! Hello! It turns out, it is not as simple as "just two small extensions". Packaging the html-escape crate is not a problem, it has no dependencies that are not already present in Fedora. smallbitvec has very outdated dependencies for running its test suite, so that has to be turned off. You also seem to have missed tiny_http 0.8.x, which is present in Fedora repos, but with a version that is too old (0.6.2). But the bigger problem will be tree-sitter-cli itself, which is split into multiple, separately-shipped Rust crates - so there's these additional dependencies to the two you assumed going into this endeavour: - tree-sitter-cli - tree-sitter - tree-sitter-config - tree-sitter-highlight - tree-sitter-loader - tree-sitter-tags Those will also have to be packaged. They don't have any dependencies that are not packaged for Fedora yet, but tree-sitter requires spin version 0.7.x, whereas we have spin 0.5.2 right now. This means, in total: - new package: rust-html-escape - new package: rust-smallbitvec - update package: rust-tiny_http to version 0.8.2 - new package: rust-tiny_http0.6 compat package - new package: rust-tree-sitter-cli - new package: rust-tree-sitter - new package: rust-tree-sitter-config - new package: rust-tree-sitter-highlight - new package: rust-tree-sitter-loader - new package: rust-tree-sitter-tags - update package: rust-spin to version 0.7.1 - new package: rust-spin0.5 compat package So, ten new packages, plus two updates, plus two new compat packages (unless I missed something - there might be more TODO items than those). Welcome to the Rust world! ;) `smallbitvec` deps are only needed for benchmark, so the test suite is actually passing without these. Should be safe to drop with metadata patch. rust-tiny_http 0.8.2 also has a benchmark-only dependency `fdlimit` which we can drop. The situation with tree-sitter-cli testsuite is complicated: it requires a few other github repos with a grammar definitions and who knows what else. I haven't succeeded in running it so far, so we can keep it turned off. And that would make `rust-spin` update unnecessary. The draft packages are available from https://copr.fedorainfracloud.org/coprs/alebastr/rust-tree-sitter-cli/; seems working with available grammar files (with exception of `build-wasm` and `playground` subcommands which require emscripten). The Rust SIG *can* help with this work, but I don't like committing the SIG (which has been mostly myself, for the past months) to more work maintaining ever more packages without a good reason. Fabio ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: rust: Request for packaging rust-html-escape and rust-smallbitvec
On Wed, Dec 1, 2021 at 5:07 PM Andreas Schneider wrote: > > Hello, > > I would like to compile the tree-sitter parser generating tool. For this rust- > html-escape and rust-smallbitvec is missing in the distro. It would allow that > you can add additional languages for highlighting in neovim. > > If someone who is familiar with rust could packages those two small > extensions, that would be really great! Hello! It turns out, it is not as simple as "just two small extensions". Packaging the html-escape crate is not a problem, it has no dependencies that are not already present in Fedora. smallbitvec has very outdated dependencies for running its test suite, so that has to be turned off. You also seem to have missed tiny_http 0.8.x, which is present in Fedora repos, but with a version that is too old (0.6.2). But the bigger problem will be tree-sitter-cli itself, which is split into multiple, separately-shipped Rust crates - so there's these additional dependencies to the two you assumed going into this endeavour: - tree-sitter-cli - tree-sitter - tree-sitter-config - tree-sitter-highlight - tree-sitter-loader - tree-sitter-tags Those will also have to be packaged. They don't have any dependencies that are not packaged for Fedora yet, but tree-sitter requires spin version 0.7.x, whereas we have spin 0.5.2 right now. This means, in total: - new package: rust-html-escape - new package: rust-smallbitvec - update package: rust-tiny_http to version 0.8.2 - new package: rust-tiny_http0.6 compat package - new package: rust-tree-sitter-cli - new package: rust-tree-sitter - new package: rust-tree-sitter-config - new package: rust-tree-sitter-highlight - new package: rust-tree-sitter-loader - new package: rust-tree-sitter-tags - update package: rust-spin to version 0.7.1 - new package: rust-spin0.5 compat package So, ten new packages, plus two updates, plus two new compat packages (unless I missed something - there might be more TODO items than those). Welcome to the Rust world! ;) The Rust SIG *can* help with this work, but I don't like committing the SIG (which has been mostly myself, for the past months) to more work maintaining ever more packages without a good reason. Fabio ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
rust: Request for packaging rust-html-escape and rust-smallbitvec
Hello, I would like to compile the tree-sitter parser generating tool. For this rust- html-escape and rust-smallbitvec is missing in the distro. It would allow that you can add additional languages for highlighting in neovim. If someone who is familiar with rust could packages those two small extensions, that would be really great! Thanks Andreas ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
