Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload
On 2015-06-29 02:24 AM, Lex Trotman wrote: On 29 June 2015 at 18:24, Thomas Martitz ku...@rockbox.org wrote: Am 29.06.2015 um 00:32 schrieb Lex Trotman: On 29 June 2015 at 07:41, Colomban Wendling lists@herbesfolles.org wrote: Le 26/06/2015 07:22, Thomas Martitz a écrit : […] However, as we entered string freeze, I don't suppose a new dialog like this is acceptable at this point? It would be really better not to indeed? What else can we do for *this* release? Hum. If this is an important enough issue, I can see these solutions: - Default to not keep history (hence prompt); - Add an extra hidden setting don't show this message again-like for a *future* dialog/infobar, so it still always asks unless the user manually changes this hidden setting. Both are suboptimal for this feature, but if it's a problem we can probably delay default enabling to the next cycle. Or just put a BIG notice in the release notes Reload is now undoable so it doesn't prompt any more That helps only existing users, and only that fraction that actually reads release notes (I would think the bulk of them doesn't). Well, yes, thats true, but it is something that can be done anyway, since it has no impact on code or strings or anything else :) Perhaps it would be indeed best to not toggle the default for this release already? PS: I do love this feature now that I'm aware of the undo'ability, it's not like I want to act against it. I just fear it creates user confusion for both new and existing users alike. Certainly it gave you a fright, and its admirable that you try to save others from it, but personally I think you are too worried. Not only it gave him fright, it lost him work because the change in behaviour is not common/obvious and lacks the visual queues needed to make one realize what has happened. Cheers, Matthew Brush ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload
On 29 June 2015 at 18:24, Thomas Martitz ku...@rockbox.org wrote: Am 29.06.2015 um 00:32 schrieb Lex Trotman: On 29 June 2015 at 07:41, Colomban Wendling lists@herbesfolles.org wrote: Le 26/06/2015 07:22, Thomas Martitz a écrit : […] However, as we entered string freeze, I don't suppose a new dialog like this is acceptable at this point? It would be really better not to indeed? What else can we do for *this* release? Hum. If this is an important enough issue, I can see these solutions: - Default to not keep history (hence prompt); - Add an extra hidden setting don't show this message again-like for a *future* dialog/infobar, so it still always asks unless the user manually changes this hidden setting. Both are suboptimal for this feature, but if it's a problem we can probably delay default enabling to the next cycle. Or just put a BIG notice in the release notes Reload is now undoable so it doesn't prompt any more That helps only existing users, and only that fraction that actually reads release notes (I would think the bulk of them doesn't). Well, yes, thats true, but it is something that can be done anyway, since it has no impact on code or strings or anything else :) Perhaps it would be indeed best to not toggle the default for this release already? PS: I do love this feature now that I'm aware of the undo'ability, it's not like I want to act against it. I just fear it creates user confusion for both new and existing users alike. Certainly it gave you a fright, and its admirable that you try to save others from it, but personally I think you are too worried. Cheers Lex Best regards ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Spawn module API
On 27.6.2015 г. 23:50, Lex Trotman wrote: On 28 June 2015 at 05:46, Dimitar Zhekovdimitar.zhe...@gmail.com wrote: On 27.6.2015 г. 04:40, Lex Trotman wrote: spawn_write_data This one looks platform independent, but it's actually very easy to create a stdin-write function that blocks under Windows... Better document it then :) from spawn.c:853: The @a stdin_cb may write to @c channel only once per invocation, only if @c G_IO_OUT is set, and only a non-zero number of characters. Though I haven't tested (or don't remember) whether writing more than 4K under Win~1 may block... If that's the case, your stdin_cb will better be identical to spawn_write_data. spawn_get_exit_status_callback I understood it as a convenient default callback, hardly worth not exporting it if everybody is going to define the same one-liner themselves. And I'm sure you will document it so nobody is confused :) and from spawn.c:853: Convinience @c GChildWatchFunc callback that copies the child exit status into a gint pointed by @a exit_status. It took me a considerable time to solve a seemingly simple task, so it would have been a shame not to document everything. :) -- E-gards: Jimmy ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload
Am 29.06.2015 um 00:32 schrieb Lex Trotman: On 29 June 2015 at 07:41, Colomban Wendling lists@herbesfolles.org wrote: Le 26/06/2015 07:22, Thomas Martitz a écrit : […] However, as we entered string freeze, I don't suppose a new dialog like this is acceptable at this point? It would be really better not to indeed? What else can we do for *this* release? Hum. If this is an important enough issue, I can see these solutions: - Default to not keep history (hence prompt); - Add an extra hidden setting don't show this message again-like for a *future* dialog/infobar, so it still always asks unless the user manually changes this hidden setting. Both are suboptimal for this feature, but if it's a problem we can probably delay default enabling to the next cycle. Or just put a BIG notice in the release notes Reload is now undoable so it doesn't prompt any more That helps only existing users, and only that fraction that actually reads release notes (I would think the bulk of them doesn't). Perhaps it would be indeed best to not toggle the default for this release already? PS: I do love this feature now that I'm aware of the undo'ability, it's not like I want to act against it. I just fear it creates user confusion for both new and existing users alike. Best regards ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
