Re: [Geany-Devel] [Test] Geany GTK3 Windows binaries for testing

[Enrico Tröger]

On 23/06/16 18:24, Colomban Wendling wrote:
> Hey!
> 
> Le 23/06/2016 à 17:28, Jiří Techet a écrit :
>> Hi Enrico,
>>
>> On Fri, Jun 17, 2016 at 2:00 AM, Enrico Tröger > > wrote:
>>
>> Hi all,
>>
>> in preparation of the upcoming release, I renewed the test installers:
>>
>> http://download.geany.org/snapshots/geany-1.28nightly20160617_setup.exe
>> 
>> http://download.geany.org/snapshots/geany-plugins-1.28nightly20160617_setup.exe
> 
> Nice!  Didn't test yet, but still nice.
> 
>> There is still the ugly Adwaita theme.
>> I didn't and I won't play with themes. If someone wants a specific
>> alternative theme included and enabled and there is some general
>> agreement, I'm fine with it.
> 
> Maybe we should just wait a little further, apparently in 3.22 (?) they
> work on some Windows theming and integration.
> 
>>
>> But I noticed a new bug:
>> with each start of Geany, the messages window will be shown a little
>> lower and at some point it is finally hidden because its position is at
>> or below the status bar.
>> No idea what is causing this, GTK3 is always surprising as it seems.
> 
> Hum, interesting, we did have such a report one day, but I never was
> able to find out what was doing it.
> https://sourceforge.net/p/geany/bugs/634/  But that was GTK2 and the
> other direction (editor shrinking).
> 
>> We should decide soon whether we want to use GTK2 or GTK3 based Windows
>> release binaries.
>>
>>
>> I would say that if there aren't any advantages of the GTK3 build (and
>> in contrary, there seem to be some issues), it's better to stick with GTK2.
> 
> Agreed, seems more reasonable to stick to something that works,
> especially if GTK3 doesn't give us something important.

IIRC the reason why we started playing with GTK3 on Windows was the
HiDPI issue with GTK2.

Though Jiří already said in March, it's probably not so important and
better to go with GTK2 as long as there are issues with GTK3.

So, I'd say also let's use GTK2 for the upcoming release and we'll say
what happens post-1.28.

GTK2 test installers will follow either later today or at the weekend.

Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.asc



signature.asc
Description: OpenPGP digital signature
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel

Re: [Geany-Devel] [Test] Geany GTK3 Windows binaries for testing

[Colomban Wendling]

Hey!

Le 23/06/2016 à 17:28, Jiří Techet a écrit :
> Hi Enrico,
> 
> On Fri, Jun 17, 2016 at 2:00 AM, Enrico Tröger  > wrote:
> 
> Hi all,
> 
> in preparation of the upcoming release, I renewed the test installers:
> 
> http://download.geany.org/snapshots/geany-1.28nightly20160617_setup.exe
> 
> http://download.geany.org/snapshots/geany-plugins-1.28nightly20160617_setup.exe

Nice!  Didn't test yet, but still nice.

> There is still the ugly Adwaita theme.
> I didn't and I won't play with themes. If someone wants a specific
> alternative theme included and enabled and there is some general
> agreement, I'm fine with it.

Maybe we should just wait a little further, apparently in 3.22 (?) they
work on some Windows theming and integration.

> 
> But I noticed a new bug:
> with each start of Geany, the messages window will be shown a little
> lower and at some point it is finally hidden because its position is at
> or below the status bar.
> No idea what is causing this, GTK3 is always surprising as it seems.

Hum, interesting, we did have such a report one day, but I never was
able to find out what was doing it.
https://sourceforge.net/p/geany/bugs/634/  But that was GTK2 and the
other direction (editor shrinking).

> We should decide soon whether we want to use GTK2 or GTK3 based Windows
> release binaries.
> 
> 
> I would say that if there aren't any advantages of the GTK3 build (and
> in contrary, there seem to be some issues), it's better to stick with GTK2.

Agreed, seems more reasonable to stick to something that works,
especially if GTK3 doesn't give us something important.

Cheers,
Colomban
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel

Re: [Geany-Devel] Two unmerged PRs on github

[Lex Trotman]

Patience, the Geany project is entirely run by volunteers.  One week
means only one weekend, and maybe they went to the beach instead of
slaving over a hot computer screen.  I understand some people have a
life :)

LGBI means "by inspection", that means the commenter has only looked
at it and hasn't tested it.  Neither of these appears to be an urgent
change, and there are other important issues to address.

Nothing needs to "happen" just that someone needs to spend some of
their formerly free time to test them (#1071 has a volunteer) and
commit them.

Cheers
Lex

On 23 June 2016 at 19:05, Erik de Castro Lopo  wrote:
> Hi all,
>
> I submitted two PRs on github:
>
> https://github.com/geany/geany/pull/1071
> https://github.com/geany/geany/pull/1074
>
> They seem to have both been approved in principle but remain un-merged
> after a week.
>
> Is this normal for relatively trivial PRs like this? What needs to happen
> to get these merged?
>
> Erik
> --
> --
> Erik de Castro Lopo
> http://www.mega-nerd.com/
> ___
> Devel mailing list
> Devel@lists.geany.org
> https://lists.geany.org/cgi-bin/mailman/listinfo/devel
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel

[Geany-Devel] Two unmerged PRs on github

[Erik de Castro Lopo]

Hi all,

I submitted two PRs on github:

https://github.com/geany/geany/pull/1071
https://github.com/geany/geany/pull/1074

They seem to have both been approved in principle but remain un-merged
after a week.

Is this normal for relatively trivial PRs like this? What needs to happen
to get these merged?

Erik
-- 
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel