Re: [Geany-Devel] geany and geany-pluigins standalone installation
Hi, Thank you. The problem was that I used the latest Geany master branch and b4n:pairtaghighligher/less-deprecated branch, which was incompatible. After downloading fresh geany-plugins master and cherry-picking the single change everything was built successfully. On 11 March 2016 at 19:52, Colomban Wendling <lists@herbesfolles.org> wrote: > Hi, > > Le 11/03/2016 18:40, Volodymyr Kononenko a écrit : > > Hi folks, > > > > I am trying to build PairTagHighlighter to verify PR > > https://github.com/geany/geany-plugins/pull/359 > > > > But I am getting undefined references to all Scintilla functions: > > CCLD pairtaghighlighter.la <http://pairtaghighlighter.la> > > .libs/pair_tag_highlighter.o: In function `findBracket': > > > /home/kononenv/devel/geany-plugins/pairtaghighlighter/src/pair_tag_highlighter.c:85: > > undefined reference to `sci_get_char_at' > > […] > > > > The way how I build Geany: > > > > * ./autogen.sh > > * ./configure --prefix= > > * make > > * make install > > Which version of Geany? It looks like you'd be building a relatively > old one, and a recent version of Geany-Plugins or something like this. > > > The way how I build geany-plugins: > > > > * export PKG_CONFIG_PATH=/lib/pkgconfig > > * ./configure --prefix= > > --with-geany-libdir=/lib --disable-addons > > --disable-autoclose --disable-automark --disable-codenav > > --disable-commander --disable-debugger --disable-defineformat > > --disable-devhelp --disable-geanyctags --disable-geanydoc > > --disable-geanyextrasel --disable-geanygendoc > > --disable-geanyinsertnum --disable-geanylatex --disable-geanylipsum > > --disable-geanylua --disable-geanymacro --disable-geanyminiscript > > --disable-geanynumberedbookmarks --disable-geanyprj > > --disable-geanypy --disable-geanysendmail --disable-geanyvc > > --disable-geanypg --disable-largefile --disable-geniuspaste > > --disable-gitchangebar --disable-lineoperations --disable-markdown > > --disable-multiterm --disable-overview --disable-pohelper > > --disable-pretty_printer --disable-projectorganizer --disable-scope > > --disable-shiftcolumn --disable-spellcheck --disable-treebrowser > > --disable-tableconvert --disable-updatechecker --disable-webhelper > > --disable-xmlsnippets > > You could use --disable-all-plugins --enable-pairtaghighlighter to avoid > having to list all --disable options ;) > > > Please suggest, how to make standalone installation in a proper way. > > Your way looks good, and all I can imagine is trying to build against an > old version of Geany not using libgeany and a recent enough version of > GP with > > https://github.com/geany/geany-plugins/commit/25e3c8851a5113423ce16a6b80085925ebac2e13 > applied. > > Regards, > Colomban > ___ > Devel mailing list > Devel@lists.geany.org > https://lists.geany.org/cgi-bin/mailman/listinfo/devel > -- Best regards, Volodymyr Kononenko http://kononenko.ws ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
[Geany-Devel] geany and geany-pluigins standalone installation
Hi folks, I am trying to build PairTagHighlighter to verify PR https://github.com/geany/geany-plugins/pull/359 But I am getting undefined references to all Scintilla functions: CCLD pairtaghighlighter.la .libs/pair_tag_highlighter.o: In function `findBracket': /home/kononenv/devel/geany-plugins/pairtaghighlighter/src/pair_tag_highlighter.c:85: undefined reference to `sci_get_char_at' /home/kononenv/devel/geany-plugins/pairtaghighlighter/src/pair_tag_highlighter.c:86: undefined reference to `sci_get_char_at' /home/kononenv/devel/geany-plugins/pairtaghighlighter/src/pair_tag_highlighter.c:87: undefined reference to `sci_get_char_at' /home/kononenv/devel/geany-plugins/pairtaghighlighter/src/pair_tag_highlighter.c:57: undefined reference to `sci_get_char_at' /home/kononenv/devel/geany-plugins/pairtaghighlighter/src/pair_tag_highlighter.c:58: undefined reference to `sci_get_char_at' .libs/pair_tag_highlighter.o:/home/kononenv/devel/geany-plugins/pairtaghighlighter/src/pair_tag_highlighter.c:59: more undefined references to `sci_get_char_at' follow .libs/pair_tag_highlighter.o: In function `clear_previous_highlighting': /home/kononenv/devel/geany-plugins/pairtaghighlighter/src/pair_tag_highlighter.c:152: undefined reference to `scintilla_send_message' .libs/pair_tag_highlighter.o: In function `highlight_tag': /home/kononenv/devel/geany-plugins/pairtaghighlighter/src/pair_tag_highlighter.c:131: undefined reference to `scintilla_send_message' /home/kononenv/devel/geany-plugins/pairtaghighlighter/src/pair_tag_highlighter.c:132: undefined reference to `scintilla_send_message' /home/kononenv/devel/geany-plugins/pairtaghighlighter/src/pair_tag_highlighter.c:134: undefined reference to `scintilla_send_message' /home/kononenv/devel/geany-plugins/pairtaghighlighter/src/pair_tag_highlighter.c:135: undefined reference to `scintilla_send_message' and etc. etc. The way how I build Geany: - ./autogen.sh - ./configure --prefix= - make - make install The way how I build geany-plugins: - export PKG_CONFIG_PATH=/lib/pkgconfig - ./configure --prefix= --with-geany-libdir=/lib --disable-addons --disable-autoclose --disable-automark --disable-codenav --disable-commander --disable-debugger --disable-defineformat --disable-devhelp --disable-geanyctags --disable-geanydoc --disable-geanyextrasel --disable-geanygendoc --disable-geanyinsertnum --disable-geanylatex --disable-geanylipsum --disable-geanylua --disable-geanymacro --disable-geanyminiscript --disable-geanynumberedbookmarks --disable-geanyprj --disable-geanypy --disable-geanysendmail --disable-geanyvc --disable-geanypg --disable-largefile --disable-geniuspaste --disable-gitchangebar --disable-lineoperations --disable-markdown --disable-multiterm --disable-overview --disable-pohelper --disable-pretty_printer --disable-projectorganizer --disable-scope --disable-shiftcolumn --disable-spellcheck --disable-treebrowser --disable-tableconvert --disable-updatechecker --disable-webhelper --disable-xmlsnippets Please suggest, how to make standalone installation in a proper way. Thank you! -- Best regards, Volodymyr Kononenko http://kononenko.ws ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] PairTagHighlighter / Not auto clear previous highlight when click other tag
Lex, Thank for exhaustive answer! A search with git bisect has shown, that the bug was introduced with updating Scintilla to 3.3.2: kvm@dell-e6220 /mnt/doc/devel/geany/geany $ git bisect good f5588043b7e6bbd9dff5ac37eb37b00a503d192a is the first bad commit commit f5588043b7e6bbd9dff5ac37eb37b00a503d192a Author: Colomban Wendling b...@herbesfolles.org Date: Wed May 22 03:23:57 2013 +0200 Update Scintilla to version 3.3.2 Similar issue http://sourceforge.net/p/scintilla/bugs/1604/ I've found on Scintilla bug tracker was fixed only for win32 - here is the patch http://sourceforge.net/p/scintilla/code/ci/23f89aef53c7ab73bdd45ae1302b97698682e3cd . I tried to detect the first Scintilla commit, which introduced the issue, but I see that merging Scintilla to Geany sources is non-trivial. Build failed after the first attempt. Folks, what do you think about it? Is it enough information that it is Scintilla issue and we need to report it or something was not taken into account during upgrading to 3.3.2? On 8 March 2015 at 23:42, Lex Trotman ele...@gmail.com wrote: cd /somedirectory mkdir geany cd geany git clone https://github.com/geany/geany.git cd geany git checkout the_version_you_want ./autogen.sh --prefix=/somedirectory/geany make install cd ../bin ./geany -c ../config gives a version of geany completely independent of your system geany for plugins cd /somedirectory/geany git clone https://github.com/geany/geany-plugins.git cd geany-plugins ./autogen.sh --prefix=/somedirectory/geany --with-geany-libdir=/somedirectory/geany/lib make install cd ../bin ./geany -c ../config and you have the plugins. Note there is no sudo in the above so you can't touch the system install by accident. For further information see the HACKING file. Cheers Lex On 9 March 2015 at 04:36, Volodymyr Kononenko vmkonone...@gmail.com wrote: Hi all, I have received several bugreports about PairTagHighlighter plugin. The subject is described on Github. While debugging I see that plugin is trying to clear highlighting on appropriate ranges, but nothing happens after SCI_INDICATORCLEARRANGE. BTW, I've checked, that clearing range is called for the correct indicator. The issue is not reproducible on 1.23.1, while on 1.24.1 it has stable reproducibility. I've found the issue in Scintilla, which I suppose is related to subject. This issue was fixed in Scintilla after 3.4.2. In Geany codebase Scintilla was updated to 3.4.4 with 46affaf commit. I want to check if the issue is reproducible on this revision and one revision before. Please, tell me how to build a certain version of Geany and plugin for it, because my playing with --with-geany-libdir and --prefix was unsuccessful. If you have another ideas why the issue could happen, please let me know. Thanks in advance! -- Best regards, Volodymyr Kononenko http://kononenko.ws ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel -- Best regards, Volodymyr Kononenko http://kononenko.ws ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] PairTagHighlighter / Not auto clear previous highlight when click other tag
Colomban, Really my fault ( Thanks a lot for participation and detecting root cause! I've tested your patch, it fixes the issue. Thanks again! P.S. The only question, when the new version of geany-plugins is planned to be released? On 9 March 2015 at 18:19, Colomban Wendling lists@herbesfolles.org wrote: Hi, tl;dr: I found the issue in the end, which is in a call from the plugin. Here below is my train of responses because they still are of some interest, but you can skip directly to the last paragraph. Le 09/03/2015 14:48, Volodymyr Kononenko a écrit : A search with git bisect has shown, that the bug was introduced with updating Scintilla to 3.3.2: […] Similar issue http://sourceforge.net/p/scintilla/bugs/1604/ I've found on Scintilla bug tracker was fixed only for win32 - here is the patch http://sourceforge.net/p/scintilla/code/ci/23f89aef53c7ab73bdd45ae1302b97698682e3cd . I highly doubt it's anything like the same issue, because the one described here is a redraw issue, which should get fixed when triggering another redraw, like e.g. scrolling the offending part offscreen and back, while the issues I see with pairtaghighlighter persist after redraws (which means the indicators themselves are still here). Moreover, clearing the indicators on the whole buffer: scintilla_send_message(sci, SCI_INDICATORCLEARRANGE, 0, sci_get_length(sci)); instead of only the range passed to the function fixes the issue for me, so I would really bet on inappropriate clear range. Which is indeed kind of weird because it really does work with 1.23 and not 1.24, even with the very same plugin .so. I tried to detect the first Scintilla commit, which introduced the issue, but I see that merging Scintilla to Geany sources is non-trivial. Build failed after the first attempt. Folks, what do you think about it? Is it enough information that it is Scintilla issue and we need to report it or something was not taken into account during upgrading to 3.3.2? Actually it's the plugin's SCI_INDICATORCLEARRANGE http://www.scintilla.org/ScintillaDoc.html#SCI_INDICATORCLEARRANGE that is incorrect: the second parameter should be the *length* to clear, not the end position. Apparently earlier Scintilla versions were forgiving on the range, but new ones aren't and do nothing with invalid ranges. I made you a PR fixing the issue: https://github.com/geany/geany-plugins/pull/200 Regards, Colomban ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel -- Best regards, Volodymyr Kononenko http://kononenko.ws ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] PairTagHighlighter / Not auto clear previous highlight when click other tag
Thanks Frank! On 9 March 2015 at 22:37, Frank Lanitz fr...@frank.uvena.de wrote: Am 09.03.2015 um 17:40 schrieb Volodymyr Kononenko: Thanks a lot for participation and detecting root cause! I've tested your patch, it fixes the issue. Just merged the PR. Cheers, Frank ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel -- Best regards, Volodymyr Kononenko http://kononenko.ws ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] [ANN] Geany 1.24 is out!
Yep, thank you :) On 14 April 2014 12:07, Frank Lanitz fr...@frank.uvena.de wrote: Am 14.04.2014 07:10, schrieb Lex Trotman: On 14 April 2014 15:01, Volodymyr Kononenko vmkonone...@gmail.com wrote: Congratz to everyone! New plugin pairtaghighlighter is not mentioned in release notes. It is part of geany-plugins, not geany. And has been annonced there quiet prominent ;) Cheers, Frank ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel -- Best regards, Volodymyr Kononenko http://kononenko.ws ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] [ANN] Geany 1.24 is out!
Congratz to everyone! New plugin pairtaghighlighter is not mentioned in release notes. On 13 April 2014 19:59, Colomban Wendling lists@herbesfolles.orgwrote: After a long delay, we are finally happy to announce a new release of Geany! For a comprehensive list of changes please see: http://www.geany.org/Documentation/ReleaseNotes Some highlights: * Fix spawning commands with spaces on Windows. * Fix infinite pagination when printing on Windows. * Fix bulk Search Replace not to match replacements. * Update Scintilla to 3.3.6. * Add experimental GTK3 support. * Lots of improvements to PHP and Fortran symbols parsing. * Add filetypes Clojure, CUDA, Batch, Graphviz, PowerShell and Rust. * Update translations: ca, cs, de, es, eu, fr, gl, he, hu, it, kk, lt, nl, pt, ru, sk, sl, sv, tr, zh_CN, zh_TW. We want to thank all developers, translators and everyone who contributed to this release with patches, feedback, bug reports and so on. Thank you! As usual, all downloads can be found on http://download.geany.org/. - Colomban ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel -- Best regards, Volodymyr Kononenko http://kononenko.ws ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
[Geany-Devel] Plugin nightly builds
Hi all, Is there any possibility to download separate plugin from nightly builds or somewhere else? I need 32-bit version of pairtaghighlighter, people in comments asked - http://kononenko.ws/en/blog/2013-06-06/pairtaghighlighter_for_geany_1.23 Thanks in advance! -- Best regards, Volodymyr Kononenko http://kononenko.ws ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Plugin nightly builds
Thank you! On 22 February 2014 00:33, Frodox fro...@zoho.com wrote: On Sat, 22 Feb 2014 00:24:02 +0200 Volodymyr Kononenko vmkonone...@gmail.com wrote: Could you suggest how to do it with Geany build system? I think smth like $ ./configure CC='gcc -m32' CFLAGS=-m32 should do the trick. But you should also have 32bit version of necessary libs. ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel -- Best regards, Volodymyr Kononenko http://kononenko.ws ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
[Geany-Devel] Mistake in utils_invert_color
Hi all!
While playing with colors for pairtaghighlighter plugin, I saw that
Scintilla is using BGR instead of normal RGB. I found existing code in
Geany source to use it in my plugin.
utils_invert_color from utils.c deals with replacing blue with red, but
with mistake.
Below are results of my testing with random color:
11001100 10011001 - input color
10011001 11001100 - result of my function (rgb2bgr)
00110011 01100110 - result of utils_invert_color
A little source file is attached.
If it is really mistake (maybe I don't know something), I will do commit
and pull request.
Any comments about this?
--
Best regards,
Volodymyr Kononenko
http://kononenko.ws
#include stdio.h
int rgb2bgr(int color)
{
int r, g, b;
r = color 16;
g = (0x00ff00 color) 8;
b = (0xff color);
color = (r | (g 8) | (b 16));
return color;
}
int utils_invert_color(int color)
{
int r, g, b;
r = 0xff - color;
g = 0xff - (color 8);
b = 0xff - (color 16);
return (r | (g 8) | (b 16));
}
void print_bin(int n)
{
int i;
for (i=1; i=24; i++)
{
(n (123)) == 0x80 ? printf(1) : printf(0);
if((0 == i%8) (0 != i))
printf( );
n = n 1;
}
printf(\n);
}
int main(void)
{
int color = 0xffcc99;
print_bin(color);
print_bin(rgb2bgr(color));
print_bin(utils_invert_color(color));
}
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Mistake in utils_invert_color
Ok. Now I've found an appropriate one - rotate_rgb. False alarm, thanks :) On 30 October 2013 23:03, Colomban Wendling lists@herbesfolles.orgwrote: Hi, Le 30/10/2013 21:10, Volodymyr Kononenko a écrit : While playing with colors for pairtaghighlighter plugin, I saw that Scintilla is using BGR instead of normal RGB. I found existing code in Geany source to use it in my plugin. utils_invert_color from utils.c deals with replacing blue with red, but with mistake. Below are results of my testing with random color: 11001100 10011001 - input color 10011001 11001100 - result of my function (rgb2bgr) 00110011 01100110 - result of utils_invert_color utils_invert_color() *inverts* a color, it doesn't transform RGB to BGR or something. It's used e.g. in the invert syntax highlighting colors feature. It's basically the C ~ operator. And if you expect this, you'll see it works just fine: 1 becomes 0 and 0 becomes 1. Not sure why we don't simply do ((~color) 0xff), but that's just an implementation detail. -- Best regards, Volodymyr Kononenko http://kononenko.ws ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Geany Version Matrix
Very useful table. I was searching such a one during development PairTagHighlighter and found similar table here: http://wiki.geany.org/plugins/development/api-versions IMHO it is better to remove the old one or to move your table to the old page (because it is already indexed by search engines). 2013/4/7 Matthew Brush mbr...@codebrainz.ca Hi, I made a table for Geany versions mapping to API, ABI, GLIB, GTK, and Scintilla versions at each release of Geany. I put it on the wiki: https://wiki.geany.org/**plugins/version_matrixhttps://wiki.geany.org/plugins/version_matrix I hope plugin developers might find this useful. Cheers, Matthew Brush __**_ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-**bin/mailman/listinfo/develhttps://lists.geany.org/cgi-bin/mailman/listinfo/devel -- Best regards, Volodymyr Kononenko http://kononenko.ws ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Find/highlight matching opening/closing HTML tag
Hi all. Yesterday Colomban made the first code review: https://github.com/geany/geany-plugins/pull/98 There are questions about using indicator. Experts in indicators, please help! Suggest exact and correct usage in my code. Thanks in advance for your help :) 2013/4/3 Volodymyr Kononenko vmkonone...@gmail.com I've made pull request: https://github.com/geany/geany-plugins/pull/98 After a short discussion on IRC channel I finally decided to make a single commit. If somebody is interested in git history, the separate plugin repo is here: https://github.com/vmkononenko/pair-tag-highlighter Please, review the pull request. 2013/4/2 Volodymyr Kononenko vmkonone...@gmail.com Hi all, I have implemented the functionality in a form of plugin, as it was suggested by Lex. The source code is available on Github: https://github.com/vmkononenko/pair-tag-highlighter I've played with several HTML files and it seems to work properly. A bit more playing with code is needed for XML support. Quick testing showed, that in some cases it does not work. To install plugin, run make make install. It may be needed to edit Makefile depending on your OS and arch. Suggestion and bugreports are welcome. After discussion in mailing list I will follow guidelines at http://www.geany.org/manual/reference/guidelines.html regarding adding plugin to main geany-plugins repository. -- Best regards, Volodymyr Kononenko http://kononenko.ws ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
