[Geany-Devel] Two unmerged PRs on github

2016-06-23 Thread Erik de Castro Lopo
Hi all,

I submitted two PRs on github:

https://github.com/geany/geany/pull/1071
https://github.com/geany/geany/pull/1074

They seem to have both been approved in principle but remain un-merged
after a week.

Is this normal for relatively trivial PRs like this? What needs to happen
to get these merged?

Erik
-- 
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel


Re: [Geany-Devel] Two unmerged PRs on github

2016-06-23 Thread Lex Trotman
Patience, the Geany project is entirely run by volunteers.  One week
means only one weekend, and maybe they went to the beach instead of
slaving over a hot computer screen.  I understand some people have a
life :)

LGBI means "by inspection", that means the commenter has only looked
at it and hasn't tested it.  Neither of these appears to be an urgent
change, and there are other important issues to address.

Nothing needs to "happen" just that someone needs to spend some of
their formerly free time to test them (#1071 has a volunteer) and
commit them.

Cheers
Lex

On 23 June 2016 at 19:05, Erik de Castro Lopo  wrote:
> Hi all,
>
> I submitted two PRs on github:
>
> https://github.com/geany/geany/pull/1071
> https://github.com/geany/geany/pull/1074
>
> They seem to have both been approved in principle but remain un-merged
> after a week.
>
> Is this normal for relatively trivial PRs like this? What needs to happen
> to get these merged?
>
> Erik
> --
> --
> Erik de Castro Lopo
> http://www.mega-nerd.com/
> ___
> Devel mailing list
> Devel@lists.geany.org
> https://lists.geany.org/cgi-bin/mailman/listinfo/devel
___
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel