Re: [Geany-Devel] Gaeny-plugins: Some minor changes to silence warnings
Am 19.02.2013 22:22, schrieb Lex Trotman: Additional patch to treebrowser.c make sure every path leading to a g_free has a g_strdup(), oops. Note I am only using the HACKING approved -Wall -Wextra -O2 -Wno-unused-parameter not the full War and Peace novel of options that Colomban uses :) Did somebody apply the patches? I went lost inside the many channels of communication ;) Cheers, Frank ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Gaeny-plugins: Some minor changes to silence warnings
On 4 March 2013 19:41, Frank Lanitz fr...@frank.uvena.de wrote: Am 19.02.2013 22:22, schrieb Lex Trotman: Additional patch to treebrowser.c make sure every path leading to a g_free has a g_strdup(), oops. Note I am only using the HACKING approved -Wall -Wextra -O2 -Wno-unused-parameter not the full War and Peace novel of options that Colomban uses :) Did somebody apply the patches? I went lost inside the many channels of communication ;) Hi Frank, I don't see them in any of the G-P commits since 17 Feb when I posted. So I'd say no. Cheers Lex Cheers, Frank ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Gaeny-plugins: Some minor changes to silence warnings
Le 04/03/2013 14:43, Frank Lanitz a écrit : Am 04.03.2013 10:23, schrieb Lex Trotman: On 4 March 2013 19:41, Frank Lanitz fr...@frank.uvena.de wrote: Am 19.02.2013 22:22, schrieb Lex Trotman: Additional patch to treebrowser.c make sure every path leading to a g_free has a g_strdup(), oops. Note I am only using the HACKING approved -Wall -Wextra -O2 -Wno-unused-parameter not the full War and Peace novel of options that Colomban uses :) Did somebody apply the patches? I went lost inside the many channels of communication ;) Hi Frank, I don't see them in any of the G-P commits since 17 Feb when I posted. So I'd say no. OK. so what to do? Just merging it as none of the maintainer seems to have shown any reaction. I'll check it and merge it later totady. Colomban ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Gaeny-plugins: Some minor changes to silence warnings
Le 04/03/2013 16:33, Colomban Wendling a écrit : Le 04/03/2013 14:43, Frank Lanitz a écrit : Am 04.03.2013 10:23, schrieb Lex Trotman: On 4 March 2013 19:41, Frank Lanitz fr...@frank.uvena.de wrote: Am 19.02.2013 22:22, schrieb Lex Trotman: Additional patch to treebrowser.c make sure every path leading to a g_free has a g_strdup(), oops. Note I am only using the HACKING approved -Wall -Wextra -O2 -Wno-unused-parameter not the full War and Peace novel of options that Colomban uses :) Did somebody apply the patches? I went lost inside the many channels of communication ;) Hi Frank, I don't see them in any of the G-P commits since 17 Feb when I posted. So I'd say no. OK. so what to do? Just merging it as none of the maintainer seems to have shown any reaction. I'll check it and merge it later totady. Done. It was mostly OK but introduced a leak, so I fixed that. I also fixed various other problems in TreeBrowser. However, it's till buggy like if you create an element in the root of the display the list gets messed up. I think calling gtk_tree_store_iter_clear_nodes()[1] unconditionally in treebrowser_browse() would fix the problem but since I don't know the plugin much I won't do this. Regards, Colomban [1] it is a *really* bad idea to name a custom function using a lib's prefix: it may clash and makes people assume it's a function from that lib. Colomban ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Gaeny-plugins: Some minor changes to silence warnings
Am 17.02.2013 04:09, schrieb Lex Trotman: Attached is a patch containing a few obvious fixes for warnings in the plugins, mostly adding consts, gpointer casts and unsigned int loop counters. The only one that is likely to have been bad (tm) is in treebrowser.c it g_freed a static string. Setting the string const found that. treebrowser.c still has warnings about two unused variables, since in each case some work is done to set them, the treebrowser maintainer should look and see if they are meant to be used somewhere, or remove them and the setting code. I had a short look and think we can apply it. At least I didn't see anything which is likely to fail. Cheers, Frank ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Gaeny-plugins: Some minor changes to silence warnings
Le 19/02/2013 13:22, Frank Lanitz a écrit : Am 17.02.2013 04:09, schrieb Lex Trotman: Attached is a patch containing a few obvious fixes for warnings in the plugins, mostly adding consts, gpointer casts and unsigned int loop counters. The only one that is likely to have been bad (tm) is in treebrowser.c it g_freed a static string. Setting the string const found that. treebrowser.c still has warnings about two unused variables, since in each case some work is done to set them, the treebrowser maintainer should look and see if they are meant to be used somewhere, or remove them and the setting code. I had a short look and think we can apply it. At least I didn't see anything which is likely to fail. I didn't test it, but agree that the diff looks fine. Cheers, Colomban ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Re: [Geany-Devel] Gaeny-plugins: Some minor changes to silence warnings
Additional patch to treebrowser.c make sure every path leading to a g_free has a g_strdup(), oops. Note I am only using the HACKING approved -Wall -Wextra -O2 -Wno-unused-parameter not the full War and Peace novel of options that Colomban uses :) Cheers Lex On 20 February 2013 00:31, Colomban Wendling lists@herbesfolles.org wrote: Le 19/02/2013 13:22, Frank Lanitz a écrit : Am 17.02.2013 04:09, schrieb Lex Trotman: Attached is a patch containing a few obvious fixes for warnings in the plugins, mostly adding consts, gpointer casts and unsigned int loop counters. The only one that is likely to have been bad (tm) is in treebrowser.c it g_freed a static string. Setting the string const found that. treebrowser.c still has warnings about two unused variables, since in each case some work is done to set them, the treebrowser maintainer should look and see if they are meant to be used somewhere, or remove them and the setting code. I had a short look and think we can apply it. At least I didn't see anything which is likely to fail. I didn't test it, but agree that the diff looks fine. Cheers, Colomban ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel warning2.patch Description: Binary data ___ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
