On Thu, Mar 05, 2009 at 04:49:37PM +0100, Holger Levsen wrote:
> Would you like to (co-)maintain the package in Debian? I'd be happy to
> sponsor uploads and/or co-maintain.
I guess so, but I don't know what that requires.
> Comments on files I looked at so far:
>
> control:
> Standards-Version should be upgraded to 3.8.0 (after checking)
I don't know how to check.
> long description is too short (you wrote more in the mail I'm replying
> to :)
Fixed. See patch attached.
> misses homepage: and vcs-pseudoheaders
Fixed homepage, don't understand vcs-pseudoheaders.
> copyright:
> misses copyright owner
> misses download location
> misses short GPL blurbs
> (see
> http://lists.debian.org/debian-devel-announce/2006/03/msg00023.html)
> mentions GPL but links to GPL-2
Fixed.
> README.Debian
> unneeded with current content (see above)
Replaced with different content.
> changelog:
> version number should rather be something like 0.1.1.git20090304-1
Left as is, until you join in.
> we should file an ITP bug, so we can close it here ;) (rather to tell
> others about out intentions to put this software into Debian)
Don't know how to do that.
> postrm+postinst:
> unconditionally ending with "exit 0" looks wrong
Okay. 107 of 1051 packages on my system
/var/lib/dpkg/info/*.postinst ended with "exit 0". Should the package
fail to install if update-rc.d fails?
> are those files needed at all? I mean, shouldnt debhelper/cdbs create
> them,
> if they contain autogenerated code only?
Don't know.
> rules:
> simple-patchsys.mk is unused, and if, I'd prefer patchsys-quilt.mk
Don't know.
> Do you have a vcs where you maintain this?
Created just now.
git clone http://dev.laptop.org/~quozl/ohm.git/
--
James Cameronmailto:qu...@us.netrek.org http://quozl.netrek.org/
diff --git a/debian/README.Debian b/debian/README.Debian
index aa31ee0..1614f1f 100644
--- a/debian/README.Debian
+++ b/debian/README.Debian
@@ -1,7 +1,16 @@
-README for Debian-style packaging of ohmd
+README for Debian packaging of ohmd
by James Cameron
-This package was built from source downloaded using
-git clone git+ssh://qu...@dev.laptop.org/git/projects/ohm
+- receives and generates D-Bus events,
- -- James Cameron , Wed, 4 Mar 2009 15:22:10 +1100
+- maintains a connection to the X server using an .Xauthority file in
+ /home/olpc or /root ... without this the detection of keyboard and
+ mouse idle is not performed,
+
+- directly uses /sys entries specific to the OLPC XO-1,
+
+- with gnome-power-manager installed the user will see a power dialog
+ in response to a power button press, often after the XO has been
+ woken from suspend.
+
+ -- James Cameron , Mon, 9 Mar 2009 20:11:51 +1100
diff --git a/debian/changelog b/debian/changelog
index e49f532..5cbfc50 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,8 +1,13 @@
ohmd (0.1.1-6.21.20090304git.quozl-1) unstable; urgency=low
* start ohmd on install
+ * start ohmd after hald (fixes a segfault)
+ * add homepage
+ * fix copyright
+ * fix build dependencies for Lenny, tested in a pbuilder
+ * add a brief system description to README.Debian
- -- James Cameron Fri, 06 Mar 2009 11:44:22 +1100
+ -- James Cameron Mon, 09 Mar 2009 20:43:51 +1100
ohmd (0.1.1-6.21.20090304git.quozl) unstable; urgency=low
diff --git a/debian/control b/debian/control
index 690f129..ea32096 100644
--- a/debian/control
+++ b/debian/control
@@ -2,11 +2,14 @@ Source: ohmd
Maintainer: James Cameron
Section: unknown
Priority: optional
-Build-Depends: debhelper (>= 4.2.32), gtk-doc-tools, libhal-dev
+Build-Depends: debhelper (>= 4.2.32), cdbs, gtk-doc-tools, libhal-dev, libglib2.0-dev, libdbus-glib-1-dev, libgtk2.0-dev
Standards-Version: 3.7.3
Package: ohmd
Architecture: any
Depends: ${shlibs:Depends}
Description: Open Hardware Manager, for OLPC XO-1 Laptops
- Provides suspend on lid close, and suspend on idle.
+ For OLPC XO-1 laptops, provides suspend on power button press,
+ suspend on lid close, display dimming on idle, and suspend on
+ extended idle.
+Homepage: http://ohm.freedesktop.org/
diff --git a/debian/copyright b/debian/copyright
index a9a6903..237b7a3 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -1,4 +1,35 @@
-Copyright: GPL
+This package was debianised by James Cameron on
+2009-03-09.
-On Debian and Ubuntu GNU/Linux systems, the complete text of the GNU General
-Public License can be found in `/usr/share/common-licenses/GPL-2'.
+The current Debian maintainer is YOUR NAME
+
+It was downloaded from:
+
+git clone git+ssh://qu...@dev.laptop.org/git/projects/ohm
+
+/*
+ * Copyright (C) 2007 Richard Hughes
+ *
+ * Licensed under the GNU Lesser General Public License Version 2
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * Licen
