Re: [PATCH 03/12] meson: record which other options are a pre-requisite

2024-05-07 Thread Peter Krempa
On Tue, May 07, 2024 at 14:58:58 +0100, Daniel P. Berrangé wrote:
> Several meson options cannot be enabled, without first enabling another
> option. This adds a small comment prior to an optino to record its

s/optino/option/

> mandatory dependencies.
> 
> Signed-off-by: Daniel P. Berrangé 
> ---
>  meson_options.txt | 20 
>  1 file changed, 20 insertions(+)
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org


[PATCH 03/12] meson: record which other options are a pre-requisite

2024-05-07 Thread Daniel P . Berrangé
Several meson options cannot be enabled, without first enabling another
option. This adds a small comment prior to an optino to record its
mandatory dependencies.

Signed-off-by: Daniel P. Berrangé 
---
 meson_options.txt | 20 
 1 file changed, 20 insertions(+)

diff --git a/meson_options.txt b/meson_options.txt
index ed91d97abf..9d729b3e1f 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -4,6 +4,7 @@ option('packager_version', type: 'string', value: '', 
description: 'Extra packag
 option('system', type: 'boolean', value: false, description: 'Set install 
paths to system ones')
 option('runstatedir', type: 'string', value: '', description: 'State directory 
for temporary sockets, pid files, etc')
 option('initconfdir', type: 'string', value: '', description: 'directory for 
init script configuration files')
+# dep:tests
 option('expensive_tests', type: 'feature', value: 'auto', description: 'set 
the default for enabling expensive tests (long timeouts)')
 option('test_coverage', type: 'boolean', value: false, description: 'turn on 
code coverage instrumentation')
 option('git_werror', type: 'feature', value: 'auto', description: 'use -Werror 
if building from GIT')
@@ -17,6 +18,7 @@ option('tests', type: 'feature', value: 'auto', description: 
'whether to build a
 option('apparmor', type: 'feature', value: 'auto', description: 'apparmor 
support')
 option('attr', type: 'feature', value: 'auto', description: 'attr support')
 option('audit', type: 'feature', value: 'auto', description: 'audit support')
+# dep:readline
 option('bash_completion', type: 'feature', value: 'auto', description: 
'bash-completion support')
 option('bash_completion_dir', type: 'string', value: '', description: 
'directory containing bash completion scripts')
 option('blkid', type: 'feature', value: 'auto', description: 'blkid support')
@@ -40,7 +42,9 @@ option('sanlock', type: 'feature', value: 'auto', 
description: 'sanlock support'
 option('sasl', type: 'feature', value: 'auto', description: 'sasl support')
 option('selinux', type: 'feature', value: 'auto', description: 'selinux 
support')
 option('selinux_mount', type: 'string', value: '', description: 'set SELinux 
mount point')
+# dep:pciaccess
 option('udev', type: 'feature', value: 'auto', description: 'udev support')
+# dep:driver_remote
 option('wireshark_dissector', type: 'feature', value: 'auto', description: 
'wireshark support')
 option('wireshark_plugindir', type: 'string', value: '', description: 
'wireshark plugins directory for use when installing wireshark plugin')
 option('yajl', type: 'feature', value: 'auto', description: 'yajl support')
@@ -48,17 +52,26 @@ option('yajl', type: 'feature', value: 'auto', description: 
'yajl support')
 
 # build driver options
 option('driver_bhyve', type: 'feature', value: 'auto', description: 'bhyve 
driver')
+# dep:curl
 option('driver_esx', type: 'feature', value: 'auto', description: 'esx driver')
+# dep:openwsman
 option('driver_hyperv', type: 'feature', value: 'auto', description: 'Hyper-V 
driver')
+# dep:pciaccess dep:udev dep:driver_remote dep:driver_libvirtd
 option('driver_interface', type: 'feature', value: 'auto', description: 'host 
interface driver')
+# dep:driver_remote
 option('driver_libvirtd', type: 'feature', value: 'auto', description: 
'libvirtd driver')
+# dep:driver_remote dep:driver_libvirtd
 option('driver_libxl', type: 'feature', value: 'auto', description: 
'libxenlight driver')
+# dep:driver_remote dep:driver_libvirtd
 option('driver_lxc', type: 'feature', value: 'auto', description: 'Linux 
Container driver')
+# dep:curl dep:yajl dep:driver_remote dep:driver_libvirtd
 option('driver_ch', type: 'feature', value: 'auto', description: 
'Cloud-Hypervisor driver')
 option('ch_user', type: 'string', value: '', description: 'username to run 
Cloud-Hypervisor system instance as')
 option('ch_group', type: 'string', value: '', description: 'groupname to run 
Cloud-Hypervisor system instance as')
+# dep:driver_remote dep:driver_libvirtd
 option('driver_network', type: 'feature', value: 'auto', description: 'virtual 
network driver')
 option('driver_openvz', type: 'feature', value: 'auto', description: 'OpenVZ 
driver')
+# dep:yajl dep:driver_remote dep:driver_libvirtd
 option('driver_qemu', type: 'feature', value: 'auto', description: 'QEMU/KVM 
driver')
 option('qemu_user', type: 'string', value: '', description: 'username to run 
QEMU system instance as')
 option('qemu_group', type: 'string', value: '', description: 'groupname to run 
QEMU system instance as')
@@ -74,7 +87,9 @@ option('driver_vmware', type: 'feature', value: 'auto', 
description: 'VMware dri
 option('driver_vz', type: 'feature', value: 'auto', description: 'Virtuozzo 
driver')
 
 option('secdriver_apparmor', type: 'feature', value: 'auto', description: 'use 
AppArmor security driver')
+# dep:secdriver_apparmor
 option('apparmor_profiles', type: 'feature', value: 'auto', description: 
'install apparmor