Re: [PATCH 1/4] qemu_capabilities: Add QEMU_CAPS_DEVICE_MTP capability

2024-03-19 Thread Michal Prívozník
On 3/8/24 21:16, Rayhan Faizel wrote:
> Signed-off-by: Rayhan Faizel 
> ---
>  src/qemu/qemu_capabilities.c  | 2 ++
>  src/qemu/qemu_capabilities.h  | 1 +
>  tests/qemucapabilitiesdata/caps_4.2.0_aarch64.xml | 1 +
>  tests/qemucapabilitiesdata/caps_4.2.0_ppc64.xml   | 1 +
>  tests/qemucapabilitiesdata/caps_4.2.0_x86_64.xml  | 1 +
>  tests/qemucapabilitiesdata/caps_5.0.0_aarch64.xml | 1 +
>  tests/qemucapabilitiesdata/caps_5.0.0_ppc64.xml   | 1 +
>  tests/qemucapabilitiesdata/caps_5.0.0_riscv64.xml | 1 +
>  tests/qemucapabilitiesdata/caps_5.0.0_x86_64.xml  | 1 +
>  tests/qemucapabilitiesdata/caps_5.1.0_x86_64.xml  | 1 +
>  tests/qemucapabilitiesdata/caps_5.2.0_aarch64.xml | 1 +
>  tests/qemucapabilitiesdata/caps_5.2.0_ppc64.xml   | 1 +
>  tests/qemucapabilitiesdata/caps_5.2.0_riscv64.xml | 1 +
>  tests/qemucapabilitiesdata/caps_5.2.0_x86_64.xml  | 1 +
>  tests/qemucapabilitiesdata/caps_6.0.0_aarch64.xml | 1 +
>  tests/qemucapabilitiesdata/caps_6.0.0_x86_64.xml  | 1 +
>  tests/qemucapabilitiesdata/caps_6.1.0_x86_64.xml  | 1 +
>  tests/qemucapabilitiesdata/caps_6.2.0_aarch64.xml | 1 +
>  tests/qemucapabilitiesdata/caps_6.2.0_ppc64.xml   | 1 +
>  tests/qemucapabilitiesdata/caps_6.2.0_x86_64.xml  | 1 +
>  tests/qemucapabilitiesdata/caps_7.0.0_aarch64+hvf.xml | 1 +
>  tests/qemucapabilitiesdata/caps_7.0.0_aarch64.xml | 1 +
>  tests/qemucapabilitiesdata/caps_7.0.0_ppc64.xml   | 1 +
>  tests/qemucapabilitiesdata/caps_7.0.0_x86_64.xml  | 1 +
>  tests/qemucapabilitiesdata/caps_7.1.0_ppc64.xml   | 1 +
>  tests/qemucapabilitiesdata/caps_7.1.0_x86_64.xml  | 1 +
>  tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 1 +
>  tests/qemucapabilitiesdata/caps_7.2.0_x86_64+hvf.xml  | 1 +
>  tests/qemucapabilitiesdata/caps_7.2.0_x86_64.xml  | 1 +
>  tests/qemucapabilitiesdata/caps_8.0.0_riscv64.xml | 1 +
>  tests/qemucapabilitiesdata/caps_8.0.0_x86_64.xml  | 1 +
>  tests/qemucapabilitiesdata/caps_8.1.0_s390x.xml   | 1 +
>  tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml  | 1 +
>  tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml | 1 +
>  tests/qemucapabilitiesdata/caps_8.2.0_s390x.xml   | 1 +
>  tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml  | 1 +
>  tests/qemucapabilitiesdata/caps_9.0.0_x86_64.xml  | 1 +
>  37 files changed, 38 insertions(+)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index ab11a929a3..7696756c3e 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -704,6 +704,7 @@ VIR_ENUM_IMPL(virQEMUCaps,
>  
>/* 455 */
>"blockjob.backing-mask-protocol", /* 
> QEMU_CAPS_BLOCKJOB_BACKING_MASK_PROTOCOL */
> +  "mtp", /* QEMU_CAPS_DEVICE_MTP */

Nitpick, I'd name this "usb-mtp" and QEMU_CAPS_DEVICE_USB_MTP so that
it's obvious the corresponding device is "-device usb-mtp" and not just
"-device mtp". I'll do the necessary changes before pushing.

Michal
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org


[PATCH 1/4] qemu_capabilities: Add QEMU_CAPS_DEVICE_MTP capability

2024-03-08 Thread Rayhan Faizel
Signed-off-by: Rayhan Faizel 
---
 src/qemu/qemu_capabilities.c  | 2 ++
 src/qemu/qemu_capabilities.h  | 1 +
 tests/qemucapabilitiesdata/caps_4.2.0_aarch64.xml | 1 +
 tests/qemucapabilitiesdata/caps_4.2.0_ppc64.xml   | 1 +
 tests/qemucapabilitiesdata/caps_4.2.0_x86_64.xml  | 1 +
 tests/qemucapabilitiesdata/caps_5.0.0_aarch64.xml | 1 +
 tests/qemucapabilitiesdata/caps_5.0.0_ppc64.xml   | 1 +
 tests/qemucapabilitiesdata/caps_5.0.0_riscv64.xml | 1 +
 tests/qemucapabilitiesdata/caps_5.0.0_x86_64.xml  | 1 +
 tests/qemucapabilitiesdata/caps_5.1.0_x86_64.xml  | 1 +
 tests/qemucapabilitiesdata/caps_5.2.0_aarch64.xml | 1 +
 tests/qemucapabilitiesdata/caps_5.2.0_ppc64.xml   | 1 +
 tests/qemucapabilitiesdata/caps_5.2.0_riscv64.xml | 1 +
 tests/qemucapabilitiesdata/caps_5.2.0_x86_64.xml  | 1 +
 tests/qemucapabilitiesdata/caps_6.0.0_aarch64.xml | 1 +
 tests/qemucapabilitiesdata/caps_6.0.0_x86_64.xml  | 1 +
 tests/qemucapabilitiesdata/caps_6.1.0_x86_64.xml  | 1 +
 tests/qemucapabilitiesdata/caps_6.2.0_aarch64.xml | 1 +
 tests/qemucapabilitiesdata/caps_6.2.0_ppc64.xml   | 1 +
 tests/qemucapabilitiesdata/caps_6.2.0_x86_64.xml  | 1 +
 tests/qemucapabilitiesdata/caps_7.0.0_aarch64+hvf.xml | 1 +
 tests/qemucapabilitiesdata/caps_7.0.0_aarch64.xml | 1 +
 tests/qemucapabilitiesdata/caps_7.0.0_ppc64.xml   | 1 +
 tests/qemucapabilitiesdata/caps_7.0.0_x86_64.xml  | 1 +
 tests/qemucapabilitiesdata/caps_7.1.0_ppc64.xml   | 1 +
 tests/qemucapabilitiesdata/caps_7.1.0_x86_64.xml  | 1 +
 tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 1 +
 tests/qemucapabilitiesdata/caps_7.2.0_x86_64+hvf.xml  | 1 +
 tests/qemucapabilitiesdata/caps_7.2.0_x86_64.xml  | 1 +
 tests/qemucapabilitiesdata/caps_8.0.0_riscv64.xml | 1 +
 tests/qemucapabilitiesdata/caps_8.0.0_x86_64.xml  | 1 +
 tests/qemucapabilitiesdata/caps_8.1.0_s390x.xml   | 1 +
 tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml  | 1 +
 tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml | 1 +
 tests/qemucapabilitiesdata/caps_8.2.0_s390x.xml   | 1 +
 tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml  | 1 +
 tests/qemucapabilitiesdata/caps_9.0.0_x86_64.xml  | 1 +
 37 files changed, 38 insertions(+)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index ab11a929a3..7696756c3e 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -704,6 +704,7 @@ VIR_ENUM_IMPL(virQEMUCaps,
 
   /* 455 */
   "blockjob.backing-mask-protocol", /* 
QEMU_CAPS_BLOCKJOB_BACKING_MASK_PROTOCOL */
+  "mtp", /* QEMU_CAPS_DEVICE_MTP */
 );
 
 
@@ -1390,6 +1391,7 @@ struct virQEMUCapsStringFlags virQEMUCapsObjectTypes[] = {
 { "virtio-crypto-device", QEMU_CAPS_DEVICE_VIRTIO_CRYPTO },
 { "cryptodev-backend-lkcf", QEMU_CAPS_OBJECT_CRYPTO_LKCF },
 { "pvpanic-pci", QEMU_CAPS_DEVICE_PANIC_PCI },
+{ "usb-mtp", QEMU_CAPS_DEVICE_MTP },
 };
 
 
diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
index ef1ad2c01c..6a98bfd3cc 100644
--- a/src/qemu/qemu_capabilities.h
+++ b/src/qemu/qemu_capabilities.h
@@ -683,6 +683,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for 
syntax-check */
 
 /* 455 */
 QEMU_CAPS_BLOCKJOB_BACKING_MASK_PROTOCOL, /* backing-mask-protocol of 
block-commit/block-stream */
+QEMU_CAPS_DEVICE_MTP, /* USB device accessed through Media Transfer 
Protocol (MTP) */
 
 QEMU_CAPS_LAST /* this must always be the last item */
 } virQEMUCapsFlags;
diff --git a/tests/qemucapabilitiesdata/caps_4.2.0_aarch64.xml 
b/tests/qemucapabilitiesdata/caps_4.2.0_aarch64.xml
index 2e6ea51d02..2d8ebf5e4a 100644
--- a/tests/qemucapabilitiesdata/caps_4.2.0_aarch64.xml
+++ b/tests/qemucapabilitiesdata/caps_4.2.0_aarch64.xml
@@ -105,6 +105,7 @@
   
   
   
+  
   4002000
   61700242
   v4.1.0-2221-g36609b4fa3
diff --git a/tests/qemucapabilitiesdata/caps_4.2.0_ppc64.xml 
b/tests/qemucapabilitiesdata/caps_4.2.0_ppc64.xml
index 9eff51672f..d638e618ed 100644
--- a/tests/qemucapabilitiesdata/caps_4.2.0_ppc64.xml
+++ b/tests/qemucapabilitiesdata/caps_4.2.0_ppc64.xml
@@ -105,6 +105,7 @@
   
   
   
+  
   4002000
   42900242
   v4.1.0-2198-g9e583f2
diff --git a/tests/qemucapabilitiesdata/caps_4.2.0_x86_64.xml 
b/tests/qemucapabilitiesdata/caps_4.2.0_x86_64.xml
index 28ccaa1271..d7607dfe6a 100644
--- a/tests/qemucapabilitiesdata/caps_4.2.0_x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_4.2.0_x86_64.xml
@@ -143,6 +143,7 @@
   
   
   
+  
   4002000
   43100242
   v4.2.0
diff --git a/tests/qemucapabilitiesdata/caps_5.0.0_aarch64.xml 
b/tests/qemucapabilitiesdata/caps_5.0.0_aarch64.xml
index 9d3b538119..04bcbe1f65 100644
--- a/tests/qemucapabilitiesdata/caps_5.0.0_aarch64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.0.0_aarch64.xml
@@ -117,6 +117,7 @@
   
   
   
+  
   500
   61700241
   v5.0.0
diff --git