Re: [PATCH 3/3] cli: Remove deprecated '-singlestep' command line option

2024-01-17 Thread Thomas Huth

On 17/01/2024 16.14, Philippe Mathieu-Daudé wrote:

This option has been deprecated before the 8.1 release,
in commit 12fd0f41d0 ("Document that -singlestep command
line option is deprecated"). Time to drop it.

Inspired-by: Thomas Huth 
Signed-off-by: Philippe Mathieu-Daudé 
---
  docs/about/deprecated.rst   | 17 -
  docs/about/removed-features.rst | 18 ++
  docs/user/main.rst  |  6 --
  bsd-user/main.c |  3 +--
  linux-user/main.c   |  2 --
  system/vl.c | 18 +-
  qemu-options.hx |  8 
  7 files changed, 20 insertions(+), 52 deletions(-)



Reviewed-by: Thomas Huth 
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org


[PATCH 3/3] cli: Remove deprecated '-singlestep' command line option

2024-01-17 Thread Philippe Mathieu-Daudé
This option has been deprecated before the 8.1 release,
in commit 12fd0f41d0 ("Document that -singlestep command
line option is deprecated"). Time to drop it.

Inspired-by: Thomas Huth 
Signed-off-by: Philippe Mathieu-Daudé 
---
 docs/about/deprecated.rst   | 17 -
 docs/about/removed-features.rst | 18 ++
 docs/user/main.rst  |  6 --
 bsd-user/main.c |  3 +--
 linux-user/main.c   |  2 --
 system/vl.c | 18 +-
 qemu-options.hx |  8 
 7 files changed, 20 insertions(+), 52 deletions(-)

diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 316a26a82c..f47446c079 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -63,23 +63,6 @@ as short-form boolean values, and passed to plugins as 
``arg_name=on``.
 However, short-form booleans are deprecated and full explicit ``arg_name=on``
 form is preferred.
 
-``-singlestep`` (since 8.1)
-'''
-
-The ``-singlestep`` option has been turned into an accelerator property,
-and given a name that better reflects what it actually does.
-Use ``-accel tcg,one-insn-per-tb=on`` instead.
-
-User-mode emulator command line arguments
--
-
-``-singlestep`` (since 8.1)
-'''
-
-The ``-singlestep`` option has been given a name that better reflects
-what it actually does. For both linux-user and bsd-user, use the
-new ``-one-insn-per-tb`` option instead.
-
 QEMU Machine Protocol (QMP) commands
 
 
diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst
index 855d788259..54081a6c19 100644
--- a/docs/about/removed-features.rst
+++ b/docs/about/removed-features.rst
@@ -482,6 +482,24 @@ Use ``-run-with async-teardown=on`` instead.
 
 Use ``-run-with chroot=dir`` instead.
 
+``-singlestep`` (removed in 9.0)
+
+
+The ``-singlestep`` option has been turned into an accelerator property,
+and given a name that better reflects what it actually does.
+Use ``-accel tcg,one-insn-per-tb=on`` instead.
+
+
+User-mode emulator command line arguments
+-
+
+``-singlestep`` (removed in 9.0)
+
+
+The ``-singlestep`` option has been given a name that better reflects
+what it actually does. For both linux-user and bsd-user, use the
+``-one-insn-per-tb`` option instead.
+
 
 QEMU Machine Protocol (QMP) commands
 
diff --git a/docs/user/main.rst b/docs/user/main.rst
index f478635396..7e7ad07409 100644
--- a/docs/user/main.rst
+++ b/docs/user/main.rst
@@ -98,9 +98,6 @@ Debug options:
This slows down emulation a lot, but can be useful in some situations,
such as when trying to analyse the logs produced by the ``-d`` option.
 
-``-singlestep``
-   This is a deprecated synonym for the ``-one-insn-per-tb`` option.
-
 Environment variables:
 
 QEMU_STRACE
@@ -251,6 +248,3 @@ Debug options:
Run the emulation with one guest instruction per translation block.
This slows down emulation a lot, but can be useful in some situations,
such as when trying to analyse the logs produced by the ``-d`` option.
-
-``-singlestep``
-   This is a deprecated synonym for the ``-one-insn-per-tb`` option.
diff --git a/bsd-user/main.c b/bsd-user/main.c
index 4de226d211..e5efb7b845 100644
--- a/bsd-user/main.c
+++ b/bsd-user/main.c
@@ -163,7 +163,6 @@ static void usage(void)
"  (use '-d help' for a list of log items)\n"
"-D logfilewrite logs to 'logfile' (default stderr)\n"
"-one-insn-per-tb  run with one guest instruction per emulated TB\n"
-   "-singlestep   deprecated synonym for -one-insn-per-tb\n"
"-strace   log system calls\n"
"-trace
[[enable=]][,events=][,file=]\n"
"  specify tracing options\n"
@@ -391,7 +390,7 @@ int main(int argc, char **argv)
 (void) envlist_unsetenv(envlist, "LD_PRELOAD");
 } else if (!strcmp(r, "seed")) {
 seed_optarg = optarg;
-} else if (!strcmp(r, "singlestep") || !strcmp(r, "one-insn-per-tb")) {
+} else if (!strcmp(r, "one-insn-per-tb")) {
 opt_one_insn_per_tb = true;
 } else if (!strcmp(r, "strace")) {
 do_strace = 1;
diff --git a/linux-user/main.c b/linux-user/main.c
index 0cdaf30d34..c9470eeccf 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -500,8 +500,6 @@ static const struct qemu_argument arg_table[] = {
 {"one-insn-per-tb",
"QEMU_ONE_INSN_PER_TB",  false, handle_arg_one_insn_per_tb,
  "",   "run with one guest instruction per emulated TB"},
-{"singlestep", "QEMU_SINGLESTEP",  false, handle_arg_one_insn_per_tb,
- "",   "deprecated synonym for