Re: [PATCH] virsysinfo: Try reading DMI table
On 4/5/24 23:12, Brett Holman wrote: >> A colleague asked about the status of this patch and it's availability in >> downstream openSUSE packages. I took a peek and LGTM. I then noticed Kristina >> has also reviewed the patch. I've added both R-B to the commit and pushed it. > > I appreciate the review and push \o/ > > Should I have resubmitted with the R-B in the commit message after > Kristina's review? Mailing list contribution process is still very > unfamiliar to me. > No need. Unfortunately, things lined up 'badly'. I mean, Kristina gave her reviewed-by during freeze period in which we try to stabilize libvirt and prepare it for upcoming release. Therefore, we do not merge new features, just bug fixes. And since she doesn't have commit access to the repo, she did not merge the patch once after the release. I knew I wanted to do it, but then Easter happened (public holiday) and quite frankly - just forgot, once I was back. Thanks Jim for keeping an eye on this! >> This appears to be your first commit to the libvirt project. >> Congratulations! :-) Indeed, congratulations! Michal ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org
Re: [PATCH] virsysinfo: Try reading DMI table
> A colleague asked about the status of this patch and it's availability in > downstream openSUSE packages. I took a peek and LGTM. I then noticed Kristina > has also reviewed the patch. I've added both R-B to the commit and pushed it. I appreciate the review and push \o/ Should I have resubmitted with the R-B in the commit message after Kristina's review? Mailing list contribution process is still very unfamiliar to me. > This appears to be your first commit to the libvirt project. Congratulations! > :-) Thanks :-) On Tue, Apr 2, 2024 at 5:13 PM Jim Fehlig wrote: > > On 3/26/24 13:38, brett.hol...@canonical.com wrote: > > From: Brett Holman > > > > Add DMI support for risc-v and mips. Attempt to read dmidecode and > > fall back to old behavior if that fails. > > > > The SMBIOS specification[1] officially supports both RISC-V and LoongArch. > > Some mips-based Loongson-3 processors also have SMBIOS. > > > > [1] > > https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.7.0.pdf > > > > Signed-off-by: Brett Holman > > Hi Brett, > > A colleague asked about the status of this patch and it's availability in > downstream openSUSE packages. I took a peek and LGTM. I then noticed Kristina > has also reviewed the patch. I've added both R-B to the commit and pushed it. > > This appears to be your first commit to the libvirt project. Congratulations! > :-) > > Regards, > Jim > > > --- > > src/util/virsysinfo.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c > > index 4a03fc3246..0d9083c891 100644 > > --- a/src/util/virsysinfo.c > > +++ b/src/util/virsysinfo.c > > @@ -1249,6 +1249,8 @@ virSysinfoRead(void) > > (defined(__x86_64__) || \ > >defined(__i386__) || \ > >defined(__amd64__) || \ > > + defined(__riscv__) || \ > > + defined(__mips__) || \ > >defined(__loongarch__)) > > return virSysinfoReadDMI(); > > #else /* WIN32 || not supported arch */ > ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org
Re: [PATCH] virsysinfo: Try reading DMI table
On 3/26/24 13:38, brett.hol...@canonical.com wrote: From: Brett Holman Add DMI support for risc-v and mips. Attempt to read dmidecode and fall back to old behavior if that fails. The SMBIOS specification[1] officially supports both RISC-V and LoongArch. Some mips-based Loongson-3 processors also have SMBIOS. [1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.7.0.pdf Signed-off-by: Brett Holman Hi Brett, A colleague asked about the status of this patch and it's availability in downstream openSUSE packages. I took a peek and LGTM. I then noticed Kristina has also reviewed the patch. I've added both R-B to the commit and pushed it. This appears to be your first commit to the libvirt project. Congratulations! :-) Regards, Jim --- src/util/virsysinfo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c index 4a03fc3246..0d9083c891 100644 --- a/src/util/virsysinfo.c +++ b/src/util/virsysinfo.c @@ -1249,6 +1249,8 @@ virSysinfoRead(void) (defined(__x86_64__) || \ defined(__i386__) || \ defined(__amd64__) || \ + defined(__riscv__) || \ + defined(__mips__) || \ defined(__loongarch__)) return virSysinfoReadDMI(); #else /* WIN32 || not supported arch */ ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org
Re: [PATCH] virsysinfo: Try reading DMI table
On Tue, Mar 26, 2024 at 8:45 PM wrote: > From: Brett Holman > > Add DMI support for risc-v and mips. Attempt to read dmidecode and > fall back to old behavior if that fails. > > The SMBIOS specification[1] officially supports both RISC-V and LoongArch. > Some mips-based Loongson-3 processors also have SMBIOS. > > [1] > https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.7.0.pdf > > Signed-off-by: Brett Holman > --- > src/util/virsysinfo.c | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Kristina Hanicova ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org
Re: [PATCH] virsysinfo: Try reading DMI table
> As I do not have knowledge in this - did you possibly include mips, because > the newest specification also includes LoongArch? > If yes - could you amend the commit message to include the link to the > newest version [2] and to explain the relationship between mips x > LoongArch? Thanks for the review. Correct, the spec doesn't support mips, but I added it because I noticed the SMBIOS table definition under hw/mips/ in qemu's source which, as you pointed out, is for LoongArch. I'll resubmit with an updated commit message. ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org
Re: [PATCH] virsysinfo: Try reading DMI table
Hello, On Mon, Mar 18, 2024 at 11:30 PM wrote: > From: Brett Holman > > The SMBIOS specification[1] includes RISC-V and mips, and some systems have > SMBIOS info. Attempt to read dmidecode and fall back to old behavior if > that > fails. > > [1] > https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.4.0.pdf thank you for the patch, but I do not fully understand one thing - in the pdf you included there is only risc-v as a supported processor architecture (section 1.1, page 15) and not mips. As I do not have knowledge in this - did you possibly include mips, because the newest specification also includes LoongArch? If yes - could you amend the commit message to include the link to the newest version [2] and to explain the relationship between mips x LoongArch? [2] https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.7.0.pdf > > Signed-off-by: Brett Holman > --- > src/util/virsysinfo.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c > index 36a861c53f..d8d660d694 100644 > --- a/src/util/virsysinfo.c > +++ b/src/util/virsysinfo.c > @@ -1248,6 +1248,8 @@ virSysinfoRead(void) > #elif !defined(WIN32) && \ > (defined(__x86_64__) || \ > defined(__i386__) || \ > + defined(__mips__) || \ > + defined(__riscv__) || \ > defined(__amd64__)) > return virSysinfoReadDMI(); > #else /* WIN32 || not supported arch */ > -- > 2.43.0 > ___ > Devel mailing list -- devel@lists.libvirt.org > To unsubscribe send an email to devel-le...@lists.libvirt.org Regards, Kristina ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org
Re: [PATCH] virsysinfo: Try reading DMI table
On Tue, Mar 19, 2024 at 07:53:35PM -, brett.hol...@canonical.com wrote: > My apologies for this duplicate, please direct reviews to this thread -> > https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/G6GPDHYL7CT7MFRECAPL7ZDSXOWQUABG/ No worries, it was my oversight to blindly approve everything in the moderator queue, without checking if you had since subscribed to the list and re-sent the patches. With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :| ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org
Re: [PATCH] virsysinfo: Try reading DMI table
My apologies for this duplicate, please direct reviews to this thread -> https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/G6GPDHYL7CT7MFRECAPL7ZDSXOWQUABG/ ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org
Re: [PATCH] virsysinfo: Try reading DMI table
My apologies for this duplicate, please direct reviews to this thread -> https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/G6GPDHYL7CT7MFRECAPL7ZDSXOWQUABG/ ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org
